Re: [PATCH v3 0/3] virtio-balloon: tweak config_changed
On 07.01.2019 14:45, Michael S. Tsirkin wrote: > On Mon, Jan 07, 2019 at 03:01:03PM +0800, Wei Wang wrote: >> Since virtio-ccw doesn't work with accessing to the config space >> inside an interrupt context, this patch series avoids that issue by >> moving the config register accesses to the related workqueue contexts. > > So is this enough to get ccw going again or do we also need > the patches that deal with NULL VQ names? This alone does not fix 4.20. You need the other ones as well.(The other patches fix the memory corruption during boot, this patch fixes the deadlock when actually changing the balloon size) > >> v2->v3 ChangeLog: >> - rename cmd_id_received to cmd_id_received_cache, and have call sites >> read the latest value via virtio_balloon_cmd_id_received. (Still >> kept Cornelia and Halil's reviewed-by as it's a minor change) >> - remove zeroing vb->num_free_page_blocks in probe since vb is >> allocated via kzalloc. >> v1->v2 ChangeLog: >> - add config_read_bitmap to indicate to the workqueue callbacks about >> the necessity of reading the related config fields. >> >> Wei Wang (3): >> virtio-balloon: tweak config_changed implementation >> virtio-balloon: improve update_balloon_size_func >> virtio_balloon: remove the unnecessary 0-initialization >> >> drivers/virtio/virtio_balloon.c | 104 >> ++-- >> 1 file changed, 69 insertions(+), 35 deletions(-) >> >> -- >> 2.7.4 > ___ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/virtualization
[PATCH v3 0/3] virtio-balloon: tweak config_changed
Since virtio-ccw doesn't work with accessing to the config space inside an interrupt context, this patch series avoids that issue by moving the config register accesses to the related workqueue contexts. v2->v3 ChangeLog: - rename cmd_id_received to cmd_id_received_cache, and have call sites read the latest value via virtio_balloon_cmd_id_received. (Still kept Cornelia and Halil's reviewed-by as it's a minor change) - remove zeroing vb->num_free_page_blocks in probe since vb is allocated via kzalloc. v1->v2 ChangeLog: - add config_read_bitmap to indicate to the workqueue callbacks about the necessity of reading the related config fields. Wei Wang (3): virtio-balloon: tweak config_changed implementation virtio-balloon: improve update_balloon_size_func virtio_balloon: remove the unnecessary 0-initialization drivers/virtio/virtio_balloon.c | 104 ++-- 1 file changed, 69 insertions(+), 35 deletions(-) -- 2.7.4 ___ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/virtualization
Re: [PATCH v3 0/3] virtio-balloon: tweak config_changed
On Mon, Jan 07, 2019 at 03:01:03PM +0800, Wei Wang wrote: > Since virtio-ccw doesn't work with accessing to the config space > inside an interrupt context, this patch series avoids that issue by > moving the config register accesses to the related workqueue contexts. So is this enough to get ccw going again or do we also need the patches that deal with NULL VQ names? > v2->v3 ChangeLog: > - rename cmd_id_received to cmd_id_received_cache, and have call sites > read the latest value via virtio_balloon_cmd_id_received. (Still > kept Cornelia and Halil's reviewed-by as it's a minor change) > - remove zeroing vb->num_free_page_blocks in probe since vb is > allocated via kzalloc. > v1->v2 ChangeLog: > - add config_read_bitmap to indicate to the workqueue callbacks about > the necessity of reading the related config fields. > > Wei Wang (3): > virtio-balloon: tweak config_changed implementation > virtio-balloon: improve update_balloon_size_func > virtio_balloon: remove the unnecessary 0-initialization > > drivers/virtio/virtio_balloon.c | 104 > ++-- > 1 file changed, 69 insertions(+), 35 deletions(-) > > -- > 2.7.4 ___ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/virtualization
Re: [PATCH v3 0/3] virtio-balloon: tweak config_changed
Can you please cc stable? Right now 4.20 does not work under KVM. On 07.01.2019 08:01, Wei Wang wrote: > Since virtio-ccw doesn't work with accessing to the config space > inside an interrupt context, this patch series avoids that issue by > moving the config register accesses to the related workqueue contexts. > > v2->v3 ChangeLog: > - rename cmd_id_received to cmd_id_received_cache, and have call sites > read the latest value via virtio_balloon_cmd_id_received. (Still > kept Cornelia and Halil's reviewed-by as it's a minor change) > - remove zeroing vb->num_free_page_blocks in probe since vb is > allocated via kzalloc. > v1->v2 ChangeLog: > - add config_read_bitmap to indicate to the workqueue callbacks about > the necessity of reading the related config fields. > > Wei Wang (3): > virtio-balloon: tweak config_changed implementation > virtio-balloon: improve update_balloon_size_func > virtio_balloon: remove the unnecessary 0-initialization > > drivers/virtio/virtio_balloon.c | 104 > ++-- > 1 file changed, 69 insertions(+), 35 deletions(-) > ___ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/virtualization
