Re: [PATCH v3 00/16] virtio-pci: towards virtio 1.0 guest support

2015-01-21 Thread Gerd Hoffmann
Hi, While hacking it up I've noticed spec doesn't match reality. The Virtio Structure PCI Capabilities section here ... http://docs.oasis-open.org/virtio/virtio/v1.0/cs01/virtio-v1.0-cs01.html#x1-690004 ... doesn't match what qemu is doing. Huh? Thanks a lot for the report,

Re: [PATCH v3 00/16] virtio-pci: towards virtio 1.0 guest support

2015-01-21 Thread Michael S. Tsirkin
On Wed, Jan 21, 2015 at 12:31:08PM +0100, Gerd Hoffmann wrote: Hi, While hacking it up I've noticed spec doesn't match reality. The Virtio Structure PCI Capabilities section here ... http://docs.oasis-open.org/virtio/virtio/v1.0/cs01/virtio-v1.0-cs01.html#x1-690004 ...

Re: [PATCH v3 00/16] virtio-pci: towards virtio 1.0 guest support

2015-01-21 Thread Michael S. Tsirkin
On Wed, Jan 21, 2015 at 02:43:11PM +0100, Gerd Hoffmann wrote: On Mi, 2015-01-21 at 13:36 +0200, Michael S. Tsirkin wrote: Want to respond to the patches with a tested-by tag? Done. Making multiplier smaller isn't in there yet, right? cheers, Gerd No - but I'll make sure to address

Re: [PATCH v3 00/16] virtio-pci: towards virtio 1.0 guest support

2015-01-21 Thread Gerd Hoffmann
On Mi, 2015-01-21 at 13:36 +0200, Michael S. Tsirkin wrote: Want to respond to the patches with a tested-by tag? Done. Making multiplier smaller isn't in there yet, right? cheers, Gerd ___ Virtualization mailing list

Re: [PATCH v3 00/16] virtio-pci: towards virtio 1.0 guest support

2015-01-20 Thread Michael S. Tsirkin
On Mon, Jan 19, 2015 at 12:07:00PM +0100, Gerd Hoffmann wrote: Hi, BTW: is there a tool (or pciutils patch) which can decode the virtio capabilities? Searched for a patch today, and all google found me was this mail asking for one :-o So I went ahead and coded one up. Attached.

Re: [PATCH v3 00/16] virtio-pci: towards virtio 1.0 guest support

2015-01-20 Thread Michael S. Tsirkin
On Mon, Jan 19, 2015 at 11:54:43AM +0100, Gerd Hoffmann wrote: Hi, I'm running 3.19-rc4 with this series applied in the guest, maybe I need more? Tried your vhost branch, rebased to 3.19-rc5 -- same result. Hmm. cheers, Gerd Yes, it was all completely broken. Looks like after

Re: [PATCH v3 00/16] virtio-pci: towards virtio 1.0 guest support

2015-01-19 Thread Michael S. Tsirkin
On Mon, Jan 19, 2015 at 12:07:00PM +0100, Gerd Hoffmann wrote: Hi, BTW: is there a tool (or pciutils patch) which can decode the virtio capabilities? Searched for a patch today, and all google found me was this mail asking for one :-o So I went ahead and coded one up. Attached.

Re: [PATCH v3 00/16] virtio-pci: towards virtio 1.0 guest support

2015-01-19 Thread Gerd Hoffmann
Hi, BTW: is there a tool (or pciutils patch) which can decode the virtio capabilities? Searched for a patch today, and all google found me was this mail asking for one :-o So I went ahead and coded one up. Attached. While hacking it up I've noticed spec doesn't match reality. The Virtio

Re: [PATCH v3 00/16] virtio-pci: towards virtio 1.0 guest support

2015-01-19 Thread Gerd Hoffmann
Hi, I'm running 3.19-rc4 with this series applied in the guest, maybe I need more? Tried your vhost branch, rebased to 3.19-rc5 -- same result. Hmm. cheers, Gerd ___ Virtualization mailing list Virtualization@lists.linux-foundation.org

Re: [PATCH v3 00/16] virtio-pci: towards virtio 1.0 guest support

2015-01-16 Thread Gerd Hoffmann
Hi, * I'd like to see some more flexibility in the pci bar layout. Stuff I have in mind: - New devices which don't need a legacy bar can use bar 0 for modern. - One MMIO bar is enough, we can place both virtio regions and msi-x regions there. I'd suggest to

Re: [PATCH v3 00/16] virtio-pci: towards virtio 1.0 guest support

2015-01-16 Thread Michael S. Tsirkin
On Fri, Jan 16, 2015 at 09:32:26AM +0100, Gerd Hoffmann wrote: Hi, * I'd like to see some more flexibility in the pci bar layout. Stuff I have in mind: - New devices which don't need a legacy bar can use bar 0 for modern. - One MMIO bar is enough, we can

Re: [PATCH v3 00/16] virtio-pci: towards virtio 1.0 guest support

2015-01-16 Thread Gerd Hoffmann
Hi, virtio-scsi seems to be broken, at least my usual fedora guest didn't boot up from virtio-scsi disk when using a guest kernel with this patch series applied. I'll re-test. Do other devices work for you? Thanks! Didn't came very far yet in my testing due to the guest

Re: [PATCH v3 00/16] virtio-pci: towards virtio 1.0 guest support

2015-01-15 Thread Gerd Hoffmann
Hi, QEMU side is still undergoing polishing, but is already testable. Looked art the qemu side for now, commenting here due to qemu patches not being posted to the list yet (guess that is at least partly already on your todo list): * Both legacy and modern should be switchable. Modern

Re: [PATCH v3 00/16] virtio-pci: towards virtio 1.0 guest support

2015-01-15 Thread Michael S. Tsirkin
On Thu, Jan 15, 2015 at 10:18:18PM +0100, Gerd Hoffmann wrote: Hi, QEMU side is still undergoing polishing, but is already testable. Looked art the qemu side for now, commenting here due to qemu patches not being posted to the list yet (guess that is at least partly already on your

[PATCH v3 00/16] virtio-pci: towards virtio 1.0 guest support

2015-01-14 Thread Michael S. Tsirkin
Changes since v2: handling for devices without config space (e.g. rng) reduce # of mappings for VQs These patches seem to work fine on my virtio-1.0 qemu branch. There haven't been any bugs since v2: just minor cleanups and enhancements. QEMU side is still undergoing polishing,