Re: [PATCH v3 04/16] virtio/console: verify device has config space

2015-01-20 Thread Amit Shah
On (Wed) 14 Jan 2015 [19:27:35], Michael S. Tsirkin wrote: Some devices might not implement config space access (e.g. remoteproc used not to - before 3.9). virtio/console needs config space access so make it fail gracefully if not there. Do we know any such devices? Wondering what prompted

Re: [PATCH v3 04/16] virtio/console: verify device has config space

2015-01-20 Thread Michael S. Tsirkin
On Tue, Jan 20, 2015 at 04:10:40PM +0530, Amit Shah wrote: On (Wed) 14 Jan 2015 [19:27:35], Michael S. Tsirkin wrote: Some devices might not implement config space access (e.g. remoteproc used not to - before 3.9). virtio/console needs config space access so make it fail gracefully if not

Re: [PATCH v3 04/16] virtio/console: verify device has config space

2015-01-20 Thread Michael S. Tsirkin
On Wed, Jan 21, 2015 at 11:44:52AM +0530, Amit Shah wrote: On (Tue) 20 Jan 2015 [13:09:55], Michael S. Tsirkin wrote: On Tue, Jan 20, 2015 at 04:10:40PM +0530, Amit Shah wrote: On (Wed) 14 Jan 2015 [19:27:35], Michael S. Tsirkin wrote: Some devices might not implement config space access

Re: [PATCH v3 04/16] virtio/console: verify device has config space

2015-01-20 Thread Amit Shah
On (Tue) 20 Jan 2015 [13:09:55], Michael S. Tsirkin wrote: On Tue, Jan 20, 2015 at 04:10:40PM +0530, Amit Shah wrote: On (Wed) 14 Jan 2015 [19:27:35], Michael S. Tsirkin wrote: Some devices might not implement config space access (e.g. remoteproc used not to - before 3.9).

[PATCH v3 04/16] virtio/console: verify device has config space

2015-01-14 Thread Michael S. Tsirkin
Some devices might not implement config space access (e.g. remoteproc used not to - before 3.9). virtio/console needs config space access so make it fail gracefully if not there. Signed-off-by: Michael S. Tsirkin m...@redhat.com --- drivers/char/virtio_console.c | 6 ++ 1 file changed, 6