Re: [PATCH v6 01/12] driver: platform: Add helper for safer setting of driver_override
On Mon, Apr 4, 2022 at 12:34 PM Krzysztof Kozlowski
wrote:
> On 04/04/2022 11:16, Andy Shevchenko wrote:
> > On Sun, Apr 3, 2022 at 9:38 PM Krzysztof Kozlowski
> > wrote:
...
> >> +int driver_set_override(struct device *dev, const char **override,
> >> + const char *s, size_t len)
> >> +{
> >> + const char *new, *old;
> >> + char *cp;
> >
> >> + if (!override || !s)
> >> + return -EINVAL;
> >
> > Still not sure if we should distinguish (s == NULL && len == 0) from
> > (s != NULL && len == 0).
> > Supplying the latter seems confusing (yes, I see that in the old code).
> > Perhaps
> > !s test, in case you want to leave it, should be also commented.
>
> The old semantics were focused on sysfs usage, so clearing is by passing
> an empty string. In the case of sysfs empty string is actually "\n". I
> intend to keep the semantics also for the in-kernel usage and in such
> case empty string can be also "".
>
> If I understand your comment correctly, you propose to change it to NULL
> for in-kernel usage, but that would change the semantics.
Yes. It's also possible to have a wrapper for sysfs use.
> > Another approach is to split above to two checks and move !s after !len.
>
> I don't follow why... The !override and !s are invalid uses. !len is a
> valid user for internal callers, just like "\n" is for sysfs.
I understand but always supplying s maybe an overhead for in-kernel usages.
In any case, it's not critical right now, just a remark that it can be modified.
> >> + /*
> >> +* The stored value will be used in sysfs show callback
> >> (sysfs_emit()),
> >> +* which has a length limit of PAGE_SIZE and adds a trailing
> >> newline.
> >> +* Thus we can store one character less to avoid truncation during
> >> sysfs
> >> +* show.
> >> +*/
> >> + if (len >= (PAGE_SIZE - 1))
> >> + return -EINVAL;
> >
> > Perhaps explain the case in the comment here?
>
> You mean the case we discuss here (to clear override with "")? Sure.
Yep. Before the below check.
> >> + if (!len) {
> >> + device_lock(dev);
> >> + old = *override;
> >> + *override = NULL;
> >
> >> + device_unlock(dev);
> >> + goto out_free;
> >
> > You may deduplicate this one, by
> >
> >goto out_unlock_free;
> >
> > But I understand your intention to keep lock-unlock in one place, so
> > perhaps dropping that label would be even better in this case and
> > keeping it
>
> Yes, exactly.
>
> >kfree(old);
> >return 0;
> >
> > here instead of goto.
>
> Slightly more code, but indeed maybe easier to follow. I'll do like this.
--
With Best Regards,
Andy Shevchenko
___
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
Re: [PATCH v6 01/12] driver: platform: Add helper for safer setting of driver_override
On Sun, Apr 3, 2022 at 9:38 PM Krzysztof Kozlowski
wrote:
>
> Several core drivers and buses expect that driver_override is a
> dynamically allocated memory thus later they can kfree() it.
>
> However such assumption is not documented, there were in the past and
> there are already users setting it to a string literal. This leads to
> kfree() of static memory during device release (e.g. in error paths or
> during unbind):
>
> kernel BUG at ../mm/slub.c:3960!
> Internal error: Oops - BUG: 0 [#1] PREEMPT SMP ARM
> ...
> (kfree) from [] (platform_device_release+0x88/0xb4)
> (platform_device_release) from [] (device_release+0x2c/0x90)
> (device_release) from [] (kobject_put+0xec/0x20c)
> (kobject_put) from [] (exynos5_clk_probe+0x154/0x18c)
> (exynos5_clk_probe) from [] (platform_drv_probe+0x6c/0xa4)
> (platform_drv_probe) from [] (really_probe+0x280/0x414)
> (really_probe) from [] (driver_probe_device+0x78/0x1c4)
> (driver_probe_device) from [] (bus_for_each_drv+0x74/0xb8)
> (bus_for_each_drv) from [] (__device_attach+0xd4/0x16c)
> (__device_attach) from [] (bus_probe_device+0x88/0x90)
> (bus_probe_device) from [] (device_add+0x3dc/0x62c)
> (device_add) from [] (of_platform_device_create_pdata+0x94/0xbc)
> (of_platform_device_create_pdata) from []
> (of_platform_bus_create+0x1a8/0x4fc)
> (of_platform_bus_create) from []
> (of_platform_bus_create+0x20c/0x4fc)
> (of_platform_bus_create) from []
> (of_platform_populate+0x84/0x118)
> (of_platform_populate) from []
> (of_platform_default_populate_init+0xa0/0xb8)
> (of_platform_default_populate_init) from []
> (do_one_initcall+0x8c/0x404)
>
> Provide a helper which clearly documents the usage of driver_override.
> This will allow later to reuse the helper and reduce the amount of
> duplicated code.
>
> Convert the platform driver to use a new helper and make the
> driver_override field const char (it is not modified by the core).
...
> +int driver_set_override(struct device *dev, const char **override,
> + const char *s, size_t len)
> +{
> + const char *new, *old;
> + char *cp;
> + if (!override || !s)
> + return -EINVAL;
Still not sure if we should distinguish (s == NULL && len == 0) from
(s != NULL && len == 0).
Supplying the latter seems confusing (yes, I see that in the old code). Perhaps
!s test, in case you want to leave it, should be also commented.
Another approach is to split above to two checks and move !s after !len.
> + /*
> +* The stored value will be used in sysfs show callback
> (sysfs_emit()),
> +* which has a length limit of PAGE_SIZE and adds a trailing newline.
> +* Thus we can store one character less to avoid truncation during
> sysfs
> +* show.
> +*/
> + if (len >= (PAGE_SIZE - 1))
> + return -EINVAL;
Perhaps explain the case in the comment here?
> + if (!len) {
> + device_lock(dev);
> + old = *override;
> + *override = NULL;
> + device_unlock(dev);
> + goto out_free;
You may deduplicate this one, by
goto out_unlock_free;
But I understand your intention to keep lock-unlock in one place, so
perhaps dropping that label would be even better in this case and
keeping it
kfree(old);
return 0;
here instead of goto.
> + }
> +
> + cp = strnchr(s, len, '\n');
> + if (cp)
> + len = cp - s;
> +
> + new = kstrndup(s, len, GFP_KERNEL);
> + if (!new)
> + return -ENOMEM;
> +
> + device_lock(dev);
> + old = *override;
> + if (cp != s) {
> + *override = new;
> + } else {
> + kfree(new);
> + *override = NULL;
> + }
> + device_unlock(dev);
> +
> +out_free:
> + kfree(old);
> +
> + return 0;
> +}
--
With Best Regards,
Andy Shevchenko
___
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
