Re: [PATCH vfio 03/11] virtio-pci: Introduce admin virtqueue

2023-10-02 Thread Feng Liu via Virtualization
On 2023-09-27 p.m.5:27, Michael S. Tsirkin wrote: If an existing device exposes a small capability matching old size, then you change size then the check will fail on the existing device and driver won't load. All this happens way before feature bit checks. Will do Thanks Feng

Re: [PATCH vfio 03/11] virtio-pci: Introduce admin virtqueue

2023-09-27 Thread Michael S. Tsirkin
On Wed, Sep 27, 2023 at 02:12:24PM -0400, Feng Liu wrote: > > > On 2023-09-26 p.m.3:23, Feng Liu via Virtualization wrote: > > External email: Use caution opening links or attachments > > > > > > On 2023-09-21 a.m.9:57, Michael S. Tsirkin wrote: > > > External email: Use caution opening links

Re: [PATCH vfio 03/11] virtio-pci: Introduce admin virtqueue

2023-09-27 Thread Feng Liu via Virtualization
On 2023-09-26 p.m.3:23, Feng Liu via Virtualization wrote: External email: Use caution opening links or attachments On 2023-09-21 a.m.9:57, Michael S. Tsirkin wrote: External email: Use caution opening links or attachments On Thu, Sep 21, 2023 at 03:40:32PM +0300, Yishai Hadas wrote:

Re: [PATCH vfio 03/11] virtio-pci: Introduce admin virtqueue

2023-09-26 Thread Feng Liu via Virtualization
On 2023-09-21 a.m.9:57, Michael S. Tsirkin wrote: External email: Use caution opening links or attachments On Thu, Sep 21, 2023 at 03:40:32PM +0300, Yishai Hadas wrote: From: Feng Liu Introduce support for the admin virtqueue. By negotiating VIRTIO_F_ADMIN_VQ feature, driver detects

Re: [PATCH vfio 03/11] virtio-pci: Introduce admin virtqueue

2023-09-21 Thread Michael S. Tsirkin
On Thu, Sep 21, 2023 at 03:40:32PM +0300, Yishai Hadas wrote: > From: Feng Liu > > Introduce support for the admin virtqueue. By negotiating > VIRTIO_F_ADMIN_VQ feature, driver detects capability and creates one > administration virtqueue. Administration virtqueue implementation in > virtio pci

[PATCH vfio 03/11] virtio-pci: Introduce admin virtqueue

2023-09-21 Thread Yishai Hadas via Virtualization
From: Feng Liu Introduce support for the admin virtqueue. By negotiating VIRTIO_F_ADMIN_VQ feature, driver detects capability and creates one administration virtqueue. Administration virtqueue implementation in virtio pci generic layer, enables multiple types of upper layer drivers such as vfio,