Re: [Qemu-devel] [PATCH 6/7] qemu: Implement virtio-pstore device

2016-08-01 Thread Namhyung Kim
On Mon, Aug 01, 2016 at 10:24:39AM +0100, Daniel P. Berrange wrote: > On Sat, Jul 30, 2016 at 05:57:02PM +0900, Namhyung Kim wrote: > > On Thu, Jul 28, 2016 at 02:22:39PM +0100, Daniel P. Berrange wrote: > > > > +static void virtio_pstore_from_filename(VirtIOPstore *s, char *name, > > > > +

Re: [Qemu-devel] [PATCH 6/7] qemu: Implement virtio-pstore device

2016-08-01 Thread Namhyung Kim
Hi Daniel, On Mon, Aug 01, 2016 at 10:21:30AM +0100, Daniel P. Berrange wrote: > On Sat, Jul 30, 2016 at 05:38:27PM +0900, Namhyung Kim wrote: > > Hello, > > > > On Thu, Jul 28, 2016 at 02:08:41PM +0100, Daniel P. Berrange wrote: > > > On Thu, Jul 28, 2016 at 01:56:07PM +0100, Stefan Hajnoczi

Re: [Qemu-devel] [PATCH 6/7] qemu: Implement virtio-pstore device

2016-08-01 Thread Daniel P. Berrange
On Sat, Jul 30, 2016 at 05:57:02PM +0900, Namhyung Kim wrote: > On Thu, Jul 28, 2016 at 02:22:39PM +0100, Daniel P. Berrange wrote: > > > +static void virtio_pstore_from_filename(VirtIOPstore *s, char *name, > > > +char *buf, size_t sz, > > > +

Re: [Qemu-devel] [PATCH 6/7] qemu: Implement virtio-pstore device

2016-08-01 Thread Daniel P. Berrange
On Sat, Jul 30, 2016 at 05:38:27PM +0900, Namhyung Kim wrote: > Hello, > > On Thu, Jul 28, 2016 at 02:08:41PM +0100, Daniel P. Berrange wrote: > > On Thu, Jul 28, 2016 at 01:56:07PM +0100, Stefan Hajnoczi wrote: > > > On Thu, Jul 28, 2016 at 02:39:53PM +0900, Namhyung Kim wrote: > > > > On Thu,

Re: [Qemu-devel] [PATCH 6/7] qemu: Implement virtio-pstore device

2016-07-30 Thread Namhyung Kim
On Thu, Jul 28, 2016 at 02:22:39PM +0100, Daniel P. Berrange wrote: > On Thu, Jul 28, 2016 at 12:08:30AM +0900, Namhyung Kim wrote: > > Add virtio pstore device to allow kernel log files saved on the host. > > It will save the log files on the directory given by pstore device > > option. > > > >

Re: [Qemu-devel] [PATCH 6/7] qemu: Implement virtio-pstore device

2016-07-30 Thread Namhyung Kim
Hello, On Thu, Jul 28, 2016 at 02:08:41PM +0100, Daniel P. Berrange wrote: > On Thu, Jul 28, 2016 at 01:56:07PM +0100, Stefan Hajnoczi wrote: > > On Thu, Jul 28, 2016 at 02:39:53PM +0900, Namhyung Kim wrote: > > > On Thu, Jul 28, 2016 at 03:02:54AM +0300, Michael S. Tsirkin wrote: > > > > On Thu,

Re: [Qemu-devel] [PATCH 6/7] qemu: Implement virtio-pstore device

2016-07-28 Thread Daniel P. Berrange
On Thu, Jul 28, 2016 at 12:08:30AM +0900, Namhyung Kim wrote: > Add virtio pstore device to allow kernel log files saved on the host. > It will save the log files on the directory given by pstore device > option. > > $ qemu-system-x86_64 -device virtio-pstore,directory=dir-xx ... > > (guest)

Re: [Qemu-devel] [PATCH 6/7] qemu: Implement virtio-pstore device

2016-07-28 Thread Daniel P. Berrange
On Thu, Jul 28, 2016 at 01:56:07PM +0100, Stefan Hajnoczi wrote: > On Thu, Jul 28, 2016 at 02:39:53PM +0900, Namhyung Kim wrote: > > On Thu, Jul 28, 2016 at 03:02:54AM +0300, Michael S. Tsirkin wrote: > > > On Thu, Jul 28, 2016 at 12:08:30AM +0900, Namhyung Kim wrote: > > > > +static ssize_t