Re: [RFC] kvm tools: Add support for virtio-mmio

2011-11-16 Thread Sasha Levin
On Wed, 2011-11-16 at 13:21 +, Pawel Moll wrote: > On Tue, 2011-11-15 at 17:56 +, Sasha Levin wrote: > > Hmm... If thats the plan, it should probably be a virtio thing (not > > virtio-mmio specific). > > > > Either way, it could also use some clarification in the spec. > > Well, the spec

Re: [RFC] kvm tools: Add support for virtio-mmio

2011-11-16 Thread Pawel Moll
On Tue, 2011-11-15 at 17:56 +, Sasha Levin wrote: > Hmm... If thats the plan, it should probably be a virtio thing (not > virtio-mmio specific). > > Either way, it could also use some clarification in the spec. Well, the spec (p. 2.1) says: "The Subsystem Vendor ID should reflect the PCI Vend

Re: [RFC] kvm tools: Add support for virtio-mmio

2011-11-15 Thread Peter Maydell
On 15 November 2011 16:47, Sasha Levin wrote: > +       vmmio->hdr = (struct virtio_mmio_hdr) { > +               .magic          = {'v', 'i', 'r', 't'}, > +               .version        = 1, > +               .device_id      = device_id - 0x1000 + 1, > +               .vendor_id      = PCI_VENDO

Re: [RFC] kvm tools: Add support for virtio-mmio

2011-11-15 Thread Sasha Levin
On Tue, 2011-11-15 at 20:18 +0200, Avi Kivity wrote: > On 11/15/2011 08:13 PM, Sasha Levin wrote: > > > > > > > > Hmm... If thats the plan, it should probably be a virtio thing (not > > > > virtio-mmio specific). > > > > > > > > Either way, it could also use some clarification in the spec. > > >

Re: [RFC] kvm tools: Add support for virtio-mmio

2011-11-15 Thread Avi Kivity
On 11/15/2011 08:13 PM, Sasha Levin wrote: > > > > > > Hmm... If thats the plan, it should probably be a virtio thing (not > > > virtio-mmio specific). > > > > > > Either way, it could also use some clarification in the spec. > > > > The spec only covers virtio-pci; this virtio-mmio is completel

Re: [RFC] kvm tools: Add support for virtio-mmio

2011-11-15 Thread Sasha Levin
On Tue, 2011-11-15 at 20:14 +0200, Avi Kivity wrote: > On 11/15/2011 07:56 PM, Sasha Levin wrote: > > > > > > This isn't a PCI device, so does it make sense to use a PCI vendor > > > ID here? The kernel doesn't check the vendor ID at the moment, > > > but presumably the idea of the field is to all

Re: [RFC] kvm tools: Add support for virtio-mmio

2011-11-15 Thread Avi Kivity
On 11/15/2011 07:56 PM, Sasha Levin wrote: > > > > This isn't a PCI device, so does it make sense to use a PCI vendor > > ID here? The kernel doesn't check the vendor ID at the moment, > > but presumably the idea of the field is to allow the kernel to > > work around implementation bugs/blacklist/

Re: [RFC] kvm tools: Add support for virtio-mmio

2011-11-15 Thread Sasha Levin
On Tue, 2011-11-15 at 17:00 +, Peter Maydell wrote: > On 15 November 2011 16:47, Sasha Levin wrote: > > + vmmio->hdr = (struct virtio_mmio_hdr) { > > + .magic = {'v', 'i', 'r', 't'}, > > + .version= 1, > > + .device_id = dev

[RFC] kvm tools: Add support for virtio-mmio

2011-11-15 Thread Sasha Levin
This patch adds support for the new virtio-mmio transport layer added in 3.2-rc1. The purpose of this new layer is to allow virtio to work on systems which don't necessarily support PCI, such as embedded systems. To apply the patch on top of the KVM tools tree, you must first pull Linus' tree on