Re: [RFC] virtio-net: help live migrate SR-IOV devices

2017-12-13 Thread Alexander Duyck
On Wed, Dec 6, 2017 at 11:28 PM, achiad shochat wrote: > On 5 December 2017 at 21:20, Michael S. Tsirkin wrote: >> On Tue, Dec 05, 2017 at 11:59:17AM +0200, achiad shochat wrote: >>> Then we'll have a single solution for both netvsc and virtio (and any

Re: [RFC] virtio-net: help live migrate SR-IOV devices

2017-12-13 Thread Jakub Kicinski
On Tue, 5 Dec 2017 11:59:17 +0200, achiad shochat wrote: > I second Jacob - having a netdev of one device driver enslave a netdev > of another device driver is an awkward a-symmetric model. > Regardless of whether they share the same backend device. > Only I am not sure the

Re: [RFC] virtio-net: help live migrate SR-IOV devices

2017-12-13 Thread Alexander Duyck
On Mon, Dec 4, 2017 at 1:51 AM, achiad shochat wrote: > On 3 December 2017 at 19:35, Stephen Hemminger > wrote: >> On Sun, 3 Dec 2017 11:14:37 +0200 >> achiad shochat wrote: >> >>> On 3 December 2017 at 07:05,

Re: [RFC] virtio-net: help live migrate SR-IOV devices

2017-12-07 Thread Michael S. Tsirkin
On Thu, Dec 07, 2017 at 08:45:33AM -0800, Alexander Duyck wrote: > As far as indicating that the interfaces are meant to be enslaved I > wonder if we couldn't look at tweaking the PCI layout of the guest and > use that to indicate that a given set of interfaces are meant to be > bonded. For

Re: [RFC] virtio-net: help live migrate SR-IOV devices

2017-12-05 Thread Stephen Hemminger
On Tue, 5 Dec 2017 14:29:28 -0800 Jakub Kicinski wrote: > On Tue, 5 Dec 2017 11:59:17 +0200, achiad shochat wrote: > > I second Jacob - having a netdev of one device driver enslave a netdev > > of another device driver is an awkward a-symmetric model. > >

Re: [RFC] virtio-net: help live migrate SR-IOV devices

2017-12-05 Thread Michael S. Tsirkin
On Tue, Dec 05, 2017 at 01:52:26PM -0800, Jesse Brandeburg wrote: > On Tue, 5 Dec 2017 21:20:07 +0200 > "Michael S. Tsirkin" wrote: > > > On Tue, Dec 05, 2017 at 11:59:17AM +0200, achiad shochat wrote: > > > Then we'll have a single solution for both netvsc and virtio (and any >

Re: [RFC] virtio-net: help live migrate SR-IOV devices

2017-12-05 Thread Jesse Brandeburg
On Tue, 5 Dec 2017 21:20:07 +0200 "Michael S. Tsirkin" wrote: > On Tue, Dec 05, 2017 at 11:59:17AM +0200, achiad shochat wrote: > > Then we'll have a single solution for both netvsc and virtio (and any > > other PV device). > > And we could handle the VF DMA dirt issue

Re: [RFC] virtio-net: help live migrate SR-IOV devices

2017-12-05 Thread Michael S. Tsirkin
On Tue, Dec 05, 2017 at 11:59:17AM +0200, achiad shochat wrote: > Then we'll have a single solution for both netvsc and virtio (and any > other PV device). > And we could handle the VF DMA dirt issue agnostically. For the record, I won't block patches adding this kist to virtio on the basis that

Re: [RFC] virtio-net: help live migrate SR-IOV devices

2017-12-05 Thread achiad shochat
On 4 December 2017 at 18:30, Alexander Duyck wrote: > On Mon, Dec 4, 2017 at 1:51 AM, achiad shochat > wrote: >> On 3 December 2017 at 19:35, Stephen Hemminger >> wrote: >>> On Sun, 3 Dec 2017 11:14:37 +0200 >>>

Re: [RFC] virtio-net: help live migrate SR-IOV devices

2017-12-04 Thread achiad shochat
On 3 December 2017 at 19:35, Stephen Hemminger wrote: > On Sun, 3 Dec 2017 11:14:37 +0200 > achiad shochat wrote: > >> On 3 December 2017 at 07:05, Michael S. Tsirkin wrote: >> > On Fri, Dec 01, 2017 at 12:08:59PM -0800,

Re: [RFC] virtio-net: help live migrate SR-IOV devices

2017-12-03 Thread Stephen Hemminger
On Sun, 3 Dec 2017 11:14:37 +0200 achiad shochat wrote: > On 3 December 2017 at 07:05, Michael S. Tsirkin wrote: > > On Fri, Dec 01, 2017 at 12:08:59PM -0800, Shannon Nelson wrote: > >> On 11/30/2017 6:11 AM, Michael S. Tsirkin wrote: > >> > On

Re: [RFC] virtio-net: help live migrate SR-IOV devices

2017-12-03 Thread achiad shochat
On 3 December 2017 at 07:05, Michael S. Tsirkin wrote: > On Fri, Dec 01, 2017 at 12:08:59PM -0800, Shannon Nelson wrote: >> On 11/30/2017 6:11 AM, Michael S. Tsirkin wrote: >> > On Thu, Nov 30, 2017 at 10:08:45AM +0200, achiad shochat wrote: >> > > Re. problem #2: >> > > Indeed

Re: [RFC] virtio-net: help live migrate SR-IOV devices

2017-12-02 Thread Michael S. Tsirkin
On Fri, Dec 01, 2017 at 12:08:59PM -0800, Shannon Nelson wrote: > On 11/30/2017 6:11 AM, Michael S. Tsirkin wrote: > > On Thu, Nov 30, 2017 at 10:08:45AM +0200, achiad shochat wrote: > > > Re. problem #2: > > > Indeed the best way to address it seems to be to enslave the VF driver > > > netdev

Re: [RFC] virtio-net: help live migrate SR-IOV devices

2017-12-01 Thread achiad shochat
On 30 November 2017 at 05:29, Jason Wang wrote: > > > On 2017年11月29日 03:27, Jesse Brandeburg wrote: >> >> Hi, I'd like to get some feedback on a proposal to enhance virtio-net >> to ease configuration of a VM and that would enable live migration of >> passthrough network

Re: [RFC] virtio-net: help live migrate SR-IOV devices

2017-12-01 Thread Shannon Nelson
On 11/30/2017 6:11 AM, Michael S. Tsirkin wrote: On Thu, Nov 30, 2017 at 10:08:45AM +0200, achiad shochat wrote: Re. problem #2: Indeed the best way to address it seems to be to enslave the VF driver netdev under a persistent anchor netdev. And it's indeed desired to allow (but not enforce) PV

Re: [RFC] virtio-net: help live migrate SR-IOV devices

2017-12-01 Thread Jakub Kicinski
On Thu, 30 Nov 2017 15:54:40 +0200, Michael S. Tsirkin wrote: > On Wed, Nov 29, 2017 at 07:51:38PM -0800, Jakub Kicinski wrote: > > On Thu, 30 Nov 2017 11:29:56 +0800, Jason Wang wrote: > > > On 2017年11月29日 03:27, Jesse Brandeburg wrote: > > > > Hi, I'd like to get some feedback on a proposal

Re: [RFC] virtio-net: help live migrate SR-IOV devices

2017-12-01 Thread Jakub Kicinski
On Wed, 29 Nov 2017 20:10:09 -0800, Stephen Hemminger wrote: > On Wed, 29 Nov 2017 19:51:38 -0800 Jakub Kicinski wrote: > > On Thu, 30 Nov 2017 11:29:56 +0800, Jason Wang wrote: > > > On 2017年11月29日 03:27, Jesse Brandeburg wrote: > > > commit 0c195567a8f6e82ea5535cd9f1d54a1626dd233e > > >

Re: [RFC] virtio-net: help live migrate SR-IOV devices

2017-12-01 Thread Jakub Kicinski
On Thu, 30 Nov 2017 11:29:56 +0800, Jason Wang wrote: > On 2017年11月29日 03:27, Jesse Brandeburg wrote: > > Hi, I'd like to get some feedback on a proposal to enhance virtio-net > > to ease configuration of a VM and that would enable live migration of > > passthrough network SR-IOV devices. > > > >

Re: [RFC] virtio-net: help live migrate SR-IOV devices

2017-11-30 Thread Michael S. Tsirkin
On Thu, Nov 30, 2017 at 12:48:22PM -0800, Jakub Kicinski wrote: > On Thu, 30 Nov 2017 15:54:40 +0200, Michael S. Tsirkin wrote: > > On Wed, Nov 29, 2017 at 07:51:38PM -0800, Jakub Kicinski wrote: > > > On Thu, 30 Nov 2017 11:29:56 +0800, Jason Wang wrote: > > > > On 2017年11月29日 03:27, Jesse

Re: [RFC] virtio-net: help live migrate SR-IOV devices

2017-11-30 Thread Michael S. Tsirkin
On Thu, Nov 30, 2017 at 11:29:56AM +0800, Jason Wang wrote: > If my understanding is correct there's no need to for any extension of > virtio spec. There appears to be a concern that some existing configurations might use same MAC for an unrelated reason. Not sure what that could be, but for

Re: [RFC] virtio-net: help live migrate SR-IOV devices

2017-11-30 Thread Michael S. Tsirkin
On Thu, Nov 30, 2017 at 10:08:45AM +0200, achiad shochat wrote: > Re. problem #2: > Indeed the best way to address it seems to be to enslave the VF driver > netdev under a persistent anchor netdev. > And it's indeed desired to allow (but not enforce) PV netdev and VF > netdev to work in

Re: [RFC] virtio-net: help live migrate SR-IOV devices

2017-11-30 Thread Michael S. Tsirkin
On Wed, Nov 29, 2017 at 07:51:38PM -0800, Jakub Kicinski wrote: > On Thu, 30 Nov 2017 11:29:56 +0800, Jason Wang wrote: > > On 2017年11月29日 03:27, Jesse Brandeburg wrote: > > > Hi, I'd like to get some feedback on a proposal to enhance virtio-net > > > to ease configuration of a VM and that would

Re: [RFC] virtio-net: help live migrate SR-IOV devices

2017-11-29 Thread Stephen Hemminger
On Wed, 29 Nov 2017 19:51:38 -0800 Jakub Kicinski wrote: > On Thu, 30 Nov 2017 11:29:56 +0800, Jason Wang wrote: > > On 2017年11月29日 03:27, Jesse Brandeburg wrote: > > > Hi, I'd like to get some feedback on a proposal to enhance > > > virtio-net to ease

Re: [RFC] virtio-net: help live migrate SR-IOV devices

2017-11-29 Thread Jason Wang
On 2017年11月29日 03:27, Jesse Brandeburg wrote: Hi, I'd like to get some feedback on a proposal to enhance virtio-net to ease configuration of a VM and that would enable live migration of passthrough network SR-IOV devices. Today we have SR-IOV network devices (VFs) that can be passed into a VM

Re: [RFC] virtio-net: help live migrate SR-IOV devices

2017-11-29 Thread Michael S. Tsirkin
On Tue, Nov 28, 2017 at 11:27:22AM -0800, Jesse Brandeburg wrote: > Hi, I'd like to get some feedback on a proposal to enhance virtio-net > to ease configuration of a VM and that would enable live migration of > passthrough network SR-IOV devices. You should also CC

[RFC] virtio-net: help live migrate SR-IOV devices

2017-11-28 Thread Jesse Brandeburg
Hi, I'd like to get some feedback on a proposal to enhance virtio-net to ease configuration of a VM and that would enable live migration of passthrough network SR-IOV devices. Today we have SR-IOV network devices (VFs) that can be passed into a VM in order to enable high performance networking