Re: [RFC PATCH 3/4] virtio: introudce a mdev based transport

2019-09-11 Thread Jason Wang
On 2019/9/11 下午5:36, Michael S. Tsirkin wrote: On Wed, Sep 11, 2019 at 10:38:39AM +0800, Jason Wang wrote: On 2019/9/10 下午9:52, Michael S. Tsirkin wrote: On Tue, Sep 10, 2019 at 09:13:02PM +0800, Jason Wang wrote: On 2019/9/10 下午6:01, Michael S. Tsirkin wrote: +#ifndef _LINUX_VIRTIO_MDEV_H

Re: [RFC PATCH 3/4] virtio: introudce a mdev based transport

2019-09-11 Thread Michael S. Tsirkin
On Wed, Sep 11, 2019 at 10:38:39AM +0800, Jason Wang wrote: > > On 2019/9/10 下午9:52, Michael S. Tsirkin wrote: > > On Tue, Sep 10, 2019 at 09:13:02PM +0800, Jason Wang wrote: > > > On 2019/9/10 下午6:01, Michael S. Tsirkin wrote: > > > > > +#ifndef _LINUX_VIRTIO_MDEV_H > > > > > +#define

Re: [RFC PATCH 3/4] virtio: introudce a mdev based transport

2019-09-10 Thread Tiwei Bie
On Wed, Sep 11, 2019 at 10:52:03AM +0800, Jason Wang wrote: > On 2019/9/11 上午9:47, Tiwei Bie wrote: > > On Tue, Sep 10, 2019 at 04:19:34PM +0800, Jason Wang wrote: > > > This path introduces a new mdev transport for virtio. This is used to > > > use kernel virtio driver to drive the mediated

Re: [RFC PATCH 3/4] virtio: introudce a mdev based transport

2019-09-10 Thread Jason Wang
On 2019/9/11 上午9:47, Tiwei Bie wrote: On Tue, Sep 10, 2019 at 04:19:34PM +0800, Jason Wang wrote: This path introduces a new mdev transport for virtio. This is used to use kernel virtio driver to drive the mediated device that is capable of populating virtqueue directly. A new virtio-mdev

Re: [RFC PATCH 3/4] virtio: introudce a mdev based transport

2019-09-10 Thread Jason Wang
On 2019/9/10 下午9:52, Michael S. Tsirkin wrote: On Tue, Sep 10, 2019 at 09:13:02PM +0800, Jason Wang wrote: On 2019/9/10 下午6:01, Michael S. Tsirkin wrote: +#ifndef _LINUX_VIRTIO_MDEV_H +#define _LINUX_VIRTIO_MDEV_H + +#include +#include +#include + +/* + * Ioctls + */ Pls add a bit more

Re: [RFC PATCH 3/4] virtio: introudce a mdev based transport

2019-09-10 Thread Tiwei Bie
On Tue, Sep 10, 2019 at 04:19:34PM +0800, Jason Wang wrote: > This path introduces a new mdev transport for virtio. This is used to > use kernel virtio driver to drive the mediated device that is capable > of populating virtqueue directly. > > A new virtio-mdev driver will be registered to the

Re: [RFC PATCH 3/4] virtio: introudce a mdev based transport

2019-09-10 Thread Michael S. Tsirkin
On Tue, Sep 10, 2019 at 09:13:02PM +0800, Jason Wang wrote: > > On 2019/9/10 下午6:01, Michael S. Tsirkin wrote: > > > +#ifndef _LINUX_VIRTIO_MDEV_H > > > +#define _LINUX_VIRTIO_MDEV_H > > > + > > > +#include > > > +#include > > > +#include > > > + > > > +/* > > > + * Ioctls > > > + */ > > Pls

Re: [RFC PATCH 3/4] virtio: introudce a mdev based transport

2019-09-10 Thread Jason Wang
On 2019/9/10 下午6:01, Michael S. Tsirkin wrote: +#ifndef _LINUX_VIRTIO_MDEV_H +#define _LINUX_VIRTIO_MDEV_H + +#include +#include +#include + +/* + * Ioctls + */ Pls add a bit more content here. It's redundant to state these are ioctls. Much better to document what does each one do. Ok.

Re: [RFC PATCH 3/4] virtio: introudce a mdev based transport

2019-09-10 Thread Michael S. Tsirkin
On Tue, Sep 10, 2019 at 04:19:34PM +0800, Jason Wang wrote: > This path introduces a new mdev transport for virtio. This is used to > use kernel virtio driver to drive the mediated device that is capable > of populating virtqueue directly. > > A new virtio-mdev driver will be registered to the

[RFC PATCH 3/4] virtio: introudce a mdev based transport

2019-09-10 Thread Jason Wang
This path introduces a new mdev transport for virtio. This is used to use kernel virtio driver to drive the mediated device that is capable of populating virtqueue directly. A new virtio-mdev driver will be registered to the mdev bus, when a new virtio-mdev device is probed, it will register the