Re: [RFC PATCH v2 0/5] TUN/VirtioNet USO features support.

2022-06-16 Thread Jason Wang
On Thu, Jun 16, 2022 at 7:59 PM Andrew Melnichenko wrote: > > Hi, Jason > Apparently, your patch should work. > For now, I have an issue where segmentation between two guests on one > host still occurs. > Neither previous "hack" nor your patch helps. > Now I'm looking what the issue may be. > If

Re: [RFC PATCH v2 0/5] TUN/VirtioNet USO features support.

2022-06-16 Thread Andrew Melnichenko
Hi, Jason Apparently, your patch should work. For now, I have an issue where segmentation between two guests on one host still occurs. Neither previous "hack" nor your patch helps. Now I'm looking what the issue may be. If you have some suggestions on where may I look, it would be helpful, thanks!

Re: [RFC PATCH v2 0/5] TUN/VirtioNet USO features support.

2022-05-26 Thread Andrew Melnichenko
I'll check it, thank you! On Thu, May 26, 2022 at 9:56 AM Jason Wang wrote: > > On Tue, May 24, 2022 at 7:07 PM Andrew Melnichenko wrote: > > > > Hi all, > > > > The issue is that host segments packets between guests on the same host. > > Tests show that it happens because SKB_GSO_DODGY skb

Re: [RFC PATCH v2 0/5] TUN/VirtioNet USO features support.

2022-05-26 Thread Jason Wang
On Tue, May 24, 2022 at 7:07 PM Andrew Melnichenko wrote: > > Hi all, > > The issue is that host segments packets between guests on the same host. > Tests show that it happens because SKB_GSO_DODGY skb offload in > virtio_net_hdr_from_skb(). > To do segmentation you need to remove SKB_GSO_DODGY

Re: [RFC PATCH v2 0/5] TUN/VirtioNet USO features support.

2022-05-24 Thread Andrew Melnichenko
Hi all, The issue is that host segments packets between guests on the same host. Tests show that it happens because SKB_GSO_DODGY skb offload in virtio_net_hdr_from_skb(). To do segmentation you need to remove SKB_GSO_DODGY or add SKB_GSO_PARTIAL The solution with DODGY/PARTIAL offload looks like

Re: [RFC PATCH v2 0/5] TUN/VirtioNet USO features support.

2022-05-17 Thread Jason Wang
On Thu, May 12, 2022 at 7:33 PM Andrew Melnychenko wrote: > > Added new offloads for TUN devices TUN_F_USO4 and TUN_F_USO6. > Technically they enable NETIF_F_GSO_UDP_L4 > (and only if USO4 & USO6 are set simultaneously). > It allows to transmission of large UDP packets. > > Different features

[RFC PATCH v2 0/5] TUN/VirtioNet USO features support.

2022-05-12 Thread Andrew Melnychenko
Added new offloads for TUN devices TUN_F_USO4 and TUN_F_USO6. Technically they enable NETIF_F_GSO_UDP_L4 (and only if USO4 & USO6 are set simultaneously). It allows to transmission of large UDP packets. Different features USO4 and USO6 are required for qemu where Windows guests can enable disable