Re: [Xen-devel] [PATCH 05/27] xen, cpu hotplug: Don't call cpu_bringup() in xen_play_dead()

2012-06-05 Thread Srivatsa S. Bhat
On 06/05/2012 11:10 PM, Thomas Gleixner wrote: > On Sat, 2 Jun 2012, Srivatsa S. Bhat wrote: >> Ok.. So, I would love to hear a confirmation about whether this patch (which >> removes cpu_bringup() in xen_play_dead()) will break things or it is good as >> is. >> >> If its not correct, then we can

Re: [Xen-devel] [PATCH 05/27] xen, cpu hotplug: Don't call cpu_bringup() in xen_play_dead()

2012-06-05 Thread Thomas Gleixner
On Sat, 2 Jun 2012, Srivatsa S. Bhat wrote: > Ok.. So, I would love to hear a confirmation about whether this patch (which > removes cpu_bringup() in xen_play_dead()) will break things or it is good as > is. > > If its not correct, then we can probably make __cpu_post_online() return an > int, >

Re: [Xen-devel] [PATCH 05/27] xen, cpu hotplug: Don't call cpu_bringup() in xen_play_dead()

2012-06-05 Thread Srivatsa S. Bhat
On 06/05/2012 10:19 PM, Konrad Rzeszutek Wilk wrote: > On Sat, Jun 02, 2012 at 11:36:00PM +0530, Srivatsa S. Bhat wrote: >> On 06/01/2012 09:06 PM, Jan Beulich wrote: >> >> On 01.06.12 at 17:13, "Srivatsa S. Bhat" >> >>> wrote: On 06/01/2012 06:29 PM, Jan Beulich wrote: >>>

Re: [Xen-devel] [PATCH 05/27] xen, cpu hotplug: Don't call cpu_bringup() in xen_play_dead()

2012-06-05 Thread Konrad Rzeszutek Wilk
On Sat, Jun 02, 2012 at 11:36:00PM +0530, Srivatsa S. Bhat wrote: > On 06/01/2012 09:06 PM, Jan Beulich wrote: > > On 01.06.12 at 17:13, "Srivatsa S. Bhat" > > > wrote: > >> On 06/01/2012 06:29 PM, Jan Beulich wrote: > >> > >> On 01.06.12 at 11:11, "Srivatsa S. Bhat" > >> > >

Re: [Xen-devel] [PATCH 05/27] xen, cpu hotplug: Don't call cpu_bringup() in xen_play_dead()

2012-06-02 Thread Srivatsa S. Bhat
On 06/01/2012 09:06 PM, Jan Beulich wrote: On 01.06.12 at 17:13, "Srivatsa S. Bhat" > wrote: >> On 06/01/2012 06:29 PM, Jan Beulich wrote: >> >> On 01.06.12 at 11:11, "Srivatsa S. Bhat" >> >>> wrote: xen_play_dead calls cpu_bringup() which looks weird, because xen_play_d

Re: [Xen-devel] [PATCH 05/27] xen, cpu hotplug: Don't call cpu_bringup() in xen_play_dead()

2012-06-01 Thread Jan Beulich
>>> On 01.06.12 at 17:13, "Srivatsa S. Bhat" wrote: > On 06/01/2012 06:29 PM, Jan Beulich wrote: > > On 01.06.12 at 11:11, "Srivatsa S. Bhat" > >> wrote: >>> xen_play_dead calls cpu_bringup() which looks weird, because xen_play_dead() >>> is invoked in the cpu down path, whereas cpu_bri

Re: [Xen-devel] [PATCH 05/27] xen, cpu hotplug: Don't call cpu_bringup() in xen_play_dead()

2012-06-01 Thread Srivatsa S. Bhat
On 06/01/2012 06:29 PM, Jan Beulich wrote: On 01.06.12 at 11:11, "Srivatsa S. Bhat" > wrote: >> xen_play_dead calls cpu_bringup() which looks weird, because xen_play_dead() >> is invoked in the cpu down path, whereas cpu_bringup() (as the name >> suggests) is useful in the cpu bringup path.

Re: [Xen-devel] [PATCH 05/27] xen, cpu hotplug: Don't call cpu_bringup() in xen_play_dead()

2012-06-01 Thread Jan Beulich
>>> On 01.06.12 at 11:11, "Srivatsa S. Bhat" wrote: > xen_play_dead calls cpu_bringup() which looks weird, because xen_play_dead() > is invoked in the cpu down path, whereas cpu_bringup() (as the name > suggests) is useful in the cpu bringup path. This might not be correct - the code as it is wi