Re: [kvm-devel] [PATCH/RFC 3/4]Introduce account modifiers mechanism

2007-08-19 Thread Avi Kivity
Laurent Vivier wrote: Avi Kivity wrote: [...] The normal user/system accounting has the same issue, no? Whereever we happen to land (kernel or user) gets the whole tick. So I think it is okay to have the same limitation for guest time. So this is how it looks like. PATCH 1 and 2

Re: [kvm-devel] [PATCH/RFC 3/4]Introduce account modifiers mechanism

2007-08-19 Thread Avi Kivity
Laurent Vivier wrote: So I think it is okay to have the same limitation for guest time. OK, so we can go back to my first patch. Who can decide to introduce this into the kernel ? The sched.c parts are best merged by Ingo, and I can carry the kvm parts. Alternatively, I can carry

Re: [kvm-devel] [PATCH/RFC 3/4]Introduce account modifiers mechanism

2007-08-17 Thread Avi Kivity
Laurent Vivier wrote: - remove PATCH 3, and add in task_struct a ktime vtime where we accumulate guest time (by calling something like guest_enter() and guest_exit() from the virtualization engine), and when in account_system_time() we have cputime vtime we substrate vtime from

Re: [kvm-devel] [PATCH/RFC 3/4]Introduce account modifiers mechanism

2007-08-17 Thread Laurent Vivier
Avi Kivity wrote: Laurent Vivier wrote: - remove PATCH 3, and add in task_struct a ktime vtime where we accumulate guest time (by calling something like guest_enter() and guest_exit() from the virtualization engine), and when in account_system_time() we have cputime vtime we

Re: [kvm-devel] [PATCH/RFC 3/4]Introduce account modifiers mechanism

2007-08-17 Thread Christian Borntraeger
Am Freitag, 17. August 2007 schrieb Laurent Vivier: The normal user/system accounting has the same issue, no? Whereever we happen to land (kernel or user) gets the whole tick. Yes... but perhaps I should rewrite this too ;-) If you look further, you will see, that this was actually

Re: [kvm-devel] [PATCH/RFC 3/4]Introduce account modifiers mechanism

2007-08-17 Thread Laurent Vivier
Avi Kivity wrote: [...] The normal user/system accounting has the same issue, no? Whereever we happen to land (kernel or user) gets the whole tick. So I think it is okay to have the same limitation for guest time. So this is how it looks like. PATCH 1 and 2 are always a prerequisite.