Re: [net-next RFC PATCH 5/5] virtio-net: flow director support

2011-12-08 Thread Sridhar Samudrala
On 12/7/2011 3:02 AM, Jason Wang wrote: On 12/06/2011 11:42 PM, Sridhar Samudrala wrote: On 12/6/2011 5:15 AM, Stefan Hajnoczi wrote: On Tue, Dec 6, 2011 at 10:21 AM, Jason Wang wrote: On 12/06/2011 05:18 PM, Stefan Hajnoczi wrote: On Tue, Dec 6, 2011 at 6:33 AM, Jason Wang wrote: On 12/

Re: [net-next RFC PATCH 5/5] virtio-net: flow director support

2011-12-07 Thread Stefan Hajnoczi
On Wed, Dec 7, 2011 at 12:10 PM, Jason Wang wrote: > On 12/07/2011 05:08 PM, Stefan Hajnoczi wrote: > [...] > >>> >  Consider the complexity of the host nic each with their own steering >>> >  features,  this series make the first step with minimal effort to try >>> > to let >>> >  guest driver an

Re: [net-next RFC PATCH 5/5] virtio-net: flow director support

2011-12-07 Thread Jason Wang
On 12/07/2011 05:08 PM, Stefan Hajnoczi wrote: [...] > Consider the complexity of the host nic each with their own steering > features, this series make the first step with minimal effort to try to let > guest driver and host tap/macvtap co-operate like what physical nic does. > There may be

Re: [net-next RFC PATCH 5/5] virtio-net: flow director support

2011-12-07 Thread Jason Wang
On 12/07/2011 07:10 AM, Sridhar Samudrala wrote: On 12/6/2011 8:14 AM, Michael S. Tsirkin wrote: On Tue, Dec 06, 2011 at 07:42:54AM -0800, Sridhar Samudrala wrote: On 12/6/2011 5:15 AM, Stefan Hajnoczi wrote: On Tue, Dec 6, 2011 at 10:21 AM, Jason Wang wrote: On 12/06/2011 05:18 PM, Stefan

Re: [net-next RFC PATCH 5/5] virtio-net: flow director support

2011-12-07 Thread Jason Wang
On 12/06/2011 11:42 PM, Sridhar Samudrala wrote: On 12/6/2011 5:15 AM, Stefan Hajnoczi wrote: On Tue, Dec 6, 2011 at 10:21 AM, Jason Wang wrote: On 12/06/2011 05:18 PM, Stefan Hajnoczi wrote: On Tue, Dec 6, 2011 at 6:33 AM, Jason Wang wrote: On 12/05/2011 06:55 PM, Stefan Hajnoczi wrote:

Re: [net-next RFC PATCH 5/5] virtio-net: flow director support

2011-12-07 Thread Stefan Hajnoczi
On Wed, Dec 7, 2011 at 3:03 AM, Jason Wang wrote: > On 12/06/2011 09:15 PM, Stefan Hajnoczi wrote: >> >> On Tue, Dec 6, 2011 at 10:21 AM, Jason Wang  wrote: >>> >>> On 12/06/2011 05:18 PM, Stefan Hajnoczi wrote: On Tue, Dec 6, 2011 at 6:33 AM, Jason Wang  wrote: > > On 12/05

Re: [net-next RFC PATCH 5/5] virtio-net: flow director support

2011-12-06 Thread Jason Wang
On 12/06/2011 09:15 PM, Stefan Hajnoczi wrote: On Tue, Dec 6, 2011 at 10:21 AM, Jason Wang wrote: On 12/06/2011 05:18 PM, Stefan Hajnoczi wrote: On Tue, Dec 6, 2011 at 6:33 AM, Jason Wangwrote: On 12/05/2011 06:55 PM, Stefan Hajnoczi wrote: On Mon, Dec 5, 2011 at 8:59 AM, Jason Wang wr

Re: [net-next RFC PATCH 5/5] virtio-net: flow director support

2011-12-06 Thread Sridhar Samudrala
On 12/6/2011 8:14 AM, Michael S. Tsirkin wrote: On Tue, Dec 06, 2011 at 07:42:54AM -0800, Sridhar Samudrala wrote: On 12/6/2011 5:15 AM, Stefan Hajnoczi wrote: On Tue, Dec 6, 2011 at 10:21 AM, Jason Wang wrote: On 12/06/2011 05:18 PM, Stefan Hajnoczi wrote: On Tue, Dec 6, 2011 at 6:33 AM, J

Re: [net-next RFC PATCH 5/5] virtio-net: flow director support

2011-12-06 Thread Ben Hutchings
On Tue, 2011-12-06 at 15:25 +0800, Jason Wang wrote: > On 12/06/2011 04:42 AM, Ben Hutchings wrote: [...] > > This is not a proper implementation of ndo_rx_flow_steer. If you steer > > a flow by changing the RSS table this can easily cause packet reordering > > in other flows. The filtering shoul

Re: [net-next RFC PATCH 5/5] virtio-net: flow director support

2011-12-06 Thread Michael S. Tsirkin
On Tue, Dec 06, 2011 at 07:42:54AM -0800, Sridhar Samudrala wrote: > On 12/6/2011 5:15 AM, Stefan Hajnoczi wrote: > >On Tue, Dec 6, 2011 at 10:21 AM, Jason Wang wrote: > >>On 12/06/2011 05:18 PM, Stefan Hajnoczi wrote: > >>>On Tue, Dec 6, 2011 at 6:33 AM, Jason Wangwrote: > On 12/05/2011 0

Re: [net-next RFC PATCH 5/5] virtio-net: flow director support

2011-12-06 Thread Sridhar Samudrala
On 12/6/2011 5:15 AM, Stefan Hajnoczi wrote: On Tue, Dec 6, 2011 at 10:21 AM, Jason Wang wrote: On 12/06/2011 05:18 PM, Stefan Hajnoczi wrote: On Tue, Dec 6, 2011 at 6:33 AM, Jason Wangwrote: On 12/05/2011 06:55 PM, Stefan Hajnoczi wrote: On Mon, Dec 5, 2011 at 8:59 AM, Jason Wang wrot

Re: [net-next RFC PATCH 5/5] virtio-net: flow director support

2011-12-06 Thread Stefan Hajnoczi
On Tue, Dec 6, 2011 at 10:21 AM, Jason Wang wrote: > On 12/06/2011 05:18 PM, Stefan Hajnoczi wrote: >> >> On Tue, Dec 6, 2011 at 6:33 AM, Jason Wang  wrote: >>> >>> On 12/05/2011 06:55 PM, Stefan Hajnoczi wrote: On Mon, Dec 5, 2011 at 8:59 AM, Jason Wang  wrote: >> The vcpus are jus

Re: [net-next RFC PATCH 5/5] virtio-net: flow director support

2011-12-06 Thread Jason Wang
On 12/06/2011 05:18 PM, Stefan Hajnoczi wrote: On Tue, Dec 6, 2011 at 6:33 AM, Jason Wang wrote: On 12/05/2011 06:55 PM, Stefan Hajnoczi wrote: On Mon, Dec 5, 2011 at 8:59 AM, Jason Wangwrote: +static int virtnet_set_fd(struct net_device *dev, u32 pfn) +{ + struct virtnet_info *vi =

Re: [net-next RFC PATCH 5/5] virtio-net: flow director support

2011-12-06 Thread Stefan Hajnoczi
On Tue, Dec 6, 2011 at 6:33 AM, Jason Wang wrote: > On 12/05/2011 06:55 PM, Stefan Hajnoczi wrote: >> >> On Mon, Dec 5, 2011 at 8:59 AM, Jason Wang  wrote: >>> >>> +static int virtnet_set_fd(struct net_device *dev, u32 pfn) >>> +{ >>> +       struct virtnet_info *vi = netdev_priv(dev); >>> +      

Re: [net-next RFC PATCH 5/5] virtio-net: flow director support

2011-12-05 Thread Jason Wang
On 12/06/2011 04:42 AM, Ben Hutchings wrote: On Mon, 2011-12-05 at 16:59 +0800, Jason Wang wrote: In order to let the packets of a flow to be passed to the desired guest cpu, we can co-operate with devices through programming the flow director which was just a hash to queue table. This kinds of

Re: [net-next RFC PATCH 5/5] virtio-net: flow director support

2011-12-05 Thread Jason Wang
On 12/05/2011 06:55 PM, Stefan Hajnoczi wrote: On Mon, Dec 5, 2011 at 8:59 AM, Jason Wang wrote: +static int virtnet_set_fd(struct net_device *dev, u32 pfn) +{ + struct virtnet_info *vi = netdev_priv(dev); + struct virtio_device *vdev = vi->vdev; + + if (virtio_has_feature(vde

Re: [net-next RFC PATCH 5/5] virtio-net: flow director support

2011-12-05 Thread Ben Hutchings
On Mon, 2011-12-05 at 16:59 +0800, Jason Wang wrote: > In order to let the packets of a flow to be passed to the desired > guest cpu, we can co-operate with devices through programming the flow > director which was just a hash to queue table. > > This kinds of co-operation is done through the acce

Re: [net-next RFC PATCH 5/5] virtio-net: flow director support

2011-12-05 Thread Stefan Hajnoczi
On Mon, Dec 5, 2011 at 8:59 AM, Jason Wang wrote: > +static int virtnet_set_fd(struct net_device *dev, u32 pfn) > +{ > +       struct virtnet_info *vi = netdev_priv(dev); > +       struct virtio_device *vdev = vi->vdev; > + > +       if (virtio_has_feature(vdev, VIRTIO_NET_F_HOST_FD)) { > +      

[net-next RFC PATCH 5/5] virtio-net: flow director support

2011-12-05 Thread Jason Wang
In order to let the packets of a flow to be passed to the desired guest cpu, we can co-operate with devices through programming the flow director which was just a hash to queue table. This kinds of co-operation is done through the accelerate RFS support, a device specific flow sterring method virt