Re: [patch v2] virtio: console: cleanup an error message

2013-07-30 Thread Rusty Russell
Dan Carpenter dan.carpen...@oracle.com writes: The PTR_ERR(NULL) here is not useful. Signed-off-by: Dan Carpenter dan.carpen...@oracle.com --- v2: completely different Applied. Thanks, Rusty. diff --git a/drivers/char/virtio_console.c b/drivers/char/virtio_console.c index

Re: [patch v2] virtio: console: cleanup an error message

2013-07-29 Thread Amit Shah
On (Mon) 22 Jul 2013 [23:41:00], Dan Carpenter wrote: The PTR_ERR(NULL) here is not useful. Signed-off-by: Dan Carpenter dan.carpen...@oracle.com --- v2: completely different diff --git a/drivers/char/virtio_console.c b/drivers/char/virtio_console.c index 1b456fe..4cf46d8 100644 ---

Re: [patch v2] virtio: console: cleanup an error message

2013-07-29 Thread Greg Kroah-Hartman
On Mon, Jul 29, 2013 at 12:41:31PM +0530, Amit Shah wrote: On (Mon) 22 Jul 2013 [23:41:00], Dan Carpenter wrote: The PTR_ERR(NULL) here is not useful. Signed-off-by: Dan Carpenter dan.carpen...@oracle.com --- v2: completely different diff --git a/drivers/char/virtio_console.c

Re: [patch v2] virtio: console: cleanup an error message

2013-07-29 Thread Dan Carpenter
On Mon, Jul 29, 2013 at 06:12:31AM -0700, Greg Kroah-Hartman wrote: On Mon, Jul 29, 2013 at 12:41:31PM +0530, Amit Shah wrote: On (Mon) 22 Jul 2013 [23:41:00], Dan Carpenter wrote: The PTR_ERR(NULL) here is not useful. Signed-off-by: Dan Carpenter dan.carpen...@oracle.com ---

Re: [patch v2] virtio: console: cleanup an error message

2013-07-29 Thread Greg Kroah-Hartman
On Mon, Jul 29, 2013 at 04:35:38PM +0300, Dan Carpenter wrote: On Mon, Jul 29, 2013 at 06:12:31AM -0700, Greg Kroah-Hartman wrote: On Mon, Jul 29, 2013 at 12:41:31PM +0530, Amit Shah wrote: On (Mon) 22 Jul 2013 [23:41:00], Dan Carpenter wrote: The PTR_ERR(NULL) here is not useful.

[patch v2] virtio: console: cleanup an error message

2013-07-22 Thread Dan Carpenter
The PTR_ERR(NULL) here is not useful. Signed-off-by: Dan Carpenter dan.carpen...@oracle.com --- v2: completely different diff --git a/drivers/char/virtio_console.c b/drivers/char/virtio_console.c index 1b456fe..4cf46d8 100644 --- a/drivers/char/virtio_console.c +++

Re: [patch v2] virtio: console: cleanup an error message

2013-07-22 Thread Greg Kroah-Hartman
On Mon, Jul 22, 2013 at 11:41:00PM +0300, Dan Carpenter wrote: The PTR_ERR(NULL) here is not useful. Signed-off-by: Dan Carpenter dan.carpen...@oracle.com --- v2: completely different diff --git a/drivers/char/virtio_console.c b/drivers/char/virtio_console.c index 1b456fe..4cf46d8 100644