size as buffer length for
big packets
On Tue, Aug 09, 2022 at 09:49:03PM +, Parav Pandit wrote:
From: Michael S. Tsirkin
Sent: Tuesday, August 9, 2022 5:38 PM
[..]
I think virtio-net driver doesn't differentiate MTU and MRU, in
which case the receive buffer will be reduced to fit the
On Wed, Aug 10, 2022 at 05:06:33PM +, Parav Pandit wrote:
>
> > From: Michael S. Tsirkin
> > Sent: Wednesday, August 10, 2022 12:59 PM
> >
> > On Wed, Aug 10, 2022 at 04:22:41PM +, Parav Pandit wrote:
> > >
> > > > From: Michael S. Tsirkin
> > > > Sent: Wednesday, August 10, 2022 12:05
> From: Michael S. Tsirkin
> Sent: Wednesday, August 10, 2022 12:59 PM
>
> On Wed, Aug 10, 2022 at 04:22:41PM +, Parav Pandit wrote:
> >
> > > From: Michael S. Tsirkin
> > > Sent: Wednesday, August 10, 2022 12:05 PM
> > >
> > > On Wed, Aug 10, 2022 at 04:00:08PM +, Parav Pandit wrote:
On Wed, Aug 10, 2022 at 12:58:58PM -0400, Michael S. Tsirkin wrote:
> On Wed, Aug 10, 2022 at 04:22:41PM +, Parav Pandit wrote:
> >
> > > From: Michael S. Tsirkin
> > > Sent: Wednesday, August 10, 2022 12:05 PM
> > >
> > > On Wed, Aug 10, 2022 at 04:00:08PM +, Parav Pandit wrote:
> > > >
On Wed, Aug 10, 2022 at 04:22:41PM +, Parav Pandit wrote:
>
> > From: Michael S. Tsirkin
> > Sent: Wednesday, August 10, 2022 12:05 PM
> >
> > On Wed, Aug 10, 2022 at 04:00:08PM +, Parav Pandit wrote:
> > >
> > > > From: Michael S. Tsirkin
> > > > Sent: Wednesday, August 10, 2022 5:03 A
> From: Michael S. Tsirkin
> Sent: Wednesday, August 10, 2022 12:05 PM
>
> On Wed, Aug 10, 2022 at 04:00:08PM +, Parav Pandit wrote:
> >
> > > From: Michael S. Tsirkin
> > > Sent: Wednesday, August 10, 2022 5:03 AM
> > > > >
> > > > > Should we make this depend on the vq reset ability mayb
On Wed, Aug 10, 2022 at 04:00:08PM +, Parav Pandit wrote:
>
> > From: Michael S. Tsirkin
> > Sent: Wednesday, August 10, 2022 5:03 AM
> > > >
> > > > Should we make this depend on the vq reset ability maybe?
> > >
> > > The advantage of this is to keep TX working. Or we can use device
> > > r
> From: Michael S. Tsirkin
> Sent: Wednesday, August 10, 2022 5:03 AM
> > >
> > > Should we make this depend on the vq reset ability maybe?
> >
> > The advantage of this is to keep TX working. Or we can use device
> > reset as a fallback if there's no vq reset.
> >
> > Thanks
>
> Device reset i
; > > Cc: Si-Wei Liu ; Jason Wang
> > > > > > ; Gavin Li ; Hemminger,
> > > > > > Stephen ; davem
> > > > > > ; virtualization > > > > > foundation.org>; Virtio-Dev ;
> > > > > > jesse.brandeb...@intel.com; alexander.h.du.
t; > > > > ; virtualization > > > > foundation.org>; Virtio-Dev ;
> > > > > jesse.brandeb...@intel.com; alexander.h.du...@intel.com;
> > > > > kubak...@wp.pl; sridhar.samudr...@intel.com; losewe...@gmail.com; Gavi
> > > > > Teitz
brandeb...@intel.com; alexander.h.du...@intel.com;
> > > > kubak...@wp.pl; sridhar.samudr...@intel.com; losewe...@gmail.com; Gavi
> > > > Teitz
> > > > Subject: Re: [virtio-dev] [PATCH] virtio-net: use mtu size as buffer
> > > > length for
> >
gt; > ; Gavin Li ; Hemminger,
> > > Stephen ; davem
> > > ; virtualization > > foundation.org>; Virtio-Dev ;
> > > jesse.brandeb...@intel.com; alexander.h.du...@intel.com;
> > > kubak...@wp.pl; sridhar.samudr...@intel.com; losewe...@gmail.com; Gavi
> &
在 2022/8/10 06:54, Si-Wei Liu 写道:
On 8/9/2022 3:37 PM, Michael S. Tsirkin wrote:
On Tue, Aug 09, 2022 at 03:32:26PM -0700, Si-Wei Liu wrote:
On 8/9/2022 2:37 PM, Michael S. Tsirkin wrote:
On Tue, Aug 09, 2022 at 07:18:30PM +, Parav Pandit wrote:
From: Si-Wei Liu
Sent: Tuesday, August
在 2022/8/10 02:38, Si-Wei Liu 写道:
On 8/9/2022 12:44 AM, Jason Wang wrote:
On Tue, Aug 9, 2022 at 3:07 PM Gavin Li wrote:
On 8/9/2022 7:56 AM, Si-Wei Liu wrote:
External email: Use caution opening links or attachments
On 8/8/2022 12:31 AM, Gavin Li wrote:
On 8/6/2022 6:11 AM, Si-Wei Li
...@wp.pl; sridhar.samudr...@intel.com; losewe...@gmail.com; Gavi
Teitz
Subject: Re: [virtio-dev] [PATCH] virtio-net: use mtu size as buffer length for
big packets
On Tue, Aug 09, 2022 at 09:49:03PM +, Parav Pandit wrote:
From: Michael S. Tsirkin
Sent: Tuesday, August 9, 2022 5:38 PM
[..]
I think
On Tue, Aug 09, 2022 at 10:49:48PM +, Parav Pandit wrote:
> > > When user prefers to override the device RO field, device is in the dark
> > > and
> > things work on best effort basis.
> >
> > Dropping packets is best effort. Getting stuck forever isn't, that's a
> > quality of
> > implement
On Tue, Aug 09, 2022 at 03:54:57PM -0700, Si-Wei Liu wrote:
>
>
> On 8/9/2022 3:37 PM, Michael S. Tsirkin wrote:
> > On Tue, Aug 09, 2022 at 03:32:26PM -0700, Si-Wei Liu wrote:
> > >
> > > On 8/9/2022 2:37 PM, Michael S. Tsirkin wrote:
> > > > On Tue, Aug 09, 2022 at 07:18:30PM +, Parav Pand
tualization > foundation.org>; Virtio-Dev ;
> > jesse.brandeb...@intel.com; alexander.h.du...@intel.com;
> > kubak...@wp.pl; sridhar.samudr...@intel.com; losewe...@gmail.com; Gavi
> > Teitz
> > Subject: Re: [virtio-dev] [PATCH] virtio-net: use mtu size as buffer length
> >
On 8/9/2022 3:37 PM, Michael S. Tsirkin wrote:
On Tue, Aug 09, 2022 at 03:32:26PM -0700, Si-Wei Liu wrote:
On 8/9/2022 2:37 PM, Michael S. Tsirkin wrote:
On Tue, Aug 09, 2022 at 07:18:30PM +, Parav Pandit wrote:
From: Si-Wei Liu
Sent: Tuesday, August 9, 2022 3:09 PM
From: Si-Wei Liu
intel.com;
> kubak...@wp.pl; sridhar.samudr...@intel.com; losewe...@gmail.com; Gavi
> Teitz
> Subject: Re: [virtio-dev] [PATCH] virtio-net: use mtu size as buffer length
> for
> big packets
>
> On Tue, Aug 09, 2022 at 09:49:03PM +, Parav Pandit wrote:
> > > From: Michae
On Tue, Aug 09, 2022 at 03:32:26PM -0700, Si-Wei Liu wrote:
>
>
> On 8/9/2022 2:37 PM, Michael S. Tsirkin wrote:
> > On Tue, Aug 09, 2022 at 07:18:30PM +, Parav Pandit wrote:
> > > > From: Si-Wei Liu
> > > > Sent: Tuesday, August 9, 2022 3:09 PM
> > > > > > From: Si-Wei Liu
> > > > > > Sent
On 8/9/2022 2:37 PM, Michael S. Tsirkin wrote:
On Tue, Aug 09, 2022 at 07:18:30PM +, Parav Pandit wrote:
From: Si-Wei Liu
Sent: Tuesday, August 9, 2022 3:09 PM
From: Si-Wei Liu
Sent: Tuesday, August 9, 2022 2:39 PM Currently it is not. Not a
single patch nor this patch, but the context
On Tue, Aug 09, 2022 at 02:39:49PM -0700, Si-Wei Liu wrote:
>
>
> On 8/9/2022 2:34 PM, Michael S. Tsirkin wrote:
> > On Tue, Aug 09, 2022 at 11:38:52AM -0700, Si-Wei Liu wrote:
> > >
> > > On 8/9/2022 12:44 AM, Jason Wang wrote:
> > > > On Tue, Aug 9, 2022 at 3:07 PM Gavin Li wrote:
> > > > > O
On Tue, Aug 09, 2022 at 09:49:03PM +, Parav Pandit wrote:
> > From: Michael S. Tsirkin
> > Sent: Tuesday, August 9, 2022 5:38 PM
>
> [..]
> > > > I think virtio-net driver doesn't differentiate MTU and MRU, in
> > > > which case the receive buffer will be reduced to fit the 1500B
> > > > payl
> From: Michael S. Tsirkin
> Sent: Tuesday, August 9, 2022 5:38 PM
[..]
> > > I think virtio-net driver doesn't differentiate MTU and MRU, in
> > > which case the receive buffer will be reduced to fit the 1500B
> > > payload size when mtu is lowered down to 1500 from 9000.
> > How? Driver reduced
On 8/9/2022 2:34 PM, Michael S. Tsirkin wrote:
On Tue, Aug 09, 2022 at 11:38:52AM -0700, Si-Wei Liu wrote:
On 8/9/2022 12:44 AM, Jason Wang wrote:
On Tue, Aug 9, 2022 at 3:07 PM Gavin Li wrote:
On 8/9/2022 7:56 AM, Si-Wei Liu wrote:
External email: Use caution opening links or attachment
On Tue, Aug 09, 2022 at 07:18:30PM +, Parav Pandit wrote:
> > From: Si-Wei Liu
> > Sent: Tuesday, August 9, 2022 3:09 PM
>
> > >> From: Si-Wei Liu
> > >> Sent: Tuesday, August 9, 2022 2:39 PM Currently it is not. Not a
> > >> single patch nor this patch, but the context for the eventual goal
On Tue, Aug 09, 2022 at 11:38:52AM -0700, Si-Wei Liu wrote:
>
>
> On 8/9/2022 12:44 AM, Jason Wang wrote:
> > On Tue, Aug 9, 2022 at 3:07 PM Gavin Li wrote:
> > >
> > > On 8/9/2022 7:56 AM, Si-Wei Liu wrote:
> > >
> > > External email: Use caution opening links or attachments
> > >
> > >
> >
On Tue, Aug 09, 2022 at 09:13:42PM +, Parav Pandit wrote:
> > From: Si-Wei Liu
> > Sent: Tuesday, August 9, 2022 4:33 PM
> >
> > On 8/9/2022 12:18 PM, Parav Pandit wrote:
> > >> From: Si-Wei Liu
> > >> Sent: Tuesday, August 9, 2022 3:09 PM
> > From: Si-Wei Liu
> > Sent: Tuesday, A
> From: Si-Wei Liu
> Sent: Tuesday, August 9, 2022 4:33 PM
>
> On 8/9/2022 12:18 PM, Parav Pandit wrote:
> >> From: Si-Wei Liu
> >> Sent: Tuesday, August 9, 2022 3:09 PM
> From: Si-Wei Liu
> Sent: Tuesday, August 9, 2022 2:39 PM Currently it is not. Not a
> single patch nor this
On 8/9/2022 12:18 PM, Parav Pandit wrote:
From: Si-Wei Liu
Sent: Tuesday, August 9, 2022 3:09 PM
From: Si-Wei Liu
Sent: Tuesday, August 9, 2022 2:39 PM Currently it is not. Not a
single patch nor this patch, but the context for the eventual goal is
to allow XDP on a MTU=9000 link when guest
> From: Si-Wei Liu
> Sent: Tuesday, August 9, 2022 3:09 PM
> >> From: Si-Wei Liu
> >> Sent: Tuesday, August 9, 2022 2:39 PM Currently it is not. Not a
> >> single patch nor this patch, but the context for the eventual goal is
> >> to allow XDP on a MTU=9000 link when guest users intentionally lo
On 8/9/2022 11:42 AM, Parav Pandit wrote:
From: Si-Wei Liu
Sent: Tuesday, August 9, 2022 2:39 PM
Currently it is not. Not a single patch nor this patch, but the context for the
eventual goal is to allow XDP on a MTU=9000 link when guest users
intentionally lower down MTU to 1500.
Which appli
> From: Si-Wei Liu
> Sent: Tuesday, August 9, 2022 2:39 PM
> Currently it is not. Not a single patch nor this patch, but the context for
> the
> eventual goal is to allow XDP on a MTU=9000 link when guest users
> intentionally lower down MTU to 1500.
Which application benefit by having asymmetr
On 8/9/2022 12:44 AM, Jason Wang wrote:
On Tue, Aug 9, 2022 at 3:07 PM Gavin Li wrote:
On 8/9/2022 7:56 AM, Si-Wei Liu wrote:
External email: Use caution opening links or attachments
On 8/8/2022 12:31 AM, Gavin Li wrote:
On 8/6/2022 6:11 AM, Si-Wei Liu wrote:
External email: Use cauti
On 8/9/2022 12:06 AM, Gavin Li wrote:
On 8/9/2022 7:56 AM, Si-Wei Liu wrote:
External email: Use caution opening links or attachments
On 8/8/2022 12:31 AM, Gavin Li wrote:
On 8/6/2022 6:11 AM, Si-Wei Liu wrote:
External email: Use caution opening links or attachments
On 8/1/2022 9:45
On Tue, Aug 9, 2022 at 5:25 PM Michael S. Tsirkin wrote:
>
> On Tue, Aug 09, 2022 at 03:44:22PM +0800, Jason Wang wrote:
> > > + unsigned int mtu = vi->dev->mtu;
>
> BTW should this not be max_mtu?
Yes.
> Otherwise if user configures mtu that
> is too small we'll add buffers that are
On Tue, Aug 9, 2022 at 5:22 PM Michael S. Tsirkin wrote:
>
> On Tue, Aug 09, 2022 at 03:44:22PM +0800, Jason Wang wrote:
> > > @@ -3571,8 +3581,10 @@ static int virtnet_probe(struct virtio_device
> > > *vdev)
> > > if (virtio_has_feature(vdev, VIRTIO_NET_F_GUEST_TSO4) ||
> > > virt
On Tue, Aug 09, 2022 at 03:44:22PM +0800, Jason Wang wrote:
> > + unsigned int mtu = vi->dev->mtu;
BTW should this not be max_mtu? Otherwise if user configures mtu that
is too small we'll add buffers that are too small. some backends simply
lock up if this happens (I think vhost does
On Tue, Aug 09, 2022 at 03:44:22PM +0800, Jason Wang wrote:
> > @@ -3571,8 +3581,10 @@ static int virtnet_probe(struct virtio_device
> > *vdev)
> > if (virtio_has_feature(vdev, VIRTIO_NET_F_GUEST_TSO4) ||
> > virtio_has_feature(vdev, VIRTIO_NET_F_GUEST_TSO6) ||
> > virtio_
On Tue, Aug 9, 2022 at 3:07 PM Gavin Li wrote:
>
>
> On 8/9/2022 7:56 AM, Si-Wei Liu wrote:
>
> External email: Use caution opening links or attachments
>
>
> On 8/8/2022 12:31 AM, Gavin Li wrote:
>
>
> On 8/6/2022 6:11 AM, Si-Wei Liu wrote:
>
> External email: Use caution opening links or attachm
On 8/8/2022 12:31 AM, Gavin Li wrote:
On 8/6/2022 6:11 AM, Si-Wei Liu wrote:
External email: Use caution opening links or attachments
On 8/1/2022 9:45 PM, Gavin Li wrote:
Currently add_recvbuf_big() allocates MAX_SKB_FRAGS segments for big
packets even when GUEST_* offloads are not present
On 8/5/2022 3:11 PM, Si-Wei Liu wrote:
On 8/1/2022 9:45 PM, Gavin Li wrote:
Currently add_recvbuf_big() allocates MAX_SKB_FRAGS segments for big
packets even when GUEST_* offloads are not present on the device.
However, if GSO is not supported,
GUEST GSO (virtio term), or GRO HW (netdev core
On 8/1/2022 9:45 PM, Gavin Li wrote:
Currently add_recvbuf_big() allocates MAX_SKB_FRAGS segments for big
packets even when GUEST_* offloads are not present on the device.
However, if GSO is not supported,
GUEST GSO (virtio term), or GRO HW (netdev core term) it should have
been be called.
On Thu, Aug 4, 2022 at 3:23 PM Jason Wang wrote:
>
> On Thu, Aug 4, 2022 at 3:10 PM Michael S. Tsirkin wrote:
> >
> > On Thu, Aug 04, 2022 at 01:00:46PM +0800, Jason Wang wrote:
> > > On Tue, Aug 2, 2022 at 12:47 PM Gavin Li wrote:
> > > >
> > > > Currently add_recvbuf_big() allocates MAX_SKB_FR
On Thu, Aug 4, 2022 at 3:10 PM Michael S. Tsirkin wrote:
>
> On Thu, Aug 04, 2022 at 01:00:46PM +0800, Jason Wang wrote:
> > On Tue, Aug 2, 2022 at 12:47 PM Gavin Li wrote:
> > >
> > > Currently add_recvbuf_big() allocates MAX_SKB_FRAGS segments for big
> > > packets even when GUEST_* offloads ar
On Thu, Aug 04, 2022 at 01:00:46PM +0800, Jason Wang wrote:
> On Tue, Aug 2, 2022 at 12:47 PM Gavin Li wrote:
> >
> > Currently add_recvbuf_big() allocates MAX_SKB_FRAGS segments for big
> > packets even when GUEST_* offloads are not present on the device.
> > However, if GSO is not supported, it
On Tue, Aug 2, 2022 at 12:47 PM Gavin Li wrote:
>
> Currently add_recvbuf_big() allocates MAX_SKB_FRAGS segments for big
> packets even when GUEST_* offloads are not present on the device.
> However, if GSO is not supported, it would be sufficient to allocate
> segments to cover just up the MTU si
48 matches
Mail list logo
