Re: Multicast and receive filtering in TUN/TAP

2008-07-11 Thread Max Krasnyansky
Rusty Russell wrote: On Friday 11 July 2008 12:20:07 Max Krasnyansky wrote: I haven't looked at the virtio stuff much, I was assuming that the host side of it is still the TUN driver. Is it not ? Yes, the host side is still tun/tap. The problem is that qemu doesnt know which multicast

Re: Multicast and receive filtering in TUN/TAP

2008-07-11 Thread Brian Braunstein
Sorry that I was confused here and it seems I am still confused. I was thinking that for any one instance of a TAP interface, there should be only 1 MAC address, since there is only 1 network interface, since the character device is not a network interface but rather the interface for the

Re: Multicast and receive filtering in TUN/TAP

2008-07-10 Thread Christian Borntraeger
Am Donnerstag, 10. Juli 2008 schrieb Max Krasnyansky: [...] The second question is do you guys think that QEMU/KVM/LGUEST/etc would benefit if receive filtering was done by the host OS. Here is a specific example of what I'm talking about. We can do what qemu/hw/e1000.c:receive_filter() does

Re: Multicast and receive filtering in TUN/TAP

2008-07-10 Thread Max Krasnyansky
Christian Borntraeger wrote: Am Donnerstag, 10. Juli 2008 schrieb Max Krasnyansky: [...] The second question is do you guys think that QEMU/KVM/LGUEST/etc would benefit if receive filtering was done by the host OS. Here is a specific example of what I'm talking about. We can do what

Re: Multicast and receive filtering in TUN/TAP

2008-07-10 Thread Christian Borntraeger
Am Donnerstag, 10. Juli 2008 schrieb Max Krasnyansky: Thing is, we are heading towards virtio. Even for Windows ? Its possible: http://marc.info/?l=kvmm=121075389300722w=2 Unfortunately, virtio_net currently does not offer a method to register multicast addresses. I haven't looked at

Re: Multicast and receive filtering in TUN/TAP

2008-07-10 Thread Shaun Jackman
Hi Max, The original patch implemented receive multicast filtering by emulating the implementation used by many physical Ethernet interfaces: hashing the multicast address. TUN emulates two network cards (and communication via the virtual link between them), the guest and the host, or the

Re: Multicast and receive filtering in TUN/TAP

2008-07-10 Thread Max Krasnyansky
Brian Braunstein wrote: Sorry that I was confused here and it seems I am still confused. I was thinking that for any one instance of a TAP interface, there should be only 1 MAC address, since there is only 1 network interface, since the character device is not a network interface but

Multicast and receive filtering in TUN/TAP

2008-07-09 Thread Max Krasnyansky
Yesterday while fixing xoff stuckiness issue in the TUN/TAP driver I got a chance to look into the multicast filtering code in there. And immediately realized how terribly broken confusing it is. The patch was originally done by Shaun (CC'ed) and went in without any proper ACK from me, Dave