RE: [PATCH 097/117] Staging: hv: storvsc: Add code to handle IDE devices using the storvsc driver

2011-07-16 Thread KY Srinivasan
] Staging: hv: storvsc: Add code to handle IDE devices using the storvsc driver Thanks, this looks much cleaner than the initial variant. + if (dev_is_ide) { + storvsc_get_ide_info(device, target, path); + host_dev-path = device_info.path_id; + host_dev

RE: [PATCH 097/117] Staging: hv: storvsc: Add code to handle IDE devices using the storvsc driver

2011-07-16 Thread KY Srinivasan
Srinivasan Cc: gre...@suse.de; linux-ker...@vger.kernel.org; de...@linuxdriverproject.org; virtualizat...@lists.osdl.org; Haiyang Zhang Subject: Re: [PATCH 097/117] Staging: hv: storvsc: Add code to handle IDE devices using the storvsc driver Thanks, this looks much cleaner than

Re: [PATCH 097/117] Staging: hv: storvsc: Add code to handle IDE devices using the storvsc driver

2011-07-16 Thread Christoph Hellwig
On Sat, Jul 16, 2011 at 04:01:39PM +0300, Sasha Levin wrote: Is think that what Christoph meant was simplifying it to: if (dev_is_ide) storvsc_get_ide_info(device, target, path); host_dev-path = device_info.path_id; host_dev-target =

RE: [PATCH 097/117] Staging: hv: storvsc: Add code to handle IDE devices using the storvsc driver

2011-07-16 Thread Sasha Levin
...@lists.osdl.org; Haiyang Zhang Subject: Re: [PATCH 097/117] Staging: hv: storvsc: Add code to handle IDE devices using the storvsc driver Thanks, this looks much cleaner than the initial variant. + if (dev_is_ide) { + storvsc_get_ide_info(device, target, path

Re: [PATCH 097/117] Staging: hv: storvsc: Add code to handle IDE devices using the storvsc driver

2011-07-15 Thread Christoph Hellwig
Thanks, this looks much cleaner than the initial variant. + if (dev_is_ide) { + storvsc_get_ide_info(device, target, path); + host_dev-path = device_info.path_id; + host_dev-target = device_info.target_id; + } else { + host_dev-path =