g KH; gre...@suse.de;
> > linux-ker...@vger.kernel.org;
> > de...@linuxdriverproject.org; virtualizat...@lists.osdl.org
> > Subject: Re: various vmbus review comments
> >
> > On Mon, May 09, 2011 at 02:56:52PM +, KY Srinivasan wrote:
> > > I will address this. Greg had
> I must be missing something here. As I look at the block driver (and
> this is indicative of other drivers as well); the exit routine -
> blkvsc_drv_exit, first iterates through all the devices it manages
> and invokes device_unregister() on each of the devices and then
> invokes vmbus_child_dri
.org
> Subject: Re: various vmbus review comments
>
> On Mon, May 09, 2011 at 02:56:52PM +, KY Srinivasan wrote:
> > I will address this. Greg had a concern about module reference counting
> > and looking at the current code, it did not appear to be an issue. The
> >
On Mon, May 09, 2011 at 02:56:52PM +, KY Srinivasan wrote:
> I will address this. Greg had a concern about module reference counting
> and looking at the current code, it did not appear to be an issue. The
> change you are suggesting will not affect the vmbus core which is what I want
> to focu
> -Original Message-
> From: Christoph Hellwig [mailto:h...@infradead.org]
> Sent: Monday, May 09, 2011 10:34 AM
> To: KY Srinivasan
> Cc: Greg KH; gre...@suse.de; linux-ker...@vger.kernel.org;
> de...@linuxdriverproject.org; virtualizat...@lists.osdl.org
> Subje
On Fri, May 06, 2011 at 01:10:38PM +, KY Srinivasan wrote:
> I audited the block and the net drivers. As part of their exit routine,
> they invoke vmbus_child_driver_unregister() after properly cleaning
> up all the devices they are managing. Do you still see an issue with
> regards to module r
> -Original Message-
> From: Greg KH [mailto:g...@kroah.com]
> Sent: Sunday, May 08, 2011 11:05 PM
> To: KY Srinivasan
> Cc: gre...@suse.de; linux-ker...@vger.kernel.org;
> de...@linuxdriverproject.org; virtualizat...@lists.osdl.org
> Subject: Re: various vmbus re
On Mon, May 09, 2011 at 01:46:56AM +, KY Srinivasan wrote:
> > - the instances of hv_driver structures need to be static and
> > not programatically defined, like all other USB and PCI
> > drivers are handled.
>
> Done. You had expressed some concern that this would expose some
> -Original Message-
> From: Greg KH [mailto:g...@kroah.com]
> Sent: Tuesday, May 03, 2011 4:47 PM
> To: KY Srinivasan
> Cc: gre...@suse.de; linux-ker...@vger.kernel.org;
> de...@linuxdriverproject.org; virtualizat...@lists.osdl.org
> Subject: various vmbus review
> -Original Message-
> From: Greg KH [mailto:g...@kroah.com]
> Sent: Friday, May 06, 2011 11:00 AM
> To: KY Srinivasan
> Cc: gre...@suse.de; linux-ker...@vger.kernel.org;
> de...@linuxdriverproject.org; virtualizat...@lists.osdl.org
> Subject: Re: various vmbus re
On Fri, May 06, 2011 at 01:10:38PM +, KY Srinivasan wrote:
> > No, I am referring to the module reference counting of the bus drivers
> > that register with the vmbus core. You aren't doing that at all, and
> > you probably need to make sure that this isn't needed. That is
> > concentrating o
> -Original Message-
> From: Greg KH [mailto:g...@kroah.com]
> Sent: Wednesday, May 04, 2011 12:32 PM
> To: KY Srinivasan
> Cc: gre...@suse.de; linux-ker...@vger.kernel.org;
> de...@linuxdriverproject.org; virtualizat...@lists.osdl.org
> Subject: Re: various vmbus re
On Wed, May 04, 2011 at 04:58:39PM +, KY Srinivasan wrote:
> > > 2) hyperv_storage.h - this has all the definitions needed to build storage
> > > drivers for Hyper-V. Storage drivers will include hyperv.h and
> > > hyperv_storage.h.
> > >
> > > 3) hyperv_net.h - this has all the definitions nee
> -Original Message-
> From: Greg KH [mailto:g...@kroah.com]
> Sent: Wednesday, May 04, 2011 12:32 PM
> To: KY Srinivasan
> Cc: gre...@suse.de; linux-ker...@vger.kernel.org;
> de...@linuxdriverproject.org; virtualizat...@lists.osdl.org
> Subject: Re: various vmbus re
rg;
> > de...@linuxdriverproject.org; virtualizat...@lists.osdl.org
> > Subject: various vmbus review comments
> >
> > I just took a quick look at the vmbus code, and have the following
> > comments:
> > - why is count_hv_channel() even a function?
>
> I will
> -Original Message-
> From: Greg KH [mailto:g...@kroah.com]
> Sent: Tuesday, May 03, 2011 4:47 PM
> To: KY Srinivasan
> Cc: gre...@suse.de; linux-ker...@vger.kernel.org;
> de...@linuxdriverproject.org; virtualizat...@lists.osdl.org
> Subject: various vmbus review
> -Original Message-
> From: Greg KH [mailto:g...@kroah.com]
> Sent: Tuesday, May 03, 2011 6:04 PM
> To: KY Srinivasan
> Cc: gre...@suse.de; linux-ker...@vger.kernel.org;
> de...@linuxdriverproject.org; virtualizat...@lists.osdl.org
> Subject: Re: various vmbus re
On Tue, May 03, 2011 at 09:00:01PM +, KY Srinivasan wrote:
> You had also suggested that I should ask for a community review once
> you had had applied my last set of patches. Now that you have applied
> all my patches, should I formally ask for this review?
I said something like "after my rev
> -Original Message-
> From: Greg KH [mailto:g...@kroah.com]
> Sent: Tuesday, May 03, 2011 4:47 PM
> To: KY Srinivasan
> Cc: gre...@suse.de; linux-ker...@vger.kernel.org;
> de...@linuxdriverproject.org; virtualizat...@lists.osdl.org
> Subject: various vmbus review
I just took a quick look at the vmbus code, and have the following
comments:
- why is count_hv_channel() even a function?
- your .h files need to be consolidated and renamed. You will
need a single hyperv.h file for include/linux/ that will
contain some of what
20 matches
Mail list logo
