Re: virtio-blk: should num_vqs be limited by num_possible_cpus()?

2019-03-21 Thread Stefan Hajnoczi
On Wed, Mar 20, 2019 at 08:53:33PM +0800, Jason Wang wrote: > > On 2019/3/19 上午10:22, Dongli Zhang wrote: > > Hi Jason, > > > > On 3/18/19 3:47 PM, Jason Wang wrote: > > > On 2019/3/15 下午8:41, Cornelia Huck wrote: > > > > On Fri, 15 Mar 2019 12:50:11 +0800 > > > > Jason Wang wrote: > > option

Re: virtio-blk: should num_vqs be limited by num_possible_cpus()?

2019-03-20 Thread Dongli Zhang
On 3/20/19 8:53 PM, Jason Wang wrote: > > On 2019/3/19 上午10:22, Dongli Zhang wrote: >> Hi Jason, >> >> On 3/18/19 3:47 PM, Jason Wang wrote: >>> On 2019/3/15 下午8:41, Cornelia Huck wrote: On Fri, 15 Mar 2019 12:50:11 +0800 Jason Wang wrote: > Or something like I proposed

Re: virtio-blk: should num_vqs be limited by num_possible_cpus()?

2019-03-20 Thread Jason Wang
On 2019/3/19 上午10:22, Dongli Zhang wrote: Hi Jason, On 3/18/19 3:47 PM, Jason Wang wrote: On 2019/3/15 下午8:41, Cornelia Huck wrote: On Fri, 15 Mar 2019 12:50:11 +0800 Jason Wang wrote: Or something like I proposed several years ago? https://do-db2.lkml.org/lkml/2014/12/25/169 Btw, for

Re: virtio-blk: should num_vqs be limited by num_possible_cpus()?

2019-03-18 Thread Dongli Zhang
Hi Jason, On 3/18/19 3:47 PM, Jason Wang wrote: > > On 2019/3/15 下午8:41, Cornelia Huck wrote: >> On Fri, 15 Mar 2019 12:50:11 +0800 >> Jason Wang wrote: >> >>> Or something like I proposed several years ago? >>> https://do-db2.lkml.org/lkml/2014/12/25/169 >>> >>> Btw, for virtio-net, I think we

Re: virtio-blk: should num_vqs be limited by num_possible_cpus()?

2019-03-18 Thread Jason Wang
On 2019/3/15 下午8:41, Cornelia Huck wrote: On Fri, 15 Mar 2019 12:50:11 +0800 Jason Wang wrote: Or something like I proposed several years ago? https://do-db2.lkml.org/lkml/2014/12/25/169 Btw, for virtio-net, I think we actually want to go for having a maximum number of supported queues like

Re: virtio-blk: should num_vqs be limited by num_possible_cpus()?

2019-03-15 Thread Cornelia Huck
On Fri, 15 Mar 2019 12:50:11 +0800 Jason Wang wrote: > Or something like I proposed several years ago? > https://do-db2.lkml.org/lkml/2014/12/25/169 > > Btw, for virtio-net, I think we actually want to go for having a maximum > number of supported queues like what hardware did. This would be

Re: virtio-blk: should num_vqs be limited by num_possible_cpus()?

2019-03-14 Thread Jason Wang
On 2019/3/14 下午2:12, Dongli Zhang wrote: On 3/13/19 5:39 PM, Cornelia Huck wrote: On Wed, 13 Mar 2019 11:26:04 +0800 Dongli Zhang wrote: On 3/13/19 1:33 AM, Cornelia Huck wrote: On Tue, 12 Mar 2019 10:22:46 -0700 (PDT) Dongli Zhang wrote: I observed that there is one msix vector for

Re: virtio-blk: should num_vqs be limited by num_possible_cpus()?

2019-03-14 Thread Dongli Zhang
On 03/14/2019 08:13 PM, Cornelia Huck wrote: > On Thu, 14 Mar 2019 14:12:32 +0800 > Dongli Zhang wrote: > >> On 3/13/19 5:39 PM, Cornelia Huck wrote: >>> On Wed, 13 Mar 2019 11:26:04 +0800 >>> Dongli Zhang wrote: >>> On 3/13/19 1:33 AM, Cornelia Huck wrote: > On Tue, 12 Mar

Re: virtio-blk: should num_vqs be limited by num_possible_cpus()?

2019-03-14 Thread Dongli Zhang
On 03/14/2019 08:32 PM, Michael S. Tsirkin wrote: > On Tue, Mar 12, 2019 at 10:22:46AM -0700, Dongli Zhang wrote: >> I observed that there is one msix vector for config and one shared vector >> for all queues in below qemu cmdline, when the num-queues for virtio-blk >> is more than the number

Re: virtio-blk: should num_vqs be limited by num_possible_cpus()?

2019-03-14 Thread Michael S. Tsirkin
On Tue, Mar 12, 2019 at 10:22:46AM -0700, Dongli Zhang wrote: > I observed that there is one msix vector for config and one shared vector > for all queues in below qemu cmdline, when the num-queues for virtio-blk > is more than the number of possible cpus: > > qemu: "-smp 4" while "-device >

Re: virtio-blk: should num_vqs be limited by num_possible_cpus()?

2019-03-14 Thread Cornelia Huck
On Thu, 14 Mar 2019 14:12:32 +0800 Dongli Zhang wrote: > On 3/13/19 5:39 PM, Cornelia Huck wrote: > > On Wed, 13 Mar 2019 11:26:04 +0800 > > Dongli Zhang wrote: > > > >> On 3/13/19 1:33 AM, Cornelia Huck wrote: > >>> On Tue, 12 Mar 2019 10:22:46 -0700 (PDT) > >>> Dongli Zhang wrote: >

Re: virtio-blk: should num_vqs be limited by num_possible_cpus()?

2019-03-14 Thread Dongli Zhang
On 3/13/19 5:39 PM, Cornelia Huck wrote: > On Wed, 13 Mar 2019 11:26:04 +0800 > Dongli Zhang wrote: > >> On 3/13/19 1:33 AM, Cornelia Huck wrote: >>> On Tue, 12 Mar 2019 10:22:46 -0700 (PDT) >>> Dongli Zhang wrote: >>> I observed that there is one msix vector for config and one

Re: virtio-blk: should num_vqs be limited by num_possible_cpus()?

2019-03-13 Thread Cornelia Huck
On Wed, 13 Mar 2019 11:26:04 +0800 Dongli Zhang wrote: > On 3/13/19 1:33 AM, Cornelia Huck wrote: > > On Tue, 12 Mar 2019 10:22:46 -0700 (PDT) > > Dongli Zhang wrote: > > > >> I observed that there is one msix vector for config and one shared vector > >> for all queues in below qemu cmdline,

Re: virtio-blk: should num_vqs be limited by num_possible_cpus()?

2019-03-12 Thread Dongli Zhang
On 3/13/19 1:33 AM, Cornelia Huck wrote: > On Tue, 12 Mar 2019 10:22:46 -0700 (PDT) > Dongli Zhang wrote: > >> I observed that there is one msix vector for config and one shared vector >> for all queues in below qemu cmdline, when the num-queues for virtio-blk >> is more than the number of

Re: virtio-blk: should num_vqs be limited by num_possible_cpus()?

2019-03-12 Thread Cornelia Huck
On Tue, 12 Mar 2019 10:22:46 -0700 (PDT) Dongli Zhang wrote: > I observed that there is one msix vector for config and one shared vector > for all queues in below qemu cmdline, when the num-queues for virtio-blk > is more than the number of possible cpus: > > qemu: "-smp 4" while "-device >

virtio-blk: should num_vqs be limited by num_possible_cpus()?

2019-03-12 Thread Dongli Zhang
I observed that there is one msix vector for config and one shared vector for all queues in below qemu cmdline, when the num-queues for virtio-blk is more than the number of possible cpus: qemu: "-smp 4" while "-device virtio-blk-pci,drive=drive-0,id=virtblk0,num-queues=6" # cat