[PATCHv2-RFC 0/2] qemu-kvm: MSI-X support

2009-05-20 Thread Michael S. Tsirkin
Here's a new version of MSI-X support patchset. I have completed save/load support, and added a global option to disable MSI-X. This is on top of qemu-kvm.git/queue Todo: split patch up, support configurations without kernel irqchip, apply to upstream qemu.git. Anthony, please take a look at

[PATCHv2-RFC 1/2] qemu-kvm: add MSI-X support

2009-05-20 Thread Michael S. Tsirkin
This adds MSI-X support infrastructure and uses that to enable MSI-X support in virtio net device. Also add a global option to disable MSI-X. Signed-off-by: Michael S. Tsirkin m...@redhat.com --- Makefile.target|2 +- hw/device-assignment.c |2 + hw/msix.c | 447

[PATCHv2-RFC 2/2] qemu-kvm: use common code for assigned msix

2009-05-20 Thread Michael S. Tsirkin
For assigned devices, use common code to enable msi-x. We need a special assigned option as assigned devices lack a standard way to get vector usage. Signed-off-by: Michael S. Tsirkin m...@redhat.com --- hw/device-assignment.c | 329

Re: [Qemu-devel] [PATCH] qemu: msi irq allocation api

2009-05-20 Thread Michael S. Tsirkin
On Wed, May 20, 2009 at 08:44:31PM +0300, Blue Swirl wrote: On 5/20/09, Michael S. Tsirkin m...@redhat.com wrote: On Wed, May 20, 2009 at 08:21:01PM +0300, Blue Swirl wrote: On 5/20/09, Michael S. Tsirkin m...@redhat.com wrote: define api for allocating/setting up msi-x irqs, and for

Re: [Qemu-devel] [PATCH] qemu: msi irq allocation api

2009-05-20 Thread Michael S. Tsirkin
On Wed, May 20, 2009 at 08:44:31PM +0300, Blue Swirl wrote: On 5/20/09, Michael S. Tsirkin m...@redhat.com wrote: On Wed, May 20, 2009 at 08:21:01PM +0300, Blue Swirl wrote: On 5/20/09, Michael S. Tsirkin m...@redhat.com wrote: define api for allocating/setting up msi-x irqs, and for

Re: [Qemu-devel] [PATCH] qemu: msi irq allocation api

2009-05-20 Thread Michael S. Tsirkin
On Wed, May 20, 2009 at 08:21:01PM +0300, Blue Swirl wrote: On 5/20/09, Michael S. Tsirkin m...@redhat.com wrote: define api for allocating/setting up msi-x irqs, and for updating them with msi-x vector information, supply implementation in ioapic. Please comment on this API: I intend to

Re: [Qemu-devel] [PATCH] qemu: msi irq allocation api

2009-05-20 Thread Blue Swirl
On 5/20/09, Avi Kivity a...@redhat.com wrote: Blue Swirl wrote: Sparc64 also uses packets (mondos, not implemented yet) for interrupt vector data, there the packet size is 8 * 64 bits. I think we should aim for a more generic API that covers this case also. Is the packet structure

Re: [Qemu-devel] [PATCH] qemu: msi irq allocation api

2009-05-20 Thread Blue Swirl
On 5/20/09, Michael S. Tsirkin m...@redhat.com wrote: On Wed, May 20, 2009 at 08:21:01PM +0300, Blue Swirl wrote: On 5/20/09, Michael S. Tsirkin m...@redhat.com wrote: define api for allocating/setting up msi-x irqs, and for updating them with msi-x vector information, supply

Re: [Qemu-devel] [PATCH] qemu: msi irq allocation api

2009-05-20 Thread Blue Swirl
On 5/20/09, Michael S. Tsirkin m...@redhat.com wrote: On Wed, May 20, 2009 at 08:44:31PM +0300, Blue Swirl wrote: On 5/20/09, Michael S. Tsirkin m...@redhat.com wrote: On Wed, May 20, 2009 at 08:21:01PM +0300, Blue Swirl wrote: On 5/20/09, Michael S. Tsirkin m...@redhat.com wrote:

Re: [Qemu-devel] [PATCH] qemu: msi irq allocation api

2009-05-20 Thread Avi Kivity
Blue Swirl wrote: Sparc64 also uses packets (mondos, not implemented yet) for interrupt vector data, there the packet size is 8 * 64 bits. I think we should aim for a more generic API that covers this case also. Is the packet structure visible to software? -- I have a truly marvellous

[PATCH] qemu: msi irq allocation api

2009-05-20 Thread Michael S. Tsirkin
define api for allocating/setting up msi-x irqs, and for updating them with msi-x vector information, supply implementation in ioapic. Please comment on this API: I intend to port my msi-x patch to work on top of it. Signed-off-by: Michael S. Tsirkin m...@redhat.com --- hw/apic.c |1 -

Re: [Qemu-devel] [PATCH] qemu: msi irq allocation api

2009-05-20 Thread Michael S. Tsirkin
On Wed, May 20, 2009 at 09:38:58PM +0300, Blue Swirl wrote: On 5/20/09, Michael S. Tsirkin m...@redhat.com wrote: On Wed, May 20, 2009 at 08:44:31PM +0300, Blue Swirl wrote: On 5/20/09, Michael S. Tsirkin m...@redhat.com wrote: On Wed, May 20, 2009 at 08:21:01PM +0300, Blue Swirl

Re: [Qemu-devel] [PATCH] qemu: msi irq allocation api

2009-05-20 Thread Michael S. Tsirkin
On Wed, May 20, 2009 at 11:02:24PM +0300, Michael S. Tsirkin wrote: On Wed, May 20, 2009 at 09:38:58PM +0300, Blue Swirl wrote: On 5/20/09, Michael S. Tsirkin m...@redhat.com wrote: On Wed, May 20, 2009 at 08:44:31PM +0300, Blue Swirl wrote: On 5/20/09, Michael S. Tsirkin

Re: [Qemu-devel] [PATCH] qemu: msi irq allocation api

2009-05-20 Thread Blue Swirl
On 5/20/09, Michael S. Tsirkin m...@redhat.com wrote: On Wed, May 20, 2009 at 09:38:58PM +0300, Blue Swirl wrote: On 5/20/09, Michael S. Tsirkin m...@redhat.com wrote: On Wed, May 20, 2009 at 08:44:31PM +0300, Blue Swirl wrote: On 5/20/09, Michael S. Tsirkin m...@redhat.com wrote:

Re: [Qemu-devel] [PATCH] qemu: msi irq allocation api

2009-05-20 Thread Blue Swirl
On 5/20/09, Michael S. Tsirkin m...@redhat.com wrote: On Wed, May 20, 2009 at 11:02:24PM +0300, Michael S. Tsirkin wrote: On Wed, May 20, 2009 at 09:38:58PM +0300, Blue Swirl wrote: On 5/20/09, Michael S. Tsirkin m...@redhat.com wrote: On Wed, May 20, 2009 at 08:44:31PM +0300, Blue

Re: [Qemu-devel] [PATCH] qemu: msi irq allocation api

2009-05-20 Thread Michael S. Tsirkin
On Wed, May 20, 2009 at 11:18:56PM +0300, Blue Swirl wrote: On 5/20/09, Michael S. Tsirkin m...@redhat.com wrote: On Wed, May 20, 2009 at 09:38:58PM +0300, Blue Swirl wrote: On 5/20/09, Michael S. Tsirkin m...@redhat.com wrote: On Wed, May 20, 2009 at 08:44:31PM +0300, Blue Swirl

Re: [Qemu-devel] [PATCH] qemu: msi irq allocation api

2009-05-20 Thread Michael S. Tsirkin
On Wed, May 20, 2009 at 11:26:42PM +0300, Blue Swirl wrote: On 5/20/09, Michael S. Tsirkin m...@redhat.com wrote: On Wed, May 20, 2009 at 11:02:24PM +0300, Michael S. Tsirkin wrote: On Wed, May 20, 2009 at 09:38:58PM +0300, Blue Swirl wrote: On 5/20/09, Michael S. Tsirkin

Re: [Qemu-devel] [PATCH] qemu: msi irq allocation api

2009-05-20 Thread Blue Swirl
On 5/20/09, Michael S. Tsirkin m...@redhat.com wrote: On Wed, May 20, 2009 at 11:26:42PM +0300, Blue Swirl wrote: On 5/20/09, Michael S. Tsirkin m...@redhat.com wrote: On Wed, May 20, 2009 at 11:02:24PM +0300, Michael S. Tsirkin wrote: On Wed, May 20, 2009 at 09:38:58PM +0300, Blue

Re: [PATCH 1/1] dm-ioband: I/O bandwidth controller

2009-05-20 Thread Ryo Tsuruta
Hi Vivek, Anyway, how are you taking care of priorities with-in same class. How will you make sure that a BE prio 0 request is not hidden behind BE prio 7 request? Same is true for prio with-in RT class. I changed io_limit parameter of dm-ioband and ran your test script again. io_limit is a