Re: [PATCH] virtio_blk: decrement index when blockdevice is removed

On 2011-04-05 06:49, Takuma Umeya wrote: When virtio block device is removed, index does not get decremented. When another virtio disk is attached it uses the next device letter to the one that is suppose to be available. Signed-off-by: Takuma Umeya tum...@redhat.com diff --git

KVM Forum 2011 - Save the Date

KVM Forum 2011 - Save the Date Conference: August 15 - 16, 2011 Location: Hyatt Regency Vancouver - Vancouver, Canada KVM is an industry leading open source hypervisor that provides an ideal platform for datacenter virtualization, virtual desktop infrastructure, and cloud computing. Once again,

Re: [PATCH] virtio_blk: decrement index when blockdevice is removed

On 2011-04-06 03:32, Rusty Russell wrote: On Tue, 05 Apr 2011 07:08:12 +0200, Jens Axboe jax...@fusionio.com wrote: On 2011-04-05 06:49, Takuma Umeya wrote: When virtio block device is removed, index does not get decremented. When another virtio disk is attached it uses the next device letter

[PATCH 2/2] Staging: hv: Zero out the request structure on allocation

As part of the cleanup of the I/O request structure, allocate them zeroed out. This fixes a bug that was introduced in the patch-set titled: Staging: hv: Cleanup-storage-drivers-phase-II. A corrected version of this patch-set was sent out earlier, however the earlier (buggy) version of this

[PATCH 1/2] Staging: hv: Properly capture the error state

Properly capture the error state after the completion of I/O. This fixes a bug that was introduced in the patch-set titled: Staging: hv: Cleanup-storage-drivers-phase-II. A corrected version of this patch-set was sent out earlier, however the earlier (buggy) version of this patch-set was already

[PATCH 0/2] Staging: hv: Fixup Phase II storage driver cleanup

This fixes a couple of bugs that was introduced in the patch-set titled: Staging: hv: Cleanup storage drivers phase II. A corrected version of this patch-set was sent out earlier, however the earlier (buggy) version of this patch-set was already applied. This patch set fixes this problem..

Re: [PATCH] virtio_blk: decrement index when blockdevice is removed

* Takuma Umeya tum...@redhat.com [2011-04-05 00:00]: When virtio block device is removed, index does not get decremented. When another virtio disk is attached it uses the next device letter to the one that is suppose to be available. Signed-off-by: Takuma Umeya tum...@redhat.com diff

[RESEND] [PATCH 00/22] Staging: hv: Cleanup-storage-drivers-phase-III

The latest upstream merge changed struct block_device_operations: This merge got rid of blkvsc_media_changed and introduced the function blkvsc_check_events. This broke all the patches that were sent after the tree was closed the last time. This is a resend of this patch-set to account for this

[PATCH 11/22] Staging: hv: Get rid of the forward declaration of blkvsc_shutdown()

Get rid of the forward declaration of blkvsc_shutdown() by moving the code around. Signed-off-by: K. Y. Srinivasan k...@microsoft.com Signed-off-by: Haiyang Zhang haiya...@microsoft.com Signed-off-by: Abhishek Kane v-abk...@microsoft.com Signed-off-by: Hank Janssen hjans...@microsoft.com ---

[PATCH 05/22] Staging: hv: Get rid of the forward declaration of blkvsc_init_rw()

Get rid of the forward declaration of blkvsc_init_rw() by moving the code around. Signed-off-by: K. Y. Srinivasan k...@microsoft.com Signed-off-by: Haiyang Zhang haiya...@microsoft.com Signed-off-by: Abhishek Kane v-abk...@microsoft.com Signed-off-by: Hank Janssen hjans...@microsoft.com ---

[PATCH 15/22] Staging: hv: Get rid of the forward declaration of blkvsc_revalidate_disk()

Get rid of the forward declaration of blkvsc_revalidate_disk() by moving the code around. Signed-off-by: K. Y. Srinivasan k...@microsoft.com Signed-off-by: Haiyang Zhang haiya...@microsoft.com Signed-off-by: Abhishek Kane v-abk...@microsoft.com Signed-off-by: Hank Janssen hjans...@microsoft.com

[PATCH 18/22] Staging: hv: Get rid of the forward declaration for blkvsc_do_pending_reqs()

Get rid of the forward declaration for blkvsc_do_pending_reqs() by moving the code around. Signed-off-by: K. Y. Srinivasan k...@microsoft.com Signed-off-by: Haiyang Zhang haiya...@microsoft.com Signed-off-by: Abhishek Kane v-abk...@microsoft.com Signed-off-by: Hank Janssen hjans...@microsoft.com

[PATCH 03/22] Staging: hv: Get rid of the forward declaration of blkvsc_open()

Get rid of the forward declaration of blkvsc_open() by moving the code around. Signed-off-by: K. Y. Srinivasan k...@microsoft.com Signed-off-by: Haiyang Zhang haiya...@microsoft.com Signed-off-by: Abhishek Kane v-abk...@microsoft.com Signed-off-by: Hank Janssen hjans...@microsoft.com ---

[PATCH 09/22] Staging: hv: Get rid of the forward declaration of blkvsc_cancel_pending_reqs()

Get rid of the forward declaration of blkvsc_cancel_pending_reqs() by moving the code around. Signed-off-by: K. Y. Srinivasan k...@microsoft.com Signed-off-by: Haiyang Zhang haiya...@microsoft.com Signed-off-by: Abhishek Kane v-abk...@microsoft.com Signed-off-by: Hank Janssen

[PATCH 20/22] Staging: hv: Move some definitions/declarations to be earlier in the file

Move some definitions/declarations to be earlier in the file. Signed-off-by: K. Y. Srinivasan k...@microsoft.com Signed-off-by: Haiyang Zhang haiya...@microsoft.com Signed-off-by: Abhishek Kane v-abk...@microsoft.com Signed-off-by: Hank Janssen hjans...@microsoft.com ---

[PATCH 08/22] Staging: hv: Get rid of the forward declaration of blkvsc_do_flush()

Get rid of the forward declaration of blkvsc_do_flush() by moving the code around. Signed-off-by: K. Y. Srinivasan k...@microsoft.com Signed-off-by: Haiyang Zhang haiya...@microsoft.com Signed-off-by: Abhishek Kane v-abk...@microsoft.com Signed-off-by: Hank Janssen hjans...@microsoft.com ---

[PATCH 01/22] Staging: hv: Get rid of the forward declaration of blkvsc_submit_request()

Get rid of the forward declaration of blkvsc_submit_request() by moving the code around. Signed-off-by: K. Y. Srinivasan k...@microsoft.com Signed-off-by: Haiyang Zhang haiya...@microsoft.com Signed-off-by: Abhishek Kane v-abk...@microsoft.com Signed-off-by: Hank Janssen hjans...@microsoft.com

[PATCH 22/22] Staging: hv: Get rid of some dead code in blkvsc_drv.c

Get rid of some dead code in blkvsc_drv.c. Signed-off-by: K. Y. Srinivasan k...@microsoft.com Signed-off-by: Haiyang Zhang haiya...@microsoft.com Signed-off-by: Abhishek Kane v-abk...@microsoft.com Signed-off-by: Hank Janssen hjans...@microsoft.com --- drivers/staging/hv/blkvsc_drv.c | 26

[PATCH 16/22] Staging: hv: Get rid of the forward declaration for blkvsc_do_inquiry()

Get rid of the forward declaration for blkvsc_do_inquiry() by moving the code around. Signed-off-by: K. Y. Srinivasan k...@microsoft.com Signed-off-by: Haiyang Zhang haiya...@microsoft.com Signed-off-by: Abhishek Kane v-abk...@microsoft.com Signed-off-by: Hank Janssen hjans...@microsoft.com ---

[PATCH 02/22] Staging: hv: Get rid of the forward declaration of blkvsc_check_events()

Get rid of the forward declaration of blkvsc_check_events() by moving the code around. Signed-off-by: K. Y. Srinivasan k...@microsoft.com Signed-off-by: Haiyang Zhang haiya...@microsoft.com Signed-off-by: Abhishek Kane v-abk...@microsoft.com Signed-off-by: Hank Janssen hjans...@microsoft.com

[PATCH 14/22] Staging: hv: Get rid of the forward declaration of blkvsc_do_read_capacity16()

Get rid of the forward declaration of blkvsc_do_read_capacity16() by moving the code around. Signed-off-by: K. Y. Srinivasan k...@microsoft.com Signed-off-by: Haiyang Zhang haiya...@microsoft.com Signed-off-by: Abhishek Kane v-abk...@microsoft.com Signed-off-by: Hank Janssen

Re: Signed bit field; int have_hotplug_status_watch:1

From: Ian Campbell ian.campb...@eu.citrix.com Date: Mon, 4 Apr 2011 09:26:24 +0100 Subject: [PATCH] xen: netback: use unsigned type for one-bit bitfield. Fixes error from sparse: CHECK drivers/net/xen-netback/xenbus.c drivers/net/xen-netback/xenbus.c:29:40: error: dubious one-bit signed

Re: [PATCH] xen: drop anti-dependency on X86_VISWS

From: Ian Campbell ian.campb...@eu.citrix.com Date: Mon, 4 Apr 2011 10:55:55 +0100 You mean the !X86_VISWS I presume? It doesn't make sense to me either. No, I think 32-bit x86 allmodconfig elides XEN because of it's X86_TSC dependency. And, well, you could type make allmodconfig on your tree

[PATCH 12/22] Staging: hv: Get rid of the forward declaration for blkvsc_release()

Get rid of the forward declaration for blkvsc_release() by moving the code around. Signed-off-by: K. Y. Srinivasan k...@microsoft.com Signed-off-by: Haiyang Zhang haiya...@microsoft.com Signed-off-by: Abhishek Kane v-abk...@microsoft.com Signed-off-by: Hank Janssen hjans...@microsoft.com ---

[PATCH 04/22] Staging: hv: Get rid of the forward declaration of blkvsc_getgeo()

Get rid of the forward declaration of blkvsc_getgeo() by moving the code around. Signed-off-by: K. Y. Srinivasan k...@microsoft.com Signed-off-by: Haiyang Zhang haiya...@microsoft.com Signed-off-by: Abhishek Kane v-abk...@microsoft.com Signed-off-by: Hank Janssen hjans...@microsoft.com ---

[PATCH 06/22] Staging: hv: Get rid of the forward declaration of blkvsc_ioctl()

Get rid of the forward declaration of blkvsc_ioctl() by moving the code around. Signed-off-by: K. Y. Srinivasan k...@microsoft.com Signed-off-by: Haiyang Zhang haiya...@microsoft.com Signed-off-by: Abhishek Kane v-abk...@microsoft.com Signed-off-by: Hank Janssen hjans...@microsoft.com ---

[PATCH 19/22] Staging: hv: Get rid of the forward declaration for blkvsc_request()

Get rid of the forward declaration for blkvsc_request() by moving the code around. Signed-off-by: K. Y. Srinivasan k...@microsoft.com Signed-off-by: Haiyang Zhang haiya...@microsoft.com Signed-off-by: Abhishek Kane v-abk...@microsoft.com Signed-off-by: Hank Janssen hjans...@microsoft.com ---

[PATCH 07/22] Staging: hv: Get rid of the forward declaration of blkvsc_cmd_completion()

Get rid of the forward declaration of blkvsc_cmd_completion() by moving the code around. Signed-off-by: K. Y. Srinivasan k...@microsoft.com Signed-off-by: Haiyang Zhang haiya...@microsoft.com Signed-off-by: Abhishek Kane v-abk...@microsoft.com Signed-off-by: Hank Janssen hjans...@microsoft.com

[PATCH 10/22] Staging: hv: Get rid of the forward declaration of blkvsc_remove()

Get rid of the forward declaration of blkvsc_remove() by moving the code around. Signed-off-by: K. Y. Srinivasan k...@microsoft.com Signed-off-by: Haiyang Zhang haiya...@microsoft.com Signed-off-by: Abhishek Kane v-abk...@microsoft.com Signed-off-by: Hank Janssen hjans...@microsoft.com ---

[PATCH 13/22] Staging: hv: Get rid of the forward declaration for blkvsc_do_read_capacity()

Get rid of the forward declaration for blkvsc_do_read_capacity() by moving the code around. Signed-off-by: K. Y. Srinivasan k...@microsoft.com Signed-off-by: Haiyang Zhang haiya...@microsoft.com Signed-off-by: Abhishek Kane v-abk...@microsoft.com Signed-off-by: Hank Janssen hjans...@microsoft.com

[PATCH 17/22] Staging: hv: Get rid of the forward declaration for blkvsc_do_request()

Get rid of the forward declaration for blkvsc_do_request() by moving the code around. Signed-off-by: K. Y. Srinivasan k...@microsoft.com Signed-off-by: Haiyang Zhang haiya...@microsoft.com Signed-off-by: Abhishek Kane v-abk...@microsoft.com Signed-off-by: Hank Janssen hjans...@microsoft.com ---

[RESEND][PATCH 00/22] Staging: hv: Cleanup storage drivers - Phase IV

The latest upstream merge changed struct block_device_operations: This merge got rid of blkvsc_media_changed and introduced the function blkvsc_check_events. This broke all the patches that were sent after the tree was closed the last time. This is a resend of this patch-set to account for this

RE: [PATCH 00/22] Staging: hv: Cleanup-storage-drivers-phase-III

-Original Message- From: Greg KH [mailto:g...@kroah.com] Sent: Tuesday, April 05, 2011 11:11 AM To: KY Srinivasan Cc: gre...@suse.de; linux-ker...@vger.kernel.org; de...@linuxdriverproject.org; virtualizat...@lists.osdl.org Subject: Re: [PATCH 00/22] Staging: hv:

[PATCH 10/22] Staging: hv: Simplify blkvsc_init_rw()

Simplyfify blkvsc_init_rw() by using a single scsi command independent of the start sector. Signed-off-by: K. Y. Srinivasan k...@microsoft.com Signed-off-by: Haiyang Zhang haiya...@microsoft.com Signed-off-by: Hank Janssen hjans...@microsoft.com --- drivers/staging/hv/blkvsc_drv.c | 58

[PATCH 07/22] Staging: hv: Get rid of the function blkvsc_do_flush()

Get rid of the function blkvsc_do_flush() and instead use the common function to force a device flush. Signed-off-by: K. Y. Srinivasan k...@microsoft.com Signed-off-by: Haiyang Zhang haiya...@microsoft.com Signed-off-by: Hank Janssen hjans...@microsoft.com --- drivers/staging/hv/blkvsc_drv.c |

[PATCH 14/22] Staging: hv: Cleanup storvsc_remove()

storvsc_remove() cannot fail, clean it up accordingly. Signed-off-by: K. Y. Srinivasan k...@microsoft.com Signed-off-by: Haiyang Zhang haiya...@microsoft.com Signed-off-by: Hank Janssen hjans...@microsoft.com --- drivers/staging/hv/storvsc_drv.c | 14 ++ 1 files changed, 2

[PATCH 03/22] Staging: hv: Simplify the code for blkvsc_getgeo()

We are making up the geometry anyway, keep it simple. Signed-off-by: K. Y. Srinivasan k...@microsoft.com Signed-off-by: Haiyang Zhang haiya...@microsoft.com Signed-off-by: Hank Janssen hjans...@microsoft.com --- drivers/staging/hv/blkvsc_drv.c | 84 +- 1

[PATCH 08/22] Staging: hv: Get rid of the state media_not_present

The block driver in Hyper-V does not handle removable media, get rid of the media_not_present state. Signed-off-by: K. Y. Srinivasan k...@microsoft.com Signed-off-by: Haiyang Zhang haiya...@microsoft.com Signed-off-by: Hank Janssen hjans...@microsoft.com --- drivers/staging/hv/blkvsc_drv.c |

[PATCH 16/22] Staging: hv: Get rid of some DPRINT_ERR() calls

Get rid of some DPRINT_ERR() calls. Signed-off-by: K. Y. Srinivasan k...@microsoft.com Signed-off-by: Haiyang Zhang haiya...@microsoft.com Signed-off-by: Hank Janssen hjans...@microsoft.com --- drivers/staging/hv/blkvsc_drv.c |9 +++-- 1 files changed, 3 insertions(+), 6 deletions(-)

[PATCH 04/22] Staging: hv: Introduce a common function for issuing commands to the device

There are multiple functions to either get info about the device (INQUIRY, CAPACITY etc) or to FLUSH the device cache. The majority of the code for these functions is identical. Introduce a common function for doing all these operations. Signed-off-by: K. Y. Srinivasan k...@microsoft.com

[PATCH 02/22] Staging: hv: Enable blkvsc_ioctl()

We can support HDIO_GET_IDENTITY ioctl, enable blkvsc_ioctl(). Signed-off-by: K. Y. Srinivasan k...@microsoft.com Signed-off-by: Haiyang Zhang haiya...@microsoft.com Signed-off-by: Hank Janssen hjans...@microsoft.com --- drivers/staging/hv/blkvsc_drv.c | 11 +++ 1 files changed, 3

[PATCH 19/22] Staging: hv: Fix a jump label (Cleanup) in blkvsc_drv

One of the goto labels was named Cleanup; change it to cleanup. Signed-off-by: K. Y. Srinivasan k...@microsoft.com Signed-off-by: Haiyang Zhang haiya...@microsoft.com Signed-off-by: Hank Janssen hjans...@microsoft.com --- drivers/staging/hv/blkvsc_drv.c | 12 ++-- 1 files changed, 6

[PATCH 01/22] Staging: hv: Get rid of blkvsc_check_events()

We don't support removable media in Hyper-V block driver. Get rid of blkvsc_check_events() as it is efectively dead code. Signed-off-by: K. Y. Srinivasan k...@microsoft.com Signed-off-by: Haiyang Zhang haiya...@microsoft.com Signed-off-by: Hank Janssen hjans...@microsoft.com ---

[PATCH 13/22] Staging: hv: Cleanup blkvsc_remove()

blkvsc_remove() cannot fail. Clean it up accordingly. Signed-off-by: K. Y. Srinivasan k...@microsoft.com Signed-off-by: Haiyang Zhang haiya...@microsoft.com Signed-off-by: Hank Janssen hjans...@microsoft.com --- drivers/staging/hv/blkvsc_drv.c | 15 +++ 1 files changed, 3

[PATCH 09/22] Staging: hv: Get rid of the function blkvsc_revalidate_disk()

The block driver in Hyper-V does not support removable media, get rid of the blkvsc_revalidate_disk(). Signed-off-by: K. Y. Srinivasan k...@microsoft.com Signed-off-by: Haiyang Zhang haiya...@microsoft.com Signed-off-by: Hank Janssen hjans...@microsoft.com --- drivers/staging/hv/blkvsc_drv.c |

[PATCH 22/22] Staging: hv: Get rid of IDE details from blkvsc_drv.c

Now get rid of IDE details from blkvsc_drv.c. Signed-off-by: K. Y. Srinivasan k...@microsoft.com Signed-off-by: Haiyang Zhang haiya...@microsoft.com Signed-off-by: Hank Janssen hjans...@microsoft.com --- drivers/staging/hv/blkvsc_drv.c | 55 +++---

[PATCH 20/22] Staging: hv: Fix a jump label (Remove) in blkvsc_drv.c

One of the jump labels was named Remove; change it to remove. Signed-off-by: K. Y. Srinivasan k...@microsoft.com Signed-off-by: Haiyang Zhang haiya...@microsoft.com Signed-off-by: Hank Janssen hjans...@microsoft.com --- drivers/staging/hv/blkvsc_drv.c |6 +++--- 1 files changed, 3

[PATCH 05/22] Staging: hv: Get rid of blkvsc_do_read_capacity()

Now that we have a common function for some of the operations on the device, use that and get rid of the function blkvsc_do_read_capacity(). Signed-off-by: K. Y. Srinivasan k...@microsoft.com Signed-off-by: Haiyang Zhang haiya...@microsoft.com Signed-off-by: Hank Janssen hjans...@microsoft.com

[PATCH 17/22] Staging: hv: Get rid of an unnecessary check in blkvsc_probe()

It is never the case that the dev_add function pointer will not be set (we set it in this code!). Get rid of this meaningless check. Signed-off-by: K. Y. Srinivasan k...@microsoft.com Signed-off-by: Haiyang Zhang haiya...@microsoft.com Signed-off-by: Hank Janssen hjans...@microsoft.com ---

[PATCH 21/22] Staging: hv: Introduce a function to map channel properties onto block device info

In preparation for removing the IDE details from the block driver, implement a function that maps channel properties to block device information. Signed-off-by: K. Y. Srinivasan k...@microsoft.com Signed-off-by: Haiyang Zhang haiya...@microsoft.com Signed-off-by: Hank Janssen

[PATCH 11/22] Staging: hv: Get rid of some DPRINT_INFO() statements

Get rid of some of the DPRINT_INFO() statements. Signed-off-by: K. Y. Srinivasan k...@microsoft.com Signed-off-by: Haiyang Zhang haiya...@microsoft.com Signed-off-by: Hank Janssen hjans...@microsoft.com --- drivers/staging/hv/blkvsc_drv.c |3 --- 1 files changed, 0 insertions(+), 3

[PATCH 06/22] Staging: hv: Get rid of blkvsc_do_read_capacity16()

Get rid of blkvsc_do_read_capacity16() and instead use the common function for retrieving capacity. Signed-off-by: K. Y. Srinivasan k...@microsoft.com Signed-off-by: Haiyang Zhang haiya...@microsoft.com Signed-off-by: Hank Janssen hjans...@microsoft.com --- drivers/staging/hv/blkvsc_drv.c | 81