Re: [PATCH V3 3/3] virtio-blk: Add bio-based IO path for virtio-blk

2012-07-27 Thread Rusty Russell
On Fri, 13 Jul 2012 16:38:51 +0800, Asias He as...@redhat.com wrote: This patch introduces bio-based IO path for virtio-blk. Acked-by: Rusty Russell ru...@rustcorp.com.au I just hope we can do better than a module option in future. Thanks, Rusty. ___

Re: Re: [RFC PATCH 0/6] virtio-trace: Support virtio-trace

2012-07-27 Thread Yoshihiro YUNOMAE
Hi Amit, Thank you for commenting on our work. (2012/07/26 20:35), Amit Shah wrote: On (Tue) 24 Jul 2012 [11:36:57], Yoshihiro YUNOMAE wrote: [...] Therefore, we propose a new system virtio-trace, which uses enhanced virtio-serial and existing ring-buffer of ftrace, for collecting guest

Re: Re: [RFC PATCH 0/6] virtio-trace: Support virtio-trace

2012-07-27 Thread Amit Shah
On (Fri) 27 Jul 2012 [17:55:11], Yoshihiro YUNOMAE wrote: Hi Amit, Thank you for commenting on our work. (2012/07/26 20:35), Amit Shah wrote: On (Tue) 24 Jul 2012 [11:36:57], Yoshihiro YUNOMAE wrote: [...] Therefore, we propose a new system virtio-trace, which uses enhanced

Re: [vmw_vmci 11/11] Apply the header code to make VMCI build

2012-07-27 Thread Alan Cox
+enum { + VMCI_SUCCESS_QUEUEPAIR_ATTACH = 5, + VMCI_SUCCESS_QUEUEPAIR_CREATE = 4, + VMCI_SUCCESS_LAST_DETACH= 3, + VMCI_SUCCESS_ACCESS_GRANTED = 2, + VMCI_SUCCESS_ENTRY_DEAD = 1, We've got a nice collection of Linux error codes than you, and it would

Re: [vmw_vmci 11/11] Apply the header code to make VMCI build

2012-07-27 Thread Sam Ravnborg
Hi Andrew. A few things noted in the following.. diff --git a/drivers/misc/Kconfig b/drivers/misc/Kconfig index 2661f6e..fe38c7a 100644 --- a/drivers/misc/Kconfig +++ b/drivers/misc/Kconfig @@ -517,4 +517,5 @@ source drivers/misc/lis3lv02d/Kconfig source drivers/misc/carma/Kconfig

Re: [net-next RFC V5 3/5] virtio: intorduce an API to set affinity for a virtqueue

2012-07-27 Thread Paolo Bonzini
Il 05/07/2012 12:29, Jason Wang ha scritto: Sometimes, virtio device need to configure irq affiniry hint to maximize the performance. Instead of just exposing the irq of a virtqueue, this patch introduce an API to set the affinity for a virtqueue. The api is best-effort, the affinity hint

Re: [vmw_vmci 11/11] Apply the header code to make VMCI build

2012-07-27 Thread Andrew Stiegmann
Hi Sam, - Original Message - From: Sam Ravnborg s...@ravnborg.org To: Andrew Stiegmann (stieg) astiegm...@vmware.com Cc: linux-ker...@vger.kernel.org, virtualization@lists.linux-foundation.org, pv-driv...@vmware.com, vm-crosst...@vmware.com, csch...@vmware.com,

Re: [Pv-drivers] [vmw_vmci 11/11] Apply the header code to make VMCI build

2012-07-27 Thread Dmitry Torokhov
Hi Alan, On Fri, Jul 27, 2012 at 10:53:57AM +0100, Alan Cox wrote: +enum { + VMCI_SUCCESS_QUEUEPAIR_ATTACH = 5, + VMCI_SUCCESS_QUEUEPAIR_CREATE = 4, + VMCI_SUCCESS_LAST_DETACH= 3, + VMCI_SUCCESS_ACCESS_GRANTED = 2, + VMCI_SUCCESS_ENTRY_DEAD = 1, We've

Re: [vmw_vmci 11/11] Apply the header code to make VMCI build

2012-07-27 Thread Greg KH
On Fri, Jul 27, 2012 at 10:20:43AM -0700, Andrew Stiegmann wrote: The kernel style is to use lower_case for everything. So this would become: vmci_device_get() This is obviously a very general comment and applies everywhere. I wish I could lower case these symbols but VMCI has

Re: [vmw_vmci 11/11] Apply the header code to make VMCI build

2012-07-27 Thread Andrew Stiegmann
- Original Message - From: Greg KH gre...@linuxfoundation.org To: Andrew Stiegmann astiegm...@vmware.com Cc: Sam Ravnborg s...@ravnborg.org, linux-ker...@vger.kernel.org, virtualization@lists.linux-foundation.org, pv-driv...@vmware.com, vm-crosst...@vmware.com, csch...@vmware.com

Re: [vmw_vmci 11/11] Apply the header code to make VMCI build

2012-07-27 Thread Greg KH
On Fri, Jul 27, 2012 at 11:39:23AM -0700, Andrew Stiegmann wrote: - Original Message - From: Greg KH gre...@linuxfoundation.org To: Andrew Stiegmann astiegm...@vmware.com Cc: Sam Ravnborg s...@ravnborg.org, linux-ker...@vger.kernel.org,

Re: Re: [Qemu-devel] [RFC PATCH 0/6] virtio-trace: Support virtio-trace

2012-07-27 Thread Blue Swirl
On Wed, Jul 25, 2012 at 8:15 AM, Masami Hiramatsu masami.hiramatsu...@hitachi.com wrote: (2012/07/25 5:26), Blue Swirl wrote: The following patch set provides a low-overhead system for collecting kernel tracing data of guests by a host in a virtualization environment. A guest OS generally

Re: [vmw_vmci 11/11] Apply the header code to make VMCI build

2012-07-27 Thread Sam Ravnborg
+ +#define CAN_BLOCK(_f) (!((_f) VMCI_QPFLAG_NONBLOCK)) +#define QP_PINNED(_f) ((_f) VMCI_QPFLAG_PINNED) Looks like poor obscufation. Use a statis inline function if you need a helper for this. These definitions are intended more as a helper to make reading the code easier.

Re: [vmw_vmci 11/11] Apply the header code to make VMCI build

2012-07-27 Thread Andrew Stiegmann
- Original Message - From: Sam Ravnborg s...@ravnborg.org To: Andrew Stiegmann astiegm...@vmware.com Cc: linux-ker...@vger.kernel.org, virtualization@lists.linux-foundation.org, pv-driv...@vmware.com, vm-crosst...@vmware.com, csch...@vmware.com, gre...@linuxfoundation.org Sent:

Re: [Pv-drivers] [vmw_vmci 11/11] Apply the header code to make VMCI build

2012-07-27 Thread Dmitry Torokhov
On Fri, Jul 27, 2012 at 11:16:39AM -0700, Greg KH wrote: On Fri, Jul 27, 2012 at 10:20:43AM -0700, Andrew Stiegmann wrote: The kernel style is to use lower_case for everything. So this would become: vmci_device_get() This is obviously a very general comment and applies

KVM Forum 2012 Call For Participation

2012-07-27 Thread KVM Forum 2012 Program Committee
= KVM Forum 2012: Call For Participation November 7-9, 2012 - Hotel Fira Palace - Barcelona, Spain (All submissions must be received before midnight Aug 31st, 2012) =

[PATCH V4 0/3] Improve virtio-blk performance

2012-07-27 Thread Asias He
Hi, Jens Rusty This version is rebased against linux-next which resolves the conflict with Paolo Bonzini's 'virtio-blk: allow toggling host cache between writeback and writethrough' patch. Patch 1/3 and 2/3 applies on linus's master as well. Since Rusty will pick up patch 3/3 so the changes to

[PATCH V4 3/3] virtio-blk: Add bio-based IO path for virtio-blk

2012-07-27 Thread Asias He
This patch introduces bio-based IO path for virtio-blk. Compared to request-based IO path, bio-based IO path uses driver provided -make_request_fn() method to bypasses the IO scheduler. It handles the bio to device directly without allocating a request in block layer. This reduces the IO path in

Re: [PATCH V3 3/3] virtio-blk: Add bio-based IO path for virtio-blk

2012-07-27 Thread Asias He
On 07/27/2012 08:33 AM, Rusty Russell wrote: On Fri, 13 Jul 2012 16:38:51 +0800, Asias He as...@redhat.com wrote: Add 'virtio_blk.use_bio=1' to kernel cmdline or 'modprobe virtio_blk use_bio=1' to enable -make_request_fn() based I/O path. This patch conflicts with Paolo's Bonzini's