Re: [PATCH -next] virtio: balloon: fix missing unlock on error in fill_balloon()

2012-11-12 Thread Rafael Aquini
On Mon, Nov 12, 2012 at 09:50:40PM +0800, Wei Yongjun wrote: From: Wei Yongjun yongjun_...@trendmicro.com.cn Add the missing unlock before return from function fill_balloon() in the error handling case. Introduced by 9864a8(virtio_balloon: introduce migration primitives to balloon pages)

Re: [PATCH] virtio-spec: serial: english tweak

2012-11-12 Thread Michael S. Tsirkin
On Sun, Sep 09, 2012 at 03:11:16PM +0300, Michael S. Tsirkin wrote: A number of virtqueues are created seems clearer than the number of virtqueues: it's virtqueues that are created not the number. Signed-off-by: Michael S. Tsirkin m...@redhat.com ping --- I'm not a native english

Re: [PATCH] virtio-spec: balloon: MUST_TELL_HOST is optional

2012-11-12 Thread Michael S. Tsirkin
On Sun, Sep 09, 2012 at 02:36:50PM +0300, Michael S. Tsirkin wrote: Drivers treat MUST_TELL_HOST as optional: windows drivers do not ack it and expect this means they can tell host *after* deflate. This was not the intent but the documentation was not very clear on this point. Luckily

Re: [PATCH -next] virtio: balloon: fix missing unlock on error in fill_balloon()

2012-11-12 Thread Andrew Morton
On Mon, 12 Nov 2012 21:50:40 +0800 Wei Yongjun weiyj...@gmail.com wrote: From: Wei Yongjun yongjun_...@trendmicro.com.cn Add the missing unlock before return from function fill_balloon() in the error handling case. Introduced by 9864a8(virtio_balloon: introduce migration primitives to

Re: [rfc net-next v6 2/3] virtio_net: multiqueue support

2012-11-12 Thread Michael S. Tsirkin
On Mon, Nov 05, 2012 at 11:38:39AM +1030, Rusty Russell wrote: @@ -924,11 +1032,10 @@ static void virtnet_get_ringparam(struct net_device *dev, { struct virtnet_info *vi = netdev_priv(dev); - ring-rx_max_pending = virtqueue_get_vring_size(vi-rvq); - ring-tx_max_pending =

[patch] virtio_balloon: unlock on error in fill_balloon()

2012-11-12 Thread Dan Carpenter
We recently added locking in fill_balloon() but there was one error path which was missed. Signed-off-by: Dan Carpenter dan.carpen...@oracle.com --- Only needed in linux-next. diff --git a/drivers/virtio/virtio_balloon.c b/drivers/virtio/virtio_balloon.c index f70151b..1c50e98 100644 ---