[PATCH RESEND v3 0/7] Enable Drivers for Intel MIC X100 Coprocessors.

2013-09-05 Thread Sudeep Dutt
ChangeLog: = v2 = v3: a) Patch 1 data structure cleanups, header file include cleanups, IDA interface reuse and switching to device_create_with_groups(..) as per feedback from Greg Kroah-Hartman. b) Patch 7 signal documentation, sleep workaround removal and sysfs access API

[PATCH RESEND v3 1/7] Intel MIC Host Driver for X100 family.

2013-09-05 Thread Sudeep Dutt
This patch enables the following: a) Initializes the Intel MIC X100 PCIe devices. b) Provides sysfs entries for family and stepping information. Co-author: Dasaratharaman Chandramouli dasaratharaman.chandramo...@intel.com Signed-off-by: Ashutosh Dixit ashutosh.di...@intel.com Signed-off-by: Caz

[PATCH RESEND v3 3/7] Intel MIC Host Driver, card OS state management.

2013-09-05 Thread Sudeep Dutt
This patch enables the following features: a) Boots and shuts down the card via sysfs entries. b) Allocates and maps a device page for communication with the card driver and updates the device page address via scratchpad registers. c) Provides sysfs entries for shutdown status, kernel

[PATCH RESEND v3 2/7] Intel MIC Host Driver Interrupt/SMPT support.

2013-09-05 Thread Sudeep Dutt
From: Dasaratharaman Chandramouli dasaratharaman.chandramo...@intel.com This patch enables the following features: a) MSIx, MSI and legacy interrupt support. b) System Memory Page Table(SMPT) support. SMPT enables system memory access from the card. On X100 devices the host can program 32 SMPT

[PATCH RESEND v3 4/7] Intel MIC Card Driver for X100 family.

2013-09-05 Thread Sudeep Dutt
This patch does the following: a) Initializes the Intel MIC X100 platform device and driver. b) Sets up support to handle shutdown requests from the host. c) Maps the device page after obtaining the device page address from the scratchpad registers updated by the host. d) Informs the host upon a

[PATCH RESEND v3 5/7] Intel MIC Host Driver Changes for Virtio Devices.

2013-09-05 Thread Sudeep Dutt
From: Ashutosh Dixit ashutosh.di...@intel.com This patch introduces the host Virtio over PCIe interface for Intel MIC. It allows creating user space backends on the host and instantiating virtio devices for them on the Intel MIC card. It uses the existing VRINGH infrastructure in the kernel to

[PATCH RESEND v3 6/7] Intel MIC Card Driver Changes for Virtio Devices.

2013-09-05 Thread Sudeep Dutt
From: Ashutosh Dixit ashutosh.di...@intel.com This patch introduces the card Virtio over PCIe interface for Intel MIC. It allows virtio drivers on the card to communicate with their user space backends on the host via a device page. Ring 3 apps on the host can add, remove and configure virtio

Re: [PATCH RESEND v3 0/7] Enable Drivers for Intel MIC X100 Coprocessors.

2013-09-05 Thread Joe Perches
Whitespace neatening... Multiline statement argument alignment. Argument wrapping. Use kmalloc_array instead of kmalloc. --- drivers/misc/mic/card/mic_virtio.c | 17 --- drivers/misc/mic/card/mic_x100.c| 4 +- drivers/misc/mic/host/mic_debugfs.c | 91

Re: [PATCH RESEND v3 1/7] Intel MIC Host Driver for X100 family.

2013-09-05 Thread Greg Kroah-Hartman
Very minor nits, you can change this in a future add-on patch: +static DEVICE_ATTR(family, S_IRUGO, mic_show_family, NULL); This should use DEVICE_ATTR_RO(), so that we don't have to audit the permissions of your DEVICE_ATTR() files. +static DEVICE_ATTR(stepping, S_IRUGO, mic_show_stepping,

Re: [PATCH RESEND v3 1/7] Intel MIC Host Driver for X100 family.

2013-09-05 Thread Greg Kroah-Hartman
On Thu, Sep 05, 2013 at 04:41:31PM -0700, Sudeep Dutt wrote: drivers/misc/mic/common/mic_device.h | 37 +++ drivers/misc/mic/host/mic_device.h| 109 + Two different files, with the same name? You are asking for trouble in the future, getting them confused :)

Re: [PATCH RESEND v3 3/7] Intel MIC Host Driver, card OS state management.

2013-09-05 Thread Greg Kroah-Hartman
Again, very minor fixups for later (I can even do them...) +static DEVICE_ATTR(state, S_IRUGO|S_IWUSR, mic_show_state, mic_store_state); DEVICE_ATTR_RW() please. Same for the other attributes you create in this patch. thanks, greg k-h ___

Re: [PATCH RESEND v3 3/7] Intel MIC Host Driver, card OS state management.

2013-09-05 Thread Greg Kroah-Hartman
On Thu, Sep 05, 2013 at 04:41:55PM -0700, Sudeep Dutt wrote: +What:/sys/class/mic/mic(x)/cmdline +Date:August 2013 +KernelVersion: 3.11 +Contact: Sudeep Dutt sudeep.d...@intel.com +Description: + An Intel MIC device runs a Linux OS during

Re: [PATCH RESEND v3 3/7] Intel MIC Host Driver, card OS state management.

2013-09-05 Thread Greg Kroah-Hartman
On Thu, Sep 05, 2013 at 04:41:55PM -0700, Sudeep Dutt wrote: +What:/sys/class/mic/mic(x)/firmware +Date:August 2013 +KernelVersion: 3.11 +Contact: Sudeep Dutt sudeep.d...@intel.com +Description: + When read, this sysfs entry provides the