Re: [PATCH net-next] virtio-net: invoke zerocopy callback on xmit path if no tx napi

2017-08-25 Thread Willem de Bruijn
>> >> > We don't enable network watchdog on virtio but we could and maybe >> >> > should. >> >> >> >> Can you elaborate? >> > >> > The issue is that holding onto buffers for very long times makes guests >> > think they are stuck. This is funamentally because from guest point of >> > view this is a

Re: [PATCH net-next] virtio-net: invoke zerocopy callback on xmit path if no tx napi

2017-08-25 Thread Willem de Bruijn
On Fri, Aug 25, 2017 at 7:32 PM, Michael S. Tsirkin wrote: > On Fri, Aug 25, 2017 at 06:44:36PM -0400, Willem de Bruijn wrote: >> >> >> > We don't enable network watchdog on virtio but we could and maybe >> >> >> > should. >> >> >> >> >> >> Can you elaborate? >> >> > >> >> > The

Re: [PATCH] [RFC] virtio: Limit the retries on a virtio device reset

2017-08-25 Thread Pierre Morel
On 25/08/2017 10:26, Cornelia Huck wrote: On Fri, 25 Aug 2017 00:16:05 +0300 "Michael S. Tsirkin" wrote: On Thu, Aug 24, 2017 at 07:07:42PM +0200, Pierre Morel wrote: - we'll have to spread these tests all over the place. I counted 19 places where to check if the reset

Re: [PATCH] [RFC] virtio: Limit the retries on a virtio device reset

2017-08-25 Thread Pierre Morel
On 24/08/2017 23:23, Michael S. Tsirkin wrote: On Thu, Aug 24, 2017 at 07:42:07PM +0200, Pierre Morel wrote: On 24/08/2017 16:19, Michael S. Tsirkin wrote: On Wed, Aug 23, 2017 at 06:33:02PM +0200, Pierre Morel wrote: Reseting a device can sometime fail, even a virtual device. If the device

Re: [PATCH] [RFC] virtio: Limit the retries on a virtio device reset

2017-08-25 Thread Michael S. Tsirkin
On Fri, Aug 25, 2017 at 10:33:57AM +0200, Pierre Morel wrote: > On 24/08/2017 23:23, Michael S. Tsirkin wrote: > > On Thu, Aug 24, 2017 at 07:42:07PM +0200, Pierre Morel wrote: > > > On 24/08/2017 16:19, Michael S. Tsirkin wrote: > > > > On Wed, Aug 23, 2017 at 06:33:02PM +0200, Pierre Morel

Re: [PATCH] [RFC] virtio: Limit the retries on a virtio device reset

2017-08-25 Thread Michael S. Tsirkin
On Fri, Aug 25, 2017 at 10:26:12AM +0200, Cornelia Huck wrote: > On Fri, 25 Aug 2017 00:16:05 +0300 > "Michael S. Tsirkin" wrote: > > > On Thu, Aug 24, 2017 at 07:07:42PM +0200, Pierre Morel wrote: > > > > - we'll have to spread these tests all over the place. > > > > > > I

[PULL] vhost: cleanups and fixes

2017-08-25 Thread Michael S. Tsirkin
The following changes since commit 14ccee78fc82f5512908f4424f541549a5705b89: Linux 4.13-rc6 (2017-08-20 14:13:52 -0700) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/mst/vhost.git tags/for_linus for you to fetch changes up to