Re: [virtio-dev] Re: [PATCH v2] virtio_balloon: export hugetlb page allocation counts

2018-04-13 Thread Michael S. Tsirkin
On Fri, Apr 13, 2018 at 10:10:57AM -0700, Jonathan Helman wrote: > > > On 04/13/2018 06:44 AM, Michael S. Tsirkin wrote: > > On Fri, Apr 13, 2018 at 03:01:11PM +0800, Jason Wang wrote: > > > > > > > > > On 2018年04月12日 08:24, Jonathan Helman wrote: > > > > > > > > > > > > On 04/10/2018 08:12

Re: [PATCH] virtio_balloon: add array of stat names

2018-04-13 Thread Jonathan Helman
On 04/13/2018 06:44 AM, Michael S. Tsirkin wrote: Jason Wang points out that it's vary hard for users to build an array of s/vary/very stat names. The naive thing is to use VIRTIO_BALLOON_S_NR but that breaks if we add more stats. Let's add an array of reasonably readable names. Thanks

Re: [virtio-dev] Re: [PATCH v2] virtio_balloon: export hugetlb page allocation counts

2018-04-13 Thread Jonathan Helman
On 04/13/2018 06:44 AM, Michael S. Tsirkin wrote: On Fri, Apr 13, 2018 at 03:01:11PM +0800, Jason Wang wrote: On 2018年04月12日 08:24, Jonathan Helman wrote: On 04/10/2018 08:12 PM, Jason Wang wrote: On 2018年04月10日 05:11, Jonathan Helman wrote: On 03/22/2018 07:38 PM, Jason Wang

Re: [virtio-dev] Re: [PATCH v2] virtio_balloon: export hugetlb page allocation counts

2018-04-13 Thread Jonathan Helman
On 04/13/2018 02:51 PM, Michael S. Tsirkin wrote: On Fri, Apr 13, 2018 at 10:10:57AM -0700, Jonathan Helman wrote: On 04/13/2018 06:44 AM, Michael S. Tsirkin wrote: On Fri, Apr 13, 2018 at 03:01:11PM +0800, Jason Wang wrote: On 2018年04月12日 08:24, Jonathan Helman wrote: On 04/10/2018

Re: [PATCH] virtio_balloon: add array of stat names

2018-04-13 Thread Michael S. Tsirkin
On Fri, Apr 13, 2018 at 11:53:31AM -0700, Jonathan Helman wrote: > > > On 04/13/2018 06:44 AM, Michael S. Tsirkin wrote: > > Jason Wang points out that it's vary hard for users to build an array of > > s/vary/very > > > stat names. The naive thing is to use VIRTIO_BALLOON_S_NR but that > >

Re: [PATCH] virtio_balloon: add array of stat names

2018-04-13 Thread Jonathan Helman
On 04/13/2018 03:07 PM, Michael S. Tsirkin wrote: On Fri, Apr 13, 2018 at 11:53:31AM -0700, Jonathan Helman wrote: On 04/13/2018 06:44 AM, Michael S. Tsirkin wrote: Jason Wang points out that it's vary hard for users to build an array of s/vary/very stat names. The naive thing is to

Re: [RFC v2] virtio: support packed ring

2018-04-13 Thread Tiwei Bie
On Fri, Apr 13, 2018 at 12:30:24PM +0800, Jason Wang wrote: > On 2018年04月01日 22:12, Tiwei Bie wrote: > > Hello everyone, > > > > This RFC implements packed ring support for virtio driver. > > > > The code was tested with DPDK vhost (testpmd/vhost-PMD) implemented > > by Jens at

Re: [virtio-dev] Re: [PATCH v2] virtio_balloon: export hugetlb page allocation counts

2018-04-13 Thread Jason Wang
On 2018年04月12日 08:24, Jonathan Helman wrote: On 04/10/2018 08:12 PM, Jason Wang wrote: On 2018年04月10日 05:11, Jonathan Helman wrote: On 03/22/2018 07:38 PM, Jason Wang wrote: On 2018年03月22日 11:10, Michael S. Tsirkin wrote: On Thu, Mar 22, 2018 at 09:52:18AM +0800, Jason Wang wrote:

[PATCH net] virtio-net: add missing virtqueue kick when flushing packets

2018-04-13 Thread Jason Wang
We tends to batch submitting packets during XDP_TX. This requires to kick virtqueue after a batch, we tried to do it through xdp_do_flush_map() which only makes sense for devmap not XDP_TX. So explicitly kick the virtqueue in this case. Reported-by: Kimitoshi Takahashi

Re: [RFC v2] virtio: support packed ring

2018-04-13 Thread Michael S. Tsirkin
On Sun, Apr 01, 2018 at 10:12:16PM +0800, Tiwei Bie wrote: > +static inline bool more_used(const struct vring_virtqueue *vq) > +{ > + return vq->packed ? more_used_packed(vq) : more_used_split(vq); > +} > + > +void *virtqueue_get_buf_ctx_split(struct virtqueue *_vq, unsigned int *len, > +

Re: [PATCH net] virtio-net: add missing virtqueue kick when flushing packets

2018-04-13 Thread David Miller
From: Jason Wang Date: Fri, 13 Apr 2018 14:58:25 +0800 > We tends to batch submitting packets during XDP_TX. This requires to > kick virtqueue after a batch, we tried to do it through > xdp_do_flush_map() which only makes sense for devmap not XDP_TX. So > explicitly kick the

Re: [virtio-dev] Re: [PATCH v2] virtio_balloon: export hugetlb page allocation counts

2018-04-13 Thread Michael S. Tsirkin
On Fri, Apr 13, 2018 at 03:01:11PM +0800, Jason Wang wrote: > > > On 2018年04月12日 08:24, Jonathan Helman wrote: > > > > > > On 04/10/2018 08:12 PM, Jason Wang wrote: > > > > > > > > > On 2018年04月10日 05:11, Jonathan Helman wrote: > > > > > > > > > > > > On 03/22/2018 07:38 PM, Jason Wang

[PATCH] virtio_balloon: add array of stat names

2018-04-13 Thread Michael S. Tsirkin
Jason Wang points out that it's vary hard for users to build an array of stat names. The naive thing is to use VIRTIO_BALLOON_S_NR but that breaks if we add more stats. Let's add an array of reasonably readable names. Fixes: 6c64fe7f2 ("virtio_balloon: export hugetlb page allocation counts") Cc: