Re: [PATCH v35 1/5] mm: support to get hints of free page blocks

2018-07-11 Thread Michal Hocko
On Tue 10-07-18 18:44:34, Linus Torvalds wrote: [...] > That was what I tried to encourage with actually removing the pages > form the page list. That would be an _incremental_ interface. You can > remove MAX_ORDER-1 pages one by one (or a hundred at a time), and mark > them free for ballooning tha

Re: [PATCH v35 1/5] mm: support to get hints of free page blocks

2018-07-11 Thread Wei Wang
On 07/11/2018 05:21 PM, Michal Hocko wrote: On Tue 10-07-18 18:44:34, Linus Torvalds wrote: [...] That was what I tried to encourage with actually removing the pages form the page list. That would be an _incremental_ interface. You can remove MAX_ORDER-1 pages one by one (or a hundred at a time)

Re: [PATCH v35 1/5] mm: support to get hints of free page blocks

2018-07-11 Thread Michal Hocko
On Wed 11-07-18 18:52:45, Wei Wang wrote: > On 07/11/2018 05:21 PM, Michal Hocko wrote: > > On Tue 10-07-18 18:44:34, Linus Torvalds wrote: > > [...] > > > That was what I tried to encourage with actually removing the pages > > > form the page list. That would be an _incremental_ interface. You can

Re: [PATCH net-next v5 0/4] net: vhost: improve performance when enable busyloop

2018-07-11 Thread Michael S. Tsirkin
On Wed, Jul 11, 2018 at 01:12:59PM +0800, Jason Wang wrote: > > > On 2018年07月11日 11:49, Tonghao Zhang wrote: > > On Wed, Jul 11, 2018 at 10:56 AM Jason Wang wrote: > > > > > > > > > On 2018年07月04日 12:31, xiangxia.m@gmail.com wrote: > > > > From: Tonghao Zhang > > > > > > > > This patches

RE: [PATCH v35 1/5] mm: support to get hints of free page blocks

2018-07-11 Thread Wang, Wei W
On Wednesday, July 11, 2018 7:10 PM, Michal Hocko wrote: > On Wed 11-07-18 18:52:45, Wei Wang wrote: > > On 07/11/2018 05:21 PM, Michal Hocko wrote: > > > On Tue 10-07-18 18:44:34, Linus Torvalds wrote: > > > [...] > > > > That was what I tried to encourage with actually removing the > > > > pages

Re: [PATCH v35 1/5] mm: support to get hints of free page blocks

2018-07-11 Thread Michal Hocko
On Wed 11-07-18 13:55:15, Wang, Wei W wrote: > On Wednesday, July 11, 2018 7:10 PM, Michal Hocko wrote: > > On Wed 11-07-18 18:52:45, Wei Wang wrote: > > > On 07/11/2018 05:21 PM, Michal Hocko wrote: > > > > On Tue 10-07-18 18:44:34, Linus Torvalds wrote: > > > > [...] > > > > > That was what I tri

Re: [PATCH v35 1/5] mm: support to get hints of free page blocks

2018-07-11 Thread Linus Torvalds
On Wed, Jul 11, 2018 at 2:21 AM Michal Hocko wrote: > > We already have an interface for that. alloc_pages(GFP_NOWAIT, MAX_ORDER -1). > So why do we need any array based interface? That was actually my original argument in the original thread - that the only new interface people might want is one

Re: [PATCH v35 1/5] mm: support to get hints of free page blocks

2018-07-11 Thread Michael S. Tsirkin
On Wed, Jul 11, 2018 at 01:09:49PM +0200, Michal Hocko wrote: > But let me note that I am not really convinced how this (or previous) > approach will really work in most workloads. We tend to cache heavily so > there is rarely any memory free. It might be that it's worth flushing the cache when VM

Re: [PATCH v35 1/5] mm: support to get hints of free page blocks

2018-07-11 Thread Wei Wang
On 07/12/2018 12:23 AM, Linus Torvalds wrote: On Wed, Jul 11, 2018 at 2:21 AM Michal Hocko wrote: We already have an interface for that. alloc_pages(GFP_NOWAIT, MAX_ORDER -1). So why do we need any array based interface? That was actually my original argument in the original thread - that the

Re: [PATCH v35 1/5] mm: support to get hints of free page blocks

2018-07-11 Thread Linus Torvalds
On Wed, Jul 11, 2018 at 7:17 PM Wei Wang wrote: > > Would it be better to remove __GFP_THISNODE? We actually want to get all > the guest free pages (from all the nodes). Maybe. Or maybe it would be better to have the memory balloon logic be per-node? Maybe you don't want to remove too much memory

Re: [PATCH v35 1/5] mm: support to get hints of free page blocks

2018-07-11 Thread Wei Wang
On 07/12/2018 10:30 AM, Linus Torvalds wrote: On Wed, Jul 11, 2018 at 7:17 PM Wei Wang wrote: Would it be better to remove __GFP_THISNODE? We actually want to get all the guest free pages (from all the nodes). Maybe. Or maybe it would be better to have the memory balloon logic be per-node? May

Re: [PATCH net-next v5 0/4] net: vhost: improve performance when enable busyloop

2018-07-11 Thread Jason Wang
On 2018年07月11日 19:59, Michael S. Tsirkin wrote: On Wed, Jul 11, 2018 at 01:12:59PM +0800, Jason Wang wrote: On 2018年07月11日 11:49, Tonghao Zhang wrote: On Wed, Jul 11, 2018 at 10:56 AM Jason Wang wrote: On 2018年07月04日 12:31, xiangxia.m@gmail.com wrote: From: Tonghao Zhang This patch

Re: [PATCH net-next v5 0/4] net: vhost: improve performance when enable busyloop

2018-07-11 Thread Michael S. Tsirkin
On Thu, Jul 12, 2018 at 11:26:12AM +0800, Jason Wang wrote: > > > On 2018年07月11日 19:59, Michael S. Tsirkin wrote: > > On Wed, Jul 11, 2018 at 01:12:59PM +0800, Jason Wang wrote: > > > > > > On 2018年07月11日 11:49, Tonghao Zhang wrote: > > > > On Wed, Jul 11, 2018 at 10:56 AM Jason Wang wrote: > >

Re: [PATCH net-next v5 0/4] net: vhost: improve performance when enable busyloop

2018-07-11 Thread Jason Wang
On 2018年07月12日 11:34, Michael S. Tsirkin wrote: On Thu, Jul 12, 2018 at 11:26:12AM +0800, Jason Wang wrote: On 2018年07月11日 19:59, Michael S. Tsirkin wrote: On Wed, Jul 11, 2018 at 01:12:59PM +0800, Jason Wang wrote: On 2018年07月11日 11:49, Tonghao Zhang wrote: On Wed, Jul 11, 2018 at 10:56 A

Re: [PATCH net-next v5 0/4] net: vhost: improve performance when enable busyloop

2018-07-11 Thread Michael S. Tsirkin
On Thu, Jul 12, 2018 at 01:21:03PM +0800, Jason Wang wrote: > > > On 2018年07月12日 11:34, Michael S. Tsirkin wrote: > > On Thu, Jul 12, 2018 at 11:26:12AM +0800, Jason Wang wrote: > > > > > > On 2018年07月11日 19:59, Michael S. Tsirkin wrote: > > > > On Wed, Jul 11, 2018 at 01:12:59PM +0800, Jason Wa

Re: [PATCH net-next v5 0/4] net: vhost: improve performance when enable busyloop

2018-07-11 Thread Jason Wang
On 2018年07月12日 13:24, Michael S. Tsirkin wrote: On Thu, Jul 12, 2018 at 01:21:03PM +0800, Jason Wang wrote: On 2018年07月12日 11:34, Michael S. Tsirkin wrote: On Thu, Jul 12, 2018 at 11:26:12AM +0800, Jason Wang wrote: On 2018年07月11日 19:59, Michael S. Tsirkin wrote: On Wed, Jul 11, 2018 at 01