Re: [PATCH v3] virtio_net: avoid using netif_tx_disable() for serializing tx routine

2018-10-17 Thread Michael S. Tsirkin
On Wed, Oct 17, 2018 at 07:44:12PM +0900, Ake Koomsin wrote: > Commit 713a98d90c5e ("virtio-net: serialize tx routine during reset") > introduces netif_tx_disable() after netif_device_detach() in order to > avoid use-after-free of tx queues. However, there are two issues. > > 1) Its operation is

Re: [PATCH v3 3/7] PCI: OF: Allow endpoints to bypass the iommu

2018-10-17 Thread Michael S. Tsirkin
On Mon, Oct 15, 2018 at 08:46:41PM +0100, Jean-philippe Brucker wrote: > [Replying with my personal address because we're having SMTP issues] > > On 15/10/2018 11:52, Michael S. Tsirkin wrote: > > On Fri, Oct 12, 2018 at 02:41:59PM -0500, Bjorn Helgaas wrote: > >> s/iommu/IOMMU/ in subject > >> >

Re: [PATCH v3 0/7] Add virtio-iommu driver

2018-10-17 Thread Michael S. Tsirkin
On Wed, Oct 17, 2018 at 12:54:28PM +0100, Jean-Philippe Brucker wrote: > On 16/10/2018 21:31, Auger Eric wrote: > > Hi Jean, > > > > On 10/16/18 8:44 PM, Jean-Philippe Brucker wrote: > >> On 16/10/2018 10:25, Auger Eric wrote: > >>> Hi Jean, > >>> > >>> On 10/12/18 4:59 PM, Jean-Philippe Brucker

Re: [RFC] VSOCK: The performance problem of vhost_vsock.

2018-10-17 Thread Jason Wang
On 2018/10/18 上午9:22, jiangyiwen wrote: On 2018/10/17 20:31, Jason Wang wrote: On 2018/10/17 下午7:41, jiangyiwen wrote: On 2018/10/17 17:51, Jason Wang wrote: On 2018/10/17 下午5:39, Jason Wang wrote: Hi Jason and Stefan, Maybe I find the reason of bad performance. I found pkt_len is limited

Re: [PATCH net-next V2 6/8] vhost: packed ring support

2018-10-17 Thread Jason Wang
On 2018/10/15 下午6:25, Michael S. Tsirkin wrote: On Mon, Oct 15, 2018 at 10:51:06AM +0800, Jason Wang wrote: On 2018年10月15日 10:43, Michael S. Tsirkin wrote: On Mon, Oct 15, 2018 at 10:22:33AM +0800, Jason Wang wrote: On 2018年10月13日 01:23, Michael S. Tsirkin wrote: On Fri, Oct 12, 2018 at

Re: [PATCH v3] virtio_net: avoid using netif_tx_disable() for serializing tx routine

2018-10-17 Thread David Miller
From: Ake Koomsin Date: Wed, 17 Oct 2018 19:44:12 +0900 > Commit 713a98d90c5e ("virtio-net: serialize tx routine during reset") > introduces netif_tx_disable() after netif_device_detach() in order to > avoid use-after-free of tx queues. However, there are two issues. > > 1) Its operation is

Re: [PATCH v2] drm/bochs: add edid support.

2018-10-17 Thread Gerd Hoffmann
Hi, > > Recent qemu (latest master branch, upcoming 3.1 release) got support > > for EDID data. This patch adds guest driver support. > > > > EDID support in qemu is not (yet) enabled by default, so please use > > 'qemu -device VGA,edid=on' for testing. > > The EDID never changes after boot?

Re: [PATCH 5/8] drm/virtio: track created object state

2018-10-17 Thread Gerd Hoffmann
On Thu, Oct 18, 2018 at 11:25:22AM +1000, Dave Airlie wrote: > On Mon, 1 Oct 2018 at 20:33, Gerd Hoffmann wrote: > > > > Track whenever the virtio_gpu_object is already created (i.e. host knows > > about it) in a new variable. Add checks to virtio_gpu_object_attach() > > to do nothing on objects

Re: [PATCH v2] virtio-gpu: add VIRTIO_GPU_F_EDID feature

2018-10-17 Thread Dave Airlie
Reviewed-by: Dave Airlie On Fri, 5 Oct 2018 at 22:52, Gerd Hoffmann wrote: > > The feature allows the guest request an EDID blob (describing monitor > capabilities) for a given scanout (aka virtual monitor connector). > > It brings a new command message, which has just a scanout field (beside >

Re: [PATCH v3 2/7] dt-bindings: virtio: Add virtio-pci-iommu node

2018-10-17 Thread Rob Herring
On Fri, 12 Oct 2018 15:59:12 +0100, Jean-Philippe Brucker wrote: > Some systems implement virtio-iommu as a PCI endpoint. The operating > systems needs to discover the relationship between IOMMU and masters long > before the PCI endpoint gets probed. Add a PCI child node to describe the >

Re: [RFC] VSOCK: The performance problem of vhost_vsock.

2018-10-17 Thread jiangyiwen
On 2018/10/17 20:31, Jason Wang wrote: > > On 2018/10/17 下午7:41, jiangyiwen wrote: >> On 2018/10/17 17:51, Jason Wang wrote: >>> On 2018/10/17 下午5:39, Jason Wang wrote: > Hi Jason and Stefan, > > Maybe I find the reason of bad performance. > > I found pkt_len is limited to

Re: [PATCH v2] drm/bochs: add edid support.

2018-10-17 Thread Dave Airlie
On Fri, 5 Oct 2018 at 22:10, Gerd Hoffmann wrote: > > Recent qemu (latest master branch, upcoming 3.1 release) got support > for EDID data. This patch adds guest driver support. > > EDID support in qemu is not (yet) enabled by default, so please use > 'qemu -device VGA,edid=on' for testing. The

Re: [PATCH 5/8] drm/virtio: track created object state

2018-10-17 Thread Dave Airlie
On Mon, 1 Oct 2018 at 20:33, Gerd Hoffmann wrote: > > Track whenever the virtio_gpu_object is already created (i.e. host knows > about it) in a new variable. Add checks to virtio_gpu_object_attach() > to do nothing on objects not created yet. > > Make virtio_gpu_ttm_bo_destroy() use the new

Re: [PATCH] virtio_net: enable tx after resuming from suspend

2018-10-17 Thread Jason Wang
On 2018/10/16 下午6:15, ake wrote: On 2018年10月16日 17:53, Jason Wang wrote: On 2018/10/15 下午6:08, ake wrote: On 2018年10月12日 18:18, ake wrote: On 2018年10月12日 17:23, Jason Wang wrote: On 2018年10月12日 12:30, ake wrote: On 2018年10月11日 22:06, Jason Wang wrote: On 2018年10月11日 18:22, ake wrote: On

Re: [RFC] virtio_net: add local_bh_disable() around u64_stats_update_begin

2018-10-17 Thread Jason Wang
On 2018/10/17 上午9:13, Toshiaki Makita wrote: On 2018/10/17 1:55, Sebastian Andrzej Siewior wrote: on 32bit, lockdep notices: | | WARNING: inconsistent lock state | 4.19.0-rc8+ #9 Tainted: GW | | inconsistent

Re: [RFC] VSOCK: The performance problem of vhost_vsock.

2018-10-17 Thread jiangyiwen
On 2018/10/15 14:12, jiangyiwen wrote: > On 2018/10/15 10:33, Jason Wang wrote: >> >> >> On 2018年10月15日 09:43, jiangyiwen wrote: >>> Hi Stefan & All: >>> >>> Now I find vhost-vsock has two performance problems even if it >>> is not designed for performance. >>> >>> First, I think vhost-vsock

Re: [PATCH v2] virtio_net: avoid using netif_tx_disable() for serializing tx routine

2018-10-17 Thread Jason Wang
On 2018/10/17 下午3:59, Ake Koomsin wrote: Commit 713a98d90c5e ("virtio-net: serialize tx routine during reset") introduces netif_tx_disable() after netif_device_detach() in order to avoid use-after-free of tx queues. However, there are two issues. 1) Its operation is redundant with

Re: [RFC] VSOCK: The performance problem of vhost_vsock.

2018-10-17 Thread Jason Wang
On 2018/10/17 下午5:27, jiangyiwen wrote: On 2018/10/15 14:12, jiangyiwen wrote: On 2018/10/15 10:33, Jason Wang wrote: On 2018年10月15日 09:43, jiangyiwen wrote: Hi Stefan & All: Now I find vhost-vsock has two performance problems even if it is not designed for performance. First, I think

Re: [RFC] VSOCK: The performance problem of vhost_vsock.

2018-10-17 Thread Jason Wang
On 2018/10/17 下午5:39, Jason Wang wrote: Hi Jason and Stefan, Maybe I find the reason of bad performance. I found pkt_len is limited to VIRTIO_VSOCK_DEFAULT_RX_BUF_SIZE(4K), it will cause the bandwidth is limited to 500~600MB/s. And once I increase to 64k, it can improve about 3

Re: [PATCH net-next V2 6/8] vhost: packed ring support

2018-10-17 Thread Jason Wang
On 2018/10/16 下午9:58, Maxime Coquelin wrote: On 10/15/2018 04:22 AM, Jason Wang wrote: On 2018年10月13日 01:23, Michael S. Tsirkin wrote: On Fri, Oct 12, 2018 at 10:32:44PM +0800, Tiwei Bie wrote: On Mon, Jul 16, 2018 at 11:28:09AM +0800, Jason Wang wrote: [...] @@ -1367,10 +1397,48 @@ long

Re: [PATCH v3 1/7] dt-bindings: virtio-mmio: Add IOMMU description

2018-10-17 Thread Rob Herring
On Fri, Oct 12, 2018 at 03:59:11PM +0100, Jean-Philippe Brucker wrote: > The nature of a virtio-mmio node is discovered by the virtio driver at > probe time. However the DMA relation between devices must be described > statically. When a virtio-mmio node is a virtio-iommu device, it needs an >

Re: [PATCH 7/8] drm/virtio: move virtio_gpu_object_{attach, detach} calls.

2018-10-17 Thread Dave Airlie
On Mon, 1 Oct 2018 at 20:33, Gerd Hoffmann wrote: > > Remove the virtio_gpu_object_{attach,detach} calls from move_notify() > callback. Add them to the ttm_tt_{populate,unpopulate} callbacks, which > is the correct place to handle this. > > The new ttm_tt_{populate,unpopulate} callbacks call the

Re: [RFC] VSOCK: The performance problem of vhost_vsock.

2018-10-17 Thread jiangyiwen
On 2018/10/17 17:39, Jason Wang wrote: > > On 2018/10/17 下午5:27, jiangyiwen wrote: >> On 2018/10/15 14:12, jiangyiwen wrote: >>> On 2018/10/15 10:33, Jason Wang wrote: On 2018年10月15日 09:43, jiangyiwen wrote: > Hi Stefan & All: > > Now I find vhost-vsock has two performance

Re: [RFC] VSOCK: The performance problem of vhost_vsock.

2018-10-17 Thread jiangyiwen
On 2018/10/17 17:51, Jason Wang wrote: > > On 2018/10/17 下午5:39, Jason Wang wrote: >>> Hi Jason and Stefan, >>> >>> Maybe I find the reason of bad performance. >>> >>> I found pkt_len is limited to VIRTIO_VSOCK_DEFAULT_RX_BUF_SIZE(4K), >>> it will cause the bandwidth is limited to

Re: [PATCH v3 0/7] Add virtio-iommu driver

2018-10-17 Thread Jean-Philippe Brucker
On 16/10/2018 21:31, Auger Eric wrote: > Hi Jean, > > On 10/16/18 8:44 PM, Jean-Philippe Brucker wrote: >> On 16/10/2018 10:25, Auger Eric wrote: >>> Hi Jean, >>> >>> On 10/12/18 4:59 PM, Jean-Philippe Brucker wrote: Implement the virtio-iommu driver, following specification v0.8 [1].

Re: [PATCH v3] virtio_net: avoid using netif_tx_disable() for serializing tx routine

2018-10-17 Thread Jason Wang
On 2018/10/17 下午6:44, Ake Koomsin wrote: Commit 713a98d90c5e ("virtio-net: serialize tx routine during reset") introduces netif_tx_disable() after netif_device_detach() in order to avoid use-after-free of tx queues. However, there are two issues. 1) Its operation is redundant with

Re: [RFC] VSOCK: The performance problem of vhost_vsock.

2018-10-17 Thread Jason Wang
On 2018/10/17 下午7:41, jiangyiwen wrote: On 2018/10/17 17:51, Jason Wang wrote: On 2018/10/17 下午5:39, Jason Wang wrote: Hi Jason and Stefan, Maybe I find the reason of bad performance. I found pkt_len is limited to VIRTIO_VSOCK_DEFAULT_RX_BUF_SIZE(4K), it will cause the bandwidth is limited