Re: [PATCH] drm/virtio: move drm_connector_update_edid_property() call

On Wed, Jun 26, 2019 at 09:51:46AM +0200, Cornelia Huck wrote: > On Fri, 5 Apr 2019 06:46:02 +0200 > Gerd Hoffmann wrote: > > > drm_connector_update_edid_property can sleep, we must not > > call it while holding a spinlock. Move the callsize. > > s/callsize/callsite/ Fixed on commit. > This

Re: [PATCH 2/2] drm/bochs: fix framebuffer setup.

On Wed, Jun 26, 2019 at 08:55:51AM +0200, Gerd Hoffmann wrote: > If bo->width doesn't match fb->width the driver fails to configure > the display correctly, resulting in a scrambled display. Fix it. > > Signed-off-by: Gerd Hoffmann > --- > drivers/gpu/drm/bochs/bochs.h | 2 +- >

Re: [PATCH v4 02/12] drm/virtio: switch virtio_gpu_wait_ioctl() to gem helper.

On Wed, Jun 19, 2019 at 11:07 PM Gerd Hoffmann wrote: > > Use drm_gem_reservation_object_wait() in virtio_gpu_wait_ioctl(). > This also makes the ioctl run lockless. The userspace has a BO cache to avoid freeing BOs immediately but to reuse them on next allocations. The BO cache checks if a BO

Re: [PATCH v4 11/12] drm/virtio: switch from ttm to gem shmem helpers

. On Wed, Jun 19, 2019 at 11:08 PM Gerd Hoffmann wrote: > > virtio-gpu basically needs a sg_table for the bo, to tell the host where > the backing pages for the object are. So the gem shmem helpers are a > perfect fit. Some drm_gem_object_funcs need thin wrappers to update the > host state,

Re: [PATCH v3 08/12] drm/virtio: rework virtio_gpu_execbuffer_ioctl fencing

I tried my best to review this series. I am not really a kernel dev so please take that with a grain of salt. On Wed, Jun 19, 2019 at 11:01 PM Gerd Hoffmann wrote: > > Hi, > > > Also, I strongly recommend you do a very basic igt to exercise this, i.e. > > allocate some buffers, submit them in

Re: [PATCH v4 09/12] drm/virtio: rework virtio_gpu_object_create fencing

On Wed, Jun 19, 2019 at 11:07 PM Gerd Hoffmann wrote: > > Use gem reservation helpers and direct reservation_object_* calls > instead of ttm. > > v3: Due to using the gem reservation object it is initialized and ready > for use before calling ttm_bo_init, so we can also drop the tricky fence >

Re: [PATCH v4 07/12] drm/virtio: add virtio_gpu_object_array & helpers

On Wed, Jun 19, 2019 at 11:08 PM Gerd Hoffmann wrote: > > Some helper functions to manage an array of gem objects. > > v4: make them virtio-private instead of generic helpers. > > Signed-off-by: Gerd Hoffmann > --- > drivers/gpu/drm/virtio/virtgpu_drv.h | 10 ++ >

Re: [PATCH v4 08/12] drm/virtio: rework virtio_gpu_execbuffer_ioctl fencing

On Wed, Jun 19, 2019 at 11:08 PM Gerd Hoffmann wrote: > > Use gem reservation helpers and direct reservation_object_* calls > instead of ttm. > > v3: Also attach the array of gem objects to the virtio command buffer, > so we can drop the object references in the completion callback. Needed >

[PATCH 2/2] drm/bochs: fix framebuffer setup.

If bo->width doesn't match fb->width the driver fails to configure the display correctly, resulting in a scrambled display. Fix it. Signed-off-by: Gerd Hoffmann --- drivers/gpu/drm/bochs/bochs.h | 2 +- drivers/gpu/drm/bochs/bochs_hw.c | 13 +

Re: [PATCH] drm/virtio: move drm_connector_update_edid_property() call

On Fri, 5 Apr 2019 06:46:02 +0200 Gerd Hoffmann wrote: > drm_connector_update_edid_property can sleep, we must not > call it while holding a spinlock. Move the callsize. s/callsize/callsite/ > > Reported-by: Max Filippov > Signed-off-by: Gerd Hoffmann > --- >