Re: VIRTIO_BALLOON_F_FREE_PAGE_HINT

2019-10-06 Thread Tyler Sanderson via Virtualization
On Sun, Oct 6, 2019 at 4:48 AM Michael S. Tsirkin wrote: > On Sun, Oct 06, 2019 at 10:30:40AM +0200, David Hildenbrand wrote: > > Please note the "use outside of a testing or debugging environment is > > not recommended". Usually you want a "soft" version of this, e.g., via > > the OOM handler

Re: VIRTIO_BALLOON_F_FREE_PAGE_HINT

2019-10-06 Thread David Hildenbrand
On 04.10.19 21:03, Tyler Sanderson wrote: > I think DEFLATE_ON_OOM makes sense conceptually, it's just that the > implementation doesn't play well with the rest of memory management > under memory pressure. > It could probably be fixed with enough effort, but IMO free page hinting > gets 90% of

Re: VIRTIO_BALLOON_F_FREE_PAGE_HINT

2019-10-06 Thread Michael S. Tsirkin
On Sun, Oct 06, 2019 at 10:30:40AM +0200, David Hildenbrand wrote: > Please note the "use outside of a testing or debugging environment is > not recommended". Usually you want a "soft" version of this, e.g., via > the OOM handler (so only drop parts of the cache, not all). Right. We'll need

[PATCH RFC net-next 1/2] drivers: net: virtio_net: Add tx_timeout stats field

2019-10-06 Thread jcfaracco
From: Julio Faracco For debug purpose of TX timeout events, a tx_timeout entry was added to monitor this special case: when dev_watchdog identifies a tx_timeout and throw an exception. We can both consider this event as an error, but driver should report as a tx_timeout statistic.

[PATCH RFC net-next 2/2] drivers: net: virtio_net: Add tx_timeout function

2019-10-06 Thread jcfaracco
From: Julio Faracco To enable dev_watchdog, virtio_net should have a tx_timeout defined (.ndo_tx_timeout). This is only a skeleton to throw a warn message. It notifies the event in some specific queue of device. This function still counts tx_timeout statistic and consider this event as an

[PATCH RFC net-next 0/2] drivers: net: virtio_net: Implement

2019-10-06 Thread jcfaracco
From: Julio Faracco Driver virtio_net is not handling error events for TX provided by dev_watchdog. This event is reached when transmission queue is having problems to transmit packets. To enable it, driver should have .ndo_tx_timeout implemented. This serie has two commits: In the past, we