Re: [PATCH] virtio_ring: fix packed ring event may missing

2019-10-27 Thread Michael S. Tsirkin
On Fri, Oct 25, 2019 at 06:53:55AM -0400, Michael S. Tsirkin wrote: > On Tue, Oct 22, 2019 at 01:10:04AM +0800, Marvin Liu wrote: > > When callback is delayed, virtio expect that vhost will kick when > > rolling over event offset. Recheck should be taken as used index may > > exceed event offset

Re: [PATCH] virtio_ring: fix packed ring event may missing

2019-10-27 Thread Michael S. Tsirkin
On Thu, Oct 24, 2019 at 11:50:51AM +0800, Jason Wang wrote: > > On 2019/10/24 上午11:26, Liu, Yong wrote: > > > > > -Original Message- > > > From: Jason Wang [mailto:jasow...@redhat.com] > > > Sent: Tuesday, October 22, 2019 9:06 PM > > > To: Liu, Yong ; m...@redhat.com; Bie, Tiwei > > >

Re: [PATCH] virtio_ring: fix packed ring event may missing

2019-10-27 Thread Michael S. Tsirkin
On Fri, Oct 25, 2019 at 05:32:49AM -0400, Michael S. Tsirkin wrote: > On Tue, Oct 22, 2019 at 01:10:04AM +0800, Marvin Liu wrote: > > When callback is delayed, virtio expect that vhost will kick when > > rolling over event offset. Recheck should be taken as used index may > > exceed event offset

[PATCH] virtio_ring: fix stalls for packed rings

2019-10-27 Thread Michael S. Tsirkin
From: Marvin Liu When VIRTIO_F_RING_EVENT_IDX is negotiated, virtio devices can use virtqueue_enable_cb_delayed_packed to reduce the number of device interrupts. At the moment, this is the case for virtio-net when the napi_tx module parameter is set to false. In this case, the virtio driver

Re: [PATCH net-next 08/14] vsock: add vsock_create_connected() called by transports

2019-10-27 Thread Stefan Hajnoczi
On Wed, Oct 23, 2019 at 11:55:48AM +0200, Stefano Garzarella wrote: > All transports call __vsock_create() with the same parameters, > most of them depending on the parent socket. In order to simplify > the VSOCK core APIs exposed to the transports, this patch adds > the vsock_create_connected()

Re: [PATCH net-next 07/14] vsock: handle buffer_size sockopts in the core

2019-10-27 Thread Stefan Hajnoczi
On Wed, Oct 23, 2019 at 11:55:47AM +0200, Stefano Garzarella wrote: > virtio_transport and vmci_transport handle the buffer_size > sockopts in a very similar way. > > In order to support multiple transports, this patch moves this > handling in the core to allow the user to change the options >

Re: [PATCH net-next] vringh: fix copy direction of vringh_iov_push_kern()

2019-10-27 Thread Michael S. Tsirkin
On Thu, Oct 24, 2019 at 11:57:18AM +0800, Jason Wang wrote: > We want to copy from iov to buf, so the direction was wrong. > > Note: no real user for the helper, but it will be used by future > features. > > Signed-off-by: Jason Wang I'm still inclined to merge it now, incorrect code tends to

Re: [PATCH] virtio_ring: fix packed ring event may missing

2019-10-27 Thread Michael S. Tsirkin
On Tue, Oct 22, 2019 at 01:10:04AM +0800, Marvin Liu wrote: > When callback is delayed, virtio expect that vhost will kick when > rolling over event offset. Recheck should be taken as used index may > exceed event offset between status check and driver event update. > > However, it is possible

Re: [PATCH net-next 00/14] vsock: add multi-transports support

2019-10-27 Thread Stefan Hajnoczi
On Wed, Oct 23, 2019 at 11:55:40AM +0200, Stefano Garzarella wrote: > This series adds the multi-transports support to vsock, following > this proposal: https://www.spinics.net/lists/netdev/msg575792.html > > With the multi-transports support, we can use VSOCK with nested VMs > (using also

Re: [PATCH net-next 12/14] vsock/vmci: register vmci_transport only when VMCI guest/host are active

2019-10-27 Thread Stefan Hajnoczi
On Wed, Oct 23, 2019 at 11:55:52AM +0200, Stefano Garzarella wrote: > +static int __init vmci_transport_init(void) > +{ > + int features = VSOCK_TRANSPORT_F_DGRAM; Where is this variable used? signature.asc Description: PGP signature ___

Re: [PATCH v2] vhost: introduce mdev based hardware backend

2019-10-27 Thread Tiwei Bie
On Fri, Oct 25, 2019 at 08:16:26AM -0400, Michael S. Tsirkin wrote: > On Fri, Oct 25, 2019 at 05:54:55PM +0800, Jason Wang wrote: > > On 2019/10/24 下午6:42, Jason Wang wrote: > > > > > > Yes. > > > > > > > > > >   And we should try to avoid > > > > putting ctrl vq and Rx/Tx vqs in the same DMA

Re: [PATCH v2] vhost: introduce mdev based hardware backend

2019-10-27 Thread Jason Wang
On 2019/10/28 上午9:58, Tiwei Bie wrote: On Fri, Oct 25, 2019 at 08:16:26AM -0400, Michael S. Tsirkin wrote: On Fri, Oct 25, 2019 at 05:54:55PM +0800, Jason Wang wrote: On 2019/10/24 下午6:42, Jason Wang wrote: Yes.   And we should try to avoid putting ctrl vq and Rx/Tx vqs in the same DMA

Re: [PATCH net-next] vringh: fix copy direction of vringh_iov_push_kern()

2019-10-27 Thread Jason Wang
On 2019/10/27 下午6:04, Michael S. Tsirkin wrote: On Thu, Oct 24, 2019 at 11:57:18AM +0800, Jason Wang wrote: We want to copy from iov to buf, so the direction was wrong. Note: no real user for the helper, but it will be used by future features. Signed-off-by: Jason Wang I'm still inclined