From: "Michael S. Tsirkin"
Date: Tue, 5 May 2020 20:01:31 -0400
> - u64_stats_update_end(>stats.syncp);
> + u64_stats_update_end_irqrestore(>stats.syncp);
Need to pass flags to this function.
___
Virtualization mailing list
> Am 06.05.2020 um 22:28 schrieb Michael S. Tsirkin :
>
> On Tue, May 05, 2020 at 06:22:51PM +0200, David Hildenbrand wrote:
>>> On 05.05.20 18:20, Michael S. Tsirkin wrote:
>>> On Tue, May 05, 2020 at 05:46:44PM +0200, David Hildenbrand wrote:
On 05.05.20 17:44, Michael S. Tsirkin wrote:
On Tue, May 05, 2020 at 06:22:51PM +0200, David Hildenbrand wrote:
> On 05.05.20 18:20, Michael S. Tsirkin wrote:
> > On Tue, May 05, 2020 at 05:46:44PM +0200, David Hildenbrand wrote:
> >> On 05.05.20 17:44, Michael S. Tsirkin wrote:
> >>> On Tue, May 05, 2020 at 04:50:13PM +0200, David
On 5/6/20 1:08 PM, Mike Stunes wrote:
On Apr 28, 2020, at 8:17 AM, Joerg Roedel wrote:
From: Mike Stunes
To avoid a future VMEXIT for a subsequent CPUID function, cache the
results returned by CPUID into an xarray.
[tl: coding standard changes, register zero extension]
Signed-off-by:
We should not exclude headroom and tailroom when XDP is set. So this
patch fixes this by initializing the truesize from PAGE_SIZE when XDP
is set.
Cc: Jesper Dangaard Brouer
Signed-off-by: Jason Wang
---
drivers/net/virtio_net.c | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff
We tried to reserve space for vnet header before
xdp.data_hard_start. But this is useless since the packet could be
modified by XDP which may invalidate the information stored in the
header and there's no way for XDP to know the existence of the vnet
header currently.
So let's just not reserve
On Wed, May 06, 2020 at 02:16:33PM +0800, Jason Wang wrote:
> We should not exclude headroom and tailroom when XDP is set. So this
> patch fixes this by initializing the truesize from PAGE_SIZE when XDP
> is set.
>
> Cc: Jesper Dangaard Brouer
> Signed-off-by: Jason Wang
Seems too aggressive,
On 2020/5/6 下午3:53, Michael S. Tsirkin wrote:
On Wed, May 06, 2020 at 02:16:32PM +0800, Jason Wang wrote:
We tried to reserve space for vnet header before
xdp.data_hard_start. But this is useless since the packet could be
modified by XDP which may invalidate the information stored in the
On 2020/5/6 下午4:21, Jesper Dangaard Brouer wrote:
On Wed, 6 May 2020 14:16:32 +0800
Jason Wang wrote:
We tried to reserve space for vnet header before
xdp.data_hard_start. But this is useless since the packet could be
modified by XDP which may invalidate the information stored in the
header
On Wed, May 06, 2020 at 03:28:47AM +, Justin He wrote:
> Hi Michael
>
> > -Original Message-
> > From: Michael S. Tsirkin
> > Sent: Monday, May 4, 2020 8:16 PM
> > To: Linus Torvalds
> > Cc: k...@vger.kernel.org; virtualization@lists.linux-foundation.org;
> > net...@vger.kernel.org;
On Wed, May 06, 2020 at 02:16:32PM +0800, Jason Wang wrote:
> We tried to reserve space for vnet header before
> xdp.data_hard_start. But this is useless since the packet could be
> modified by XDP which may invalidate the information stored in the
> header and there's no way for XDP to know the
So for mergeable bufs, we use ewma machinery to guess the correct buffer
size. If we don't guess correctly, XDP has to do aggressive copies.
Problem is, xdp paths do not update the ewma at all, except
sometimes with XDP_PASS. So whatever we happen to have
before we attach XDP, will mostly stay
On 2020/5/6 下午4:08, Michael S. Tsirkin wrote:
So for mergeable bufs, we use ewma machinery to guess the correct buffer
size. If we don't guess correctly, XDP has to do aggressive copies.
Problem is, xdp paths do not update the ewma at all, except
sometimes with XDP_PASS. So whatever we happen
On Wed, 6 May 2020 04:08:27 -0400
"Michael S. Tsirkin" wrote:
> So for mergeable bufs, we use ewma machinery to guess the correct buffer
> size. If we don't guess correctly, XDP has to do aggressive copies.
>
> Problem is, xdp paths do not update the ewma at all, except
> sometimes with
On Wed, May 06, 2020 at 03:19:55AM -0400, Michael S. Tsirkin wrote:
> On Wed, May 06, 2020 at 03:28:47AM +, Justin He wrote:
> > Hi Michael
> >
> > > -Original Message-
> > > From: Michael S. Tsirkin
> > > Sent: Monday, May 4, 2020 8:16 PM
> > > To: Linus Torvalds
> > > Cc:
On 2020/5/6 下午3:37, Michael S. Tsirkin wrote:
On Wed, May 06, 2020 at 02:16:33PM +0800, Jason Wang wrote:
We should not exclude headroom and tailroom when XDP is set. So this
patch fixes this by initializing the truesize from PAGE_SIZE when XDP
is set.
Cc: Jesper Dangaard Brouer
On Wed, 6 May 2020 14:16:32 +0800
Jason Wang wrote:
> We tried to reserve space for vnet header before
> xdp.data_hard_start. But this is useless since the packet could be
> modified by XDP which may invalidate the information stored in the
> header and
IMHO above statements are wrong. XDP
On Wed, May 06, 2020 at 03:19:55AM -0400, Michael S. Tsirkin wrote:
> On Wed, May 06, 2020 at 03:28:47AM +, Justin He wrote:
> > Hi Michael
> >
> > > -Original Message-
> > > From: Michael S. Tsirkin
> > > Sent: Monday, May 4, 2020 8:16 PM
> > > To: Linus Torvalds
> > > Cc:
On Tue, May 05, 2020 at 08:47:47PM +0200, Julia Lawall wrote:
> Elsewhere in the file, there is a list_for_each_entry with
> >resv_regions as the second argument, suggesting that
> >resv_regions is the list head. So exchange the
> arguments on the list_add call to put the list head in the
>
On Wed, May 06, 2020 at 11:25:46AM +0200, Stefano Garzarella wrote:
> On Wed, May 06, 2020 at 03:19:55AM -0400, Michael S. Tsirkin wrote:
> > On Wed, May 06, 2020 at 03:28:47AM +, Justin He wrote:
> > > Hi Michael
> > >
> > > > -Original Message-
> > > > From: Michael S. Tsirkin
> >
On Wed, May 06, 2020 at 04:19:40PM +0800, Jason Wang wrote:
>
> On 2020/5/6 下午3:53, Michael S. Tsirkin wrote:
> > On Wed, May 06, 2020 at 02:16:32PM +0800, Jason Wang wrote:
> > > We tried to reserve space for vnet header before
> > > xdp.data_hard_start. But this is useless since the packet
On Wed, May 06, 2020 at 04:34:36PM +0800, Jason Wang wrote:
>
> On 2020/5/6 下午4:21, Jesper Dangaard Brouer wrote:
> > On Wed, 6 May 2020 14:16:32 +0800
> > Jason Wang wrote:
> >
> > > We tried to reserve space for vnet header before
> > > xdp.data_hard_start. But this is useless since the
On Wed, May 06, 2020 at 10:37:57AM +0200, Jesper Dangaard Brouer wrote:
> On Wed, 6 May 2020 04:08:27 -0400
> "Michael S. Tsirkin" wrote:
>
> > So for mergeable bufs, we use ewma machinery to guess the correct buffer
> > size. If we don't guess correctly, XDP has to do aggressive copies.
> >
>
On Wed, May 06, 2020 at 04:37:41PM +0800, Jason Wang wrote:
>
> On 2020/5/6 下午4:08, Michael S. Tsirkin wrote:
> > So for mergeable bufs, we use ewma machinery to guess the correct buffer
> > size. If we don't guess correctly, XDP has to do aggressive copies.
> >
> > Problem is, xdp paths do not
On Wed, May 06, 2020 at 04:21:15PM +0800, Jason Wang wrote:
>
> On 2020/5/6 下午3:37, Michael S. Tsirkin wrote:
> > On Wed, May 06, 2020 at 02:16:33PM +0800, Jason Wang wrote:
> > > We should not exclude headroom and tailroom when XDP is set. So this
> > > patch fixes this by initializing the
25 matches
Mail list logo
