Re: [PATCH 07/17] vhost scsi: support delayed IO vq creation

2020-10-25 Thread Jason Wang
On 2020/10/22 上午8:34, Mike Christie wrote: Each vhost-scsi device will need a evt and ctl queue, but the number of IO queues depends on whatever the user has configured in userspace. This patch has vhost-scsi create the evt, ctl and one IO vq at device open time. We then create the other IO vqs

Re: [PATCH] drm/: Constify struct drm_driver

2020-10-25 Thread Sam Ravnborg
Hi Daniel. On Fri, Oct 23, 2020 at 06:04:44PM +0200, Daniel Vetter wrote: > Only the following drivers aren't converted: > - amdgpu, because of the driver_feature mangling due to virt support > - nouveau, because DRIVER_ATOMIC uapi is still not the default on the > platforms where it's

Re: [PATCH 03/17] vhost net: use goto error handling in open

2020-10-25 Thread Jason Wang
On 2020/10/22 上午8:34, Mike Christie wrote: In the next patches vhost_dev_init will be able to fail. This patch has vhost_net_open use goto error handling like is done in the other vhost code to make handling vhost_dev_init failures easier to handle and extend in the future. Signed-off-by: Mike

Re: [PATCH] drm/: Constify struct drm_driver

2020-10-25 Thread Daniel Vetter
On Sun, Oct 25, 2020 at 11:23 PM Sam Ravnborg wrote: > > Hi Daniel. > > On Fri, Oct 23, 2020 at 06:04:44PM +0200, Daniel Vetter wrote: > > Only the following drivers aren't converted: > > - amdgpu, because of the driver_feature mangling due to virt support > > - nouveau, because DRIVER_ATOMIC

Re: [PATCH] vdpa: handle irq bypass register failure case

2020-10-25 Thread Jason Wang
On 2020/10/23 下午6:40, Zhu Lingshan wrote: LKP considered variable 'ret' in vhost_vdpa_setup_vq_irq() as a unused variable, so suggest we remove it. Actually it stores return value of irq_bypass_register_producer(), but we did not check it, we should handle the failure case. This commit will

Re: [PATCH net] vhost_vdpa: Return -EFUALT if copy_from_user() fails

2020-10-25 Thread Jason Wang
On 2020/10/23 下午11:34, Michael S. Tsirkin wrote: On Fri, Oct 23, 2020 at 03:08:53PM +0300, Dan Carpenter wrote: The copy_to/from_user() functions return the number of bytes which we weren't able to copy but the ioctl should return -EFAULT if they fail. Fixes: a127c5bbb6a8 ("vhost-vdpa: fix

Re: [PATCH] virtio_ring: use DMA when memory encryption is active

2020-10-25 Thread Jason Wang
On 2020/10/23 下午6:55, Sebastian Hofmann wrote: Jason Wang hat am 23.10.2020 11:10 geschrieben: On 2020/10/23 下午5:00, Sebastian Hofmann wrote: Michael S. Tsirkin hat am 22.10.2020 13:39 geschrieben: On Wed, Oct 21, 2020 at 05:14:25PM +0200, Sebastian Hofmann wrote: virtio_ring does

Re: [PATCH 01/17] vhost scsi: add lun parser helper

2020-10-25 Thread Jason Wang
On 2020/10/22 上午8:34, Mike Christie wrote: Move code to parse lun from req's lun_buf to helper, so tmf code can use it in the next patch. Signed-off-by: Mike Christie Reviewed-by: Paolo Bonzini --- drivers/vhost/scsi.c | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-)