Re: [PATCH v3 2/4] drm/qxl: unpin release objects

2021-01-22 Thread Thomas Zimmermann
Hi Am 20.01.21 um 12:12 schrieb Gerd Hoffmann: Balances the qxl_create_bo(..., pinned=true, ...); call in qxl_release_bo_alloc(). Signed-off-by: Gerd Hoffmann --- drivers/gpu/drm/qxl/qxl_release.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/qxl/qxl_release.c

Re: [PATCH RFC] virtio-blk: support per-device queue depth

2021-01-22 Thread Michael S. Tsirkin
On Fri, Jan 22, 2021 at 09:43:27AM +0800, Joseph Qi wrote: > Hi Michael, > > Any comments on this patch? > > Thanks, > Joseph Suggest copying all reviewers, including Paolo Bonzini and Stefan Hajnoczi . ___ Virtualization mailing list

Re: [PATCH v3 3/4] drm/qxl: release shadow on shutdown

2021-01-22 Thread Thomas Zimmermann
Hi Am 20.01.21 um 12:12 schrieb Gerd Hoffmann: In case we have a shadow surface on shutdown release it so it doesn't leak. Signed-off-by: Gerd Hoffmann --- drivers/gpu/drm/qxl/qxl_display.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/gpu/drm/qxl/qxl_display.c

Re: [PATCH v3 1/4] drm/qxl: use drmm_mode_config_init

2021-01-22 Thread Thomas Zimmermann
Am 20.01.21 um 12:12 schrieb Gerd Hoffmann: Signed-off-by: Gerd Hoffmann Reviewed-by: Daniel Vetter Acked-by: Thomas Zimmermann --- drivers/gpu/drm/qxl/qxl_display.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/qxl/qxl_display.c

[PATCH V2 1/2] block: remove unnecessary argument from blk_execute_rq_nowait

2021-01-22 Thread Guoqing Jiang
The 'q' is not used since commit a1ce35fa4985 ("block: remove dead elevator code"), also update the comment of the function. And more importantly it never really was needed to start with given that we can trivial derive it from struct request. Cc: target-de...@vger.kernel.org Cc:

[PATCH V2 0/2] remove unused argument from blk_execute_rq_nowait and blk_execute_rq

2021-01-22 Thread Guoqing Jiang
V2 changes: 1. update commit header per Christoph's comment. Hi Jens, This series remove unused 'q' from blk_execute_rq_nowait and blk_execute_rq. Also update the comment for blk_execute_rq_nowait. Thanks, Guoqing Guoqing Jiang (2): block: remove unnecessary argument from

[PATCH V2 2/2] block: remove unnecessary argument from blk_execute_rq

2021-01-22 Thread Guoqing Jiang
We can remove 'q' from blk_execute_rq as well after the previous change in blk_execute_rq_nowait. And more importantly it never really was needed to start with given that we can trivial derive it from struct request. Cc: linux-s...@vger.kernel.org Cc: virtualization@lists.linux-foundation.org

Re: [PATCH V2 2/2] block: remove unnecessary argument from blk_execute_rq

2021-01-22 Thread Ulf Hansson
On Fri, 22 Jan 2021 at 10:28, Guoqing Jiang wrote: > > We can remove 'q' from blk_execute_rq as well after the previous change > in blk_execute_rq_nowait. > > And more importantly it never really was needed to start with given > that we can trivial derive it from struct request. > > Cc:

[PATCH iproute2-next 0/2] Add vdpa device management tool

2021-01-22 Thread Parav Pandit
Linux vdpa interface allows vdpa device management functionality. This includes adding, removing, querying vdpa devices. vdpa interface also includes showing supported management devices which support such operations. This patchset includes kernel uapi headers and a vdpa tool. examples: $ vdpa

[PATCH iproute2-next 1/2] Add kernel headers

2021-01-22 Thread Parav Pandit
Add kernel headers to commit from kernel tree [1]. 79991caf5202c7 ("vdpa_sim_net: Add support for user supported devices") [1] https://git.kernel.org/pub/scm/linux/kernel/git/mst/vhost.git branch: linux-next Signed-off-by: Parav Pandit --- include/uapi/linux/vdpa.h | 40

[PATCH iproute2-next 2/2] vdpa: Add vdpa tool

2021-01-22 Thread Parav Pandit
vdpa tool is created to create, delete and query vdpa devices. examples: Show vdpa management device that supports creating, deleting vdpa devices. $ vdpa mgmtdev show vdpasim: supported_classes net $ vdpa mgmtdev show -jp { "show": { "vdpasim": { "supported_classes": [

Re: [PATCH v4] drm/virtio: Track total GPU memory for virtio driver

2021-01-22 Thread Daniel Vetter
On Thu, Jan 21, 2021 at 11:58:22PM -0800, Yiwei Zhang wrote: > On Thu, Jan 21, 2021 at 9:40 PM Yiwei Zhang wrote: > > > > On the success of virtio_gpu_object_create, add size of newly allocated > > bo to the tracked total_mem. In drm_gem_object_funcs.free, after the gem > > bo loses its last

[PATCH][next] vpda: Fix memory leaks of msg on error return paths

2021-01-22 Thread Colin King
From: Colin Ian King There are two error return paths that neglect to free the allocated object msg that lead to memory leaks. Fix this by adding an error exit path that frees msg. Addresses-Coverity: ("Resource leak") Fixes: 39502d042a70 ("vdpa: Enable user to query vdpa device info")

Re: [PATCH v3 2/4] drm/qxl: unpin release objects

2021-01-22 Thread Gerd Hoffmann
On Fri, Jan 22, 2021 at 09:13:42AM +0100, Thomas Zimmermann wrote: > Hi > > Am 20.01.21 um 12:12 schrieb Gerd Hoffmann: > > Balances the qxl_create_bo(..., pinned=true, ...); > > call in qxl_release_bo_alloc(). > > > > Signed-off-by: Gerd Hoffmann > > --- > > drivers/gpu/drm/qxl/qxl_release.c

Re: [PATCH v3 2/4] drm/qxl: unpin release objects

2021-01-22 Thread Daniel Vetter
On Fri, Jan 22, 2021 at 2:35 PM Gerd Hoffmann wrote: > > On Fri, Jan 22, 2021 at 09:13:42AM +0100, Thomas Zimmermann wrote: > > Hi > > > > Am 20.01.21 um 12:12 schrieb Gerd Hoffmann: > > > Balances the qxl_create_bo(..., pinned=true, ...); > > > call in qxl_release_bo_alloc(). > > > > > >