Re: [PATCH net-next v4 2/6] virtio/vsock: add 'VIRTIO_VSOCK_SEQ_EOR' bit.

2021-09-05 Thread Michael S. Tsirkin
On Fri, Sep 03, 2021 at 09:15:20AM +0300, Arseny Krasnov wrote: > This bit is used to handle POSIX MSG_EOR flag passed from > userspace in 'send*()' system calls. It marks end of each > record and is visible to receiver using 'recvmsg()' system > call. > > Signed-off-by: Arseny Krasnov >

Re: [PATCH net-next v5 0/6] virtio/vsock: introduce MSG_EOR flag for SEQPACKET

2021-09-05 Thread Michael S. Tsirkin
On Sun, Sep 05, 2021 at 07:21:10PM +0300, Arseny Krasnov wrote: > > On 05.09.2021 19:19, Michael S. Tsirkin wrote: > > On Sun, Sep 05, 2021 at 07:02:44PM +0300, Arseny Krasnov wrote: > >> On 05.09.2021 18:55, Michael S. Tsirkin wrote: > >>> On Fri, Sep 03, 2021 at 03:30:13PM +0300, Arseny Krasnov

Re: [PATCH] vhost_net: Convert from atomic_t to refcount_t on vhost_net_ubuf_ref->refcount

2021-09-05 Thread Michael S. Tsirkin
On Sat, Jul 17, 2021 at 06:20:30PM +0800, Xiyu Yang wrote: > refcount_t type and corresponding API can protect refcounters from > accidental underflow and overflow and further use-after-free situations. > > Signed-off-by: Xiyu Yang > Signed-off-by: Xin Tan Pls resubmit after addressing the

Re: [PATCH net-next v5 0/6] virtio/vsock: introduce MSG_EOR flag for SEQPACKET

2021-09-05 Thread Michael S. Tsirkin
On Fri, Sep 03, 2021 at 03:30:13PM +0300, Arseny Krasnov wrote: > This patchset implements support of MSG_EOR bit for SEQPACKET > AF_VSOCK sockets over virtio transport. > First we need to define 'messages' and 'records' like this: > Message is result of sending calls: 'write()',

Re: [PATCH v3 1/1] virtio-blk: add num_request_queues module parameter

2021-09-05 Thread Michael S. Tsirkin
On Sun, Sep 05, 2021 at 01:20:24PM +0300, Leon Romanovsky wrote: > On Sun, Sep 05, 2021 at 01:49:46AM -0700, Chaitanya Kulkarni wrote: > > > > On 9/5/2021 12:46 AM, Leon Romanovsky wrote: > > > > +static unsigned int num_request_queues; > > > > +module_param_cb(num_request_queues, _count_ops, >

Re: [PATCH net-next v5 0/6] virtio/vsock: introduce MSG_EOR flag for SEQPACKET

2021-09-05 Thread Michael S. Tsirkin
On Sun, Sep 05, 2021 at 07:02:44PM +0300, Arseny Krasnov wrote: > > On 05.09.2021 18:55, Michael S. Tsirkin wrote: > > On Fri, Sep 03, 2021 at 03:30:13PM +0300, Arseny Krasnov wrote: > >>This patchset implements support of MSG_EOR bit for SEQPACKET > >> AF_VSOCK sockets over virtio transport.

Re: [PATCH v14] i2c: virtio: add a virtio i2c frontend driver

2021-09-05 Thread Viresh Kumar
On 04-09-21, 16:01, Michael S. Tsirkin wrote: > Same as with qemu bits, I am confused as to what is the status > of proposed spec changes and whether the driver will work > with them. This is already merged as well. The current version simply fails to transmit the messages in case the length of

Re: [PATCH v13 03/13] file: Export receive_fd() to modules

2021-09-05 Thread Michael S. Tsirkin
On Tue, Aug 31, 2021 at 06:36:24PM +0800, Xie Yongji wrote: > Export receive_fd() so that some modules can use > it to pass file descriptor between processes without > missing any security stuffs. > > Signed-off-by: Xie Yongji > Acked-by: Jason Wang This needs some acks from fs devels. Viro?

Re: [PATCH v2 1/1] virtio-blk: add num_io_queues module parameter

2021-09-05 Thread Michael S. Tsirkin
On Thu, Sep 02, 2021 at 02:45:52PM +0100, Stefan Hajnoczi wrote: > On Tue, Aug 31, 2021 at 04:50:35PM +0300, Max Gurtovoy wrote: > > Sometimes a user would like to control the amount of IO queues to be > > created for a block device. For example, for limiting the memory > > footprint of virtio-blk

Re: [PATCH v13 03/13] file: Export receive_fd() to modules

2021-09-05 Thread Al Viro
On Sun, Sep 05, 2021 at 11:57:22AM -0400, Michael S. Tsirkin wrote: > On Tue, Aug 31, 2021 at 06:36:24PM +0800, Xie Yongji wrote: > > Export receive_fd() so that some modules can use > > it to pass file descriptor between processes without > > missing any security stuffs. > > > > Signed-off-by:

[vhost:vhost 37/40] drivers/block/virtio_blk.c:30:16: error: implicit declaration of function 'param_set_uint_minmax'; did you mean 'param_set_uint'?

2021-09-05 Thread kernel test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/mst/vhost.git vhost head: ebf3b42574b049bd40f6ea04f4e6845664d5b6d5 commit: dc1aba74cc840c5b97e7f50a7dbc135b764207a1 [37/40] virtio-blk: add num_io_queues module parameter config: arc-randconfig-r043-20210906 (attached as .config) compiler:

[vhost:vhost 37/40] drivers/block/virtio_blk.c:30:9: error: implicit declaration of function 'param_set_uint_minmax'; did you mean 'param_set_uint'?

2021-09-05 Thread kernel test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/mst/vhost.git vhost head: ebf3b42574b049bd40f6ea04f4e6845664d5b6d5 commit: dc1aba74cc840c5b97e7f50a7dbc135b764207a1 [37/40] virtio-blk: add num_io_queues module parameter config: x86_64-allyesconfig (attached as .config) compiler: gcc-9

Re: [PATCH 1/1] virtio: add VIRTIO_F_IN_ORDER to header file

2021-09-05 Thread Michael S. Tsirkin
On Sun, Sep 05, 2021 at 03:09:11PM +0300, Max Gurtovoy wrote: > For now only add this definition from the spec. In the future, The > drivers should negotiate this feature to optimize the performance. > > Signed-off-by: Max Gurtovoy So I think IN_ORDER was a mistake since it breaks ability to do

[vhost:vhost 37/40] drivers/block/virtio_blk.c:30:9: error: implicit declaration of function 'param_set_uint_minmax'

2021-09-05 Thread kernel test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/mst/vhost.git vhost head: ebf3b42574b049bd40f6ea04f4e6845664d5b6d5 commit: dc1aba74cc840c5b97e7f50a7dbc135b764207a1 [37/40] virtio-blk: add num_io_queues module parameter config: hexagon-randconfig-r041-20210905 (attached as .config

Re: [PATCH v6 42/76] x86/sev-es: Setup early #VC handler

2021-09-05 Thread Juergen Gross via Virtualization
On 04.09.21 11:39, Lai Jiangshan wrote: @@ -363,6 +370,33 @@ SYM_CODE_START_LOCAL(early_idt_handler_common) jmp restore_regs_and_return_to_kernel SYM_CODE_END(early_idt_handler_common) +#ifdef CONFIG_AMD_MEM_ENCRYPT +/* + * VC Exception handler used during very early boot. The + *

Re: [PATCH v13 05/13] vdpa: Add reset callback in vdpa_config_ops

2021-09-05 Thread Michael S. Tsirkin
On Tue, Aug 31, 2021 at 06:36:26PM +0800, Xie Yongji wrote: > This adds a new callback to support device specific reset > behavior. The vdpa bus driver will call the reset function > instead of setting status to zero during resetting. > > Signed-off-by: Xie Yongji This does gloss over a

Re: [PATCH v12 05/13] vdpa: Add reset callback in vdpa_config_ops

2021-09-05 Thread Michael S. Tsirkin
On Mon, Aug 30, 2021 at 10:17:29PM +0800, Xie Yongji wrote: > This adds a new callback to support device specific reset > behavior. The vdpa bus driver will call the reset function > instead of setting status to zero during resetting. > > Signed-off-by: Xie Yongji This does gloss over a

Re: [PATCH v3 1/1] virtio-blk: add num_request_queues module parameter

2021-09-05 Thread Leon Romanovsky
On Sun, Sep 05, 2021 at 02:16:58PM +0300, Max Gurtovoy wrote: > > On 9/5/2021 1:19 PM, Leon Romanovsky wrote: > > On Sun, Sep 05, 2021 at 12:19:09PM +0300, Max Gurtovoy wrote: > > > On 9/5/2021 11:49 AM, Chaitanya Kulkarni wrote: > > > > On 9/5/2021 12:46 AM, Leon Romanovsky wrote: > > > > > >

Re: [PATCH v3 1/1] virtio-blk: add num_request_queues module parameter

2021-09-05 Thread Leon Romanovsky
On Thu, Sep 02, 2021 at 11:46:22PM +0300, Max Gurtovoy wrote: > Sometimes a user would like to control the amount of request queues to > be created for a block device. For example, for limiting the memory > footprint of virtio-blk devices. > > Reviewed-by: Christoph Hellwig > Reviewed-by: Stefan

Re: [PATCH v3 1/1] virtio-blk: add num_request_queues module parameter

2021-09-05 Thread Leon Romanovsky
On Sun, Sep 05, 2021 at 12:19:09PM +0300, Max Gurtovoy wrote: > > On 9/5/2021 11:49 AM, Chaitanya Kulkarni wrote: > > > > On 9/5/2021 12:46 AM, Leon Romanovsky wrote: > > > > +static unsigned int num_request_queues; > > > > +module_param_cb(num_request_queues, _count_ops, > > > >

Re: [PATCH v3 1/1] virtio-blk: add num_request_queues module parameter

2021-09-05 Thread Leon Romanovsky
On Sun, Sep 05, 2021 at 01:49:46AM -0700, Chaitanya Kulkarni wrote: > > On 9/5/2021 12:46 AM, Leon Romanovsky wrote: > > > +static unsigned int num_request_queues; > > > +module_param_cb(num_request_queues, _count_ops, > > > _request_queues, > > > + 0644); > > >