Re: [PATCH 1/4] hwrng: virtio - add an internal buffer

2021-09-23 Thread Michael S. Tsirkin
On Thu, Sep 23, 2021 at 08:26:06AM +0200, Laurent Vivier wrote: > On 22/09/2021 21:02, Michael S. Tsirkin wrote: > > On Wed, Sep 22, 2021 at 07:09:00PM +0200, Laurent Vivier wrote: > > > hwrng core uses two buffers that can be mixed in the > > > virtio-rng queue. > > > > > > If the buffer is

Re: [PATCH 1/4] hwrng: virtio - add an internal buffer

2021-09-23 Thread Laurent Vivier
On 23/09/2021 09:04, Michael S. Tsirkin wrote: On Thu, Sep 23, 2021 at 08:26:06AM +0200, Laurent Vivier wrote: On 22/09/2021 21:02, Michael S. Tsirkin wrote: On Wed, Sep 22, 2021 at 07:09:00PM +0200, Laurent Vivier wrote: hwrng core uses two buffers that can be mixed in the virtio-rng queue.

Re: [PATCH 1/4] hwrng: virtio - add an internal buffer

2021-09-23 Thread Laurent Vivier
On 22/09/2021 21:02, Michael S. Tsirkin wrote: On Wed, Sep 22, 2021 at 07:09:00PM +0200, Laurent Vivier wrote: hwrng core uses two buffers that can be mixed in the virtio-rng queue. If the buffer is provided with wait=0 it is enqueued in the virtio-rng queue but unused by the caller. On the

Re: [PATCH v3 1/1] virtio-blk: avoid preallocating big SGL for data

2021-09-23 Thread Michael S. Tsirkin
OK by me. Acked-by: Michael S. Tsirkin I will queue it for the next kernel. Thanks! On Thu, Sep 23, 2021 at 04:40:56PM +0300, Max Gurtovoy wrote: > Hi MST/Jens, > > Do we need more review here or are we ok with the code and the test matrix ? > > If we're ok, we need to decide if this goes