On Mon, Aug 08, 2022 at 08:45:48AM -0400, Michael S. Tsirkin wrote:
> > > Also yes, I think it's a good idea to change crosvm anyway. While the
> > > work around I describe might make sense upstream I don't think it's a
> > > reasonable thing to do in stable kernels.
> > > I think I'll prepare a
On Mon, Aug 15, 2022 at 10:56:03AM -0700, Bobby Eshleman wrote:
> Hey everybody,
>
> This series introduces datagrams, packet scheduling, and sk_buff usage
> to virtio vsock.
>
> The usage of struct sk_buff benefits users by a) preparing vsock to use
> other related systems that require sk_buff,
Legacy virtio pci has no way to communicate a change in vq size to
the hypervisor. If ring sizes don't match hypervisor will happily
corrupt memory.
We add a check to vring size before calling
vp_legacy_set_queue_address(). Checking the memory range directly is a
bit cumbersome.
Signed-off-by:
* Google Scholar H-Index = 25
* Indexed in WoS, Scopus, DBLP, etc.
CALL for WORKSHOPS
WorldCIST'23 - 11st World Conference on Information Systems and Technologies
Pisa, Italy, 4 - 6 April 2023
http://worldcist.org/
On Wed, Aug 17, 2022 at 02:36:31PM +0800, Xuan Zhuo wrote:
> On Wed, 17 Aug 2022 08:13:59 +0200, Dmitry Vyukov wrote:
> > On Mon, 15 Aug 2022 17:32:06 -0400, Michael wrote:
> > > So if you pass the size parameter for a legacy device it will
> > > try to make the ring smaller and that is not legal
On Tue, Aug 16, 2022 at 09:42:51AM +, Bobby Eshleman wrote:
> > The basic question to answer then is this: with a net device qdisc
> > etc in the picture, how is this different from virtio net then?
> > Why do you still want to use vsock?
> >
>
> When using virtio-net, users looking for
The pull request you sent on Wed, 17 Aug 2022 06:38:42 -0400:
> https://git.kernel.org/pub/scm/linux/kernel/git/mst/vhost.git tags/for_linus
has been merged into torvalds/linux.git:
https://git.kernel.org/torvalds/c/274a2eebf80c60246f9edd6ef8e9a095ad121264
Thank you!
--
Deet-doot-dot, I am a
On Tue, Aug 16, 2022 at 11:47 PM Xuan Zhuo wrote:
>
> + BUG_ON(num != virtqueue_get_vring_size(vq));
> +
Please, no more BUG_ON.
Add a WARN_ON_ONCE() and return an error.
Linus
___
Virtualization mailing list
On Wed, Aug 17, 2022 at 02:48:22PM +0100, Will Deacon wrote:
> On Mon, Aug 08, 2022 at 08:45:48AM -0400, Michael S. Tsirkin wrote:
> > > > Also yes, I think it's a good idea to change crosvm anyway. While the
> > > > work around I describe might make sense upstream I don't think it's a
> > > >
On Tue, Aug 16, 2022 at 10:50:55AM +, Bobby Eshleman wrote:
> > > > Eh, I was hoping it was a side channel of an existing virtio_net
> > > > which is not the case. Given the zero-config requirement IDK if
> > > > we'll be able to fit this into netdev semantics :(
> > >
> > > It's
On Wed, Aug 17, 2022 at 10:14:26AM +0800, Zhu, Lingshan wrote:
> Yes it is a little messy, and we can not check _F_VERSION_1 because of
> transitional devices, so maybe this is the best we can do for now
I think vhost generally needs an API to declare config space endian-ness
to kernel. vdpa can
On Wed, Aug 17, 2022 at 05:13:59PM +0800, Zhu, Lingshan wrote:
>
>
> On 8/17/2022 4:55 PM, Michael S. Tsirkin wrote:
> > On Wed, Aug 17, 2022 at 10:14:26AM +0800, Zhu, Lingshan wrote:
> > > Yes it is a little messy, and we can not check _F_VERSION_1 because of
> > > transitional devices, so
On Wed, Aug 17, 2022 at 05:43:22PM +0800, Zhu, Lingshan wrote:
>
>
> On 8/17/2022 5:39 PM, Michael S. Tsirkin wrote:
> > On Wed, Aug 17, 2022 at 05:13:59PM +0800, Zhu, Lingshan wrote:
> > >
> > > On 8/17/2022 4:55 PM, Michael S. Tsirkin wrote:
> > > > On Wed, Aug 17, 2022 at 10:14:26AM +0800,
The following changes since commit 568035b01cfb107af8d2e4bd2fb9aea22cf5b868:
Linux 6.0-rc1 (2022-08-14 15:50:18 -0700)
are available in the Git repository at:
https://git.kernel.org/pub/scm/linux/kernel/git/mst/vhost.git tags/for_linus
for you to fetch changes up to
On Mon, 15 Aug 2022 17:32:06 -0400, Michael wrote:
> So if you pass the size parameter for a legacy device it will
> try to make the ring smaller and that is not legal with
> legacy at all. But the driver treats legacy and modern
> the same, it allocates a smaller queue anyway.
>
> Lo and behold,
On Wed, Aug 17, 2022 at 10:11:36AM +0800, Zhu, Lingshan wrote:
>
>
> On 8/17/2022 6:48 AM, Si-Wei Liu wrote:
>
>
>
> On 8/16/2022 1:29 AM, Zhu, Lingshan wrote:
>
>
>
> On 8/16/2022 3:41 PM, Si-Wei Liu wrote:
>
> Hi Michael,
>
> I just noticed this
On Wed, 17 Aug 2022 08:13:59 +0200, Dmitry Vyukov wrote:
> On Mon, 15 Aug 2022 17:32:06 -0400, Michael wrote:
> > So if you pass the size parameter for a legacy device it will
> > try to make the ring smaller and that is not legal with
> > legacy at all. But the driver treats legacy and modern
>
On Tue, Aug 16, 2022 at 11:08:26AM +, Bobby Eshleman wrote:
> On Wed, Aug 17, 2022 at 01:02:52PM -0400, Michael S. Tsirkin wrote:
> > On Tue, Aug 16, 2022 at 09:42:51AM +, Bobby Eshleman wrote:
> > > > The basic question to answer then is this: with a net device qdisc
> > > > etc in the
On 8/16/2022 11:23 PM, Zhu, Lingshan wrote:
On 8/17/2022 2:14 PM, Michael S. Tsirkin wrote:
On Wed, Aug 17, 2022 at 10:11:36AM +0800, Zhu, Lingshan wrote:
On 8/17/2022 6:48 AM, Si-Wei Liu wrote:
On 8/16/2022 1:29 AM, Zhu, Lingshan wrote:
On 8/16/2022 3:41 PM, Si-Wei
On 8/16/2022 7:14 PM, Zhu, Lingshan wrote:
While the fix is fine, the comment is misleading in giving readers
false hope. This is in vdpa_dev_net_config_fill() the vdpa tool query
path, instead of calls from the VMM dealing with vhost/virtio
plumbing specifics. I think what's missing today
The vDPA driver framework is largely undocumented. Add a basic page that
describes what vDPA is, where to get more information, and how to use
the simulator for testing.
In the future it would be nice to add an overview of the driver API as
well as comprehensive doc comments.
Cc: "Michael S.
在 2022/8/17 18:37, Michael S. Tsirkin 写道:
On Wed, Aug 17, 2022 at 05:43:22PM +0800, Zhu, Lingshan wrote:
On 8/17/2022 5:39 PM, Michael S. Tsirkin wrote:
On Wed, Aug 17, 2022 at 05:13:59PM +0800, Zhu, Lingshan wrote:
On 8/17/2022 4:55 PM, Michael S. Tsirkin wrote:
On Wed, Aug 17, 2022 at
在 2022/8/17 10:03, Zhu, Lingshan 写道:
On 8/17/2022 5:09 AM, Michael S. Tsirkin wrote:
On Tue, Aug 16, 2022 at 09:02:17PM +, Parav Pandit wrote:
From: Zhu, Lingshan
Sent: Tuesday, August 16, 2022 12:19 AM
On 8/16/2022 10:32 AM, Parav Pandit wrote:
From: Zhu Lingshan
Sent: Monday,
在 2022/8/17 14:54, Michael S. Tsirkin 写道:
On Mon, Aug 15, 2022 at 10:56:03AM -0700, Bobby Eshleman wrote:
Hey everybody,
This series introduces datagrams, packet scheduling, and sk_buff usage
to virtio vsock.
The usage of struct sk_buff benefits users by a) preparing vsock to use
other
在 2022/8/18 01:20, Michael S. Tsirkin 写道:
On Tue, Aug 16, 2022 at 10:50:55AM +, Bobby Eshleman wrote:
Eh, I was hoping it was a side channel of an existing virtio_net
which is not the case. Given the zero-config requirement IDK if
we'll be able to fit this into netdev semantics :(
It's
Legacy virtio pci has no way to communicate a change in vq size to
the hypervisor. If ring sizes don't match hypervisor will happily
corrupt memory.
We add a check to vring size before calling
vp_legacy_set_queue_address(). Checking the memory range directly is a
bit cumbersome.
Signed-off-by:
On Wed, 17 Aug 2022 21:57:16 +0800, Guo Zhi wrote:
> We didn't unmask F_NEXT flag in desc_extra in the end of a chain,
> unmask it so that we can access desc_extra to get next information.
I think we should state the purpose of this.
>
> Signed-off-by: Guo Zhi
> ---
>
On Wed, 17 Aug 2022 21:57:17 +0800, Guo Zhi wrote:
> If in order feature negotiated, we can skip the used ring to get
> buffer's desc id sequentially.
>
> Signed-off-by: Guo Zhi
> ---
> drivers/virtio/virtio_ring.c | 53 ++--
> 1 file changed, 45 insertions(+), 8
On Wed, 17 Aug 2022 08:58:20 -0700, Linus Torvalds
wrote:
> On Tue, Aug 16, 2022 at 11:47 PM Xuan Zhuo wrote:
> >
> > + BUG_ON(num != virtqueue_get_vring_size(vq));
> > +
>
> Please, no more BUG_ON.
>
> Add a WARN_ON_ONCE() and return an error.
OK, I will post v2 with WARN_ON_ONCE().
29 matches
Mail list logo
