Re: [PATCH RFC net-next v2 0/3] vsock: add support for sockmap

2023-02-16 Thread Stefano Garzarella
Hi Bobby, sorry for my late reply, but I have been offline these days. I came back a few days ago and had to work off some accumulated work :-) On Mon, Jan 30, 2023 at 08:35:11PM -0800, Bobby Eshleman wrote: Add support for sockmap to vsock. We're testing usage of vsock as a way to redirect

Re: [PATCH vhost 00/10] virtio core prepares for AF_XDP

2023-02-16 Thread Xuan Zhuo
On Thu, 16 Feb 2023 13:27:00 +0800, Jason Wang wrote: > On Tue, Feb 14, 2023 at 3:27 PM Xuan Zhuo wrote: > > > > XDP socket(AF_XDP) is an excellent bypass kernel network framework. The zero > > copy feature of xsk (XDP socket) needs to be supported by the driver. The > > performance of zero copy

Re: [PATCH 17/17] drm/cirrus: Use VGA macro constants to unblank

2023-02-16 Thread Thomas Zimmermann
Hi, thanks for taking a look at the patches. Am 16.02.23 um 12:33 schrieb Gerd Hoffmann: On Wed, Feb 15, 2023 at 05:15:17PM +0100, Thomas Zimmermann wrote: Set the VGA bit for unblanking with macro constants instead of magic values. No functional changes. blank/unblank should work simliar

Re: [PATCH 17/17] drm/cirrus: Use VGA macro constants to unblank

2023-02-16 Thread Gerd Hoffmann
On Thu, Feb 16, 2023 at 02:52:51PM +0200, Ville Syrjälä wrote: > On Thu, Feb 16, 2023 at 01:03:02PM +0100, Thomas Zimmermann wrote: > > Hi, > > > > thanks for taking a look at the patches. > > > > Am 16.02.23 um 12:33 schrieb Gerd Hoffmann: > > > On Wed, Feb 15, 2023 at 05:15:17PM +0100, Thomas

Re: [RFC PATCH v1 05/12] vsock/virtio: non-linear skb support

2023-02-16 Thread Stefano Garzarella
On Mon, Feb 06, 2023 at 06:58:24AM +, Arseniy Krasnov wrote: Use pages of non-linear skb as buffers in virtio tx queue. Signed-off-by: Arseniy Krasnov --- net/vmw_vsock/virtio_transport.c | 31 +-- 1 file changed, 25 insertions(+), 6 deletions(-) diff --git

Re: [PATCH 17/17] drm/cirrus: Use VGA macro constants to unblank

2023-02-16 Thread Gerd Hoffmann
On Wed, Feb 15, 2023 at 05:15:17PM +0100, Thomas Zimmermann wrote: > Set the VGA bit for unblanking with macro constants instead of magic > values. No functional changes. blank/unblank should work simliar to bochs (see commit 250e743915d4), that is maybe a nice thing to add of you modernize the

Re: [PATCH v10 00/11] Add generic memory shrinker to VirtIO-GPU and Panfrost DRM drivers

2023-02-16 Thread Daniel Vetter
On Mon, Jan 30, 2023 at 03:02:10PM +0300, Dmitry Osipenko wrote: > On 1/27/23 11:13, Gerd Hoffmann wrote: > > On Thu, Jan 26, 2023 at 01:55:09AM +0300, Dmitry Osipenko wrote: > >> Hello Thomas and Gerd, > >> > >> On 1/9/23 00:04, Dmitry Osipenko wrote: > >>> This series: > >>> > >>> 1. Makes

Re: [PATCH 17/17] drm/cirrus: Use VGA macro constants to unblank

2023-02-16 Thread Thomas Zimmermann
Hi Am 16.02.23 um 13:52 schrieb Ville Syrjälä: On Thu, Feb 16, 2023 at 01:03:02PM +0100, Thomas Zimmermann wrote: Hi, thanks for taking a look at the patches. Am 16.02.23 um 12:33 schrieb Gerd Hoffmann: On Wed, Feb 15, 2023 at 05:15:17PM +0100, Thomas Zimmermann wrote: Set the VGA bit for

Re: [RFC PATCH v1 02/12] vsock: read from socket's error queue

2023-02-16 Thread Stefano Garzarella
On Mon, Feb 06, 2023 at 06:54:51AM +, Arseniy Krasnov wrote: This adds handling of MSG_ERRQUEUE input flag for receive call, thus skb from socket's error queue is read. A general tip, add a little more description in the commit messages, especially to explain why these changes are

Re: [RFC PATCH v1 03/12] vsock: check for MSG_ZEROCOPY support

2023-02-16 Thread Stefano Garzarella
On Mon, Feb 06, 2023 at 06:55:46AM +, Arseniy Krasnov wrote: This feature totally depends on transport, so if transport doesn't support it, return error. Signed-off-by: Arseniy Krasnov --- include/net/af_vsock.h | 2 ++ net/vmw_vsock/af_vsock.c | 7 +++ 2 files changed, 9 insertions(+)

Re: [RFC PATCH v1 00/12] vsock: MSG_ZEROCOPY flag support

2023-02-16 Thread Stefano Garzarella
Hi Arseniy, sorry for the delay, but I was offline. On Mon, Feb 06, 2023 at 06:51:55AM +, Arseniy Krasnov wrote: Hello, DESCRIPTION this is MSG_ZEROCOPY feature support for virtio/vsock. I tried to follow current implementation for TCP as much as possible: 1)

Re: [RFC PATCH v1 04/12] vhost/vsock: non-linear skb handling support

2023-02-16 Thread Stefano Garzarella
On Mon, Feb 06, 2023 at 06:57:16AM +, Arseniy Krasnov wrote: This adds copying to guest's virtio buffers from non-linear skbs. Such skbs are created by protocol layer when MSG_ZEROCOPY flags is used. Signed-off-by: Arseniy Krasnov --- drivers/vhost/vsock.c| 56

Re: [PATCH 17/17] drm/cirrus: Use VGA macro constants to unblank

2023-02-16 Thread Gerd Hoffmann
On Thu, Feb 16, 2023 at 01:03:02PM +0100, Thomas Zimmermann wrote: > Hi, > > thanks for taking a look at the patches. > > Am 16.02.23 um 12:33 schrieb Gerd Hoffmann: > > On Wed, Feb 15, 2023 at 05:15:17PM +0100, Thomas Zimmermann wrote: > > > Set the VGA bit for unblanking with macro constants

Re: [RFC PATCH v1 01/12] vsock: check error queue to set EPOLLERR

2023-02-16 Thread Stefano Garzarella
On Mon, Feb 06, 2023 at 06:53:22AM +, Arseniy Krasnov wrote: If socket's error queue is not empty, EPOLLERR must be set. Could this patch go regardless of this series? Can you explain (even in the commit message) what happens without this patch? Thanks, Stefano Signed-off-by: Arseniy

Re: [PATCH v3 04/14] vdpa: add vhost_vdpa_suspend

2023-02-16 Thread Alvaro Karsz
Hi, > The function vhost.c:vhost_dev_stop fetches the vring base so the vq > state can be migrated to other devices. However, this is unreliable in > vdpa, since we didn't signal the device to suspend the queues, making > the value fetched useless. > > Suspend the device if possible before

Re: [RFC PATCH v1 06/12] vsock/virtio: non-linear skb handling for TAP dev

2023-02-16 Thread Stefano Garzarella
On Mon, Feb 06, 2023 at 06:59:21AM +, Arseniy Krasnov wrote: For TAP device new skb is created and data from the current skb is copied to it. This adds copying data from non-linear skb to new the skb. Signed-off-by: Arseniy Krasnov --- net/vmw_vsock/virtio_transport_common.c | 43

Re: [PATCH 17/17] drm/cirrus: Use VGA macro constants to unblank

2023-02-16 Thread Ville Syrjälä
On Thu, Feb 16, 2023 at 01:03:02PM +0100, Thomas Zimmermann wrote: > Hi, > > thanks for taking a look at the patches. > > Am 16.02.23 um 12:33 schrieb Gerd Hoffmann: > > On Wed, Feb 15, 2023 at 05:15:17PM +0100, Thomas Zimmermann wrote: > >> Set the VGA bit for unblanking with macro constants

Re: [PATCH RFC net-next v2 2/3] selftests/bpf: add vsock to vmtest.sh

2023-02-16 Thread Stefano Garzarella
On Mon, Jan 30, 2023 at 08:35:13PM -0800, Bobby Eshleman wrote: Add vsock loopback to the test kernel. This allows sockmap for vsock to be tested. Signed-off-by: Bobby Eshleman --- tools/testing/selftests/bpf/config.aarch64 | 2 ++ tools/testing/selftests/bpf/config.s390x | 3 +++

Re: [PATCH RFC net-next v2 3/3] selftests/bpf: Add a test case for vsock sockmap

2023-02-16 Thread Stefano Garzarella
On Mon, Jan 30, 2023 at 08:35:14PM -0800, Bobby Eshleman wrote: Add a test case testing the redirection from connectible AF_VSOCK sockets to connectible AF_UNIX sockets. Signed-off-by: Bobby Eshleman --- .../selftests/bpf/prog_tests/sockmap_listen.c | 163 + 1 file

Re: [PATCH RFC net-next v2 1/3] vsock: support sockmap

2023-02-16 Thread Stefano Garzarella
On Mon, Jan 30, 2023 at 08:35:12PM -0800, Bobby Eshleman wrote: This patch adds sockmap support for vsock sockets. It is intended to be usable by all transports, but only the virtio transport is implemented. Signed-off-by: Bobby Eshleman --- drivers/vhost/vsock.c | 1 +

Re: [PATCH 17/17] drm/cirrus: Use VGA macro constants to unblank

2023-02-16 Thread Ville Syrjälä
On Thu, Feb 16, 2023 at 02:21:43PM +0100, Thomas Zimmermann wrote: > Hi > > Am 16.02.23 um 13:52 schrieb Ville Syrjälä: > > On Thu, Feb 16, 2023 at 01:03:02PM +0100, Thomas Zimmermann wrote: > >> Hi, > >> > >> thanks for taking a look at the patches. > >> > >> Am 16.02.23 um 12:33 schrieb Gerd

Re: [RFC PATCH v1 07/12] vsock/virtio: MGS_ZEROCOPY flag support

2023-02-16 Thread Stefano Garzarella
On Mon, Feb 06, 2023 at 07:00:35AM +, Arseniy Krasnov wrote: This adds main logic of MSG_ZEROCOPY flag processing for packet creation. When this flag is set and user's iov iterator fits for zerocopy transmission, call 'get_user_pages()' and add returned pages to the newly created skb.

[linux-next:master] BUILD REGRESSION 509583475828c4fd86897113f78315c1431edcc3

2023-02-16 Thread kernel test robot
tree/branch: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master branch HEAD: 509583475828c4fd86897113f78315c1431edcc3 Add linux-next specific files for 20230216 Error/Warning reports: https://lore.kernel.org/oe-kbuild-all/202302061911.c7xvhx9v-...@intel.com https

Re: [PATCH] scsi: virtio_scsi: Modify the kmalloc allocation flag

2023-02-16 Thread Christoph Hellwig
On Sat, Feb 18, 2023 at 08:53:56AM +0800, Li zeming wrote: > The inq_result pointer must be allocated successfully; otherwise, > subsequent function execution may crash. The error needs to be handled. Or in fact this LLDD needs to stop breaking layering and issuing it's own INQUIRY commands.

Re: [RFC PATCH v1 12/12] test/vsock: MSG_ZEROCOPY support for vsock_perf

2023-02-16 Thread Stefano Garzarella
On Mon, Feb 06, 2023 at 07:06:32AM +, Arseniy Krasnov wrote: To use this option pass '--zc' parameter: --zerocopy or --zero-copy maybe better follow what we did with the other parameters :-) ./vsock_perf --zc --sender --port --bytes With this option MSG_ZEROCOPY flag will be

Re: [PATCH v10 00/11] Add generic memory shrinker to VirtIO-GPU and Panfrost DRM drivers

2023-02-16 Thread Daniel Vetter
On Thu, Feb 16, 2023 at 11:43:38PM +0300, Dmitry Osipenko wrote: > On 2/16/23 15:15, Daniel Vetter wrote: > > On Mon, Jan 30, 2023 at 03:02:10PM +0300, Dmitry Osipenko wrote: > >> On 1/27/23 11:13, Gerd Hoffmann wrote: > >>> On Thu, Jan 26, 2023 at 01:55:09AM +0300, Dmitry Osipenko wrote: >

Re: [PATCH vhost 00/10] virtio core prepares for AF_XDP

2023-02-16 Thread Jason Wang
On Thu, Feb 16, 2023 at 7:50 PM Xuan Zhuo wrote: > > On Thu, 16 Feb 2023 13:27:00 +0800, Jason Wang wrote: > > On Tue, Feb 14, 2023 at 3:27 PM Xuan Zhuo > > wrote: > > > > > > XDP socket(AF_XDP) is an excellent bypass kernel network framework. The > > > zero > > > copy feature of xsk (XDP

Re: [PATCH v2] vhost/vdpa: Add MSI translation tables to iommu for software-managed MSI

2023-02-16 Thread Jason Wang
On Fri, Feb 17, 2023 at 8:15 AM Jason Gunthorpe wrote: > > On Tue, Feb 07, 2023 at 08:08:43PM +0800, Nanyong Sun wrote: > > From: Rong Wang > > > > Once enable iommu domain for one device, the MSI > > translation tables have to be there for software-managed MSI. > > Otherwise, platform with

Re: [PATCH] vhost-vdpa: cleanup memory maps when closing vdpa fds

2023-02-16 Thread Jason Wang
On Wed, Feb 15, 2023 at 1:16 PM Longpeng (Mike, Cloud Infrastructure Service Product Dept.) wrote: > > > > 在 2023/2/15 10:56, Jason Wang 写道: > > On Wed, Feb 15, 2023 at 10:49 AM Longpeng (Mike, Cloud Infrastructure > > Service Product Dept.) wrote: > >> > >> > >> > >> 在 2023/2/15 10:00, Jason

Re: [PATCH v2 01/13] vdpa net: move iova tree creation from init to start

2023-02-16 Thread Si-Wei Liu
On 2/15/2023 11:35 PM, Eugenio Perez Martin wrote: On Thu, Feb 16, 2023 at 3:15 AM Si-Wei Liu wrote: On 2/14/2023 11:07 AM, Eugenio Perez Martin wrote: On Tue, Feb 14, 2023 at 2:45 AM Si-Wei Liu wrote: On 2/13/2023 3:14 AM, Eugenio Perez Martin wrote: On Mon, Feb 13, 2023 at 7:51 AM