Re: [PATCHv3 0/4] qemu-kvm: vhost net support

2009-08-18 Thread Alex Williamson
On Mon, Aug 17, 2009 at 6:37 AM, Michael S. Tsirkinm...@redhat.com wrote: This adds support for vhost-net virtio kernel backend. This is RFC, but works without issues for me. I got this to build by syncing up some headers in kvm/include/linux, but it doesn't seem to be working quite right. I

Re: [PATCHv3 0/4] qemu-kvm: vhost net support

2009-08-18 Thread Alex Williamson
On Tue, Aug 18, 2009 at 3:04 PM, Michael S. Tsirkinm...@redhat.com wrote: Did you assign ip address in host by any chance? You don't want that. Nope, just up on the host, no IP: eth10 Link encap:Ethernet HWaddr 00:17:a4:77:a4:08 inet6 addr: fe80::217:a4ff:fe77:a408/64 Scope:Link

Re: [PATCHv3 0/4] qemu-kvm: vhost net support

2009-08-18 Thread Alex Williamson
On Tue, Aug 18, 2009 at 3:11 PM, Alex Williamsonalex.william...@hp.com wrote: On Tue, Aug 18, 2009 at 3:04 PM, Michael S. Tsirkinm...@redhat.com wrote: Did you assign ip address in host by any chance? You don't want that. Nope, just up on the host, no IP: eth10     Link encap:Ethernet  

Re: [PATCHv3 0/4] qemu-kvm: vhost net support

2009-08-20 Thread Alex Williamson
On Thu, Aug 20, 2009 at 1:03 AM, Michael S. Tsirkinm...@redhat.com wrote: I think the duplicates are our best hint that something's wrong at this point. Let's try to see where do they come from. What is it exactly that you see? # ping 10.100.100.74 PING 10.100.100.74 (10.100.100.74) 56(84)

Re: [PATCHv3 0/4] qemu-kvm: vhost net support

2009-08-24 Thread Alex Williamson
On Sun, Aug 23, 2009 at 1:22 PM, Michael S. Tsirkinm...@redhat.com wrote: Just had a different, but slightly similar problem when the host running qemu had forwarding enabled. Is it possible your host is forwarding the packets somewhere else, and that's why we get the dupes? sysctl -w

Re: PCI device not properly reset after VFIO

2012-10-18 Thread Alex Williamson
Hi Hannes, Thanks for testing vfio On Thu, 2012-10-18 at 08:47 +0200, Hannes Reinecke wrote: Hi Alex, I've been playing around with VFIO and megasas (of course). What I did now was switching between VFIO and 'normal' operation, ie emulated access. megasas is happily running under VFIO,

Re: PCI device not properly reset after VFIO

2012-10-18 Thread Alex Williamson
On Thu, 2012-10-18 at 17:06 +0200, Hannes Reinecke wrote: On 10/18/2012 04:40 PM, Alex Williamson wrote: Hi Hannes, Thanks for testing vfio On Thu, 2012-10-18 at 08:47 +0200, Hannes Reinecke wrote: Hi Alex, I've been playing around with VFIO and megasas (of course). What I did

2013 Linux Plumbers Virtualization Microconference proposal call for participation

2013-05-16 Thread Alex Williamson
Hey folks, We'd like to hold another virtualization microconference as part of this year's Linux Plumbers Conference. To do so, we need to show that there's enough interest, materials, and people willing to attend. Anthony and Amit have already started a wiki page for the microconference:

Re: binding/unbinding devices to vfio-pci

2013-07-02 Thread Alex Williamson
On Tue, 2013-07-02 at 15:13 +, Yoder Stuart-B08248 wrote: -Original Message- From: Alex Williamson [mailto:alex.william...@redhat.com] Sent: Tuesday, July 02, 2013 9:46 AM To: Yoder Stuart-B08248 Cc: k...@vger.kernel.org list; Alexander Graf; Bhushan Bharat-R65777

Re: RFC: vfio interface for platform devices

2013-07-02 Thread Alex Williamson
On Tue, 2013-07-02 at 23:25 +, Yoder Stuart-B08248 wrote: The write-up below is the first draft of a proposal for how the kernel can expose platform devices to user space using vfio. In short, I'm proposing a new ioctl VFIO_DEVICE_GET_DEVTREE_INFO which allows user space to correlate

Re: RFC: vfio interface for platform devices (v2)

2013-07-03 Thread Alex Williamson
On Wed, 2013-07-03 at 21:40 +, Yoder Stuart-B08248 wrote: Version 2 -VFIO_GROUP_GET_DEVICE_FD-- specified that the path is a sysfs path -VFIO_DEVICE_GET_INFO-- defined 2 flags instead of 1 -deleted VFIO_DEVICE_GET_DEVTREE_INFO ioctl -VFIO_DEVICE_GET_REGION_INFO-- updated as per

Call for Proposals: 2013 Linux Plumbers Virtualization Microconference

2013-07-12 Thread Alex Williamson
The Call for Proposals for the 2013 Linux Plumbers Virtualization Microconference is now open. This uconf is being held as part of Linux Plumbers Conference in New Orleans, Louisiana, USA September 18-20th and is co-located with LinuxCon North America. For more information see:

Re: Call for Proposals: 2013 Linux Plumbers Virtualization Microconference

2013-07-14 Thread Alex Williamson
On Fri, 2013-07-12 at 14:38 -0600, Alex Williamson wrote: The Call for Proposals for the 2013 Linux Plumbers Virtualization Microconference is now open. This uconf is being held as part of Linux Plumbers Conference in New Orleans, Louisiana, USA September 18-20th and is co-located

Re: Call for Proposals: 2013 Linux Plumbers Virtualization Microconference

2013-07-24 Thread Alex Williamson
On Sun, 2013-07-14 at 15:59 -0600, Alex Williamson wrote: On Fri, 2013-07-12 at 14:38 -0600, Alex Williamson wrote: The Call for Proposals for the 2013 Linux Plumbers Virtualization Microconference is now open. This uconf is being held as part of Linux Plumbers Conference in New Orleans

Re: Linux Plumbers ACPI/PM, PCI Microconference

2013-07-30 Thread Alex Williamson
On Wed, 2013-07-31 at 00:02 +, Shuah Khan wrote: On 07/30/2013 05:38 PM, Rafael J. Wysocki wrote: On Wednesday, July 17, 2013 08:31:55 AM Shuah Khan wrote: Myron, On Tue, Jul 16, 2013 at 8:21 PM, Myron Stowe myron.st...@gmail.com wrote: Shuah - You brought up the idea about

Re: [PATCH v8 34/50] vhost/net: virtio 1.0 byte swap

2015-01-06 Thread Alex Williamson
On Mon, 2014-12-01 at 18:05 +0200, Michael S. Tsirkin wrote: I had to add an explicit tag to suppress compiler warning: gcc isn't smart enough to notice that len is always initialized since function is called with size 0. I'm getting a panic inside a guest when this change is applied on the

Re: [PATCH] vhost/net: length miscalculation

2015-01-07 Thread Alex Williamson
datalen with the wrong sign, causing guest panics. Fixes: 8b38694a2dc8b18374310df50174f1e4376d6824 Reported-by: Alex Williamson alex.william...@redhat.com Suggested-by: Greg Kurz gk...@linux.vnet.ibm.com Signed-off-by: Michael S. Tsirkin m...@redhat.com --- Alex, could you please confirm

Re: [PATCH RFC 2/3] vfio: report group noiommu status

2016-04-18 Thread Alex Williamson
On Mon, 18 Apr 2016 12:58:20 +0300 "Michael S. Tsirkin" wrote: > When using vfio, callers might want to know whether device is added to a > regular group or an non-iommu group. > > Report this status from vfio_add_group_dev. > > Signed-off-by: Michael S. Tsirkin

Re: [PATCH RFC 3/3] vfio: add virtio pci quirk

2016-04-18 Thread Alex Williamson
a_decode); > vga_set_legacy_decoding(pdev, > diff --git a/drivers/vfio/pci/vfio_pci_virtio.c > b/drivers/vfio/pci/vfio_pci_virtio.c > new file mode 100644 > index 000..1a32064 > --- /dev/null > +++ b/drivers/vfio/pci/vfio_pci_virtio.c > @@ -0,0 +1,135 @@ &g

Re: [PATCH RFC] fixup! virtio: convert to use DMA api

2016-04-19 Thread Alex Williamson
On Tue, 19 Apr 2016 12:13:29 +0300 "Michael S. Tsirkin" wrote: > On Mon, Apr 18, 2016 at 02:29:33PM -0400, David Woodhouse wrote: > > On Mon, 2016-04-18 at 19:27 +0300, Michael S. Tsirkin wrote: > > > I balk at adding more hacks to a broken system. My goals are > > > merely to

Re: [PATCH v2 2/2] vfio: add virtio pci quirk

2016-08-29 Thread Alex Williamson
gt; diff --git a/drivers/vfio/pci/vfio_pci_virtio.c > b/drivers/vfio/pci/vfio_pci_virtio.c > new file mode 100644 > index 000..e1ecffd > --- /dev/null > +++ b/drivers/vfio/pci/vfio_pci_virtio.c > @@ -0,0 +1,140 @@ > +/* > + * VFIO PCI Intel Graphics support ^^^

Re: [PATCH v2 2/2] vfio: add virtio pci quirk

2016-08-29 Thread Alex Williamson
On Mon, 29 Aug 2016 21:23:25 -0600 Alex Williamson <alex.william...@redhat.com> wrote: > On Tue, 30 Aug 2016 05:27:17 +0300 > "Michael S. Tsirkin" <m...@redhat.com> wrote: > > > Modern virtio pci devices can set VIRTIO_F_IOMMU_PLATFORM > > t

Re: [PATCH v2 2/2] vfio: add virtio pci quirk

2016-08-29 Thread Alex Williamson
On Mon, 29 Aug 2016 21:52:20 -0600 Alex Williamson <alex.william...@redhat.com> wrote: > On Mon, 29 Aug 2016 21:23:25 -0600 > Alex Williamson <alex.william...@redhat.com> wrote: > > > On Tue, 30 Aug 2016 05:27:17 +0300 > > "Michael S. Tsirkin" <m...

Re: [PATCH v2 2/2] vfio: add virtio pci quirk

2016-08-30 Thread Alex Williamson
On Tue, 30 Aug 2016 08:20:38 +0300 "Michael S. Tsirkin" <m...@redhat.com> wrote: > On Mon, Aug 29, 2016 at 10:53:04PM -0600, Alex Williamson wrote: > > On Mon, 29 Aug 2016 21:52:20 -0600 > > Alex Williamson <alex.william...@redhat.com> wrote: > >

Re: Need information on type 2 IOMMU

2017-04-09 Thread Alex Williamson
On Mon, 10 Apr 2017 08:00:45 +0530 valmiki wrote: > Hi All, > > We have drivers/vfio/vfio_iommu_type1.c. what is type1 iommu? Is it > w.r.t vfio layer it is being referred? > > Is there type 2 IOMMU w.r.t vfio? If so what is it? type1 is the 1st type. It's an arbitrary

Re: [PATCH 1/3] Fix ERROR: trailing statements should be on next line

2017-05-14 Thread Alex Williamson
On Mon, 15 May 2017 05:58:05 +0300 "Michael S. Tsirkin" wrote: > On Sun, May 14, 2017 at 07:51:28PM +0200, Maciek Fijalkowski wrote: > > From: Maciej Fijalkowski > > > > Signed-off-by: Maciej Fijalkowski > > I prefer the original form - ;

Re: [PATCH 4/4] vfio: Allow type-1 IOMMU instantiation with a virtio-iommu

2018-02-14 Thread Alex Williamson
On Wed, 14 Feb 2018 14:53:40 + Jean-Philippe Brucker wrote: > When enabling both VFIO and VIRTIO_IOMMU modules, automatically select > VFIO_IOMMU_TYPE1 as well. > > Signed-off-by: Jean-Philippe Brucker > --- >

Re: [RFC v2] vhost: introduce mdev based hardware vhost backend

2019-07-05 Thread Alex Williamson
On Thu, 4 Jul 2019 14:21:34 +0800 Tiwei Bie wrote: > On Thu, Jul 04, 2019 at 12:31:48PM +0800, Jason Wang wrote: > > On 2019/7/3 下午9:08, Tiwei Bie wrote: > > > On Wed, Jul 03, 2019 at 08:16:23PM +0800, Jason Wang wrote: > > > > On 2019/7/3 下午7:52, Tiwei Bie wrote: > > > > > On Wed, Jul 03,

Re: [RFC v2] vhost: introduce mdev based hardware vhost backend

2019-07-03 Thread Alex Williamson
On Wed, 3 Jul 2019 17:13:39 +0800 Tiwei Bie wrote: > diff --git a/include/uapi/linux/vfio.h b/include/uapi/linux/vfio.h > index 8f10748dac79..6c5718ab7eeb 100644 > --- a/include/uapi/linux/vfio.h > +++ b/include/uapi/linux/vfio.h > @@ -201,6 +201,7 @@ struct vfio_device_info { > #define

Re: [RFC PATCH 0/2] Mdev: support mutiple kinds of devices

2019-09-17 Thread Alex Williamson
[cc +Parav] On Thu, 12 Sep 2019 17:40:10 +0800 Jason Wang wrote: > Hi all: > > During the development of virtio-mdev[1]. I find that mdev needs to be > extended to support devices other than vfio mdev device. So this > series tries to extend the mdev to be able to differ from different >

Re: [RFC PATCH 2/4] mdev: introduce helper to set per device dma ops

2019-09-17 Thread Alex Williamson
On Tue, 10 Sep 2019 16:19:33 +0800 Jason Wang wrote: > This patch introduces mdev_set_dma_ops() which allows parent to set > per device DMA ops. This help for the kernel driver to setup a correct > DMA mappings. > > Signed-off-by: Jason Wang > --- > drivers/vfio/mdev/mdev_core.c | 7 +++ >

Re: [RFC PATCH 0/2] Mdev: support mutiple kinds of devices

2019-09-17 Thread Alex Williamson
On Wed, 18 Sep 2019 01:54:43 + "Tian, Kevin" wrote: > > From: Alex Williamson > > Sent: Wednesday, September 18, 2019 1:31 AM > > > > [cc +Parav] > > > > On Thu, 12 Sep 2019 17:40:10 +0800 > > Jason Wang wrote: > > > > &

Re: [PATCH V2 6/8] mdev: introduce virtio device and its device ops

2019-09-30 Thread Alex Williamson
On Fri, 27 Sep 2019 16:25:13 + Parav Pandit wrote: > Hi Alex, > > > > -Original Message- > > From: Alex Williamson > > Sent: Tuesday, September 24, 2019 6:07 PM > > To: Jason Wang > > Cc: k...@vger.kernel.org; linux-s...@vger.kernel.org; li

Re: [PATCH V2 5/8] mdev: introduce device specific ops

2019-09-26 Thread Alex Williamson
On Thu, 26 Sep 2019 11:46:55 -0400 "Michael S. Tsirkin" wrote: > On Wed, Sep 25, 2019 at 10:30:28AM -0600, Alex Williamson wrote: > > On Wed, 25 Sep 2019 10:11:00 -0400 > > Rob Miller wrote: > > > > > On Tue, 24 Sep 2019 21:53:29 +0800 > > >

Re: [PATCH 5/6] vringh: fix copy direction of vringh_iov_push_kern()

2019-09-23 Thread Alex Williamson
On Mon, 23 Sep 2019 21:03:30 +0800 Jason Wang wrote: > We want to copy from iov to buf, so the direction was wrong. > > Signed-off-by: Jason Wang > --- > drivers/vhost/vringh.c | 8 +++- > 1 file changed, 7 insertions(+), 1 deletion(-) Why is this included in the series? Seems like an

Re: [PATCH 1/6] mdev: class id support

2019-09-23 Thread Alex Williamson
On Mon, 23 Sep 2019 21:03:26 +0800 Jason Wang wrote: > Mdev bus only supports vfio driver right now, so it doesn't implement > match method. But in the future, we may add drivers other than vfio, > one example is virtio-mdev[1] driver. This means we need to add device > class id support in bus

Re: [PATCH 5/6] vringh: fix copy direction of vringh_iov_push_kern()

2019-09-24 Thread Alex Williamson
On Mon, 23 Sep 2019 12:00:41 -0400 "Michael S. Tsirkin" wrote: > On Mon, Sep 23, 2019 at 09:45:59AM -0600, Alex Williamson wrote: > > On Mon, 23 Sep 2019 21:03:30 +0800 > > Jason Wang wrote: > > > > > We want to copy from iov to buf, so the dire

Re: [PATCH V7 3/6] mdev: introduce device specific ops

2019-11-04 Thread Alex Williamson
On Mon, 4 Nov 2019 20:39:49 +0800 Jason Wang wrote: > Currently, except for the create and remove, the rest of > mdev_parent_ops is designed for vfio-mdev driver only and may not help > for kernel mdev driver. With the help of class id, this patch > introduces device specific callbacks inside

Re: [PATCH V7 4/6] mdev: introduce virtio device and its device ops

2019-11-04 Thread Alex Williamson
On Mon, 4 Nov 2019 20:39:50 +0800 Jason Wang wrote: > This patch implements basic support for mdev driver that supports > virtio transport for kernel virtio driver. > > Signed-off-by: Jason Wang > --- > drivers/vfio/mdev/mdev_core.c| 20 > drivers/vfio/mdev/mdev_private.h | 2 + >

Re: [PATCH V7 1/6] mdev: class id support

2019-11-04 Thread Alex Williamson
On Mon, 4 Nov 2019 20:39:47 +0800 Jason Wang wrote: > Mdev bus only supports vfio driver right now, so it doesn't implement > match method. But in the future, we may add drivers other than vfio, > the first driver could be virtio-mdev. This means we need to add > device class id support in bus

Re: [PATCH V7 4/6] mdev: introduce virtio device and its device ops

2019-11-04 Thread Alex Williamson
On Tue, 5 Nov 2019 11:52:41 +0800 Jason Wang wrote: > On 2019/11/5 上午5:50, Alex Williamson wrote: > > On Mon, 4 Nov 2019 20:39:50 +0800 > > Jason Wang wrote: > > > >> This patch implements basic support for mdev driver that supports > >> vi

Re: [PATCH V8 4/6] mdev: introduce virtio device and its device ops

2019-11-05 Thread Alex Williamson
On Tue, 5 Nov 2019 17:32:38 +0800 Jason Wang wrote: > This patch implements basic support for mdev driver that supports > virtio transport for kernel virtio driver. > > Signed-off-by: Jason Wang > --- > drivers/vfio/mdev/mdev_core.c| 21 + > drivers/vfio/mdev/mdev_private.h | 2 +

Re: [PATCH V8 3/6] mdev: introduce device specific ops

2019-11-05 Thread Alex Williamson
On Tue, 5 Nov 2019 17:50:25 +0100 Cornelia Huck wrote: > On Tue, 5 Nov 2019 17:32:37 +0800 > Jason Wang wrote: > > > Currently, except for the create and remove, the rest of > > mdev_parent_ops is designed for vfio-mdev driver only and may not help > > for kernel mdev driver. With the help of

Re: [PATCH V8 0/6] mdev based hardware virtio offloading support

2019-11-06 Thread Alex Williamson
On Wed, 6 Nov 2019 14:25:23 -0500 "Michael S. Tsirkin" wrote: > On Wed, Nov 06, 2019 at 12:03:12PM -0700, Alex Williamson wrote: > > On Wed, 6 Nov 2019 11:56:46 +0800 > > Jason Wang wrote: > > > > > On 2019/11/6 上午1:58, Alex Williamson wrote: &g

Re: [PATCH V8 0/6] mdev based hardware virtio offloading support

2019-11-05 Thread Alex Williamson
On Tue, 5 Nov 2019 17:32:34 +0800 Jason Wang wrote: > Hi all: > > There are hardwares that can do virtio datapath offloading while > having its own control path. This path tries to implement a mdev based > unified API to support using kernel virtio driver to drive those > devices. This is done

Re: [PATCH V8 0/6] mdev based hardware virtio offloading support

2019-11-06 Thread Alex Williamson
On Wed, 6 Nov 2019 11:56:46 +0800 Jason Wang wrote: > On 2019/11/6 上午1:58, Alex Williamson wrote: > > On Tue, 5 Nov 2019 17:32:34 +0800 > > Jason Wang wrote: > > > >> Hi all: > >> > >> There are hardwares that can do virtio datapath o

Re: [PATCH V9 6/6] docs: sample driver to demonstrate how to implement virtio-mdev framework

2019-11-06 Thread Alex Williamson
On Wed, 6 Nov 2019 14:50:30 -0800 Randy Dunlap wrote: > On 11/5/19 11:05 PM, Jason Wang wrote: > > diff --git a/samples/Kconfig b/samples/Kconfig > > index c8dacb4dda80..13a2443e18e0 100644 > > --- a/samples/Kconfig > > +++ b/samples/Kconfig > > @@ -131,6 +131,16 @@ config SAMPLE_VFIO_MDEV_MDPY

Re: [PATCH V3 4/7] mdev: introduce device specific ops

2019-10-16 Thread Alex Williamson
On Wed, 16 Oct 2019 20:48:06 + Parav Pandit wrote: > > From: Alex Williamson > > On Wed, 16 Oct 2019 15:31:25 + > > Parav Pandit wrote: > > > > From: Cornelia Huck > > > > Parav Pandit wrote: > > > > > > From: Alex Williamso

Re: [PATCH V3 4/7] mdev: introduce device specific ops

2019-10-15 Thread Alex Williamson
On Tue, 15 Oct 2019 20:17:01 +0800 Jason Wang wrote: > On 2019/10/15 下午6:41, Cornelia Huck wrote: > > On Fri, 11 Oct 2019 16:15:54 +0800 > > Jason Wang wrote: > > > >> Currently, except for the create and remove, the rest of > >> mdev_parent_ops is designed for vfio-mdev driver only and may

Re: [PATCH V3 1/7] mdev: class id support

2019-10-15 Thread Alex Williamson
On Fri, 11 Oct 2019 16:15:51 +0800 Jason Wang wrote: > diff --git a/drivers/vfio/mdev/mdev_core.c b/drivers/vfio/mdev/mdev_core.c > index b558d4cfd082..724e9b9841d8 100644 > --- a/drivers/vfio/mdev/mdev_core.c > +++ b/drivers/vfio/mdev/mdev_core.c > @@ -45,6 +45,12 @@ void

Re: [PATCH V5 1/6] mdev: class id support

2019-10-24 Thread Alex Williamson
On Thu, 24 Oct 2019 11:27:36 +0800 Jason Wang wrote: > On 2019/10/24 上午5:42, Alex Williamson wrote: > > On Wed, 23 Oct 2019 21:07:47 +0800 > > Jason Wang wrote: > > > >> Mdev bus only supports vfio driver right now, so it doesn't implement > >> matc

Re: [PATCH V5 1/6] mdev: class id support

2019-10-24 Thread Alex Williamson
On Thu, 24 Oct 2019 13:46:36 -0600 Alex Williamson wrote: > On Thu, 24 Oct 2019 11:27:36 +0800 > Jason Wang wrote: > > > On 2019/10/24 上午5:42, Alex Williamson wrote: > > > On Wed, 23 Oct 2019 21:07:47 +0800 > > > Jason Wang wrote: > > > >

Re: [PATCH V5 4/6] mdev: introduce virtio device and its device ops

2019-10-24 Thread Alex Williamson
On Thu, 24 Oct 2019 11:51:35 +0800 Jason Wang wrote: > On 2019/10/24 上午5:57, Alex Williamson wrote: > > On Wed, 23 Oct 2019 21:07:50 +0800 > > Jason Wang wrote: > > > >> This patch implements basic support for mdev driver that supports > >> vi

Re: [PATCH V5 2/6] modpost: add support for mdev class id

2019-10-24 Thread Alex Williamson
On Thu, 24 Oct 2019 11:31:04 +0800 Jason Wang wrote: > On 2019/10/24 上午5:42, Alex Williamson wrote: > > On Wed, 23 Oct 2019 21:07:48 +0800 > > Jason Wang wrote: > > > >> Add support to parse mdev class id table. > >> > >> Reviewed-

Re: [PATCH V5 2/6] modpost: add support for mdev class id

2019-10-23 Thread Alex Williamson
On Wed, 23 Oct 2019 21:07:48 +0800 Jason Wang wrote: > Add support to parse mdev class id table. > > Reviewed-by: Parav Pandit > Signed-off-by: Jason Wang > --- > drivers/vfio/mdev/vfio_mdev.c | 2 ++ > scripts/mod/devicetable-offsets.c | 3 +++ > scripts/mod/file2alias.c | 10

Re: [PATCH V5 1/6] mdev: class id support

2019-10-23 Thread Alex Williamson
On Wed, 23 Oct 2019 21:07:47 +0800 Jason Wang wrote: > Mdev bus only supports vfio driver right now, so it doesn't implement > match method. But in the future, we may add drivers other than vfio, > the first driver could be virtio-mdev. This means we need to add > device class id support in bus

Re: [PATCH V5 4/6] mdev: introduce virtio device and its device ops

2019-10-23 Thread Alex Williamson
On Wed, 23 Oct 2019 21:07:50 +0800 Jason Wang wrote: > This patch implements basic support for mdev driver that supports > virtio transport for kernel virtio driver. > > Signed-off-by: Jason Wang > --- > drivers/vfio/mdev/mdev_core.c| 20 > drivers/vfio/mdev/mdev_private.h | 2 + >

Re: [PATCH V4 4/6] mdev: introduce virtio device and its device ops

2019-10-17 Thread Alex Williamson
On Thu, 17 Oct 2019 18:48:34 +0800 Jason Wang wrote: > This patch implements basic support for mdev driver that supports > virtio transport for kernel virtio driver. > > Signed-off-by: Jason Wang > --- > drivers/vfio/mdev/mdev_core.c | 12 +++ > include/linux/mdev.h | 4 + >

Re: [PATCH V4 3/6] mdev: introduce device specific ops

2019-10-17 Thread Alex Williamson
On Thu, 17 Oct 2019 17:07:55 +0200 Cornelia Huck wrote: > On Thu, 17 Oct 2019 18:48:33 +0800 > Jason Wang wrote: > > > Currently, except for the create and remove, the rest of > > mdev_parent_ops is designed for vfio-mdev driver only and may not help > > for kernel mdev driver. With the help

Re: [PATCH V3 4/7] mdev: introduce device specific ops

2019-10-16 Thread Alex Williamson
On Wed, 16 Oct 2019 15:31:25 + Parav Pandit wrote: > > -Original Message- > > From: Cornelia Huck > > Sent: Wednesday, October 16, 2019 3:53 AM > > To: Parav Pandit > > Cc: Alex Williamson ; Jason Wang > > ; k...@vger.kernel.org; linux

Re: [PATCH V2 6/8] mdev: introduce virtio device and its device ops

2019-09-24 Thread Alex Williamson
On Tue, 24 Sep 2019 21:53:30 +0800 Jason Wang wrote: > This patch implements basic support for mdev driver that supports > virtio transport for kernel virtio driver. > > Signed-off-by: Jason Wang > --- > include/linux/mdev.h| 2 + > include/linux/virtio_mdev.h | 145

Re: [PATCH V2 5/8] mdev: introduce device specific ops

2019-09-24 Thread Alex Williamson
On Tue, 24 Sep 2019 21:53:29 +0800 Jason Wang wrote: > Currently, except for the create and remove, the rest of > mdev_parent_ops is designed for vfio-mdev driver only and may not help > for kernel mdev driver. With the help of class id, this patch > introduces device specific callbacks inside

Re: [PATCH V2 2/8] mdev: class id support

2019-09-24 Thread Alex Williamson
On Tue, 24 Sep 2019 21:53:26 +0800 Jason Wang wrote: > Mdev bus only supports vfio driver right now, so it doesn't implement > match method. But in the future, we may add drivers other than vfio, > the first driver could be virtio-mdev. This means we need to add > device class id support in bus

Re: [PATCH V2 5/8] mdev: introduce device specific ops

2019-09-25 Thread Alex Williamson
On Wed, 25 Sep 2019 10:11:00 -0400 Rob Miller wrote: > > > On Tue, 24 Sep 2019 21:53:29 +0800 > > > Jason Wang wrote: > > > > diff --git a/drivers/vfio/mdev/vfio_mdev.c > > > b/drivers/vfio/mdev/vfio_mdev.c > > > > index 891cf83a2d9a..95efa054442f 100644 > > > > ---

Re: [PATCH for QEMU v2] hw/vfio: Add VMD Passthrough Quirk

2020-05-11 Thread Alex Williamson
On Mon, 11 May 2020 15:01:27 -0400 Jon Derrick wrote: > The VMD endpoint provides a real PCIe domain to the guest, including Please define VMD. I'm sure this is obvious to many, but I've had to do some research. The best TL;DR summary I've found is Keith's original commit 185a383ada2e adding

Re: [PATCH for QEMU v2] hw/vfio: Add VMD Passthrough Quirk

2020-05-13 Thread Alex Williamson
On Wed, 13 May 2020 00:35:47 + "Derrick, Jonathan" wrote: > Hi Alex, > > I'm probably not getting the translation technical details correct. > > On Mon, 2020-05-11 at 16:59 -0600, Alex Williamson wrote: > > On Mon, 11 May 2020 15:01:27 -0400 > > Jon

Re: [PATCH for QEMU v2] hw/vfio: Add VMD Passthrough Quirk

2020-05-13 Thread Alex Williamson
On Wed, 13 May 2020 19:26:34 + "Derrick, Jonathan" wrote: > On Wed, 2020-05-13 at 11:55 -0600, Alex Williamson wrote: > > On Wed, 13 May 2020 00:35:47 + > > "Derrick, Jonathan" wrote: > > > > > Hi Alex, > > > > > >

Re: [PATCH] iommu/virtio: Reject IOMMU page granule larger than PAGE_SIZE

2020-03-19 Thread Alex Williamson
On Wed, 18 Mar 2020 17:14:05 +0100 Auger Eric wrote: > Hi, > > On 3/18/20 1:00 PM, Robin Murphy wrote: > > On 2020-03-18 11:40 am, Jean-Philippe Brucker wrote: > >> We don't currently support IOMMUs with a page granule larger than the > >> system page size. The IOVA allocator has a BUG_ON()

Re: [PATCH 2/7] kvm/vfio: detect assigned device via irqbypass manager

2020-07-12 Thread Alex Williamson
On Sun, 12 Jul 2020 22:49:21 +0800 Zhu Lingshan wrote: > We used to detect assigned device via VFIO manipulated device > conters. This is less flexible consider VFIO is not the only > interface for assigned device. vDPA devices has dedicated > backed hardware as well. So this patch tries to

Re: [PATCH V2 2/6] kvm: detect assigned device via irqbypass manager

2020-07-17 Thread Alex Williamson
On Thu, 16 Jul 2020 19:23:45 +0800 Zhu Lingshan wrote: > vDPA devices has dedicated backed hardware like > passthrough-ed devices. Then it is possible to setup irq > offloading to vCPU for vDPA devices. Thus this patch tries to > manipulated assigned device counters via irqbypass manager. > >

Re: [RFC 3/3] vfio: Share the KVM instance with Vdmabuf

2021-01-19 Thread Alex Williamson
On Tue, 19 Jan 2021 00:28:12 -0800 Vivek Kasireddy wrote: > Getting a copy of the KVM instance is necessary for mapping Guest > pages in the Host. > > TODO: Instead of invoking the symbol directly, there needs to be a > better way of getting a copy of the KVM instance probably by using > other

Re: [RFC 3/3] vfio: Share the KVM instance with Vdmabuf

2021-01-19 Thread Alex Williamson
On Wed, 20 Jan 2021 00:14:49 + "Kasireddy, Vivek" wrote: > Hi Alex, > > > -Original Message- > > From: Alex Williamson > > Sent: Tuesday, January 19, 2021 7:40 AM > > To: Kasireddy, Vivek > > Cc: virtualization@lists.linux-foundation.o

Re: [RFC 3/3] vfio: Share the KVM instance with Vdmabuf

2021-01-19 Thread Alex Williamson
On Wed, 20 Jan 2021 03:05:49 + "Tian, Kevin" wrote: > > From: Alex Williamson > > Sent: Wednesday, January 20, 2021 8:51 AM > > > > On Wed, 20 Jan 2021 00:14:49 + > > "Kasireddy, Vivek" wrote: > > > > > Hi Al

Re: [PATCH 3/5] iommu: Introduce the domain op enforce_cache_coherency()

2022-04-05 Thread Alex Williamson
On Tue, 5 Apr 2022 13:16:02 -0300 Jason Gunthorpe wrote: > This new mechanism will replace using IOMMU_CAP_CACHE_COHERENCY and > IOMMU_CACHE to control the no-snoop blocking behavior of the IOMMU. > > Currently only Intel and AMD IOMMUs are known to support this > feature. They both implement

Re: [PATCH 2/5] vfio: Require that devices support DMA cache coherence

2022-04-05 Thread Alex Williamson
On Tue, 5 Apr 2022 13:16:01 -0300 Jason Gunthorpe wrote: > dev_is_dma_coherent() is the control to determine if IOMMU_CACHE can be > supported. > > IOMMU_CACHE means that normal DMAs do not require any additional coherency > mechanism and is the basic uAPI that VFIO exposes to userspace. For >

Re: [PATCH 1/5] iommu: Replace uses of IOMMU_CAP_CACHE_COHERENCY with dev_is_dma_coherent()

2022-04-07 Thread Alex Williamson
On Thu, 7 Apr 2022 12:23:31 -0300 Jason Gunthorpe wrote: > On Thu, Apr 07, 2022 at 04:17:11PM +0100, Robin Murphy wrote: > > > For the specific case of overriding PCIe No Snoop (which is more problematic > > from an Arm SMMU PoV) when assigning to a VM, would that not be easier > > solved by

Re: [PATCH V1 vfio 9/9] vfio/virtio: Introduce a vfio driver over virtio devices

2023-10-25 Thread Alex Williamson
On Wed, 25 Oct 2023 17:35:51 +0300 Yishai Hadas wrote: > On 24/10/2023 22:57, Alex Williamson wrote: > > On Tue, 17 Oct 2023 16:42:17 +0300 > > Yishai Hadas wrote: > > > >> Introduce a vfio driver over virtio devices to support the legacy > &

Re: [PATCH V1 vfio 9/9] vfio/virtio: Introduce a vfio driver over virtio devices

2023-10-24 Thread Alex Williamson
On Tue, 17 Oct 2023 16:42:17 +0300 Yishai Hadas wrote: > Introduce a vfio driver over virtio devices to support the legacy > interface functionality for VFs. > > Background, from the virtio spec [1]. > > In some systems, there

Re: [PATCH V1 vfio 9/9] vfio/virtio: Introduce a vfio driver over virtio devices

2023-10-26 Thread Alex Williamson
On Thu, 26 Oct 2023 15:08:12 +0300 Yishai Hadas wrote: > On 25/10/2023 22:13, Alex Williamson wrote: > > On Wed, 25 Oct 2023 17:35:51 +0300 > > Yishai Hadas wrote: > > > >> On 24/10/2023 22:57, Alex Williamson wrote: > >>> On Tue, 17 Oct 202

Re: [PATCH vfio 11/11] vfio/virtio: Introduce a vfio driver over virtio devices

2023-09-21 Thread Alex Williamson
On Thu, 21 Sep 2023 15:40:40 +0300 Yishai Hadas wrote: > Introduce a vfio driver over virtio devices to support the legacy > interface functionality for VFs. > > Background, from the virtio spec [1]. > > In some systems, there

Re: [PATCH vfio 11/11] vfio/virtio: Introduce a vfio driver over virtio devices

2023-09-21 Thread Alex Williamson
On Thu, 21 Sep 2023 15:40:40 +0300 Yishai Hadas wrote: > Introduce a vfio driver over virtio devices to support the legacy > interface functionality for VFs. > > Background, from the virtio spec [1]. > > In some systems, there

Re: [PATCH vfio 08/11] vfio/pci: Expose vfio_pci_core_setup_barmap()

2023-09-21 Thread Alex Williamson
On Thu, 21 Sep 2023 15:40:37 +0300 Yishai Hadas wrote: > Expose vfio_pci_core_setup_barmap() to be used by drivers. > > This will let drivers to mmap a BAR and re-use it from both vfio and the > driver when it's applicable. > > This API will be used in the next patches by the vfio/virtio

Re: [PATCH vfio 11/11] vfio/virtio: Introduce a vfio driver over virtio devices

2023-09-21 Thread Alex Williamson
On Thu, 21 Sep 2023 16:20:59 -0400 "Michael S. Tsirkin" wrote: > On Thu, Sep 21, 2023 at 05:01:21PM -0300, Jason Gunthorpe wrote: > > On Thu, Sep 21, 2023 at 01:58:32PM -0600, Alex Williamson wrote: > > > > > > +static const st

Re: [PATCH V1 vfio 9/9] vfio/virtio: Introduce a vfio driver over virtio devices

2023-10-17 Thread Alex Williamson
On Tue, 17 Oct 2023 16:42:17 +0300 Yishai Hadas wrote: > +static int virtiovf_pci_probe(struct pci_dev *pdev, > + const struct pci_device_id *id) > +{ > + const struct vfio_device_ops *ops = _acc_vfio_pci_ops; > + struct virtiovf_pci_core_device *virtvdev; > +

Re: [PATCH V1 vfio 9/9] vfio/virtio: Introduce a vfio driver over virtio devices

2023-10-18 Thread Alex Williamson
On Wed, 18 Oct 2023 12:01:57 +0300 Yishai Hadas wrote: > On 17/10/2023 23:24, Alex Williamson wrote: > > On Tue, 17 Oct 2023 16:42:17 +0300 > > Yishai Hadas wrote: > >> +static int virtiovf_pci_probe(struct pci_dev *pdev, > >> +

Re: [PATCH V1 vfio 9/9] vfio/virtio: Introduce a vfio driver over virtio devices

2023-10-18 Thread Alex Williamson
On Wed, 18 Oct 2023 13:33:33 -0300 Jason Gunthorpe wrote: > On Tue, Oct 17, 2023 at 02:24:48PM -0600, Alex Williamson wrote: > > On Tue, 17 Oct 2023 16:42:17 +0300 > > Yishai Hadas wrote: > > > +static int virtiovf_pci_probe(struct pci_dev *pdev, > > > +

Re: [PATCH V1 vfio 0/9] Introduce a vfio driver over virtio devices

2023-10-23 Thread Alex Williamson
On Sun, 22 Oct 2023 11:20:31 +0300 Yishai Hadas wrote: > On 17/10/2023 16:42, Yishai Hadas wrote: > > This series introduce a vfio driver over virtio devices to support the > > legacy interface functionality for VFs. > > > > Background, from the virtio spec [1]. > >

Re: [PATCH V1 vfio 0/9] Introduce a vfio driver over virtio devices

2023-10-23 Thread Alex Williamson
On Mon, 23 Oct 2023 12:42:57 -0300 Jason Gunthorpe wrote: > On Mon, Oct 23, 2023 at 09:33:23AM -0600, Alex Williamson wrote: > > > > Alex, > > > Are you fine to leave the provisioning of the VF including the control > > > of its transitional capability in

Re: [PATCH V1 vfio 0/9] Introduce a vfio driver over virtio devices

2023-10-23 Thread Alex Williamson
On Mon, 23 Oct 2023 13:20:43 -0300 Jason Gunthorpe wrote: > On Mon, Oct 23, 2023 at 10:09:13AM -0600, Alex Williamson wrote: > > On Mon, 23 Oct 2023 12:42:57 -0300 > > Jason Gunthorpe wrote: > > > > > On Mon, Oct 23, 2023 at 09:33:23AM -0600, Alex Williamson

Re: [PATCH v2 2/5] vfio/iommu_type1: Prefer to reuse domains vs match enforced cache coherency

2022-06-21 Thread Alex Williamson
On Wed, 15 Jun 2022 17:03:01 -0700 Nicolin Chen wrote: > From: Jason Gunthorpe > > The KVM mechanism for controlling wbinvd is based on OR of the coherency > property of all devices attached to a guest, no matter those devices are > attached to a single domain or multiple domains. > > So,

Re: [PATCH v5 0/5] cover-letter: Simplify vfio_iommu_type1 attach/detach routine

2022-07-06 Thread Alex Williamson
On Fri, 1 Jul 2022 14:44:50 -0700 Nicolin Chen wrote: > This is a preparatory series for IOMMUFD v2 patches. It enforces error > code -EMEDIUMTYPE in iommu_attach_device() and iommu_attach_group() when > an IOMMU domain and a device/group are incompatible. It also drops the > useless domain->ops

Re: [PATCH v5 0/5] cover-letter: Simplify vfio_iommu_type1 attach/detach routine

2022-07-06 Thread Alex Williamson
On Wed, 6 Jul 2022 10:53:52 -0700 Nicolin Chen wrote: > On Wed, Jul 06, 2022 at 11:42:17AM -0600, Alex Williamson wrote: > > > On Fri, 1 Jul 2022 14:44:50 -0700 > > Nicolin Chen wrote: > > > > > This is a preparatory series for IOMMUFD v2 patches. It enfor

Re: vIOMMU gIOVA to HPA mapping

2022-11-14 Thread Alex Williamson
On Mon, 14 Nov 2022 20:31:49 +0800 "leo...@tom.com" wrote: > Hi, > Here is my application scenario: > 1. The NIC (Network Information Center) passes through to the VM(Virtual > Machine); > 2. The VM uses the user mode driver DPDK; > > Question: > 1. vIOMMU maintains the mapping

Re: [PATCH 0/2] eventfd: simplify signal helpers

2023-07-13 Thread Alex Williamson
On Thu, 13 Jul 2023 12:05:36 +0200 Christian Brauner wrote: > Hey everyone, > > This simplifies the eventfd_signal() and eventfd_signal_mask() helpers > by removing the count argument which is effectively unused. We have a patch under review which does in fact make use of the signaling value:

Re: [PATCH 0/2] eventfd: simplify signal helpers

2023-07-17 Thread Alex Williamson
On Mon, 17 Jul 2023 10:29:34 +0200 Grzegorz Jaszczyk wrote: > pt., 14 lip 2023 o 09:05 Christian Brauner napisał(a): > > > > On Thu, Jul 13, 2023 at 11:10:54AM -0600, Alex Williamson wrote: > > > On Thu, 13 Jul 2023 12:05:36 +0200 > > > Christian Brauner wr

Re: [PATCH 0/2] eventfd: simplify signal helpers

2023-07-17 Thread Alex Williamson
On Mon, 17 Jul 2023 19:12:16 -0300 Jason Gunthorpe wrote: > On Mon, Jul 17, 2023 at 01:08:31PM -0600, Alex Williamson wrote: > > > What would that mechanism be? We've been iterating on getting the > > serialization and buffering correct, but I don't know of another means