Re: [patch 09/20] rename struct paravirt_patch to paravirt_patch_site for clarity

2007-04-06 Thread Andrew Morton
On Wed, 04 Apr 2007 12:12:00 -0700 Jeremy Fitzhardinge [EMAIL PROTECTED] wrote: Rename struct paravirt_patch to paravirt_patch_site, so that it clearly refers to a callsite, and not the patch which may be applied to that callsite. Needed a bit of updating for Andi's recently-merged

Re: [patch 18/20] clean up tsc-based sched_clock

2007-04-06 Thread Andrew Morton
On Wed, 04 Apr 2007 12:12:09 -0700 Jeremy Fitzhardinge [EMAIL PROTECTED] wrote: Three cleanups: - change instable - unstable - its better to use get_cpu_var for getting this cpu's variables - change cycles_2_ns to do the full computation rather than just the tsc-ns scaling. Its a

Re: [patch 07/20] Allow paravirt backend to choose kernel PMD sharing

2007-04-06 Thread Andrew Morton
On Wed, 04 Apr 2007 12:11:58 -0700 Jeremy Fitzhardinge [EMAIL PROTECTED] wrote: Normally when running in PAE mode, the 4th PMD maps the kernel address space, which can be shared among all processes (since they all need the same kernel mappings). Xen, however, does not allow guests to have

Re: [patch 07/20] Allow paravirt backend to choose kernel PMD sharing

2007-04-06 Thread Andrew Morton
On Fri, 06 Apr 2007 17:02:58 -0700 Jeremy Fitzhardinge [EMAIL PROTECTED] wrote: Andrew Morton wrote: All this paravirt stuff isn't making the kernel any prettier, is it? You're too kind. wli's comment on the first version of this patch was something along the lines of this patch

Re: [patch 07/20] Allow paravirt backend to choose kernel PMD sharing

2007-04-06 Thread Andrew Morton
On Fri, 06 Apr 2007 17:40:13 -0700 Jeremy Fitzhardinge [EMAIL PROTECTED] wrote: Andrew Morton wrote: Something like that. I don't want to redo my patch if we're going to change your patch ;) OK. I won't specifically redo it on top of your patches, but I'll rework it to remove

Re: [patch 2/4] clean up identify_cpu

2007-04-07 Thread Andrew Morton
On Fri, 06 Apr 2007 15:41:54 -0700 Jeremy Fitzhardinge [EMAIL PROTECTED] wrote: identify_cpu() is used to identify both the boot CPU and secondary CPUs, but it performs some actions which only apply to the boot CPU. Those functions are therefore really __init functions, but because they're

Re: [patch 2/4] clean up identify_cpu

2007-04-07 Thread Andrew Morton
On Sat, 07 Apr 2007 10:20:17 -0700 Jeremy Fitzhardinge [EMAIL PROTECTED] wrote: I don't have a x86-64 compile environment on hand, so the 64 bits are completely untested http://userweb.kernel.org/~akpm/cross-compilers/ ___ Virtualization mailing

Re: [patch 4/6] Rename the parainstructions symbols to be consistent with the others

2007-04-10 Thread Andrew Morton
On Tue, 10 Apr 2007 20:07:48 +0200 Andi Kleen [EMAIL PROTECTED] wrote: On Wednesday 04 April 2007 03:06:59 Jeremy Fitzhardinge wrote: The other symbols used to delineate the alt-instructions sections have the form __foo/__foo_end. Rename parainstructions to match. This patch breaks

Re: [patch 1/4] Ignore stolen time in the softlockup watchdog

2007-04-24 Thread Andrew Morton
On Tue, 27 Mar 2007 14:49:20 -0700 Jeremy Fitzhardinge [EMAIL PROTECTED] wrote: The softlockup watchdog is currently a nuisance in a virtual machine, since the whole system could have the CPU stolen from it for a long period of time. While it would be unlikely for a guest domain to be

Re: [patch 1/4] Ignore stolen time in the softlockup watchdog

2007-04-24 Thread Andrew Morton
On Mon, 23 Apr 2007 23:58:20 -0700 Jeremy Fitzhardinge [EMAIL PROTECTED] wrote: Andrew Morton wrote: On Tue, 27 Mar 2007 14:49:20 -0700 Jeremy Fitzhardinge [EMAIL PROTECTED] wrote: The softlockup watchdog is currently a nuisance in a virtual machine, since the whole system could

Re: [patch 1/4] Ignore stolen time in the softlockup watchdog

2007-04-24 Thread Andrew Morton
On Tue, 24 Apr 2007 11:16:09 -0700 Jeremy Fitzhardinge [EMAIL PROTECTED] wrote: Andrew Morton wrote: I said that because the damn thing went away when I was hunting it down because I lost the config and was unable to remember the right combination of debug settings. Fortunately it later

Re: [patch 1/4] Ignore stolen time in the softlockup watchdog

2007-04-24 Thread Andrew Morton
On Tue, 24 Apr 2007 13:00:49 -0700 Jeremy Fitzhardinge [EMAIL PROTECTED] wrote: Andrew Morton wrote: Well, it _is_ mysterious. Did you try to locate the code which failed? I got lost in macros and include files, and gave up very very easily. Stop hiding, Ingo. OK, I've managed

lguest re-review

2007-05-09 Thread Andrew Morton
Some concern was expressed over the lguest review status, so I shall send the patches out again for people to review, to test, to make observations about the author's personal appearance, etc. I'll plan on sending these patches off to Linus in a week's time, assuming all goes well. Thanks.

Re: lguest re-review

2007-05-09 Thread Andrew Morton
On Thu, 10 May 2007 10:24:08 +1000 Rusty Russell [EMAIL PROTECTED] wrote: On Wed, 2007-05-09 at 02:51 -0700, Andrew Morton wrote: Some concern was expressed over the lguest review status, so I shall send the patches out again for people to review, to test, to make observations about

Re: [PATCH 1/7] lguest documentation: infrastructure and Chapter I

2007-06-08 Thread Andrew Morton
On Fri, 08 Jun 2007 13:10:57 +1000 Rusty Russell [EMAIL PROTECTED] wrote: The netfilter code had very good documentation: the Netfilter Hacking HOWTO. Noone ever read it. So this time I'm trying something different, using a bit of Knuthiness. Signed-off-by: Rusty Russell [EMAIL

Re: [PATCH 2/3] fbdev: Make deferred I/O work as advertized

2008-03-19 Thread Andrew Morton
On Wed, 19 Mar 2008 19:24:25 +0800 Jaya Kumar [EMAIL PROTECTED] wrote: On Wed, Mar 19, 2008 at 6:45 PM, Markus Armbruster [EMAIL PROTECTED] wrote: Any progress on this? Considering that fb_defio is utterly broken without the fix (writing the frame buffer makes the VM endlessly

Re: [PATCH 2/3] fbdev: Make deferred I/O work as advertized

2008-03-19 Thread Andrew Morton
On Thu, 20 Mar 2008 06:30:37 +0800 Jaya Kumar [EMAIL PROTECTED] wrote: On Thu, Mar 20, 2008 at 2:37 AM, Andrew Morton [EMAIL PROTECTED] wrote: Do we need some of all of that patch in 2.6.25? I wasn't aware of such a need. If the drivers/video/fb_defio.c hunk of that patch fixes

Re: [RFC/PATCH 01/15 v2] preparation: provide hook to enable pgstes in user pagetable

2008-03-24 Thread Andrew Morton
On Sat, 22 Mar 2008 18:02:37 +0100 Carsten Otte [EMAIL PROTECTED] wrote: From: Martin Schwidefsky [EMAIL PROTECTED] The SIE instruction on s390 uses the 2nd half of the page table page to virtualize the storage keys of a guest. This patch offers the s390_enable_sie function, which

Re: [PATCH 2/5] /dev/vring: simple userspace-kernel ringbuffer interface.

2008-04-18 Thread Andrew Morton
On Fri, 18 Apr 2008 14:39:48 +1000 Rusty Russell [EMAIL PROTECTED] wrote: virtio introduced a ring structure ABI for guest-host communications (currently used by lguest and kvm). Using this same ABI, we can create a nice fd version. This is useful for efficiently passing packets to and

Re: [PATCH 5/5] tun: vringfd xmit support.

2008-04-18 Thread Andrew Morton
On Fri, 18 Apr 2008 14:43:24 +1000 Rusty Russell [EMAIL PROTECTED] wrote: This patch modifies tun to allow a vringfd to specify the send buffer. The user does a write to push out packets from the buffer. Again we use the 'struct virtio_net_hdr' to allow userspace to send GSO packets. In

Re: [PATCH 2/5] /dev/vring: simple userspace-kernel ringbuffer interface.

2008-04-18 Thread Andrew Morton
On Sat, 19 Apr 2008 00:32:39 +1000 Rusty Russell [EMAIL PROTECTED] wrote: Isn't this kinda-sorta like what a relayfs file does? The oprofile buffers? etc? Nothing in common at all, no hope? An excellent question, but I thought the modern kernel etiquette was to only comment on

Re: [PATCH 5/5] tun: vringfd xmit support.

2008-04-18 Thread Andrew Morton
: Export release_pages; nice undo for get_user_pages. Andrew Morton suggests tun/tap use release_pages, but it's not exported. It's not clear to me why this is in swap.c, but it exists even without CONFIG_SWAP, so that's OK. Signed-off-by: Rusty Russell [EMAIL PROTECTED] diff -r

Re: [PATCH 5/5] tun: vringfd xmit support.

2008-04-18 Thread Andrew Morton
On Sat, 19 Apr 2008 01:15:15 +1000 Rusty Russell [EMAIL PROTECTED] wrote: It's not clear to me why this is in swap.c, but it exists even without CONFIG_SWAP, so that's OK. We should have done mv mm/swap.c mm/mmlib.c years ago. ___ Virtualization

Re: [PATCH 5/5] tun: vringfd xmit support.

2008-04-19 Thread Andrew Morton
On Sun, 20 Apr 2008 00:41:43 +1000 Rusty Russell [EMAIL PROTECTED] wrote: On Saturday 19 April 2008 05:06:34 Andrew Morton wrote: On Sat, 19 Apr 2008 01:15:15 +1000 Rusty Russell [EMAIL PROTECTED] wrote: What is the maximum numbet of pages which an unpriviliged user can concurrently

Re: [PATCH 2/2] dm-ioband: I/O bandwidth controller v0.0.4: Document

2008-04-26 Thread Andrew Morton
On Thu, 24 Apr 2008 20:22:19 +0900 (JST) Ryo Tsuruta [EMAIL PROTECTED] wrote: +What's dm-ioband all about? + + dm-ioband is an I/O bandwidth controller implemented as a device-mapper + driver. Several jobs using the same physical device have to share the + bandwidth of the device.

Re: [PATCHv2 1/2] mm: export use_mm/unuse_mm to modules

2009-08-11 Thread Andrew Morton
On Wed, 12 Aug 2009 00:27:52 +0300 Michael S. Tsirkin m...@redhat.com wrote: vhost net module wants to do copy to/from user from a kernel thread, which needs use_mm (like what fs/aio has). Move that into mm/ and export to modules. OK by me. Please include this change in the virtio patchset.

Re: [PATCHv2 1/2] mm: export use_mm/unuse_mm to modules

2009-09-16 Thread Andrew Morton
On Thu, 17 Sep 2009 08:38:18 +0300 Michael S. Tsirkin m...@redhat.com wrote: Hi Andrew, On Tue, Aug 11, 2009 at 03:10:10PM -0700, Andrew Morton wrote: On Wed, 12 Aug 2009 00:27:52 +0300 Michael S. Tsirkin m...@redhat.com wrote: vhost net module wants to do copy to/from user from

Re: [PATCH] change acquire/release_console_sem() to console_lock/unlock()

2011-01-20 Thread Andrew Morton
On Thu, 20 Jan 2011 17:55:02 +0100 torbenh torb...@gmx.de wrote: On Thu, Jan 20, 2011 at 08:34:48AM -0800, Greg KH wrote: On Thu, Jan 20, 2011 at 04:58:13PM +0100, Torben Hohn wrote: the -rt patches change the console_semaphore to console_mutex. so a quite large chunk of the patches

Re: [PATCH] change acquire/release_console_sem() to console_lock/unlock()

2011-01-21 Thread Andrew Morton
On Fri, 21 Jan 2011 09:10:06 +0100 Geert Uytterhoeven ge...@linux-m68k.org wrote: include/linux/mutex.h: /* * NOTE: mutex_trylock() follows the spin_trylock() convention, * not the down_trylock() convention! * * Returns 1 if the mutex has been acquired successfully, and 0 on

Re: [PATCH] xen-blkfront: use bitmap_set() and bitmap_clear()

2012-01-20 Thread Andrew Morton
On Fri, 20 Jan 2012 11:09:38 -0500 Konrad Rzeszutek Wilk konrad.w...@oracle.com wrote: Did you test this patch with a large amount of minors? Sorry I didn't do runtime test. Please do. The poor guy probably doesn't know how to test it and surely it would be quite a lot of work for

Re: [PATCH] xen-blkfront: use bitmap_set() and bitmap_clear()

2012-01-20 Thread Andrew Morton
On Fri, 20 Jan 2012 18:55:08 -0500 Konrad Rzeszutek Wilk konrad.w...@oracle.com wrote: On Fri, Jan 20, 2012 at 03:11:49PM -0800, Andrew Morton wrote: On Fri, 20 Jan 2012 11:09:38 -0500 Konrad Rzeszutek Wilk konrad.w...@oracle.com wrote: Did you test this patch with a large

Re: [PATCH v4 1/3] mm: introduce compaction and migration for virtio ballooned pages

2012-07-18 Thread Andrew Morton
On Tue, 17 Jul 2012 13:50:41 -0300 Rafael Aquini aqu...@redhat.com wrote: This patch introduces the helper functions as well as the necessary changes to teach compaction and migration bits how to cope with pages which are part of a guest memory balloon, in order to make them movable by memory

Re: [PATCH v4 2/3] virtio_balloon: introduce migration primitives to balloon pages

2012-07-18 Thread Andrew Morton
On Tue, 17 Jul 2012 13:50:42 -0300 Rafael Aquini aqu...@redhat.com wrote: Besides making balloon pages movable at allocation time and introducing the necessary primitives to perform balloon page migration/compaction, this patch also introduces the following locking scheme to provide the

Re: [PATCH v4 1/3] mm: introduce compaction and migration for virtio ballooned pages

2012-07-18 Thread Andrew Morton
On Wed, 18 Jul 2012 20:07:07 -0300 Rafael Aquini aqu...@redhat.com wrote: +} +#else +static inline bool is_balloon_page(struct page *page) { return false; } +static inline bool isolate_balloon_page(struct page *page) { return false; } +static inline bool

Re: [PATCH v4 1/3] mm: introduce compaction and migration for virtio ballooned pages

2012-07-18 Thread Andrew Morton
On Wed, 18 Jul 2012 22:00:48 -0300 Rafael Aquini aqu...@redhat.com wrote: So the function needs a better name - one which communicates that it is a balloon page *for the purposes of processing by the compaction code*. Making the function private to compaction.c would help with that, if

Re: [PATCH v10 0/5] make balloon pages movable by compaction

2012-09-17 Thread Andrew Morton
On Mon, 17 Sep 2012 13:38:15 -0300 Rafael Aquini aqu...@redhat.com wrote: Memory fragmentation introduced by ballooning might reduce significantly the number of 2MB contiguous memory blocks that can be used within a guest, thus imposing performance penalties associated with the reduced number

Re: [PATCH v10 3/5] virtio_balloon: introduce migration primitives to balloon pages

2012-09-17 Thread Andrew Morton
On Mon, 17 Sep 2012 13:38:18 -0300 Rafael Aquini aqu...@redhat.com wrote: Memory fragmentation introduced by ballooning might reduce significantly the number of 2MB contiguous memory blocks that can be used within a guest, thus imposing performance penalties associated with the reduced number

Re: [PATCH v10 1/5] mm: introduce a common interface for balloon pages mobility

2012-09-17 Thread Andrew Morton
On Mon, 17 Sep 2012 13:38:16 -0300 Rafael Aquini aqu...@redhat.com wrote: Memory fragmentation introduced by ballooning might reduce significantly the number of 2MB contiguous memory blocks that can be used within a guest, thus imposing performance penalties associated with the reduced number

Re: [PATCH v10 1/5] mm: introduce a common interface for balloon pages mobility

2012-09-18 Thread Andrew Morton
On Tue, 18 Sep 2012 13:24:21 -0300 Rafael Aquini aqu...@redhat.com wrote: On Mon, Sep 17, 2012 at 03:15:43PM -0700, Andrew Morton wrote: +/* return code to identify when a ballooned page has been migrated */ +#define BALLOON_MIGRATION_RETURN 0xba1100 I didn't really spend enough time

Re: [PATCH v2 2/3] virtio: 9p: correctly pass physical address to userspace for high pages

2012-10-22 Thread Andrew Morton
On Fri, 19 Oct 2012 14:03:32 +0100 Will Deacon will.dea...@arm.com wrote: When using a virtio transport, the 9p net device may pass the physical address of a kernel buffer to userspace via a scatterlist inside a virtqueue. If the kernel buffer is mapped outside of the linear mapping (e.g.

Re: [PATCH v2 1/3] mm: highmem: export kmap_to_page for modules

2012-10-22 Thread Andrew Morton
On Fri, 19 Oct 2012 14:03:31 +0100 Will Deacon will.dea...@arm.com wrote: Some virtio device drivers (9p) need to translate high virtual addresses to physical addresses, which are inserted into the virtqueue for processing by userspace. This patch exports the kmap_to_page symbol, so that

Re: [PATCH v11 1/7] mm: adjust address_space_operations.migratepage() return code

2012-11-07 Thread Andrew Morton
On Wed, 7 Nov 2012 01:05:48 -0200 Rafael Aquini aqu...@redhat.com wrote: This patch introduces MIGRATEPAGE_SUCCESS as the default return code for address_space_operations.migratepage() method and documents the expected return code for the same method in failure cases. I hit a large number of

Re: [PATCH v11 5/7] virtio_balloon: introduce migration primitives to balloon pages

2012-11-07 Thread Andrew Morton
On Wed, 7 Nov 2012 01:05:52 -0200 Rafael Aquini aqu...@redhat.com wrote: Memory fragmentation introduced by ballooning might reduce significantly the number of 2MB contiguous memory blocks that can be used within a guest, thus imposing performance penalties associated with the reduced number

Re: [PATCH v11 3/7] mm: introduce a common interface for balloon pages mobility

2012-11-07 Thread Andrew Morton
On Wed, 7 Nov 2012 01:05:50 -0200 Rafael Aquini aqu...@redhat.com wrote: Memory fragmentation introduced by ballooning might reduce significantly the number of 2MB contiguous memory blocks that can be used within a guest, thus imposing performance penalties associated with the reduced number

Re: [PATCH v11 5/7] virtio_balloon: introduce migration primitives to balloon pages

2012-11-07 Thread Andrew Morton
On Thu, 08 Nov 2012 09:32:18 +1030 Rusty Russell ru...@rustcorp.com.au wrote: Rafael Aquini aqu...@redhat.com writes: + * virtballoon_migratepage - perform the balloon page migration on behalf of + * a compation thread. (called under page lock) + if

Re: [PATCH -next] virtio: balloon: fix missing unlock on error in fill_balloon()

2012-11-12 Thread Andrew Morton
On Mon, 12 Nov 2012 21:50:40 +0800 Wei Yongjun weiyj...@gmail.com wrote: From: Wei Yongjun yongjun_...@trendmicro.com.cn Add the missing unlock before return from function fill_balloon() in the error handling case. Introduced by 9864a8(virtio_balloon: introduce migration primitives to

Re: [PATCH v11 7/7] mm: add vm event counters for balloon pages compaction

2012-11-20 Thread Andrew Morton
On Fri, 9 Nov 2012 12:58:29 -0200 Rafael Aquini aqu...@redhat.com wrote: On Fri, Nov 09, 2012 at 12:20:33PM +, Mel Gorman wrote: On Wed, Nov 07, 2012 at 01:05:54AM -0200, Rafael Aquini wrote: This patch introduces a new set of vm event counters to keep track of ballooned pages

Re: [PATCH v11 4/7] mm: introduce compaction and migration for ballooned pages

2012-11-20 Thread Andrew Morton
On Fri, 9 Nov 2012 12:16:02 + Mel Gorman m...@csn.ul.ie wrote: On Wed, Nov 07, 2012 at 01:05:51AM -0200, Rafael Aquini wrote: Memory fragmentation introduced by ballooning might reduce significantly the number of 2MB contiguous memory blocks that can be used within a guest, thus

Re: [PATCH] drivers: virtio: Use PTR_RET function

2013-03-25 Thread Andrew Morton
On Tue, 26 Mar 2013 13:57:09 +1030 Rusty Russell ru...@rustcorp.com.au wrote: Alexandru Gheorghiu gheorghiuan...@gmail.com writes: Used PTR_RET function instead of IS_ERR and PTR_ERR. Patch found using coccinelle. WTF is PTR_RET? PTR_RET doesn't return anything. Why is it called

Re: [PATCH-v3 1/4] idr: Percpu ida

2013-08-20 Thread Andrew Morton
On Fri, 16 Aug 2013 23:09:06 + Nicholas A. Bellinger n...@linux-iscsi.org wrote: From: Kent Overstreet k...@daterainc.com Percpu frontend for allocating ids. With percpu allocation (that works), it's impossible to guarantee it will always be possible to allocate all nr_tags -

Re: [PATCH-v3 1/4] idr: Percpu ida

2013-08-28 Thread Andrew Morton
On Wed, 28 Aug 2013 12:53:17 -0700 Kent Overstreet k...@daterainc.com wrote: + while (1) { + spin_lock(pool-lock); + + /* + * prepare_to_wait() must come before steal_tags(), in case + * percpu_ida_free() on another cpu flips a bit in +

Re: [PATCH] percpu ida: Switch to cpumask_t, add some comments

2013-08-28 Thread Andrew Morton
On Wed, 28 Aug 2013 12:55:17 -0700 Kent Overstreet k...@daterainc.com wrote: Fixup patch, addressing Andrew's review feedback: Looks reasonable. lib/idr.c | 38 +- I still don't think it should be in this file. You say that some as-yet-unmerged

Re: [PATCH-v3 1/4] idr: Percpu ida

2013-08-28 Thread Andrew Morton
On Wed, 28 Aug 2013 13:44:54 -0700 Kent Overstreet k...@daterainc.com wrote: What guarantees that this wait will terminate? It seems fairly clear to me from the break statement a couple lines up; if we were passed __GFP_WAIT we terminate iff we succesfully allocated a tag. If we

Re: [PATCH] percpu ida: Switch to cpumask_t, add some comments

2013-08-28 Thread Andrew Morton
On Wed, 28 Aug 2013 14:00:10 -0700 Kent Overstreet k...@daterainc.com wrote: On Wed, Aug 28, 2013 at 01:25:50PM -0700, Andrew Morton wrote: On Wed, 28 Aug 2013 12:55:17 -0700 Kent Overstreet k...@daterainc.com wrote: Fixup patch, addressing Andrew's review feedback: Looks

Re: [PATCH-v3 1/4] idr: Percpu ida

2013-08-28 Thread Andrew Morton
On Wed, 28 Aug 2013 14:12:17 -0700 Kent Overstreet k...@daterainc.com wrote: How's this look? diff --git a/lib/idr.c b/lib/idr.c index 15c021c..a3f8e9a 100644 --- a/lib/idr.c +++ b/lib/idr.c @@ -1288,6 +1288,11 @@ static inline unsigned alloc_local_tag(struct percpu_ida *pool, * Safe

Re: [PATCH] percpu ida: Switch to cpumask_t, add some comments

2013-08-28 Thread Andrew Morton
On Wed, 28 Aug 2013 14:23:58 -0700 Kent Overstreet k...@daterainc.com wrote: I found things to be quite the opposite - it took 5 minutes of staring, head-scratching, double-checking and penny-dropping before I was confident that the newly-added code actually has nothing at all to do with

Re: [RFCv3 0/5] enable migration of driver pages

2015-07-07 Thread Andrew Morton
On Tue, 7 Jul 2015 13:36:20 +0900 Gioh Kim gioh@lge.com wrote: From: Gioh Kim guru...@hanmail.net Hello, This series try to enable migration of non-LRU pages, such as driver's page. My ARM-based platform occured severe fragmentation problem after long-term (several days) test.

Re: [RFCv3 0/5] enable migration of driver pages

2015-07-07 Thread Andrew Morton
On Wed, 08 Jul 2015 09:02:59 +0900 Gioh Kim gioh@lge.com wrote: 2015-07-08 __ 7:37___ Andrew Morton ___(___) ___ ___: On Tue, 7 Jul 2015 13:36:20 +0900 Gioh Kim gioh@lge.com wrote: From: Gioh Kim guru...@hanmail.net Hello, This series try to enable migration of non

Re: [PATCH v7 00/12] Support non-lru page migration

2016-06-01 Thread Andrew Morton
On Wed, 1 Jun 2016 08:21:09 +0900 Minchan Kim wrote: > Recently, I got many reports about perfermance degradation in embedded > system(Android mobile phone, webOS TV and so on) and easy fork fail. > > The problem was fragmentation caused by zram and GPU driver mainly. >

Re: [PATCH v3 00/16] Support non-lru page migration

2016-03-30 Thread Andrew Morton
On Wed, 30 Mar 2016 16:11:59 +0900 Minchan Kim wrote: > Recently, I got many reports about perfermance degradation > in embedded system(Android mobile phone, webOS TV and so on) > and failed to fork easily. > > The problem was fragmentation caused by zram and GPU driver >

Re: [PATCH v4 00/13] Support non-lru page migration

2016-04-27 Thread Andrew Morton
On Wed, 27 Apr 2016 16:48:13 +0900 Minchan Kim wrote: > Recently, I got many reports about perfermance degradation in embedded > system(Android mobile phone, webOS TV and so on) and easy fork fail. > > The problem was fragmentation caused by zram and GPU driver mainly. >

Re: [PATCH kernel v8 3/4] mm: add inerface to offer info about unused pages

2017-03-16 Thread Andrew Morton
On Thu, 16 Mar 2017 15:08:46 +0800 Wei Wang wrote: > From: Liang Li > > This patch adds a function to provides a snapshot of the present system > unused pages. An important usage of this function is to provide the > unsused pages to the Live

Re: [PATCH v9 3/5] mm: function to offer a page block on the free list

2017-04-13 Thread Andrew Morton
On Thu, 13 Apr 2017 17:35:06 +0800 Wei Wang wrote: > Add a function to find a page block on the free list specified by the > caller. Pages from the page block may be used immediately after the > function returns. The caller is responsible for detecting or preventing > the

Re: [PATCH v13 1/5] Introduce xbitmap

2017-08-09 Thread Andrew Morton
On Thu, 3 Aug 2017 14:38:15 +0800 Wei Wang wrote: > From: Matthew Wilcox > > The eXtensible Bitmap is a sparse bitmap representation which is > efficient for set bits which tend to cluster. It supports up to > 'unsigned long' worth of bits, and

Re: [PATCH v18 01/10] idr: add #include

2017-11-30 Thread Andrew Morton
On Wed, 29 Nov 2017 16:58:17 -0800 Matthew Wilcox wrote: > On Wed, Nov 29, 2017 at 09:55:17PM +0800, Wei Wang wrote: > > The was removed from radix-tree.h by the following commit: > > f5bba9d11a256ad2a1c2f8e7fc6aabe6416b7890. > > > > Since that commit,

Re: [PATCH] kvmalloc: always use vmalloc if CONFIG_DEBUG_VM

2018-05-01 Thread Andrew Morton
On Tue, 24 Apr 2018 12:33:01 -0400 (EDT) Mikulas Patocka wrote: > > > On Tue, 24 Apr 2018, Michal Hocko wrote: > > > On Tue 24-04-18 11:30:40, Mikulas Patocka wrote: > > > > > > > > > On Tue, 24 Apr 2018, Michal Hocko wrote: > > > > > > > On Mon 23-04-18 20:25:15,

Re: [PATCH v25 1/2 RESEND] mm: support reporting free page blocks

2018-01-25 Thread Andrew Morton
On Thu, 25 Jan 2018 17:38:27 +0800 Wei Wang wrote: > This patch adds support to walk through the free page blocks in the > system and report them via a callback function. Some page blocks may > leave the free list after zone->lock is released, so it is the caller's >

Re: [PATCH v29 1/4] mm: support reporting free page blocks

2018-04-10 Thread Andrew Morton
On Tue, 10 Apr 2018 21:19:31 +0300 "Michael S. Tsirkin" wrote: > > Andrew, were your questions answered? If yes could I bother you for an ack on > this? > Still not very happy that readers are told that "this function may sleep" when it clearly doesn't do so. If we wish to

Re: [PATCH] kvmalloc: always use vmalloc if CONFIG_DEBUG_VM

2018-04-19 Thread Andrew Morton
On Thu, 19 Apr 2018 12:12:38 -0400 (EDT) Mikulas Patocka wrote: > The kvmalloc function tries to use kmalloc and falls back to vmalloc if > kmalloc fails. > > Unfortunatelly, some kernel code has bugs - it uses kvmalloc and then > uses DMA-API on the returned memory or

Re: [PATCH] kvmalloc: always use vmalloc if CONFIG_DEBUG_VM

2018-04-19 Thread Andrew Morton
On Thu, 19 Apr 2018 17:19:20 -0400 (EDT) Mikulas Patocka wrote: > > > In order to detect these bugs reliably I submit this patch that changes > > > kvmalloc to always use vmalloc if CONFIG_DEBUG_VM is turned on. > > > > > > ... > > > > > > --- linux-2.6.orig/mm/util.c

Re: [PATCH v29 3/4] mm/page_poison: expose page_poisoning_enabled to kernel modules

2018-03-26 Thread Andrew Morton
On Mon, 26 Mar 2018 10:39:53 +0800 Wei Wang <wei.w.w...@intel.com> wrote: > In some usages, e.g. virtio-balloon, a kernel module needs to know if > page poisoning is in use. This patch exposes the page_poisoning_enabled > function to kernel modules. Acked-by: Andrew Mor

Re: [PATCH v29 1/4] mm: support reporting free page blocks

2018-03-26 Thread Andrew Morton
On Mon, 26 Mar 2018 10:39:51 +0800 Wei Wang wrote: > This patch adds support to walk through the free page blocks in the > system and report them via a callback function. Some page blocks may > leave the free list after zone->lock is released, so it is the caller's >

Re: [PATCH v2 0/3] kcov: collect coverage from usb and vhost

2019-10-24 Thread Andrew Morton
On Thu, 24 Oct 2019 14:47:31 +0200 Andrey Konovalov wrote: > > is it expected that the new kcov feature will be used elsewhere in the > > kernel? > > > > If the latter, which are the expected subsystems? > > Currently we encountered two cases where this is useful: USB and vhost > workers. Most

Re: [PATCH v2 1/3] kcov: remote coverage support

2019-10-23 Thread Andrew Morton
On Wed, 23 Oct 2019 17:24:29 +0200 Andrey Konovalov wrote: > This patch adds background thread coverage collection ability to kcov. > > With KCOV_ENABLE coverage is collected only for syscalls that are issued > from the current process. With KCOV_REMOTE_ENABLE it's possible to collect >

Re: [PATCH v2 0/3] kcov: collect coverage from usb and vhost

2019-10-23 Thread Andrew Morton
On Wed, 23 Oct 2019 17:24:28 +0200 Andrey Konovalov wrote: > This patchset extends kcov to allow collecting coverage from the USB > subsystem and vhost workers. See the first patch description for details > about the kcov extension. The other two patches apply this kcov extension > to USB and

Re: [PATCH v2 07/10] mm/memory_hotplug: Introduce offline_and_remove_memory()

2020-04-14 Thread Andrew Morton
he ACK from Michael > > > > Acked-by: Michal Hocko [1] > > > > [1] https://lkml.kernel.org/r/20200302142737.gp4...@dhcp22.suse.cz > > > Andrew, could you pls ack merging this through the vhost tree, > with the rest of the patchset? I wish the device_o

Re: [PATCH v2 05/10] mm: Allow to offline unmovable PageOffline() pages via MEM_GOING_OFFLINE

2020-04-14 Thread Andrew Morton
On Tue, 14 Apr 2020 12:34:26 -0400 "Michael S. Tsirkin" wrote: > Andrew, could you please ack merging this through the vhost tree > together with the rest of the patches? Acked-by: Andrew Morton ___ Virtualization mailing lis

Re: [PATCH v2 2/3] mm/memory_hotplug: Introduce MHP_NO_FIRMWARE_MEMMAP

2020-04-30 Thread Andrew Morton
On Thu, 30 Apr 2020 20:43:39 +0200 David Hildenbrand wrote: > > > > Why does the firmware map support hotplug entries? > > I assume: > > The firmware memmap was added primarily for x86-64 kexec (and still, is > mostly used on x86-64 only IIRC). There, we had ACPI hotplug. When DIMMs > get

Re: [PATCH v5 0/6] mm / virtio-mem: support ZONE_MOVABLE

2020-08-21 Thread Andrew Morton
On Fri, 21 Aug 2020 10:45:33 +0200 David Hildenbrand wrote: > On 21.08.20 10:31, David Hildenbrand wrote: > > On 16.08.20 14:53, David Hildenbrand wrote: > >> For 5.10. Patch #1-#4,#6 have RBs or ACKs, patch #5 is virtio-mem stuff > >> maintained by me. This should go via the -mm tree. > >> > >

Re: [PATCH v4 0/6] mm / virtio-mem: support ZONE_MOVABLE

2020-08-10 Thread Andrew Morton
On Mon, 10 Aug 2020 09:56:32 +0200 David Hildenbrand wrote: > On 04.08.20 21:41, David Hildenbrand wrote: > > @Andrew can we give this a churn and consider it for v5.9 in case there > > are no more comments? > > @Andrew, Ping, so I assume we'll target v5.10? Yep, sorry. Merging a significant

Re: [PATCH v5 2/2] mm, treewide: Rename kzfree() to kfree_sensitive()

2020-06-16 Thread Andrew Morton
On Tue, 16 Jun 2020 11:43:11 -0400 Waiman Long wrote: > As said by Linus: > > A symmetric naming is only helpful if it implies symmetries in use. > Otherwise it's actively misleading. > > In "kzalloc()", the z is meaningful and an important part of what the > caller wants. > > In

Re: [PATCH v2 27/29] mm/memory_hotplug: extend offline_and_remove_memory() to handle more than one memory block

2020-11-17 Thread Andrew Morton
e() simply onlines all memory in case > something goes wrong. It doesn't restore previous online type. Let's do > that, so we won't overwrite what e.g., user space configured. > > ... > uint8_t is a bit of a mouthful. u8 is less typing ;) Doesn't matter. Acked-by: And