Re: [PATCH 1/2] Convert target drivers to use sbitmap

2018-06-12 Thread Bart Van Assche
On Tue, 2018-05-15 at 09:00 -0700, Matthew Wilcox wrote: > diff --git a/drivers/scsi/qla2xxx/qla_target.c > b/drivers/scsi/qla2xxx/qla_target.c > index 025dc2d3f3de..cdf671c2af61 100644 > --- a/drivers/scsi/qla2xxx/qla_target.c > +++ b/drivers/scsi/qla2xxx/qla_target.c > @@ -3719,7 +3719,8 @@

Re: [PATCH 0/3] Use sbitmap instead of percpu_ida

2018-06-12 Thread Bart Van Assche
t understanding how to set up a > target platform. > > Changes from v1: > - Fixed bugs pointed out by Jens in iscsit_wait_for_tag() > - Abstracted out tag freeing as requested by Bart > - Made iscsit_wait_for_tag static as pointed out by 0day For the whole series: Reviewed-by

Re: [PATCH 1/2] Convert target drivers to use sbitmap

2018-06-12 Thread Bart Van Assche
On Tue, 2018-06-12 at 09:15 -0700, Matthew Wilcox wrote: > On Tue, Jun 12, 2018 at 03:22:42PM +0000, Bart Van Assche wrote: > > On Tue, 2018-05-15 at 09:00 -0700, Matthew Wilcox wrote: > > > diff --git a/drivers/scsi/qla2xxx/qla_target.c > > > b/drivers/scsi/qla2x

[PATCH 09/12] virtio_blk: Use blk_rq_is_scsi()

2017-10-26 Thread Bart Van Assche
This patch does not change any functionality. Signed-off-by: Bart Van Assche <bart.vanass...@wdc.com> Cc: Michael S. Tsirkin <m...@redhat.com> Cc: Jason Wang <jasow...@redhat.com> Cc: virtualization@lists.linux-foundation.org --- drivers/block/virtio_blk.c | 2 +- 1 file ch

Re: [RFC 3/3] RDMA/virtio-rdma: VirtIO rdma driver

2019-04-15 Thread Bart Van Assche
On 4/11/19 4:01 AM, Yuval Shaia wrote: > +++ b/drivers/infiniband/hw/virtio/Kconfig > @@ -0,0 +1,6 @@ > +config INFINIBAND_VIRTIO_RDMA > + tristate "VirtIO Paravirtualized RDMA Driver" > + depends on NETDEVICES && ETHERNET && PCI && INET > + ---help--- > + This driver provides

Re: [PATCH 4/6] tcm_vhost: Initial merge for vhost level target fabric driver

2012-07-05 Thread Bart Van Assche
On 07/04/12 04:24, Nicholas A. Bellinger wrote: +/* Fill in status and signal that we are done processing this command + * + * This is scheduled in the vhost work queue so we are called with the owner + * process mm and can access the vring. + */ +static void

Re: [PATCH 4/6] tcm_vhost: Initial merge for vhost level target fabric driver

2012-07-05 Thread Bart Van Assche
On 07/05/12 17:47, Bart Van Assche wrote: On 07/04/12 04:24, Nicholas A. Bellinger wrote: +/* Fill in status and signal that we are done processing this command + * + * This is scheduled in the vhost work queue so we are called with the owner + * process mm and can access the vring

Re: [PATCH 0/6] tcm_vhost/virtio-scsi WIP code for-3.6

2012-07-05 Thread Bart Van Assche
On 07/05/12 17:53, Bart Van Assche wrote: On 07/05/12 01:52, Nicholas A. Bellinger wrote: fio randrw workload | virtio-scsi-raw | virtio-scsi+tcm_vhost | bare-metal raw block 25 Write / 75 Read | ~15K

Re: [PATCH V7 4/5] virtio-scsi: introduce multiqueue support

2013-03-25 Thread Bart Van Assche
On 03/23/13 12:28, Wanlong Gao wrote: +static struct virtio_scsi_vq *virtscsi_pick_vq(struct virtio_scsi *vscsi, + struct virtio_scsi_target_state *tgt) +{ + struct virtio_scsi_vq *vq; + unsigned long flags; + u32 queue_num; + +

Re: [PATCH] linux/types.h: enable endian checks for all sparse builds

2016-12-08 Thread Bart Van Assche
On 12/07/16 18:29, Michael S. Tsirkin wrote: > By now, linux is mostly endian-clean. Enabling endian-ness > checks for everyone produces about 200 new sparse warnings for me - > less than 10% over the 2000 sparse warnings already there. > > Not a big deal, OTOH enabling this helps people notice >

Re: [PATCH] linux/types.h: enable endian checks for all sparse builds

2016-12-08 Thread Bart Van Assche
On 12/07/16 21:54, Michael S. Tsirkin wrote: > On Thu, Dec 08, 2016 at 05:21:47AM +0000, Bart Van Assche wrote: >> Additionally, there are notable exceptions to the rule that most drivers >> are endian-clean, e.g. drivers/scsi/qla2xxx. I would appreciate it if it >> would rem

Re: [PATCH] linux/types.h: enable endian checks for all sparse builds

2016-12-09 Thread Bart Van Assche
On 12/08/16 22:40, Madhani, Himanshu wrote: > We’ll take a look and send patches to resolve these warnings. Thanks! Bart. ___ Virtualization mailing list Virtualization@lists.linux-foundation.org

Re: [PATCH 3/5] Move dma_ops from archdata into struct device

2016-12-09 Thread Bart Van Assche
On 12/09/2016 11:13 AM, David Woodhouse wrote: On Fri, 2016-12-09 at 19:22 +0100, Christoph Hellwig wrote: We'll need a bit of a wieder audience for this I think.. On Wed, Dec 07, 2016 at 05:11:28PM -0800, Bart Van Assche wrote: Additionally, introduce set_dma_ops(). A later patch

Re: 4.14: WARNING: CPU: 4 PID: 2895 at block/blk-mq.c:1144 with virtio-blk

2017-11-20 Thread Bart Van Assche
On Fri, 2017-11-17 at 15:42 +0100, Christian Borntraeger wrote: > This is > > b7a71e66d (Jens Axboe2017-08-01 09:28:24 -0600 1141) * > are mapped to it. > b7a71e66d (Jens Axboe2017-08-01 09:28:24 -0600 1142) */ > 6a83e74d2 (Bart Van Ass

Re: [PATCH] virtio-blk: Use kobj_to_dev() instead of container_of()

2020-08-20 Thread Bart Van Assche
On 2020-08-20 18:19, Tian Tao wrote: > Use kobj_to_dev() instead of container_of() Reviewed-by: Bart Van Assche ___ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/virtualization

Re: [PATCH 4/8] vhost scsi: fix cmd completion race

2020-09-21 Thread Bart Van Assche
On 2020-09-21 19:48, Bart Van Assche wrote: > On 2020-09-21 11:23, Mike Christie wrote: >> We might not do the final se_cmd put from vhost_scsi_complete_cmd_work. >> If the last put happens a little later then we could race where >> vhost_scsi_complete_cmd_work does vhost_s

Re: [PATCH 2/8] vhost: add helper to check if a vq has been setup

2020-09-21 Thread Bart Van Assche
On 2020-09-21 11:23, Mike Christie wrote: > +bool vhost_vq_is_setup(struct vhost_virtqueue *vq) > +{ > + if (vq->avail && vq->desc && vq->used && vhost_vq_access_ok(vq)) > + return true; > + else > + return false; > +} Has it been considered changing the body of

Re: [PATCH 4/8] vhost scsi: fix cmd completion race

2020-09-21 Thread Bart Van Assche
On 2020-09-21 11:23, Mike Christie wrote: > We might not do the final se_cmd put from vhost_scsi_complete_cmd_work. > If the last put happens a little later then we could race where > vhost_scsi_complete_cmd_work does vhost_signal, the guest runs and sends > more IO, and vhost_scsi_handle_vq runs