Re: A set of standard virtual devices?

2007-04-03 Thread Cornelia Huck
On Tue, 3 Apr 2007 11:41:49 +0200, Arnd Bergmann [EMAIL PROTECTED] wrote: On Tuesday 03 April 2007, H. Peter Anvin wrote: However, one probably wants to think about what the heck one actually means with virtualization in the absence of a lot of this stuff.  PCI is probably the closest

Re: A set of standard virtual devices?

2007-04-03 Thread Cornelia Huck
On Tue, 3 Apr 2007 11:26:52 +0200, Andi Kleen [EMAIL PROTECTED] wrote: On s390, it would be more than strangeness. There's no implementation of PCI at all, someone would have to cook it up - and it wouldn't have any use beyond those special devices. Since there isn't any bus type that

Re: [PATCH 5/6] kvm-s390: use register_virtio_root_device()

2008-12-11 Thread Cornelia Huck
On Thu, 11 Dec 2008 10:05:49 +0100, Christian Borntraeger [EMAIL PROTECTED] wrote: Am Mittwoch, 10. Dezember 2008 schrieb Mark McLoughlin: This is basically a no-op change, since it does exactly the same thing as s390_root_dev_register() when the caller isn't a module. Ok, I gave it a

Re: [PATCH 2/6] virtio: add register_virtio_root_device()

2008-12-11 Thread Cornelia Huck
On Wed, 10 Dec 2008 17:45:35 +, Mark McLoughlin [EMAIL PROTECTED] wrote: Add a function to allocate a root device object to group the devices from a given virtio implementation. Also add a 'module' sysfs symlink to allow so that userspace can generically determine which virtio

Re: [PATCH 1/4] driver core: add root_device_register()

2008-12-11 Thread Cornelia Huck
On Thu, 11 Dec 2008 16:16:53 +, Mark McLoughlin [EMAIL PROTECTED] wrote: Add support for allocating root device objects which group device objects under /sys/devices directories. Also add a sysfs 'module' symlink which points to the owner of the root device object. This will be used in

Re: [PATCH 1/4] driver core: add root_device_register()

2008-12-12 Thread Cornelia Huck
On Thu, 11 Dec 2008 18:23:27 +, Mark McLoughlin mar...@redhat.com wrote: diff --git a/drivers/base/core.c b/drivers/base/core.c index 8c2cc26..20e5825 100644 --- a/drivers/base/core.c +++ b/drivers/base/core.c @@ -1196,6 +1196,93 @@ EXPORT_SYMBOL_GPL(put_device);

Re: [PATCH 1/4] driver core: add root_device_register()

2008-12-12 Thread Cornelia Huck
will be used in virtio to allow userspace to determine which virtio bus implementation a given device is associated with. [Includes suggestions from Cornelia Huck] Signed-off-by: Mark McLoughlin mar...@redhat.com Acked-by: Cornelia Huck cornelia.h...@de.ibm.com --- drivers/base/core.c

Re: [PATCH 4/4] s390: remove s390_root_dev_*()

2008-12-12 Thread Cornelia Huck
On Thu, 11 Dec 2008 18:00:25 +0100, Cornelia Huck cornelia.h...@de.ibm.com wrote: On Thu, 11 Dec 2008 16:16:56 +, Mark McLoughlin mar...@redhat.com wrote: Replace s390_root_dev_register() with root_device_register() etc. Nice, one more special case generalized :) I'll give it a run

Re: [PATCH 4/4] s390: remove s390_root_dev_*()

2008-12-12 Thread Cornelia Huck
On Fri, 12 Dec 2008 09:35:46 +, Mark McLoughlin mar...@redhat.com wrote: From: Mark McLoughlin mar...@redhat.com Subject: [PATCH] s390: remove s390_root_dev_*() Replace s390_root_dev_register() with root_device_register() etc. [Includes fix from Cornelia Huck] Signed-off-by: Mark

Re: Proposal for virtio standardization.

2012-10-09 Thread Cornelia Huck
On Thu, 27 Sep 2012 09:59:33 +0930 Rusty Russell ru...@rustcorp.com.au wrote: Hi all, I've had several requests for a more formal approach to the virtio draft spec, and (after some soul-searching) I'd like to try that. The proposal is to use OASIS as the standards body, as

Re: [PATCH 0/3] virtio-net: inline header support

2012-10-12 Thread Cornelia Huck
On Fri, 12 Oct 2012 09:07:46 +1030 Rusty Russell ru...@rustcorp.com.au wrote: Michael S. Tsirkin m...@redhat.com writes: On Thu, Oct 11, 2012 at 10:33:31AM +1030, Rusty Russell wrote: OK. Well, Anthony wants qemu to be robust in this regard, so I am tempted to rework all the qemu drivers

[PATCH] virtio: Don't access index after unregister.

2012-11-08 Thread Cornelia Huck
to release before calling device_unregister(). Signed-off-by: Cornelia Huck cornelia.h...@de.ibm.com --- drivers/virtio/virtio.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/virtio/virtio.c b/drivers/virtio/virtio.c index 1e8659c..809b0de 100644 --- a/drivers/virtio

Re: [PATCH v3 0/5] kvm: Make ioeventfd usable on s390.

2013-02-26 Thread Cornelia Huck
On Tue, 26 Feb 2013 13:13:39 +0100 Christian Borntraeger borntrae...@de.ibm.com wrote: On 26/02/13 12:18, Michael S. Tsirkin wrote: virtio_ccw: pass a cookie value to kvm hypercall Lookups by channel/vq pair on host during virtio notifications might be expensive. Interpret hypercall

Re: [PATCH v3 0/5] kvm: Make ioeventfd usable on s390.

2013-02-26 Thread Cornelia Huck
On Tue, 26 Feb 2013 15:56:43 +0200 Michael S. Tsirkin m...@redhat.com wrote: On Tue, Feb 26, 2013 at 02:29:07PM +0100, Cornelia Huck wrote: On Tue, 26 Feb 2013 13:13:39 +0100 Christian Borntraeger borntrae...@de.ibm.com wrote: On 26/02/13 12:18, Michael S. Tsirkin wrote: virtio_ccw

Re: [PATCH 03/22] virtio_config: make transports implement accessors.

2013-03-21 Thread Cornelia Huck
On Thu, 21 Mar 2013 18:59:24 +1030 Rusty Russell ru...@rustcorp.com.au wrote: All transports just pass through at the moment. Cc: Ohad Ben-Cohen o...@wizery.com Cc: Brian Swetland swetl...@google.com Cc: Cornelia Huck cornelia.h...@de.ibm.com Cc: Pawel Moll pawel.m...@arm.com Cc

Re: [PATCH 05/22] virtio: add support for 64 bit features.

2013-03-21 Thread Cornelia Huck
On Thu, 21 Mar 2013 18:59:26 +1030 Rusty Russell ru...@rustcorp.com.au wrote: Change the u32 to a u64, and make sure to use 1ULL everywhere! Cc: Ohad Ben-Cohen o...@wizery.com Cc: Brian Swetland swetl...@google.com Cc: Cornelia Huck cornelia.h...@de.ibm.com Cc: Pawel Moll pawel.m

Re: [PATCH 03/22] virtio_config: make transports implement accessors.

2013-03-22 Thread Cornelia Huck
On Fri, 22 Mar 2013 11:01:20 +1030 Rusty Russell ru...@rustcorp.com.au wrote: Nice understatement. I guess you know where I cut pasted from... Here is the updated version. Looks sane to me. Thanks, Rusty. diff --git a/drivers/s390/kvm/kvm_virtio.c b/drivers/s390/kvm/kvm_virtio.c

Re: [PATCH 05/22] virtio: add support for 64 bit features.

2013-03-22 Thread Cornelia Huck
On Fri, 22 Mar 2013 11:20:05 +1030 Rusty Russell ru...@rustcorp.com.au wrote: Cornelia Huck cornelia.h...@de.ibm.com writes: On Thu, 21 Mar 2013 18:59:26 +1030 Rusty Russell ru...@rustcorp.com.au wrote: Change the u32 to a u64, and make sure to use 1ULL everywhere! And a not-even

Re: [PATCH] KVM: Fix kvm_irqfd_init initialization

2013-05-07 Thread Cornelia Huck
on the error handling path. This way, the kvm_irqfd system will not be ready. Since we can't have the initialization as kvm module init function without forcing everyone to split modules, this is probably the best way to handle this. Acked-by: Cornelia Huck cornelia.h...@de.ibm.com This patch fix

Re: [PATCH v2] KVM: Fix kvm_irqfd_init initialization

2013-05-08 Thread Cornelia Huck
---[ end trace 13fb1e4b6e5ab21f ]--- Signed-off-by: Asias He as...@redhat.com Acked-by: Cornelia Huck cornelia.h...@de.ibm.com --- virt/kvm/kvm_main.c | 18 +- 1 file changed, 13 insertions(+), 5 deletions(-) diff --git a/virt/kvm/kvm_main.c b/virt/kvm/kvm_main.c index

[RFC PATCH v2] virtio-ccw: Document adapter interrupts.

2013-07-09 Thread Cornelia Huck
Signed-off-by: Cornelia Huck cornelia.h...@de.ibm.com --- virtio-spec.lyx | 147 +-- 1 file changed, 144 insertions(+), 3 deletions(-) diff --git a/virtio-spec.lyx b/virtio-spec.lyx index c920155..4729766 100644 --- a/virtio-spec.lyx +++ b

[RFC PATCH v2] Adapter interrupts for virtio-ccw.

2013-07-09 Thread Cornelia Huck
Hi, here's again my proposal for adapter (thin) interrupt support for virtio-ccw devices, originally posted at http://marc.info/?l=linux-virtualizationm=137060143904927w=2 The document is unchanged, only rebased against current master. Cornelia Huck (1): virtio-ccw: Document adapter

[RFC PATCH v2] qemu: Adapter interrupts for virtio-ccw.

2013-07-09 Thread Cornelia Huck
Hi, here's the current implementation of virtio-ccw adapter interrupts in qemu. Code is unchanged, only rebased against current master. Cornelia Huck (1): s390/virtio-ccw: Adapter interrupt support. hw/s390x/css.c| 10 hw/s390x/css.h|2 ++ hw/s390x/virtio

[RFC PATCH v2] s390/virtio-ccw: Adapter interrupt support.

2013-07-09 Thread Cornelia Huck
. Signed-off-by: Cornelia Huck cornelia.h...@de.ibm.com --- hw/s390x/css.c| 10 hw/s390x/css.h|2 ++ hw/s390x/virtio-ccw.c | 64 - hw/s390x/virtio-ccw.h |4 target-s390x/ioinst.h |2 ++ target-s390x/kvm.c

[RFC PATCH v2 0/2] KVM: s390: virtio-ccw adapter interrupts.

2013-07-09 Thread Cornelia Huck
Hi, next version of the guest exploitation of virtio-ccw adapter interrupts. Changes from the last version: - adapt to latest kvm-next - changed housekeeping for indicator locations: we now use cacheline-sized and aligned areas - minor tweaks Cornelia Huck (2): KVM: s390: virtio-ccw

[RFC PATCH v2 1/2] KVM: s390: virtio-ccw: Handle command rejects.

2013-07-09 Thread Cornelia Huck
A command reject for a ccw may happen if we run on a host not supporting a certain feature. We want to be able to handle this as special case of command failure, so let's split this off from the generic -EIO error code. Signed-off-by: Cornelia Huck cornelia.h...@de.ibm.com --- drivers/s390/kvm

[RFC PATCH v2 2/2] KVM: s390: virtio-ccw adapter interrupt support.

2013-07-09 Thread Cornelia Huck
a summary indicator for all devices sharing the same indicator area. Indicator bits for the individual virtqueues may be contained in the same indicator area for different devices. Signed-off-by: Cornelia Huck cornelia.h...@de.ibm.com --- arch/s390/include/asm/irq.h | 1 + arch/s390/kernel/irq.c

Re: [RFC PATCH v2] s390/virtio-ccw: Adapter interrupt support.

2013-07-09 Thread Cornelia Huck
On Tue, 09 Jul 2013 15:27:14 +0200 Christian Borntraeger borntrae...@de.ibm.com wrote: On 09/07/13 13:34, Cornelia Huck wrote: Handle the new CCW_CMD_SET_IND_ADAPTER command enabling adapter interrupts on guest request. When active, host-guest notifications will be handled via

Re: [PATCH 0/3] virtio: Clean up scatterlists and use the DMA API

2014-08-27 Thread Cornelia Huck
On Tue, 26 Aug 2014 14:16:59 -0700 Andy Lutomirski l...@amacapital.net wrote: This fixes virtio on Xen guests as well as on any other platform on which physical addresses don't match bus addresses. This can be tested with: virtme-run --xen xen --kimg arch/x86/boot/bzImage --console

Re: [PATCH 02/16] virtio: unify config_changed handling

2014-10-06 Thread Cornelia Huck
++ drivers/virtio/virtio_mmio.c | 7 ++- drivers/virtio/virtio_pci.c| 6 +- 7 files changed, 18 insertions(+), 28 deletions(-) Reviewed-by: Cornelia Huck cornelia.h...@de.ibm.com ___ Virtualization mailing list Virtualization

Re: [PATCH 03/16] virtio: refactor to use drv_to_virtio

2014-10-06 Thread Cornelia Huck
On Sun, 5 Oct 2014 19:06:59 +0300 Michael S. Tsirkin m...@redhat.com wrote: Use drv_to_virtio instead of open-coding it. Fix whitespace damage introduced by virtio: unify config_changed handling Would it make sense to merge this into the previous patch? Signed-off-by: Michael S.

Re: [PATCH 04/16] virtio-pci: move freeze/restore to virtio core

2014-10-06 Thread Cornelia Huck
the current 'failed' status of the device. What about 'saved_failed'? Otherwise, moving this into common virtio code makes sense. Reviewed-by: Cornelia Huck cornelia.h...@de.ibm.com ___ Virtualization mailing list Virtualization@lists.linux-foundation.org

Re: [PATCH 05/16] virtio: defer config changed notifications

2014-10-06 Thread Cornelia Huck
On Sun, 5 Oct 2014 19:07:05 +0300 Michael S. Tsirkin m...@redhat.com wrote: Defer config changed notifications that arrive during probe/scan/freeze/restore. This will allow drivers to set DRIVER_OK earlier, without worrying about racing with config change interrupts. This change will

Re: [PATCH 06/16] virtio_blk: drop config_enable

2014-10-06 Thread Cornelia Huck
On Sun, 5 Oct 2014 19:07:07 +0300 Michael S. Tsirkin m...@redhat.com wrote: Now that virtio core ensures config changes don't arrive during probing, drop config_enable flag in virtio blk. On removal, flush is now sufficient to guarantee that no change work is queued. This help simplify

Re: [PATCH 07/16] virtio-blk: drop config_mutex

2014-10-06 Thread Cornelia Huck
workqueues non-reentrant all workqueues are non-reentrant, and config_enable is now gone. Get rid of the unnecessary lock. Signed-off-by: Michael S. Tsirkin m...@redhat.com --- drivers/block/virtio_blk.c | 8 1 file changed, 8 deletions(-) Reviewed-by: Cornelia Huck cornelia.h

Re: [PATCH 09/16] virtio-net: drop config_mutex

2014-10-06 Thread Cornelia Huck
: - mutex_unlock(vi-config_lock); + return; } static void virtnet_config_changed(struct virtio_device *vdev) I'd probably return directly in the remaining 'goto done;' cases, but still Reviewed-by: Cornelia Huck cornelia.h...@de.ibm.com

Re: [PATCH 11/16] virtio_net: minor cleanup

2014-10-06 Thread Cornelia Huck
++ 1 file changed, 2 insertions(+), 4 deletions(-) If you don't want to merge it into the mutex removal patch, maybe move it one up in the series? Acked-by: Cornelia Huck cornelia.h...@de.ibm.com ___ Virtualization mailing list Virtualization

Re: [PATCH 06/16] virtio_blk: drop config_enable

2014-10-06 Thread Cornelia Huck
On Mon, 6 Oct 2014 15:09:53 +0300 Michael S. Tsirkin m...@redhat.com wrote: On Mon, Oct 06, 2014 at 01:42:29PM +0200, Cornelia Huck wrote: On Sun, 5 Oct 2014 19:07:07 +0300 Michael S. Tsirkin m...@redhat.com wrote: Now that virtio core ensures config changes don't arrive during

Re: [PATCH 06/16] virtio_blk: drop config_enable

2014-10-06 Thread Cornelia Huck
On Mon, 6 Oct 2014 15:31:10 +0300 Michael S. Tsirkin m...@redhat.com wrote: On Mon, Oct 06, 2014 at 02:20:38PM +0200, Cornelia Huck wrote: On Mon, 6 Oct 2014 15:09:53 +0300 Michael S. Tsirkin m...@redhat.com wrote: On Mon, Oct 06, 2014 at 01:42:29PM +0200, Cornelia Huck wrote

Re: [PATCH 10/16] virtio: add API to enable VQs early

2014-10-06 Thread Cornelia Huck
On Sun, 5 Oct 2014 19:07:19 +0300 Michael S. Tsirkin m...@redhat.com wrote: virtio spec requires DRIVER_OK to be set before VQs are used, but some drivers use VQs before probe function returns. Since DRIVER_OK is set after probe, this violates the spec. Even though transitional devices

Re: [PATCH 16/16] virtio_net: fix use after free on allocation failure

2014-10-06 Thread Cornelia Huck
device first - same as we do on device removal. Signed-off-by: Michael S. Tsirkin m...@redhat.com --- drivers/net/virtio_net.c | 2 ++ 1 file changed, 2 insertions(+) Reviewed-by: Cornelia Huck cornelia.h...@de.ibm.com ___ Virtualization mailing

Re: [PATCH v2 02/15] virtio: unify config_changed handling

2014-10-06 Thread Cornelia Huck
+ drivers/virtio/virtio_mmio.c | 7 ++- drivers/virtio/virtio_pci.c| 6 +- 7 files changed, 17 insertions(+), 28 deletions(-) Reviewed-by: Cornelia Huck cornelia.h...@de.ibm.com ___ Virtualization mailing list Virtualization@lists.linux

Re: [PATCH v2 03/15] virtio-pci: move freeze/restore to virtio core

2014-10-06 Thread Cornelia Huck
for CONFIG_S_FAILED bit (for restore) Have you considered s/failed/saved_failed/ ? * @dev: underlying device. * @id: the device type identification (used to match it with a driver). * @config: the configuration ops for this device. Otherwise, my Reviewed-by: Cornelia Huck cornelia.h

Re: [PATCH v2 04/15] virtio: defer config changed notifications

2014-10-06 Thread Cornelia Huck
++ drivers/virtio/virtio.c | 57 + 2 files changed, 54 insertions(+), 9 deletions(-) Reviewed-by: Cornelia Huck cornelia.h...@de.ibm.com ___ Virtualization mailing list Virtualization@lists.linux

Re: [PATCH v2 05/15] virtio_blk: drop config_enable

2014-10-06 Thread Cornelia Huck
the driver, and will allow setting DRIVER_OK earlier without losing config change notifications. Signed-off-by: Michael S. Tsirkin m...@redhat.com --- drivers/block/virtio_blk.c | 23 --- 1 file changed, 4 insertions(+), 19 deletions(-) Reviewed-by: Cornelia Huck

Re: [PATCH v2 07/15] virtio_net: drop config_enable

2014-10-06 Thread Cornelia Huck
the driver, and will allow setting DRIVER_OK earlier without losing config change notifications. Signed-off-by: Michael S. Tsirkin m...@redhat.com --- drivers/net/virtio_net.c | 27 --- 1 file changed, 4 insertions(+), 23 deletions(-) Reviewed-by: Cornelia Huck

Re: [PATCH v2 10/15] virtio: add API to enable VQs early

2014-10-06 Thread Cornelia Huck
...@redhat.com --- include/linux/virtio_config.h | 17 + 1 file changed, 17 insertions(+) Reviewed-by: Cornelia Huck cornelia.h...@de.ibm.com ___ Virtualization mailing list Virtualization@lists.linux-foundation.org https

Re: [PATCH v2 03/15] virtio-pci: move freeze/restore to virtio core

2014-10-06 Thread Cornelia Huck
On Mon, 6 Oct 2014 18:26:55 +0300 Michael S. Tsirkin m...@redhat.com wrote: On Mon, Oct 06, 2014 at 05:20:55PM +0200, Cornelia Huck wrote: On Mon, 6 Oct 2014 18:10:51 +0300 Michael S. Tsirkin m...@redhat.com wrote: This is in preparation to extending config changed event handling

Re: [PATCH v2 11/15] virtio_net: enable VQs early

2014-10-06 Thread Cornelia Huck
before using VQs. Signed-off-by: Michael S. Tsirkin m...@redhat.com --- drivers/net/virtio_net.c | 2 ++ 1 file changed, 2 insertions(+) Reviewed-by: Cornelia Huck cornelia.h...@de.ibm.com ___ Virtualization mailing list Virtualization@lists.linux

Re: [PATCH v2 12/15] virtio_blk: enable VQs early

2014-10-06 Thread Cornelia Huck
. To fix, call virtio_enable_vqs_early before using VQs. Signed-off-by: Michael S. Tsirkin m...@redhat.com --- drivers/block/virtio_blk.c | 2 ++ 1 file changed, 2 insertions(+) Reviewed-by: Cornelia Huck cornelia.h...@de.ibm.com

[PATCH RFC 00/11] qemu: towards virtio-1 host support

2014-10-07 Thread Cornelia Huck
like to know whether I walk into the right direction, so let's consider this as a starting point. Cornelia Huck (8): virtio: cull virtio_bus_set_vdev_features virtio: support more feature bits s390x/virtio-ccw: fix check for WRITE_FEAT virtio: introduce legacy virtio devices virtio: allow

[PATCH RFC 01/11] virtio: use u32, not bitmap for struct virtio_device's features

2014-10-07 Thread Cornelia Huck
...@rustcorp.com.au Signed-off-by: Cornelia Huck cornelia.h...@de.ibm.com Acked-by: Pawel Moll pawel.m...@arm.com Acked-by: Ohad Ben-Cohen o...@wizery.com --- drivers/char/virtio_console.c |2 +- drivers/lguest/lguest_device.c |8 drivers/remoteproc/remoteproc_virtio.c

[PATCH RFC 05/11] virtio_config: endian conversion for v1.0.

2014-10-07 Thread Cornelia Huck
From: Rusty Russell ru...@rustcorp.com.au Reviewed-by: David Hildenbrand d...@linux.vnet.ibm.com Signed-off-by: Rusty Russell ru...@rustcorp.com.au Signed-off-by: Cornelia Huck cornelia.h...@de.ibm.com --- include/linux/virtio_config.h |9 ++--- 1 file changed, 6 insertions(+), 3

[PATCH RFC 06/11] virtio: allow virtio-1 queue layout

2014-10-07 Thread Cornelia Huck
For virtio-1 devices, we allow a more complex queue layout that doesn't require descriptor table and rings on a physically-contigous memory area: add virtio_queue_set_rings() to allow transports to set this up. Signed-off-by: Cornelia Huck cornelia.h...@de.ibm.com --- hw/virtio/virtio.c

[PATCH RFC 10/11] KVM: s390: virtio-ccw revision 1 SET_VQ

2014-10-07 Thread Cornelia Huck
The CCW_CMD_SET_VQ command has a different format for revision 1+ devices, allowing to specify a more complex virtqueue layout. For now, we stay however with the old layout and simply use the new command format for virtio-1 devices. Signed-off-by: Cornelia Huck cornelia.h...@de.ibm.com

[PATCH RFC 09/11] s390x/virtio-ccw: add virtio set-revision call

2014-10-07 Thread Cornelia Huck
-by: Thomas Huth th...@linux.vnet.ibm.com Signed-off-by: Cornelia Huck cornelia.h...@de.ibm.com --- hw/s390x/virtio-ccw.c | 54 + hw/s390x/virtio-ccw.h |7 ++- 2 files changed, 60 insertions(+), 1 deletion(-) diff --git a/hw/s390x/virtio-ccw.c b

[PATCH RFC 02/11] virtio: cull virtio_bus_set_vdev_features

2014-10-07 Thread Cornelia Huck
The only user of this function was virtio-ccw, and it should use virtio_set_features() like everybody else: We need to make sure that bad features are masked out properly, which this function did not do. Reviewed-by: Thomas Huth th...@linux.vnet.ibm.com Signed-off-by: Cornelia Huck cornelia.h

[PATCH RFC 07/11] dataplane: allow virtio-1 devices

2014-10-07 Thread Cornelia Huck
Handle endianness conversion for virtio-1 virtqueues correctly. Note that dataplane now needs to be built per-target. Signed-off-by: Cornelia Huck cornelia.h...@de.ibm.com --- hw/block/dataplane/virtio-blk.c |3 +- hw/scsi/virtio-scsi-dataplane.c |2 +- hw/virtio/Makefile.objs

[PATCH RFC 07/11] virtio_net: use v1.0 endian.

2014-10-07 Thread Cornelia Huck
From: Rusty Russell ru...@rustcorp.com.au [Cornelia Huck: converted some missed fields] Signed-off-by: Rusty Russell ru...@rustcorp.com.au Signed-off-by: Cornelia Huck cornelia.h...@de.ibm.com --- drivers/net/virtio_net.c | 31 +++ 1 file changed, 19 insertions

[PATCH RFC 05/11] virtio: introduce legacy virtio devices

2014-10-07 Thread Cornelia Huck
...@linux.vnet.ibm.com Signed-off-by: Cornelia Huck cornelia.h...@de.ibm.com --- hw/virtio/virtio.c|6 +- include/hw/virtio/virtio-access.h |4 include/hw/virtio/virtio.h| 13 +++-- 3 files changed, 20 insertions(+), 3 deletions(-) diff --git a/hw

[PATCH RFC 02/11] virtio: add support for 64 bit features.

2014-10-07 Thread Cornelia Huck
-off-by: Cornelia Huck cornelia.h...@de.ibm.com Acked-by: Pawel Moll pawel.m...@arm.com Acked-by: Ohad Ben-Cohen o...@wizery.com --- drivers/char/virtio_console.c |2 +- drivers/lguest/lguest_device.c | 10 +- drivers/remoteproc/remoteproc_virtio.c |5

[PATCH RFC 03/11] virtio: endianess conversion helpers

2014-10-07 Thread Cornelia Huck
-by: Cornelia Huck cornelia.h...@de.ibm.com --- drivers/virtio/virtio.c|4 include/linux/virtio.h | 40 include/uapi/linux/virtio_config.h |3 +++ 3 files changed, 47 insertions(+) diff --git a/drivers/virtio/virtio.c b/drivers

[PATCH RFC 04/11] virtio_ring: implement endian reversal based on VERSION_1 feature.

2014-10-07 Thread Cornelia Huck
From: Rusty Russell ru...@rustcorp.com.au [Cornelia Huck: we don't need the vq-vring.num - vq-ring_mask change] Signed-off-by: Rusty Russell ru...@rustcorp.com.au Signed-off-by: Cornelia Huck cornelia.h...@de.ibm.com --- drivers/virtio/virtio_ring.c | 195

[PATCH RFC 10/11] s390x/virtio-ccw: support virtio-1 set_vq format

2014-10-07 Thread Cornelia Huck
Support the new CCW_CMD_SET_VQ format for virtio-1 devices. While we're at it, refactor the code a bit and enforce big endian fields (which had always been required, even for legacy). Reviewed-by: Thomas Huth th...@linux.vnet.ibm.com Signed-off-by: Cornelia Huck cornelia.h...@de.ibm.com --- hw

[PATCH RFC 08/11] virtio_blk: use virtio v1.0 endian

2014-10-07 Thread Cornelia Huck
Note that we care only about the fields still in use for virtio v1.0. Reviewed-by: Thomas Huth th...@linux.vnet.ibm.com Reviewed-by: David Hildenbrand d...@linux.vnet.ibm.com Signed-off-by: Cornelia Huck cornelia.h...@de.ibm.com --- drivers/block/virtio_blk.c |4 1 file changed, 4

[PATCH RFC 09/11] KVM: s390: Set virtio-ccw transport revision

2014-10-07 Thread Cornelia Huck
From: Thomas Huth th...@linux.vnet.ibm.com With the new SET-VIRTIO-REVISION command of the virtio 1.0 standard, we can now negotiate the virtio-ccw revision after setting a channel online. Note that we don't negotiate version 1 yet. [Cornelia Huck: reworked revision loop a bit] Reviewed

[PATCH RFC 11/11] s390x/virtio-ccw: enable virtio 1.0

2014-10-07 Thread Cornelia Huck
virtio-ccw should now have everything in place to operate virtio 1.0 devices, so let's enable revision 1. Signed-off-by: Cornelia Huck cornelia.h...@de.ibm.com --- hw/s390x/virtio-ccw.h |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/s390x/virtio-ccw.h b/hw/s390x/virtio

[PATCH RFC 03/11] virtio: support more feature bits

2014-10-07 Thread Cornelia Huck
field, so that all feature bits may be accessed (in chunks of 32 bits). vhost and migration have been ignored for now. Reviewed-by: Thomas Huth th...@linux.vnet.ibm.com Signed-off-by: Cornelia Huck cornelia.h...@de.ibm.com --- hw/9pfs/virtio-9p-device.c |7 ++- hw/block/virtio-blk.c

[PATCH RFC 04/11] s390x/virtio-ccw: fix check for WRITE_FEAT

2014-10-07 Thread Cornelia Huck
We need to check guest feature size, not host feature size to find out whether we should call virtio_set_features(). This check is possible now that vdev-guest_features is an array. Reviewed-by: Thomas Huth th...@linux.vnet.ibm.com Signed-off-by: Cornelia Huck cornelia.h...@de.ibm.com --- hw

[PATCH RFC 08/11] s390x/css: Add a callback for when subchannel gets disabled

2014-10-07 Thread Cornelia Huck
From: Thomas Huth th...@linux.vnet.ibm.com We need a possibility to run code when a subchannel gets disabled. This patch adds the necessary infrastructure. Signed-off-by: Thomas Huth th...@linux.vnet.ibm.com Signed-off-by: Cornelia Huck cornelia.h...@de.ibm.com --- hw/s390x/css.c | 12

Re: [PATCH RFC 00/11] qemu: towards virtio-1 host support

2014-10-08 Thread Cornelia Huck
On Tue, 07 Oct 2014 18:24:22 -0700 Andy Lutomirski l...@amacapital.net wrote: On 10/07/2014 07:39 AM, Cornelia Huck wrote: This patchset aims to get us some way to implement virtio-1 compliant and transitional devices in qemu. Branch available at git://github.com/cohuck/qemu virtio-1

Re: [PATCH RFC 08/11] virtio_blk: use virtio v1.0 endian

2014-10-13 Thread Cornelia Huck
On Mon, 13 Oct 2014 16:28:32 +1030 Rusty Russell ru...@rustcorp.com.au wrote: Cornelia Huck cornelia.h...@de.ibm.com writes: Note that we care only about the fields still in use for virtio v1.0. Reviewed-by: Thomas Huth th...@linux.vnet.ibm.com Reviewed-by: David Hildenbrand d

Re: [PATCH RFC 03/11] virtio: support more feature bits

2014-10-13 Thread Cornelia Huck
On Mon, 13 Oct 2014 16:23:58 +1030 Rusty Russell ru...@rustcorp.com.au wrote: Cornelia Huck cornelia.h...@de.ibm.com writes: With virtio-1, we support more than 32 feature bits. Let's make vdev-guest_features depend on the number of supported feature bits, allowing us to grow the feature

Re: [PATCH] virtio_ccw: remove unsued variable

2014-10-20 Thread Cornelia Huck
| 1 - 1 file changed, 1 deletion(-) Acked-by: Cornelia Huck cornelia.h...@de.ibm.com Rusty: Will you take this through the virtio tree, or should I push this through the kvm/s390 tree? ___ Virtualization mailing list Virtualization@lists.linux

Re: [PATCH v4 13/25] virtio_console: enable VQs early

2014-10-20 Thread Cornelia Huck
On Mon, 20 Oct 2014 13:07:50 +0100 Thomas Graf tg...@suug.ch wrote: On 10/13/14 at 10:50am, Michael S. Tsirkin wrote: virtio spec requires drivers to set DRIVER_OK before using VQs. This is set automatically after probe returns, virtio console violated this rule by adding inbufs, which

[PATCH] virtio_console: move early VQ enablement

2014-10-20 Thread Cornelia Huck
move virtio_device_ready() to the probe function just before trying to use the virtqueues instead. This is fine as nothing can fail inbetween. Reported-by: Thomas Graf tg...@suug.ch Reviewed-by: Michael S. Tsirkin m...@redhat.com Signed-off-by: Cornelia Huck cornelia.h...@de.ibm.com --- drivers

Re: [PATCH RFC] virtio 1.0 vring endian-ness

2014-10-22 Thread Cornelia Huck
On Wed, 22 Oct 2014 01:09:40 +0300 Michael S. Tsirkin m...@redhat.com wrote: This adds wrappers to switch between native endian-ness (virtio 0.9) and virtio endian-ness (virtio 1.0). Add new typedefs as well, so that we can check statically that we didn't miss any accesses. All callers

Re: [PATCH RFC 04/11] virtio_ring: implement endian reversal based on VERSION_1 feature.

2014-10-22 Thread Cornelia Huck
On Wed, 22 Oct 2014 17:02:26 +0300 Michael S. Tsirkin m...@redhat.com wrote: On Tue, Oct 07, 2014 at 04:39:45PM +0200, Cornelia Huck wrote: From: Rusty Russell ru...@rustcorp.com.au [Cornelia Huck: we don't need the vq-vring.num - vq-ring_mask change] Signed-off-by: Rusty Russell ru

Re: [PATCH RFC v3 01/16] virtio: memory access APIs

2014-10-23 Thread Cornelia Huck
On Wed, 22 Oct 2014 21:44:08 +0300 Michael S. Tsirkin m...@redhat.com wrote: virtio 1.0 makes all memory structures LE, so we need APIs to conditionally do a byteswap on BE architectures. To make it easier to check code statically, add virtio specific types for multi-byte integers in

Re: [PATCH RFC v3 05/16] virtio: add virtio 1.0 feature bit

2014-10-23 Thread Cornelia Huck
On Wed, 22 Oct 2014 21:44:31 +0300 Michael S. Tsirkin m...@redhat.com wrote: Based on original patches by Rusty Russell, Thomas Huth and Cornelia Huck. Signed-off-by: Michael S. Tsirkin m...@redhat.com --- include/uapi/linux/virtio_config.h | 7 +-- drivers/virtio/virtio_ring.c

Re: [PATCH RFC v3 06/16] virtio: make endian-ness depend on virtio 1.0

2014-10-23 Thread Cornelia Huck
On Wed, 22 Oct 2014 21:44:34 +0300 Michael S. Tsirkin m...@redhat.com wrote: virtio 1.0 is LE, virtio without 1.0 is native endian. Signed-off-by: Michael S. Tsirkin m...@redhat.com --- include/linux/virtio_config.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) Looks sane.

Re: [PATCH RFC v3 09/16] virtio: set FEATURES_OK

2014-10-23 Thread Cornelia Huck
On Wed, 22 Oct 2014 21:44:44 +0300 Michael S. Tsirkin m...@redhat.com wrote: set FEATURES_OK as per virtio 1.0 spec Signed-off-by: Michael S. Tsirkin m...@redhat.com --- include/uapi/linux/virtio_config.h | 2 ++ drivers/virtio/virtio.c| 29 ++--- 2

Re: [PATCH RFC v3 09/16] virtio: set FEATURES_OK

2014-10-23 Thread Cornelia Huck
On Thu, 23 Oct 2014 15:51:39 +0300 Michael S. Tsirkin m...@redhat.com wrote: On Thu, Oct 23, 2014 at 02:28:08PM +0200, Cornelia Huck wrote: On Wed, 22 Oct 2014 21:44:44 +0300 Michael S. Tsirkin m...@redhat.com wrote: set FEATURES_OK as per virtio 1.0 spec Signed-off-by: Michael

Re: [PATCH RFC 00/11] qemu: towards virtio-1 host support

2014-10-24 Thread Cornelia Huck
On Fri, 24 Oct 2014 00:42:20 +0300 Michael S. Tsirkin m...@redhat.com wrote: On Tue, Oct 07, 2014 at 04:39:56PM +0200, Cornelia Huck wrote: This patchset aims to get us some way to implement virtio-1 compliant and transitional devices in qemu. Branch available at git://github.com/cohuck

Re: [PATCH RFC v4 07/17] virtio_config: endian conversion for v1.0

2014-10-24 Thread Cornelia Huck
On Thu, 23 Oct 2014 19:24:30 +0300 Michael S. Tsirkin m...@redhat.com wrote: We (ab)use virtio conversion functions for device-specific config space accesses. Reviewed-by: David Hildenbrand d...@linux.vnet.ibm.com Signed-off-by: Rusty Russell ru...@rustcorp.com.au Signed-off-by: Cornelia

Re: [PATCH RFC 00/11] qemu: towards virtio-1 host support

2014-10-24 Thread Cornelia Huck
On Fri, 24 Oct 2014 10:38:39 +0200 Cornelia Huck cornelia.h...@de.ibm.com wrote: On Fri, 24 Oct 2014 00:42:20 +0300 Michael S. Tsirkin m...@redhat.com wrote: On Tue, Oct 07, 2014 at 04:39:56PM +0200, Cornelia Huck wrote: This patchset aims to get us some way to implement virtio-1

Re: [Qemu-devel] [PATCH RFC 07/11] dataplane: allow virtio-1 devices

2014-10-30 Thread Cornelia Huck
On Tue, 28 Oct 2014 16:22:54 +0100 Greg Kurz gk...@linux.vnet.ibm.com wrote: On Tue, 7 Oct 2014 16:40:03 +0200 Cornelia Huck cornelia.h...@de.ibm.com wrote: Handle endianness conversion for virtio-1 virtqueues correctly. Note that dataplane now needs to be built per-target

Re: [PATCH RFC 00/11] qemu: towards virtio-1 host support

2014-10-30 Thread Cornelia Huck
On Tue, 28 Oct 2014 06:43:29 +0200 Michael S. Tsirkin m...@redhat.com wrote: On Fri, Oct 24, 2014 at 10:38:39AM +0200, Cornelia Huck wrote: On Fri, 24 Oct 2014 00:42:20 +0300 Michael S. Tsirkin m...@redhat.com wrote: On Tue, Oct 07, 2014 at 04:39:56PM +0200, Cornelia Huck wrote

Re: [PATCH] virtio_ccw: remove unsued variable

2014-10-30 Thread Cornelia Huck
/virtio_ccw.c:891:24: warning: unused variable ‘drv’ [-Wunused-variable] struct virtio_driver *drv; Signed-off-by: Sebastian Ott seb...@linux.vnet.ibm.com Acked-by: Cornelia Huck cornelia.h...@de.ibm.com Acked-by: Michael S. Tsirkin m...@redhat.com --- drivers/s390/kvm

Re: [Qemu-devel] [PATCH RFC 05/11] virtio: introduce legacy virtio devices

2014-10-30 Thread Cornelia Huck
On Tue, 28 Oct 2014 16:40:18 +0100 Greg Kurz gk...@linux.vnet.ibm.com wrote: On Tue, 7 Oct 2014 16:40:01 +0200 Cornelia Huck cornelia.h...@de.ibm.com wrote: Introduce a helper function to indicate whether a virtio device is operating in legacy or virtio standard mode. It may

Re: [PATCH] virtio_ccw: remove unsued variable

2014-10-31 Thread Cornelia Huck
On Fri, 31 Oct 2014 10:31:19 +1030 Rusty Russell ru...@rustcorp.com.au wrote: Cornelia Huck cornelia.h...@de.ibm.com writes: On Tue, 28 Oct 2014 19:37:58 +0200 Michael S. Tsirkin m...@redhat.com wrote: On Tue, Oct 28, 2014 at 04:39:12PM +0100, Sebastian Ott wrote: virtio_ccw: remove

Re: [Qemu-devel] [PATCH RFC 05/11] virtio: introduce legacy virtio devices

2014-11-03 Thread Cornelia Huck
On Thu, 30 Oct 2014 23:29:50 +0100 Greg Kurz gk...@linux.vnet.ibm.com wrote: On Thu, 30 Oct 2014 19:02:01 +0100 Cornelia Huck cornelia.h...@de.ibm.com wrote: On Tue, 28 Oct 2014 16:40:18 +0100 Greg Kurz gk...@linux.vnet.ibm.com wrote: On Tue, 7 Oct 2014 16:40:01 +0200 Cornelia

Re: [PATCH 1/2] virito: introduce methods of fixing device features

2014-11-13 Thread Cornelia Huck
On Thu, 13 Nov 2014 13:52:53 +0800 Jason Wang jasow...@redhat.com wrote: typo in subject-prefix: s/virito/virtio/ Buggy host may advertised buggy host features (a usual case is that host advertise a feature whose dependencies were missed). In this case, driver should detect and disable the

Re: [PATCH 2/2] virtio-net: fix buggy features advertised by host

2014-11-13 Thread Cornelia Huck
On Thu, 13 Nov 2014 13:52:54 +0800 Jason Wang jasow...@redhat.com wrote: This patch tries to detect the possible buggy features advertised by host and fix them. One example is booting virtio-net with only ctrl_vq disabled, qemu may still advertise many features which depends on it. This will

Re: [PATCH 1/2] virito: introduce methods of fixing device features

2014-11-13 Thread Cornelia Huck
On Thu, 13 Nov 2014 17:11:30 +0800 Jason Wang jasow...@redhat.com wrote: On 11/13/2014 04:46 PM, Cornelia Huck wrote: On Thu, 13 Nov 2014 13:52:53 +0800 Jason Wang jasow...@redhat.com wrote: +static inline void virtio_disable_feature(struct virtio_device *vdev

Re: [PATCH V3 1/2] virtio: introduce methods of sanitizing device features

2014-11-17 Thread Cornelia Huck
...@rustcorp.com.au Cc: Michael S. Tsirkin m...@redhat.com Cc: Cornelia Huck cornelia.h...@de.ibm.com Cc: Wanlong Gao gaowanl...@cn.fujitsu.com Signed-off-by: Jason Wang jasow...@redhat.com Hmm this conflicts with virtio 1.0 work: we drop features as bitmap there. But that's an implementation

Re: [PATCH V3 1/2] virtio: introduce methods of sanitizing device features

2014-11-17 Thread Cornelia Huck
On Mon, 17 Nov 2014 12:11:39 +0200 Michael S. Tsirkin m...@redhat.com wrote: On Mon, Nov 17, 2014 at 10:44:30AM +0100, Cornelia Huck wrote: On Mon, 17 Nov 2014 11:37:01 +0200 Michael S. Tsirkin m...@redhat.com wrote: On Mon, Nov 17, 2014 at 05:17:17PM +0800, Jason Wang wrote: Buggy

Re: [PATCH V3 1/2] virtio: introduce methods of sanitizing device features

2014-11-17 Thread Cornelia Huck
On Mon, 17 Nov 2014 12:28:49 +0200 Michael S. Tsirkin m...@redhat.com wrote: On Mon, Nov 17, 2014 at 11:20:48AM +0100, Cornelia Huck wrote: On Mon, 17 Nov 2014 12:11:39 +0200 Michael S. Tsirkin m...@redhat.com wrote: On Mon, Nov 17, 2014 at 10:44:30AM +0100, Cornelia Huck wrote

Re: [PATCH V2 net] virtio-net: validate features during probe

2014-11-19 Thread Cornelia Huck
with ctrl_vq=off through qemu. Cc: Rusty Russell ru...@rustcorp.com.au Cc: Michael S. Tsirkin m...@redhat.com Cc: Cornelia Huck cornelia.h...@de.ibm.com Cc: Wanlong Gao gaowanl...@cn.fujitsu.com Signed-off-by: Jason Wang jasow...@redhat.com --- Changes from V1: - Drop VIRTIO_NET_F_*_UFO

Re: [PATCH net V5] virtio-net: validate features during probe

2014-11-20 Thread Cornelia Huck
ru...@rustcorp.com.au Cc: Cornelia Huck cornelia.h...@de.ibm.com Cc: Wanlong Gao gaowanl...@cn.fujitsu.com Signed-off-by: Michael S. Tsirkin m...@redhat.com Signed-off-by: Jason Wang jasow...@redhat.com +static bool virtnet_validate_features(struct virtio_device *vdev

  1   2   3   4   5   6   7   >