Re: [PATCH] Add virtio gpu driver.

2015-03-24 Thread Daniel Vetter
On Tue, Mar 24, 2015 at 05:07:18PM +0100, Gerd Hoffmann wrote: From: Dave Airlie airl...@gmail.com This patch adds a kms driver for the virtio gpu. The xorg modesetting driver can handle the device just fine, the framebuffer for fbcon is there too. Qemu patches for the host side are

Re: [PATCH] Add virtio gpu driver.

2015-03-26 Thread Daniel Vetter
there and can help out. Cheers, Daniel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch ___ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/virtualization

Re: [PATCH] Add virtio gpu driver.

2015-03-30 Thread Daniel Vetter
yet. -Daniel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch ___ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/virtualization

Re: [PATCH 0/4] enable migration of driver pages

2015-07-29 Thread Daniel Vetter
series, so I think that's really what we should use to judge these patches. Of course then there's the seemingly eternal chicken/egg problem of upstream gpu drivers for SoCs :( -Daniel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch

Re: [PATCH 0/4] enable migration of driver pages

2015-07-29 Thread Daniel Vetter
On Wed, Jul 29, 2015 at 01:16:14PM +0100, Mel Gorman wrote: On Wed, Jul 29, 2015 at 12:55:54PM +0200, Daniel Vetter wrote: On Wed, Jul 29, 2015 at 11:49:45AM +0100, Mel Gorman wrote: On Mon, Jul 13, 2015 at 05:35:15PM +0900, Gioh Kim wrote: My ARM-based platform occured severe

Re: [RFCv3 0/5] enable migration of driver pages

2015-07-09 Thread Daniel Vetter
there's a bit a lack of gpu drivers from the arm world in upstream, which is probabyl why this patch series doesn't come with a user. Might be better to first upstream the driver before talking about additional infrastructure that it needs. -Daniel -- Daniel Vetter Software Engineer, Intel

Re: [PATCH v2 5/6] virtio-gpu: add basic prime support

2015-09-22 Thread Daniel Vetter
abuse, e.g. we already use -ENOENT to signal any kind of lookup failure in ioctls (even if the fd itself is obviously there so not possible that the fd isn't there). Cheers, Daniel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch _

Re: [PATCH v2 5/6] virtio-gpu: add basic prime support

2015-09-22 Thread Daniel Vetter
> +} > + > +void virtgpu_gem_prime_vunmap(struct drm_gem_object *obj, void *vaddr) > +{ > + WARN_ONCE(1, "not implemented"); > +} > + > +int virtgpu_gem_prime_mmap(struct drm_gem_object *obj, > +struct vm_area_struct *area)

Re: [PATCH 01/20] drm/atomic: Fix remaining places where !funcs->best_encoder is valid

2016-06-02 Thread Daniel Vetter
lper. >> + */ >> + if (fb_helper->dev->mode_config.funcs->atomic_commit && >> + !connector_funcs->best_encoder) >> + encoder = drm_atomic_helper_best_encoder(connector); >> + else >> + encoder = conn

Re: [PATCH 01/20] drm/atomic: Fix remaining places where !funcs->best_encoder is valid

2016-06-03 Thread Daniel Vetter
On Fri, Jun 03, 2016 at 09:37:43AM +0200, Boris Brezillon wrote: > On Thu, 2 Jun 2016 23:57:02 +0200 > Daniel Vetter <dan...@ffwll.ch> wrote: > > > On Thu, Jun 2, 2016 at 11:05 PM, Laurent Pinchart > > <laurent.pinch...@ideasonboard.com> wrote: > > > Hi

Re: [PATCH v2 01/20] drm/atomic: Fix remaining places where !funcs->best_encoder is valid

2016-06-07 Thread Daniel Vetter
@best_encoder is required. > + * This function is used by drm_atomic_helper_check_modeset(). > + * If it is not implemented, the core will fallback to @best_encoder > + * (or drm_atomic_helper_best_encoder() if @best_encoder is NULL). >* >* NOTE: >* > -- > 2.7.4 > -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch ___ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/virtualization

Re: [PATCH v2 06/20] drm: i915: Rely on the default ->best_encoder() behavior where appropriate

2016-06-10 Thread Daniel Vetter
On Fri, Jun 10, 2016 at 05:24:12PM +0200, Daniel Vetter wrote: > On Tue, Jun 07, 2016 at 01:48:01PM +0200, Boris Brezillon wrote: > > For all outputs except dp_mst, we have a 1:1 relationship between > > connectors and encoders and the driver is relying on the atomic helpers:

Re: [PATCH v2 00/20] drm/atomic: Provide default ->best_encoder() behavior

2016-06-10 Thread Daniel Vetter
gra/hdmi.c | 1 - > drivers/gpu/drm/tegra/output.c | 8 > drivers/gpu/drm/tegra/rgb.c| 1 - > drivers/gpu/drm/tegra/sor.c | 1 - > drivers/gpu/drm/vc4/vc

Re: [PATCH v3 7/7] [wip] virtio-gpu: add page flip support

2016-05-30 Thread Daniel Vetter
On Fri, May 27, 2016 at 09:50:27AM +0200, Daniel Vetter wrote: > On Fri, May 27, 2016 at 09:46:03AM +0200, Gerd Hoffmann wrote: > > On Mi, 2016-05-25 at 18:37 +0200, Daniel Vetter wrote: > > > On Fri, Oct 2, 2015 at 1:58 PM, Gerd Hoffmann <kra...@redhat.com> wrote: >

Re: [PATCH v3 7/7] [wip] virtio-gpu: add page flip support

2016-05-30 Thread Daniel Vetter
g the old crtc is definitely not what you want. Another option is that virtio isn't happy about bashing in plane state for disabled crtc. Again helpers have you covered, look at the active_only parameter for drm_atomic_helper_commit_planes(). Aside, if you wonder why these defaults: They match w

Re: [PATCH] virtio-gpu: fix output lookup

2016-05-30 Thread Daniel Vetter
gt;state->fb); > bo = gem_to_virtio_gpu_obj(vgfb->obj); > -- > 1.8.3.1 > > _______ > dri-devel mailing list > dri-de...@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel --

Re: [PATCH v3 7/7] [wip] virtio-gpu: add page flip support

2016-05-31 Thread Daniel Vetter
tested-by. > > Grr, mail is not in my dri-devel folder. Guess that is the > "avoid-duplicates" mailman option at work. > > Feel free to just add the r-b too. Or I'll send it for the next version > of the series. Added your r-b

Re: [PATCH] Add virtio gpu driver.

2016-05-31 Thread Daniel Vetter
s of an object (since chicken-egg: you want the list of properties before creating a new framebuffer, so can't use that framebuffer to enumerate them). But really not a big concern. -Daniel -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch _

Re: [PATCH] virtio-gpu: fix output lookup

2016-05-31 Thread Daniel Vetter
> vgfb = to_virtio_gpu_framebuffer(plane->state->fb); > bo = gem_to_virtio_gpu_obj(vgfb->obj); > -- > 1.8.3.1 > > _______ > dri-devel mailing list > dri-de...@lists.freedesktop.org > https://lists.freedesktop.org/mailm

Re: [PATCH] Add virtio gpu driver.

2016-05-27 Thread Daniel Vetter
->crtc_y, > + plane->state->crtc_w, > + plane->state->crtc_h); > + break; > + > + default: > + WARN_ON(true); > + } > } > > > @@ -105,21 +167,

Re: [PATCH v3 7/7] [wip] virtio-gpu: add page flip support

2016-05-27 Thread Daniel Vetter
On Fri, May 27, 2016 at 09:46:03AM +0200, Gerd Hoffmann wrote: > On Mi, 2016-05-25 at 18:37 +0200, Daniel Vetter wrote: > > On Fri, Oct 2, 2015 at 1:58 PM, Gerd Hoffmann <kra...@redhat.com> wrote: > > > Signed-off-by: Gerd Hoffmann <kra...@redhat.com>

Re: [PATCH v7 00/12] Support non-lru page migration

2016-06-01 Thread Daniel Vetter
e pages again. The fix is to get off those pages again (either by unpinning timely, or registering an mmu_notifier if the driver wants to keep the pages pinned indefinitely, as a caching optimization). At least that's my guess, and iirc it was confirmed first time

Re: [PATCH v3 7/7] [wip] virtio-gpu: add page flip support

2016-05-31 Thread Daniel Vetter
out certain things). I'll pick up your patch into my nonblocking atomic branch to make sure virtio isn't accidentally broken. btw can you pls drop an ack or r-b onto my virtio conversion? I already added your tested-by. Thanks, Daniel -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 7

Re: [PATCH v2 03/17] drm/exynos: removed optional dummy encoder mode_fixup function.

2016-02-16 Thread Daniel Vetter
; > - .mode_fixup = exynos_dsi_mode_fixup, > > .mode_set = exynos_dsi_mode_set, > > .enable = exynos_dsi_enable, > > .disable = exynos_dsi_disable, > > -- > > 2.5.0 > > > ___ >

Re: [PATCH 01/16] drm: fixes crct set_mode when crtc mode_fixup is null.

2016-02-16 Thread Daniel Vetter
) { > + DRM_DEBUG_KMS("CRTC fixup failed\n"); > + goto done; > + } > } > DRM_DEBUG_KMS("[CRTC:%d:%s]\n", crtc->base.id, crtc->name); > > -- > 2.5.0 > -- Daniel Vetter Software Engi

Re: [PATCH v2 00/17] drm encoders cleanup: nuke optional dummy encoder mode_fixup function.

2016-02-16 Thread Daniel Vetter
s/gpu/drm/virtio/virtgpu_display.c | 8 > 33 files changed, 244 deletions(-) > > -- > 2.5.0 > > ___ > dri-devel mailing list > dri-de...@lists.freedesktop.org > https://lists.freedesktop.org/ma

Re: [PATCH 11/16] drm/atmel-hldcd: removed optional dummy crtc mode_fixup function.

2016-02-17 Thread Daniel Vetter
c_crtc_atomic_flush(struct > >> drm_crtc *crtc, > >> } > >> > >> static const struct drm_crtc_helper_funcs lcdc_crtc_helper_funcs = { > >> - .mode_fixup = atmel_hlcdc_crtc_mode_fixup, > >>.mode_set = drm_helper_crtc_mode_set

Re: [PATCH 01/17] drm/virtio: removed optional dummy encoder mode_fixup function.

2016-02-14 Thread Daniel Vetter
; dri-devel mailing list > dri-de...@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch ___ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/virtualization

Re: [PATCH 00/16] drm crtc cleanup: nuke optional dummy crtc mode_fixup function.

2016-03-04 Thread Daniel Vetter
| 8 > drivers/gpu/drm/sti/sti_crtc.c | 9 - > drivers/gpu/drm/udl/udl_modeset.c | 9 - > drivers/gpu/drm/virtio/virtgpu_display.c | 8 > 22 files changed, 12 insertions(+), 158 deletions(-) > > -- > 2.5.0 &

Re: [PATCH v3 7/7] [wip] virtio-gpu: add page flip support

2016-05-25 Thread Daniel Vetter
_atomic_helper_page_flip, > -#endif > + .page_flip = virtio_gpu_page_flip, > .reset = drm_atomic_helper_crtc_reset, > .atomic_duplicate_state = drm_atomic_helper_crtc_duplicate_state, > .atomic_de

Re: [PATCH] Add virtio gpu driver.

2016-05-25 Thread Daniel Vetter
On Mon, Mar 30, 2015 at 4:49 PM, Daniel Vetter <dan...@ffwll.ch> wrote: > On Mon, Mar 30, 2015 at 02:23:47PM +0200, Gerd Hoffmann wrote: >> > > Signed-off-by: Dave Airlie <airl...@redhat.com> >> > > Signed-off-by: Gerd Hoffmann <kra...@redhat.com> &g

Re: [PATCH] drm/virtio: fix building without CONFIG_FBDEV

2016-08-02 Thread Daniel Vetter
> This adds a compile-time check in the driver to ensure we only > attempt to call that function if either CONFIG_FB=y or > both subsystems are configured as loadable modules. > > Signed-off-by: Arnd Bergmann <a...@arndb.de> > Fixes: 0b6320dfdfea ("drm/virtio: m

Re: [PATCH 1/2] drm: virtio: add virtio_gpu_translate_format

2017-04-03 Thread Daniel Vetter
hey're supposed to encode endinaness. But the copy-paste looks correct :-) Acked-by: Daniel Vetter <daniel.vet...@ffwll.ch> > --- > drivers/gpu/drm/virtio/virtgpu_drv.h | 1 + > drivers/gpu/drm/virtio/virtgpu_fb.c| 58 + > drivers/gp

Re: [PATCH 2/2] drm: virtio: fix virtio_gpu_mode_dumb_create

2017-04-03 Thread Daniel Vetter
about some big endian platforms. On the patch itself, once you've added more details about what/how it falls over: Acked-by: Daniel Vetter <daniel.vet...@ffwll.ch> -Daniel > --- > drivers/gpu/drm/virtio/virtgpu_gem.c | 6 -- > 1 file changed, 4 insertions(+), 2 deletions(

Re: [PATCH] drm: virtio: fix virtio_gpu_cursor_formats

2017-04-06 Thread Daniel Vetter
-- > > 2.9.3 > > > > ___ > > dri-devel mailing list > > dri-de...@lists.freedesktop.org > > https://lists.freedesktop.org/mailman/listinfo/dri-devel > > -- > Ville Syrjälä > Intel OTC &

Re: [PATCH] drm: virtio: fix kmem_cache_alloc error check

2017-03-13 Thread Daniel Vetter
guess we should have smatch integrated into 0day to catch these ... Reviewed-by: Daniel Vetter <daniel.vet...@ffwll.ch> > --- > drivers/gpu/drm/virtio/virtgpu_vq.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/virtio/virtgpu_vq.c

Re: [PATCH] drm: virtio: use kmem_cache

2017-03-01 Thread Daniel Vetter
On Wed, Mar 01, 2017 at 03:09:08PM +0100, Gerd Hoffmann wrote: > Just use kmem_cache instead of rolling > our own, limited implementation. > > Signed-off-by: Gerd Hoffmann <kra...@redhat.com> Looks very reasonable. Reviewed-by: Daniel Vetter <daniel.vet...@ffwll.ch>

Re: [Intel-gfx] [PATCH libdrm] drm: Remove create_handle() drm_framebuffer "virtual".

2017-08-10 Thread Daniel Vetter
_cma *fb; > >> + struct drm_framebuffer *fb; > > > > > > This fb pointer isn't necessary, since fb_helper already has one. > > > > I'll remove it... but I am sure when I look deeper there will be more > of these in the various dri

Re: [PATCH 3/4] drm/qxl: Drop fbdev hwaccel flags

2017-07-19 Thread Daniel Vetter
On Thu, Jul 06, 2017 at 02:57:34PM +0200, Daniel Vetter wrote: > It's not accelarated, just system memory. Note we don't even need to > set the default flag since that's now always 0. > > Cc: Dave Airlie <airl...@redhat.com> > Cc: Gerd Hoffmann <kra...@redhat.com> >

[PATCH 7/8] drm: Nuke drm_atomic_helper_connector_dpms

2017-07-25 Thread Daniel Vetter
. Signed-off-by: Daniel Vetter <daniel.vet...@intel.com> Cc: Archit Taneja <arch...@codeaurora.org> Cc: Andrzej Hajda <a.ha...@samsung.com> Cc: Laurent Pinchart <laurent.pinch...@ideasonboard.com> Cc: Peter Senna Tschudin <peter.se...@collabora.com> Cc: Martin Donnelly <m

Re: [Intel-gfx] [PATCH v3 00/16] improve the fb_setcmap helper

2017-07-05 Thread Daniel Vetter
| 11 +- > include/drm/drm_fb_helper.h | 32 - > include/drm/drm_modeset_helper_vtables.h| 16 --- > 48 files changed, 301 insertions(+), 702 deletions(-) > > -- > 2.1.4 > > ___ > Intel-gfx mailing list > intel-...@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/intel-gfx -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch ___ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/virtualization

[PATCH 3/4] drm/qxl: Drop fbdev hwaccel flags

2017-07-06 Thread Daniel Vetter
It's not accelarated, just system memory. Note we don't even need to set the default flag since that's now always 0. Cc: Dave Airlie <airl...@redhat.com> Cc: Gerd Hoffmann <kra...@redhat.com> Cc: virtualization@lists.linux-foundation.org Signed-off-by: Daniel Vetter <daniel.v

Re: [Intel-gfx] [PATCH v3 00/16] improve the fb_setcmap helper

2017-07-05 Thread Daniel Vetter
On Wed, Jul 05, 2017 at 10:09:21AM +0200, Peter Rosin wrote: > On 2017-07-05 08:08, Daniel Vetter wrote: > > On Tue, Jul 04, 2017 at 12:36:56PM +0200, Peter Rosin wrote: > >> Hi! > >> > >> While trying to get CLUT support for the atmel_hlcdc driver, and >

Re: [PATCH] drm/virtio: make drm_fb_helper_funcs const

2017-08-09 Thread Daniel Vetter
_fb_helper_funcs = { > +static const struct drm_fb_helper_funcs virtio_gpu_fb_helper_funcs = { > .fb_probe = virtio_gpufb_create, > }; > > -- > 1.9.1 > > ___ > dri-devel mailing list > dri-de...@lists.freedesktop.org > https://lists.fre

[PATCH 02/37] drm: Remove drm_device->virtdev

2017-06-12 Thread Daniel Vetter
Airlie <airl...@linux.ie> Cc: Gerd Hoffmann <kra...@redhat.com> Cc: virtualization@lists.linux-foundation.org Signed-off-by: Daniel Vetter <daniel.vet...@intel.com> --- drivers/gpu/drm/virtio/virtgpu_drm_bus.c | 1 - drivers/gpu/drm/virtio/virtgpu_kms.c | 4 ++--

Re: [PATCH 00/11] improve the fb_setcmap helper

2017-06-21 Thread Daniel Vetter
| 1 - > include/drm/drm_fb_helper.h | 32 --- > include/drm/drm_modeset_helper_vtables.h| 16 > 36 files changed, 171 insertions(+), 640 deletions(-) > > -- > 2.1.4 > > ___ > dri-devel mailing list >

Re: [PATCH 01/11] drm/fb-helper: do a generic fb_setcmap helper in terms of crtc .gamma_set

2017-06-21 Thread Daniel Vetter
tc->funcs->gamma_set(crtc, r, g, b, > + crtc->gamma_size, ); > + if (ret) > + break; > } > - out: > - drm_modeset_unlock_all(dev); > - return rc; > +out: > + if (ret == -EDEADLK) { >

Re: [Nouveau] [PATCH 01/11] drm/fb-helper: do a generic fb_setcmap helper in terms of crtc .gamma_set

2017-06-21 Thread Daniel Vetter
On Wed, Jun 21, 2017 at 04:59:31PM +0900, Michel Dänzer wrote: > On 21/06/17 04:38 PM, Daniel Vetter wrote: > > On Tue, Jun 20, 2017 at 09:25:25PM +0200, Peter Rosin wrote: > >> This makes the redundant fb helpers .load_lut, .gamma_set and .gamma_get > >> totally

Re: [PATCH 01/11] drm/fb-helper: do a generic fb_setcmap helper in terms of crtc .gamma_set

2017-06-22 Thread Daniel Vetter
On Wed, Jun 21, 2017 at 11:40:52AM +0200, Peter Rosin wrote: > On 2017-06-21 09:38, Daniel Vetter wrote: > > On Tue, Jun 20, 2017 at 09:25:25PM +0200, Peter Rosin wrote: > >> This makes the redundant fb helpers .load_lut, .gamma_set and .gamma_get > >> totally

Re: [PATCH 11/11] drm: remove unused and redundant callbacks

2017-06-22 Thread Daniel Vetter
> driver > > :: TO: Russell King <rmk+ker...@arm.linux.org.uk> > :: CC: Russell King <rmk+ker...@arm.linux.org.uk> > > --- > 0-DAY kernel test infrastructureOpen Source Technology Center > https://lists.01.org/pipermail/kbuil

Re: [PATCH v2 02/14] drm/fb-helper: remove drm_fb_helper_save_lut_atomic

2017-06-26 Thread Daniel Vetter
mode_set->x, > -- > 2.1.4 > > ___ > dri-devel mailing list > dri-de...@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel -- Daniel Vetter Soft

Re: [PATCH v2 03/14] drm/fb-helper: do a generic fb_setcmap helper in terms of crtc .gamma_set

2017-06-26 Thread Daniel Vetter
> - if (crtc_funcs->load_lut) > - crtc_funcs->load_lut(crtc); > + ret = crtc->funcs->gamma_set(crtc, r, g, b, > + crtc->gamma_size, ); As discussed on earlier threads, I think the cleanest version here would be 2

Re: [PATCH v2 01/14] drm/fb-helper: keep the .gamma_store updated in drm_fb_helper_setcmap

2017-06-26 Thread Daniel Vetter
cmap->len * sizeof(u16)); > + memcpy(b + cmap->start, cmap->blue, > +cmap->len * sizeof(u16)); > + } > + > for (j = 0; j < cmap->len; j++) { > u16 hred

Re: [PATCH v2 00/14] improve the fb_setcmap helper

2017-06-26 Thread Daniel Vetter
| 1 - > include/drm/drm_fb_helper.h | 32 -- > include/drm/drm_modeset_helper_vtables.h| 16 --- > 40 files changed, 205 insertions(+), 658 deletions(-) > > -- > 2.1.4 > > ___ > dri-devel

Re: [PATCH v2 03/14] drm/fb-helper: do a generic fb_setcmap helper in terms of crtc .gamma_set

2017-06-26 Thread Daniel Vetter
amma_size, ); > + if (ret == -EDEADLK) { > + drm_modeset_backoff(); > + goto retry; > } > - if (crtc_funcs->load_lut) > - crtc_funcs->load_lut(crtc); > +drop_locks: > +

Re: [Intel-gfx] [PATCH v2 13/14] drm: stm: remove dead code and pointless local lut storage

2017-06-23 Thread Daniel Vetter
gt; index d7a9c73..620ca55 100644 > > --- a/drivers/gpu/drm/stm/ltdc.h > > +++ b/drivers/gpu/drm/stm/ltdc.h > > @@ -27,7 +27,6 @@ struct ltdc_device { > > struct drm_panel *panel; > > struct mutex err_lock; /* protecting error_status */ > > struct ltdc_caps caps; > > - u32 clut[

Re: [PATCH 01/11] drm/fb-helper: do a generic fb_setcmap helper in terms of crtc .gamma_set

2017-06-23 Thread Daniel Vetter
On Thu, Jun 22, 2017 at 10:48:10AM +0200, Peter Rosin wrote: > On 2017-06-22 08:36, Daniel Vetter wrote: > > On Wed, Jun 21, 2017 at 11:40:52AM +0200, Peter Rosin wrote: > >> On 2017-06-21 09:38, Daniel Vetter wrote: > >>> On Tue, Jun 20, 2017 at 09:25

Re: [Nouveau] [PATCH v2 00/14] improve the fb_setcmap helper

2017-06-27 Thread Daniel Vetter
is open for refactorings like this all the time, and maintainers make sure the code will get into upstream asap, without interferring with the upstream merge window schedules. Like Dave said, don't worry. -Daniel -- Daniel Vetter Software Engineer,

Re: [PATCH] drm/virtio: Replace instances of reference/unreference with get/put

2017-10-02 Thread Daniel Vetter
*dev, void *data, > out_unres: > virtio_gpu_object_unreserve(qobj); > out: > - drm_gem_object_unreference_unlocked(gobj); > + drm_gem_object_put_unlocked(gobj); > return ret; > } > > @@ -462,7 +462,7 @@ static int virtio_gpu_wait_ioctl(struct drm

Re: [PATCH] drm: virtio: constify drm_fb_helper_funcs

2017-08-22 Thread Daniel Vetter
> > ___ > dri-devel mailing list > dri-de...@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch _

Re: [PATCH 02/13] fbdev: add remove_conflicting_pci_framebuffers()

2017-11-28 Thread Daniel Vetter
On Mon, Nov 27, 2017 at 08:52:19PM +, Sudip Mukherjee wrote: > On Mon, Nov 27, 2017 at 11:27:59AM +0100, Daniel Vetter wrote: > > On Fri, Nov 24, 2017 at 06:53:31PM +0100, Michał Mirosław wrote: > > > Almost all drivers using remove_conflicting_framebuffers() wrap it with &

Re: [PATCH 02/13] fbdev: add remove_conflicting_pci_framebuffers()

2017-11-29 Thread Daniel Vetter
On Tue, Nov 28, 2017 at 12:30:30PM +, Sudip Mukherjee wrote: > On Tue, Nov 28, 2017 at 12:32:38PM +0100, Greg KH wrote: > > On Tue, Nov 28, 2017 at 11:22:17AM +0100, Daniel Vetter wrote: > > > On Mon, Nov 27, 2017 at 08:52:19PM +, Sudip Mukherjee wrote: > > > &

Re: [PATCH 02/13] fbdev: add remove_conflicting_pci_framebuffers()

2017-11-27 Thread Daniel Vetter
uct *a, > const char *name, bool primary); > extern int fb_prepare_logo(struct fb_info *fb_info, int rotate); > -- > 2.11.0 > > ___ > dri-devel mailing list > dri-de...@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch ___ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/virtualization

Re: [PATCH 00/13] remove_conflicting_framebuffers() cleanup

2017-11-27 Thread Daniel Vetter
s new semantics of > remove_conflicting_framebuffers() from this series. This > can be considered independently, though. Except for that patches I've commented on: Acked-by: Daniel Vetter <daniel.vet...@ffwll.ch> Since this is for tegra and Thierry has drm-misc commit rights, it's probably simplest when Thierry pushe

Re: [PATCH 02/13] fbdev: add remove_conflicting_pci_framebuffers()

2017-11-30 Thread Daniel Vetter
On Thu, Nov 30, 2017 at 11:49:53PM +, Sudip Mukherjee wrote: > Hi Daniel, > > On Wed, Nov 29, 2017 at 10:56:34AM +0100, Daniel Vetter wrote: > > On Tue, Nov 28, 2017 at 12:30:30PM +, Sudip Mukherjee wrote: > > > On Tue, Nov 28, 2017 at 12:32:38PM +0100, Greg KH wr

[PATCH 16/17] drm/virtio: Remove unecessary dma_fence_ops

2018-04-27 Thread Daniel Vetter
dma_fence_default_wait is the default now, same for the trivial enable_signaling implementation. Signed-off-by: Daniel Vetter <daniel.vet...@ffwll.ch> Cc: David Airlie <airl...@linux.ie> Cc: Gerd Hoffmann <kra...@redhat.com> Cc: virtualization@lists.linux-foundation.org --

[PATCH 12/17] drm/qxl: Remove unecessary dma_fence_ops

2018-04-27 Thread Daniel Vetter
dma_fence_default_wait is the default now, same for the trivial enable_signaling implementation. Signed-off-by: Daniel Vetter <daniel.vet...@ffwll.ch> Cc: Dave Airlie <airl...@redhat.com> Cc: Gerd Hoffmann <kra...@redhat.com> Cc: virtualization@lists.linux-foundation.org --- d

Re: [PATCH 14/15] drm/virtio: Remove unecessary dma_fence_ops

2018-07-03 Thread Daniel Vetter
On Thu, May 03, 2018 at 04:26:02PM +0200, Daniel Vetter wrote: > dma_fence_default_wait is the default now, same for the trivial > enable_signaling implementation. > > Reviewed-by: Eric Anholt > Signed-off-by: Daniel Vetter > Cc: David Airlie > Cc: Gerd Hoffmann

[PATCH] drm/qxl: Remove unecessary dma_fence_ops

2018-05-02 Thread Daniel Vetter
The trivial enable_signaling implementation matches the default code. v2: Fix up commit message to match patch better (Eric). Cc: Eric Anholt <e...@anholt.net> Reviewed-by: Eric Anholt <e...@anholt.net> Signed-off-by: Daniel Vetter <daniel.vet...@ffwll.ch> Cc: Dave Airlie <a

[PATCH] drm/qxl: Remove unecessary dma_fence_ops

2018-05-02 Thread Daniel Vetter
The trivial enable_signaling implementation matches the default code. v2: Fix up commit message to match patch better (Eric). Cc: Eric Anholt <e...@anholt.net> Reviewed-by: Eric Anholt <e...@anholt.net> Signed-off-by: Daniel Vetter <daniel.vet...@ffwll.ch> Cc: Dave Airlie <a

Re: [Intel-gfx] [PATCH] drm/core: Remove drm_dev_unref() and it's uses

2018-04-26 Thread Daniel Vetter
7 @@ static int vc4_drm_bind(struct device *dev) > vc4_gem_destroy(drm); > vc4_bo_cache_destroy(drm); > dev_unref: > - drm_dev_unref(drm); > + drm_dev_put(drm); > return ret; > } > > @@ -327,7 +327,7 @@ static void vc4_drm_unbind(struct device *dev) > > drm_mode_config_cleanup(drm); > > - drm_dev_unref(drm); > + drm_dev_put(drm); > } > > static const struct component_master_ops vc4_drm_ops = { > diff --git a/drivers/gpu/drm/vgem/vgem_drv.c b/drivers/gpu/drm/vgem/vgem_drv.c > index 2524ff116f00..305f87665499 100644 > --- a/drivers/gpu/drm/vgem/vgem_drv.c > +++ b/drivers/gpu/drm/vgem/vgem_drv.c > @@ -505,7 +505,7 @@ static int __init vgem_init(void) > static void __exit vgem_exit(void) > { > drm_dev_unregister(_device->drm); > - drm_dev_unref(_device->drm); > + drm_dev_put(_device->drm); > } > > module_init(vgem_init); > diff --git a/drivers/gpu/drm/virtio/virtgpu_drm_bus.c > b/drivers/gpu/drm/virtio/virtgpu_drm_bus.c > index 7df8d0c9026a..094b876f6da6 100644 > --- a/drivers/gpu/drm/virtio/virtgpu_drm_bus.c > +++ b/drivers/gpu/drm/virtio/virtgpu_drm_bus.c > @@ -85,6 +85,6 @@ int drm_virtio_init(struct drm_driver *driver, struct > virtio_device *vdev) > return 0; > > err_free: > - drm_dev_unref(dev); > + drm_dev_put(dev); > return ret; > } > diff --git a/drivers/gpu/drm/zte/zx_drm_drv.c > b/drivers/gpu/drm/zte/zx_drm_drv.c > index 6f4205e80378..02ae1caf6e8a 100644 > --- a/drivers/gpu/drm/zte/zx_drm_drv.c > +++ b/drivers/gpu/drm/zte/zx_drm_drv.c > @@ -122,7 +122,7 @@ static int zx_drm_bind(struct device *dev) > component_unbind_all(dev, drm); > out_unregister: > dev_set_drvdata(dev, NULL); > - drm_dev_unref(drm); > + drm_dev_put(drm); > return ret; > } > > @@ -136,7 +136,7 @@ static void zx_drm_unbind(struct device *dev) > drm_mode_config_cleanup(drm); > component_unbind_all(dev, drm); > dev_set_drvdata(dev, NULL); > - drm_dev_unref(drm); > + drm_dev_put(drm); > } > > static const struct component_master_ops zx_drm_master_ops = { > diff --git a/include/drm/drm_drv.h b/include/drm/drm_drv.h > index d23dcdd1bd95..c16dd4424b8a 100644 > --- a/include/drm/drm_drv.h > +++ b/include/drm/drm_drv.h > @@ -622,7 +622,6 @@ void drm_dev_unregister(struct drm_device *dev); > > void drm_dev_get(struct drm_device *dev); > void drm_dev_put(struct drm_device *dev); > -void drm_dev_unref(struct drm_device *dev); > void drm_put_dev(struct drm_device *dev); > void drm_dev_unplug(struct drm_device *dev); > > -- > 2.14.1 > > ___ > Intel-gfx mailing list > intel-...@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/intel-gfx -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch ___ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/virtualization

[PATCH 11/15] drm/qxl: Remove unecessary dma_fence_ops

2018-05-03 Thread Daniel Vetter
The trivial enable_signaling implementation matches the default code. v2: Fix up commit message to match patch better (Eric). Cc: Eric Anholt <e...@anholt.net> Reviewed-by: Eric Anholt <e...@anholt.net> Signed-off-by: Daniel Vetter <daniel.vet...@ffwll.ch> Cc: Dave Airlie <a

[PATCH 14/15] drm/virtio: Remove unecessary dma_fence_ops

2018-05-03 Thread Daniel Vetter
dma_fence_default_wait is the default now, same for the trivial enable_signaling implementation. Reviewed-by: Eric Anholt <e...@anholt.net> Signed-off-by: Daniel Vetter <daniel.vet...@ffwll.ch> Cc: David Airlie <airl...@linux.ie> Cc: Gerd Hoffmann <kra...@redhat.co

Re: [PATCH] drm/bochs: make structure bochs_bo_driver static

2018-02-19 Thread Daniel Vetter
t_populate = ttm_pool_populate, > .ttm_tt_unpopulate = ttm_pool_unpopulate, > -- > 2.15.1 > > ___ > dri-devel mailing list > dri-de...@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel -- Daniel Vetter Software Engi

Re: [PATCH] bochs: convert to drm_fb_helper_fbdev_setup/teardown

2018-09-05 Thread Daniel Vetter
gem-shmem support for it (still in flight) from Noralf should be able to pull that off. That gives you the fb_mmap implementation, but with 100% generic code instead of a driver specific hack like Max did. > > Signed-off-by: Peter Wu lgtm. Acked-by: Daniel Vetter I'll leave merging to Gerd. -Danie

Re: [PATCH v2 02/12] fbdev: allow apertures == NULL in remove_conflicting_framebuffers()

2018-08-31 Thread Daniel Vetter
On Fri, Aug 31, 2018 at 10:56:56AM +0200, Daniel Vetter wrote: > On Thu, Aug 30, 2018 at 11:00:05PM +0200, Michał Mirosław wrote: > > Interpret (otherwise-invalid) NULL apertures argument to mean all-memory > > range. This will allow to remove several duplicates of this code f

Re: [PATCH] drm/cirrus: flip default to 32bpp

2018-07-09 Thread Daniel Vetter
Nobody's using cirrus because they care > about color fidelity and it'll use less CPU to update. There's > precedent here, mgag200 defaults to 16bpp on sufficiently memory- > impaired devices. Yeah nouveau does the same fallback to 16bpp if there's not enough vram. So do a bunch of oth

Re: [Intel-gfx] [PATCH 08/13] drm/virtio: Stop updating plane->crtc

2018-04-05 Thread Daniel Vetter
<airl...@linux.ie> > Cc: Gerd Hoffmann <kra...@redhat.com> > Cc: virtualization@lists.linux-foundation.org > Signed-off-by: Ville Syrjälä <ville.syrj...@linux.intel.com> > Reviewed-by: Maarten Lankhorst <maarten.lankho...@linux.intel.com> Reviewed-by: Danie

Re: [PATCH 1/2] qxl: fix qxl_release_{map,unmap}

2018-04-20 Thread Daniel Vetter
<kra...@redhat.com> Sweeet. Since the buggy code uses the same expression for page frame and offset I don't think there's a security bug. You might still want to cc: stable (since without you defacto can't ever use this feature). Reviewed-by: Daniel Vetter <daniel.vet...@ffwll.ch> > --- &

Re: [PATCH v2 4/4] qxl: drop dummy functions

2018-04-20 Thread Daniel Vetter
quot;\n"); > - return 0; > -} > - > static void qxl_conn_destroy(struct drm_connector *connector) > { > struct qxl_output *qxl_output = > @@ -1081,7 +1032,6 @@ static const struct drm_connector_funcs > qxl_connector_funcs = { > .dpms = drm_helper_conn

Re: [PATCH] drm/virtio: fix mode_valid's return type

2018-04-25 Thread Daniel Vetter
> dri-devel mailing list > dri-de...@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch ___ Virtualizati

Re: [PATCH] gpu: drm: qxl: Adding new typedef vm_fault_t

2018-04-24 Thread Daniel Vetter
rge with 4.17-rcX soon? For backmerge requests you need to cc/ping the drm-misc maintainers. Adding them. I think the hold-up also was that Dave was on vacations still. -Daniel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch ___ Vi

Re: [PATCH 00/23] drm: Eliminate plane->fb/crtc usage for atomic drivers

2018-03-27 Thread Daniel Vetter
Deucher <alexander.deuc...@amd.com> > Cc: amd-...@lists.freedesktop.org > Cc: Benjamin Gaignard <benjamin.gaign...@linaro.org> > Cc: Boris Brezillon <boris.brezil...@free-electrons.com> > Cc: ch...@chris-wilson.co.uk > Cc: "Christian König" <chr

Re: [Outreachy kernel] [PATCH] drm/qxl: Replace drm_gem_object_reference/unreference() with _get/put()

2018-03-21 Thread Daniel Vetter
nref the ttm bo */ > - drm_gem_object_unreference_unlocked(>gem_base); > + drm_gem_object_put_unlocked(>gem_base); > } > } > > -- > 2.7.4 > > -- > You received this message because you are subscribed

Re: [Intel-gfx] [PATCH] drm/core: Remove drm_dev_unref() and it's uses

2018-04-26 Thread Daniel Vetter
On Thu, Apr 26, 2018 at 3:14 PM, Alexandre Belloni <alexandre.bell...@bootlin.com> wrote: > Hi, > > On 26/04/2018 15:45:44+0300, Laurent Pinchart wrote: >> Hi Daniel, >> >> On Thursday, 26 April 2018 15:36:15 EEST Daniel Vetter wrote: >> > On Thu, Apr 26,

Re: [PATCH v2] virtio-gpu: add VIRTIO_GPU_F_EDID feature

2018-10-05 Thread Daniel Vetter
256 bytes)? > > If not, maybe add comment to explain why you chose 1024. EDID in the wild can be up to 512 bytes. -Daniel > > > +}; > > + > > #define VIRTIO_GPU_EVENT_DISPLAY (1 << 0) > > > > struct virtio_gpu_config { > > -- > > 2.9.

Re: [Outreachy kernel] [PATCH 0/6] drm/qxl: Remove checkpatch issues

2018-10-29 Thread Daniel Vetter
nsubscr...@googlegroups.com. > To post to this group, send email to outreachy-ker...@googlegroups.com. > To view this discussion on the web visit > https://groups.google.com/d/msgid/outreachy-kernel/cover.1540579956.git.shayenneluzmoura%40g

Re: [PATCH v3] drm/bochs: add edid support.

2018-10-30 Thread Daniel Vetter
if you don't have a i2c_adapater (because the hw has some magic "give me an edid" block). For virtual hw we hopefully don't randomly drop bits on the floor between the guest and host. Imo totally fine as-is. E.g. we also don't feed the VBT edid through drm_do_get_edid

Re: [PATCH v4] drm/bochs: add edid support.

2018-10-30 Thread Daniel Vetter
device VGA,edid=on' for testing. > > Signed-off-by: Gerd Hoffmann I liked v3 more, but Acked-by: Daniel Vetter on either wone. -Daniel > --- > drivers/gpu/drm/bochs/bochs.h | 2 ++ > drivers/gpu/drm/bochs/bochs_hw.c | 30 ++ > drive

Re: [PATCH v3] drm/bochs: add edid support.

2018-10-30 Thread Daniel Vetter
On Tue, Oct 30, 2018 at 11:28:24AM +0200, Jani Nikula wrote: > On Tue, 30 Oct 2018, Daniel Vetter wrote: > > On Mon, Oct 29, 2018 at 09:05:20PM +0100, Gerd Hoffmann wrote: > >> On Mon, Oct 29, 2018 at 07:44:28PM +0200, Jani Nikula wrote: > >> > On Mon, 29

Re: [PATCH v4 2/2] drm/virtio: add edid support

2018-10-30 Thread Daniel Vetter
edid), > +GFP_KERNEL); > + if (!resp_buf) > + return -ENOMEM; > + > + cmd_p = virtio_gpu_alloc_cmd_resp > + (vgdev, _gpu_cmd_get_edid_cb, , > + sizeof(*cmd_p), sizeof(struct virtio_gpu_r

Re: [PATCH] qxl: fix null-pointer crash during suspend

2018-10-02 Thread Daniel Vetter
()") Cc: # v4.14+ Reviewed-by: Daniel Vetter I'll let Gerd pick this one up, after some testing. Also adding Laurent. -Daniel > "crtc_funcs->disable" call would crash (resulting in suspend failure). > Fix this by converting the suspend/resume functions to use the > drm_

Re: [PATCH v3 00/13] remove_conflicting_framebuffers() cleanup

2018-09-03 Thread Daniel Vetter
; drivers/video/fbdev/core/fbmem.c | 63 +++- > include/drm/drm_fb_helper.h | 12 + > include/linux/fb.h | 2 + > 13 files changed, 89 insertions(+), 172 deletions(-) > > -- > 2.18.0 > > _____

Re: [PATCH v3 00/13] remove_conflicting_framebuffers() cleanup

2018-09-03 Thread Daniel Vetter
On Mon, Sep 03, 2018 at 01:31:34PM +0200, Bartlomiej Zolnierkiewicz wrote: > On Monday, September 03, 2018 09:43:15 AM Daniel Vetter wrote: > > On Sat, Sep 01, 2018 at 04:08:41PM +0200, Michał Mirosław wrote: > > > This series cleans up duplicated code for replacing firmwa

Re: [PATCH v3 04/13] fbdev: add remove_conflicting_pci_framebuffers()

2018-09-03 Thread Daniel Vetter
nfo); > +extern int remove_conflicting_pci_framebuffers(struct pci_dev *pdev, int > res_id, > +const char *name); > extern int remove_conflicting_framebuffers(struct apertures_struct *a, > const char

Re: [Intel-gfx] [PATCH 7/7] drm: Split out drm_probe_helper.h

2019-01-16 Thread Daniel Vetter
On Tue, Dec 18, 2018 at 10:27:47AM +0100, Benjamin Gaignard wrote: > Le lun. 17 déc. 2018 à 21:48, Rodrigo Vivi a écrit : > > > > On Mon, Dec 17, 2018 at 08:43:03PM +0100, Daniel Vetter wrote: > > > Having the probe helper stuff (which pretty much everyone needs) in >

Re: [PATCH] drm/cirrus: fix connector leak at unload

2019-01-16 Thread Daniel Vetter
On Fri, Jan 11, 2019 at 09:02:34AM -0500, Rob Clark wrote: > This fixes an '*ERROR* connector VGA-2 leaked!' splat at driver unload. > > Signed-off-by: Rob Clark > --- > Similar case to the issue that was fixed recently in drm/ast Reviewed-by: Daniel Vetter > > d

[PATCH] drm: Split out drm_probe_helper.h

2019-01-16 Thread Daniel Vetter
Acked-by: Oleksandr Andrushchenko Acked-by: CK Hu Acked-by: Alex Deucher Reviewed-by: Laurent Pinchart Signed-off-by: Daniel Vetter Cc: linux-arm-ker...@lists.infradead.org Cc: virtualization@lists.linux-foundation.org Cc: etna...@lists.freedesktop.org Cc: linux-samsung-...@vger.kernel.org Cc:

Re: [Spice-devel] [PATCH 1/3] drm/qxl: add mode/framebuffer check functions

2019-01-16 Thread Daniel Vetter
t > qdev->vram_size) { > > > - DRM_ERROR("Mode doesn't fit in vram size (vgamem)"); > > > - return -EINVAL; > > > - } > > ... that check moved into the new function. > > cheers, > Gerd > -- Daniel Vetter Software Engineer, Intel Corporat

[PATCH] drm: Split out drm_probe_helper.h

2019-01-16 Thread Daniel Vetter
Acked-by: Benjamin Gaignard Acked-by: Jani Nikula Acked-by: Neil Armstrong Acked-by: Oleksandr Andrushchenko Acked-by: CK Hu Acked-by: Alex Deucher Reviewed-by: Laurent Pinchart Acked-by: Liviu Dudau Signed-off-by: Daniel Vetter Cc: linux-arm-ker...@lists.infradead.org Cc: virtualization@lists

  1   2   3   4   >