Re: [patch 13/26] Xen-paravirt_ops: Consistently wrap paravirt ops callsites to make them patchable

2007-03-18 Thread David Miller
From: Rusty Russell [EMAIL PROTECTED] Date: Sat, 17 Mar 2007 21:33:58 +1100 On Fri, 2007-03-16 at 13:38 -0700, Jeremy Fitzhardinge wrote: David Miller wrote: Perhaps the problem can be dealt with using ELF relocations. There is another case, discussed yesterday on netdev, where run

Re: [patch 13/26] Xen-paravirt_ops: Consistently wrap paravirt ops callsites to make them patchable

2007-03-19 Thread David Miller
From: Linus Torvalds [EMAIL PROTECTED] Date: Mon, 19 Mar 2007 20:18:14 -0700 (PDT) Please don't subject us to another couple months of hair-pulling only to have Linus yank the thing out again, there are certainly more useful things to spend time on :-) Good call. Dwarf2 unwinding

Re: [patch 13/26] Xen-paravirt_ops: Consistently wrap paravirt ops callsites to make them patchable

2007-04-12 Thread David Miller
From: Paul Mackerras [EMAIL PROTECTED] Date: Wed, 21 Mar 2007 11:03:14 +1100 Linus Torvalds writes: We should just do this natively. There's been several tests over the years saying that it's much more efficient to do sti/cli as a simple store, and handling the oops, we got an

Re: [1/2] [NET] link_watch: Move link watch list into net_device

2007-05-09 Thread David Miller
From: Herbert Xu [EMAIL PROTECTED] Date: Tue, 8 May 2007 22:13:22 +1000 [NET] link_watch: Move link watch list into net_device These days the link watch mechanism is an integral part of the network subsystem as it manages the carrier status. So it now makes sense to allocate some memory

Re: [1/2] [NET] link_watch: Move link watch list into net_device

2007-05-10 Thread David Miller
From: Jeremy Fitzhardinge [EMAIL PROTECTED] Date: Thu, 10 May 2007 15:00:05 -0700 Herbert Xu wrote: [NET] link_watch: Move link watch list into net_device These days the link watch mechanism is an integral part of the network subsystem as it manages the carrier status. So it now makes

Re: [1/2] [NET] link_watch: Move link watch list into net_device

2007-05-10 Thread David Miller
From: Jeremy Fitzhardinge [EMAIL PROTECTED] Date: Thu, 10 May 2007 15:22:17 -0700 Andrew Morton wrote: Five minutes after boot is when jiffies wraps. Are you sure it's a list-screwup rather than a jiffy-wrap screwup? Hm, its suggestive, isn't it? Apparently they've already fixed

Re: [1/2] [NET] link_watch: Move link watch list into net_device

2007-05-10 Thread David Miller
From: Jeremy Fitzhardinge [EMAIL PROTECTED] Date: Thu, 10 May 2007 15:45:42 -0700 David Miller wrote: I'm not so certain now that we know it's the jiffies wrap point :-) The fixes in question are attached below and they were posted and discussed on netdev: Yep, this patch gets

Re: [PATCH 3/3] Virtio draft IV: the net driver

2007-07-11 Thread David Miller
From: Rusty Russell [EMAIL PROTECTED] Date: Thu, 12 Jul 2007 12:21:33 +1000 Dave, I think you're the only one (so far?) with multiple irqs. Luckily there are known hw implementations with that issue so I won't be weird for long :) It's not clear that guest-controlled interrupt mitigation is

Re: [PATCH 1/3] skb_partial_csum_set

2008-01-15 Thread David Miller
From: Rusty Russell [EMAIL PROTECTED] Date: Tue, 15 Jan 2008 21:41:55 +1100 Implement skb_partial_csum_set, for setting partial csums on untrusted packets. Use it in virtio_net (replacing buggy version there), it's also going to be used by TAP for partial csum support. Signed-off-by:

Re: [PATCH RFC 4/5] tun: vringfd xmit support.

2008-04-07 Thread David Miller
From: Rusty Russell [EMAIL PROTECTED] Date: Mon, 7 Apr 2008 17:24:51 +1000 On Monday 07 April 2008 15:13:44 Herbert Xu wrote: On second thought, this is not going to work. The network stack can clone individual pages out of this skb and put it into a new skb. Therefore whatever scheme we

Re: [PATCH 2/5] /dev/vring: simple userspace-kernel ringbuffer interface.

2008-04-19 Thread David Miller
From: Rusty Russell [EMAIL PROTECTED] Date: Sun, 20 Apr 2008 02:41:14 +1000 If only there were some kind of, I don't know... summit... for kernel people... I'm starting to disbelieve the myth that because we can discuss technical issues on mailing lists, we should talk primarily about

Re: [6/6] [VIRTIO] net: Allow receiving SG packets

2008-04-21 Thread David Miller
From: Rusty Russell [EMAIL PROTECTED] Date: Tue, 22 Apr 2008 05:06:16 +1000 I'm not sure what the right number is here. Say worst case is header which goes over a page boundary then MAX_SKB_FRAGS in the skb, but for some reason that already has a +2: /* To allow 64K frame to be packed as

Re: [6/6] [VIRTIO] net: Allow receiving SG packets

2008-04-21 Thread David Miller
From: Rusty Russell [EMAIL PROTECTED] Date: Tue, 22 Apr 2008 12:50:27 +1000 But I was curious as to why the +2 in the MAX_SKB_FRAGS definition? To be honest I have no idea. When Alexey added the TSO changeset way back then, it had the +2, from the history-2.6 tree: commit

Re: [PATCH 5/5] Remove now unused structs from kvm_para.h

2008-06-03 Thread David Miller
You sent these patches to kvm-owner, ie. the mailing list owner, and not the list itself which would be plain kvm. ___ Virtualization mailing list Virtualization@lists.linux-foundation.org

Re: [PATCH 1/4] tun: Interface to query tun/tap features.

2008-07-01 Thread David Miller
From: Max Krasnyansky [EMAIL PROTECTED] Date: Tue, 01 Jul 2008 21:59:02 -0700 Dave, do you want me to put all outstanding TUN patches into a git tree so that you can pull them in one shot ? Otherwise if you're ok with applying them one by one please apply this one. Acked-by: Max Krasnyansky

Re: [PATCH 1/3] tun: Interface to query tun/tap features.

2008-07-03 Thread David Miller
From: Rusty Russell [EMAIL PROTECTED] Date: Thu, 3 Jul 2008 11:32:12 +1000 The problem with introducing checksum offload and gso to tun is they need to set dev-features to enable GSO and/or checksumming, which is supposed to be done before register_netdevice(), ie. as part of TUNSETIFF. ...

Re: [PATCH] tun: Fix/rewrite packet filtering logic

2008-07-14 Thread David Miller
From: David Miller [EMAIL PROTECTED] Date: Mon, 14 Jul 2008 22:16:02 -0700 (PDT) It doesn't apply cleanly to net-next-2.6, as I just tried to stick this into my tree. Ignore this, I did something stupid. ___ Virtualization mailing list Virtualization

Re: [PATCH] tun: Fix/rewrite packet filtering logic

2008-07-14 Thread David Miller
From: Max Krasnyansky [EMAIL PROTECTED] Date: Sat, 12 Jul 2008 01:52:54 -0700 This is on top of the latest and greatest :). Assuming virt folks are ok with the API this should go into 2.6.27. Really? :-) It doesn't apply cleanly to net-next-2.6, as I just tried to stick this into my tree.

Re: [PATCH] tun: Fix/rewrite packet filtering logic

2008-07-22 Thread David Miller
From: Jeff Garzik [EMAIL PROTECTED] Date: Tue, 22 Jul 2008 19:41:47 -0400 looks mostly OK, but stuff like the above should be (void __user *) arg Did you check this with sparse (Documentation/sparse.txt)? Jeff, I already added this particular patch to the tree a week or so ago.

Re: [PATCH 1/1] tun: TUNGETIFF interface to query name and flags

2008-08-15 Thread David Miller
From: Max Krasnyansky [EMAIL PROTECTED] Date: Fri, 15 Aug 2008 11:00:19 -0700 Rusty Russell wrote: On Thursday 14 August 2008 00:30:16 Mark McLoughlin wrote: A very simple approach is attached; I did consider doing a TUNGETFLAGS that would return tun-flags, but I think it's nicer to have a

Re: [PATCH] virtio_net: large tx MTU support

2008-11-26 Thread David Miller
From: Mark McLoughlin [EMAIL PROTECTED] Date: Wed, 26 Nov 2008 13:58:11 + We don't really have a max tx packet size limit, so allow configuring the device with up to 64k tx MTU. Signed-off-by: Mark McLoughlin [EMAIL PROTECTED] Rusty, ACK? If so, I'll toss this into net-next-2.6,

Re: [PATCH] AF_VMCHANNEL address family for guest-host communication.

2008-12-14 Thread David Miller
From: Gleb Natapov g...@redhat.com Date: Sun, 14 Dec 2008 13:50:55 +0200 It is undesirable to use TCP/IP for this purpose since network connectivity may not exist between host and guest and if it exists the traffic can be not routable between host and guest for security reasons or TCP/IP

Re: [PATCH] AF_VMCHANNEL address family for guest-host communication.

2008-12-15 Thread David Miller
From: Anthony Liguori anth...@codemonkey.ws Date: Mon, 15 Dec 2008 09:02:23 -0600 There is already an AF_IUCV for s390. This is a scarecrow and irrelevant to this discussion. And this is exactly why I asked that any arguments in this thread avoid talking about virtualization technology and why

Re: [PATCH] AF_VMCHANNEL address family for guest-host communication.

2008-12-15 Thread David Miller
From: Anthony Liguori anth...@codemonkey.ws Date: Mon, 15 Dec 2008 14:44:26 -0600 We want this communication mechanism to be simple and reliable as we want to implement the backends drivers in the host userspace with minimum mess. One implication of your statement here is that TCP is

Re: [2/2] tun: Fix sk_sleep races when attaching/detaching

2009-04-20 Thread David Miller
From: Herbert Xu herb...@gondor.apana.org.au Date: Mon, 20 Apr 2009 16:35:50 +0800 On Thu, Apr 16, 2009 at 07:09:52PM +0800, Herbert Xu wrote: tun: Fix sk_sleep races when attaching/detaching That patch doesn't apply anymore because of contextual changes caused by the first patch. Here's

Re: [RFC] virtio: orphan skbs if we're relying on timer to free them

2009-05-18 Thread David Miller
From: Rusty Russell ru...@rustcorp.com.au Date: Mon, 18 May 2009 22:18:47 +0930 We check for finished xmit skbs on every xmit, or on a timer (unless the host promises to force an interrupt when the xmit ring is empty). This can penalize userspace tasks which fill their sockbuf. Not much

Re: [RFC] virtio: orphan skbs if we're relying on timer to free them

2009-05-21 Thread David Miller
From: Rusty Russell ru...@rustcorp.com.au Date: Thu, 21 May 2009 16:27:05 +0930 On Tue, 19 May 2009 12:10:13 pm David Miller wrote: What you're doing by orphan'ing is creating a situation where a single UDP socket can loop doing sends and monopolize the TX queue of a device. The only control

Re: [PATCH 1/4] net: skb_orphan on dev_hard_start_xmit

2009-06-02 Thread David Miller
From: Patrick Ohly patrick.o...@intel.com Date: Mon, 01 Jun 2009 21:47:22 +0200 On Fri, 2009-05-29 at 23:44 +0930, Rusty Russell wrote: This patch adds skb_orphan to the start of dev_hard_start_xmit(): it can be premature in the NETDEV_TX_BUSY case, but that's uncommon. Would it be possible

Re: [PATCH 1/4] net: skb_orphan on dev_hard_start_xmit

2009-06-02 Thread David Miller
From: Rusty Russell ru...@rustcorp.com.au Date: Tue, 2 Jun 2009 23:38:29 +0930 On Tue, 2 Jun 2009 04:55:53 pm David Miller wrote: From: Patrick Ohly patrick.o...@intel.com Date: Mon, 01 Jun 2009 21:47:22 +0200 On Fri, 2009-05-29 at 23:44 +0930, Rusty Russell wrote: This patch adds

Re: [PATCH 1/4] net: skb_orphan on dev_hard_start_xmit

2009-06-03 Thread David Miller
From: Rusty Russell ru...@rustcorp.com.au Date: Thu, 4 Jun 2009 13:24:57 +0930 On Thu, 4 Jun 2009 06:32:53 am Eric Dumazet wrote: Also, taking a reference on socket for each xmit packet in flight is very expensive, since it slows down receiver in __udp4_lib_lookup(). Several cpus are fighting

Re: [PATCH 1/4] net: skb_orphan on dev_hard_start_xmit

2009-06-03 Thread David Miller
From: Eric Dumazet eric.duma...@gmail.com Date: Thu, 04 Jun 2009 06:54:24 +0200 We also can avoid the sock_put()/sock_hold() pair for each tx packet, to only touch sk_wmem_alloc (with appropriate atomic_sub_return() in sock_wfree() and atomic_dec_test in sk_free We could initialize

Re: [PATCH 1/4] net: skb_orphan on dev_hard_start_xmit

2009-07-03 Thread David Miller
From: Herbert Xu herb...@gondor.apana.org.au Date: Fri, 3 Jul 2009 15:55:30 +0800 Calling skb_orphan like this should be forbidden. Apart from the problems already raised, it is a sign that the driver is trying to paper over a more serious issue of not cleaning up skb's timely. Yes

Re: [PATCH 1/4] net: skb_orphan on dev_hard_start_xmit

2009-07-03 Thread David Miller
From: Herbert Xu herb...@gondor.apana.org.au Date: Sat, 4 Jul 2009 11:08:30 +0800 On Fri, Jul 03, 2009 at 08:02:54PM -0700, David Miller wrote: In particular the case of handling a device without usable TX completion event indications is still quite troublesome. e Which particular devices

Re: [PATCH] net/bridge: Add 'hairpin' port forwarding mode

2009-08-13 Thread David Miller
From: Fischer, Anna anna.fisc...@hp.com Date: Thu, 13 Aug 2009 16:55:16 + This patch adds a 'hairpin' (also called 'reflective relay') mode port configuration to the Linux Ethernet bridge kernel module. A bridge supporting hairpin forwarding mode can send frames back out through the port

Re: [PATCH 1/4] net: skb_orphan on dev_hard_start_xmit

2009-08-17 Thread David Miller
From: Herbert Xu herb...@gondor.apana.org.au Date: Sun, 5 Jul 2009 11:34:08 +0800 Here's an even crazier idea that doesn't use dummy descriptors. xmit(skb) if (TX queue contains no interrupting descriptor qdisc is empty) mark TX descriptor as interrupting

Re: [PATCH 1/4] net: skb_orphan on dev_hard_start_xmit

2009-08-18 Thread David Miller
From: Herbert Xu herb...@gondor.apana.org.au Date: Wed, 19 Aug 2009 13:19:26 +1000 I'm in the process of repeating the same experiment with cxgb3 which hopefully should let me turn interrupts off on descriptors while still reporting completion status. Ok, I look forward to seeing your work

Re: [PATCH 2.6.31-rc9] net: VMware virtual Ethernet NIC driver: vmxnet3

2009-09-28 Thread David Miller
From: Shreyas Bhatewara sbhatew...@vmware.com Date: Mon, 28 Sep 2009 16:56:45 -0700 + uint32_t rxdIdx:12;/* Index of the RxDesc */ Don't use uint32_t et al. sized types, use u32 and friends throughout. ___ Virtualization mailing list

Re: [PATCH 2.6.32-rc1] net: VMware virtual Ethernet NIC driver: vmxnet3

2009-09-30 Thread David Miller
From: Stephen Hemminger shemmin...@vyatta.com Date: Wed, 30 Sep 2009 17:39:23 -0700 Why not use NETIF_F_LRO and ethtool to control LRO support? In fact, you must, in order to handle bridging and routing correctly. Bridging and routing is illegal with LRO enabled, so the kernel automatically

Re: [PATCH 2.6.32-rc1] net: VMware virtual Ethernet NIC driver: vmxnet3

2009-10-01 Thread David Miller
From: Shreyas Bhatewara sbhatew...@vmware.com Date: Wed, 30 Sep 2009 14:34:57 -0700 (PDT) +{ + struct vmxnet3_adapter *adapter = netdev_priv(netdev); + u8 *base; + int i; + + VMXNET3_WRITE_BAR1_REG(adapter, VMXNET3_REG_CMD, VMXNET3_CMD_GET_STATS); + + /* this does assume

Re: [PATCH 2.6.32-rc4] net: VMware virtual Ethernet NIC driver: vmxnet3

2009-10-13 Thread David Miller
From: Shreyas Bhatewara sbhatew...@vmware.com Date: Mon, 12 Oct 2009 15:18:42 -0700 (PDT) Ethernet NIC driver for VMware's vmxnet3 From: Shreyas Bhatewara sbhatew...@vmware.com This patch adds driver support for VMware's virtual Ethernet NIC: vmxnet3 Guests running on VMware hypervisors

Re: [PATCHv7 1/3] tun: export underlying socket

2009-11-04 Thread David Miller
From: Michael S. Tsirkin m...@redhat.com Date: Tue, 3 Nov 2009 19:24:00 +0200 Assuming it's okay with davem, I think it makes sense to merge this patch through Rusty's tree because vhost is the first user of the new interface. Posted here for completeness. I'm fine with that, please add my:

Re: [PATCHv3 0/4] macvlan: add vepa and bridge mode

2009-11-26 Thread David Miller
From: Patrick McHardy ka...@trash.net Date: Thu, 26 Nov 2009 17:26:17 +0100 Arnd Bergmann wrote: Version 2 description: The patch to iproute2 has not changed, so I'm not including it this time. Patch 4/4 (the netlink interface) is basically unchanged as well but included for completeness.

Re: [RFC] macvlan: add tap device backend

2009-12-14 Thread David Miller
From: Arnd Bergmann a...@arndb.de Date: Mon, 14 Dec 2009 13:00:36 +0100 c) prepare a combined patch for net-next.git, or This is probably fine. I'll be taking patches into net-next-2.6 right after Linus releases 2.6.33-rc1. ___ Virtualization mailing

Re: [PATCH 0/2] virtio net improvements

2010-02-02 Thread David Miller
From: Rusty Russell ru...@rustcorp.com.au Date: Wed, 3 Feb 2010 09:57:06 +1030 On Fri, 29 Jan 2010 11:46:43 pm Rusty Russell wrote: Hi Dave, Nice driver optimization from Shirley, but requires a new virtio hook. Do you want to take both? I have nothing else overlapping it. Dave, any

Re: [PATCH 1/2] virtio: Add ability to detach unused buffers from vrings

2010-02-02 Thread David Miller
From: Rusty Russell ru...@rustcorp.com.au Date: Fri, 29 Jan 2010 23:49:05 +1030 From: Shirley Ma mashi...@us.ibm.com There's currently no way for a virtio driver to ask for unused buffers, so it has to keep a list itself to reclaim them at shutdown. This is redundant, since virtio_ring

Re: [PATCH 2/2] virtio_net: Defer skb allocation in receive path Date: Wed, 13 Jan 2010 12:53:38 -0800

2010-02-02 Thread David Miller
From: Rusty Russell ru...@rustcorp.com.au Date: Fri, 29 Jan 2010 23:50:04 +1030 From: Shirley Ma mashi...@us.ibm.com virtio_net receives packets from its pre-allocated vring buffers, then it delivers these packets to upper layer protocols as skb buffs. So it's not necessary to pre-allocate

Re: [PATCH 0/3 v4] macvtap driver

2010-02-03 Thread David Miller
From: Arnd Bergmann a...@arndb.de Date: Sat, 30 Jan 2010 23:22:15 +0100 This is the fourth version of the macvtap driver, based on the comments I got for the last version I got a few days ago. Very few changes: * release netdev in chardev open function so we can destroy it properly. *

Re: [PATCH] vhost-net: switch to smp barriers

2010-02-14 Thread David Miller
From: Michael S. Tsirkin m...@redhat.com Date: Sat, 13 Feb 2010 19:39:11 +0200 Dave, I see it's marked not applicable: http://patchwork.ozlabs.org/patch/44207/ the patch applies to net-next as of b3b3f04fb587ecb61b5baa6c1c5f0e666fd12d73. Can this be queued up please? Should I resubmit with

Re: [PATCH 3/3] vhost: fix get_user_pages_fast error handling

2010-02-23 Thread David Miller
Just for the record I'm generally not interested in vhost patches. If it's a specific network one that will be merged via the networking tree, yes please CC: me. But if it's a bunch of changes to vhost.c and other pieces of infrastructure, feel free to leave me out of it. It just clutters my

Re: [PATCH 3/3] vhost: fix get_user_pages_fast error handling

2010-02-23 Thread David Miller
From: Michael S. Tsirkin m...@redhat.com Date: Wed, 24 Feb 2010 07:37:37 +0200 Dave, so while Rusty's on vacation, what's the best way to get vhost infrastructure fixes in? Are you ok with getting pull requests and merging them into net-next? That should keep the clutter in your inbox to the

Re: [PATCH 3/3] vhost: fix get_user_pages_fast error handling

2010-02-23 Thread David Miller
From: Michael S. Tsirkin m...@redhat.com Date: Wed, 24 Feb 2010 09:34:25 +0200 Implicitly, I guess. He said if there's an issue Michael Tsirkin is the best person to resolve it, this was wrt merging his virtiolguest tree. He didn't mention vhost, I wrote all of vhost though, there shouldn't be

Re: [GIT PULL] vhost-net fixes for 2.6.34

2010-02-28 Thread David Miller
From: Michael S. Tsirkin m...@redhat.com Date: Sun, 28 Feb 2010 20:44:40 +0200 The following changes since commit 655ffee284dfcf9a24ac0343f3e5ee6db85b85c5: Jiri Pirko (1): wireless: convert to use netdev_for_each_mc_addr are available in the git repository at:

Re: [GIT PULL] vhost-net fixes for issues in 2.6.34-rc1

2010-03-20 Thread David Miller
From: Michael S. Tsirkin m...@redhat.com Date: Thu, 18 Mar 2010 11:53:55 +0200 The following tree includes patches fixing issues with vhost-net in 2.6.34-rc1. Please pull them for 2.6.34. Pulled, thanks a lot. ___ Virtualization mailing list

Re: [GIT PULL] vhost-net fix for 2.6.34-rc3

2010-04-07 Thread David Miller
From: Michael S. Tsirkin m...@redhat.com Date: Wed, 7 Apr 2010 20:35:02 +0300 David, The following tree includes a patch fixing an issue with vhost-net in 2.6.34-rc3. Please pull for 2.6.34. Pulled, thanks Michael. ___ Virtualization mailing list

Re: [GIT PULL] first round of vhost-net enhancements for net-next

2010-05-03 Thread David Miller
From: David Miller da...@davemloft.net Date: Mon, 03 May 2010 15:07:29 -0700 (PDT) From: Michael S. Tsirkin m...@redhat.com Date: Tue, 4 May 2010 00:32:45 +0300 The following tree includes a couple of enhancements that help vhost-net. Please pull them for net-next. Another set of patches

Re: [GIT PULL] first round of vhost-net enhancements for net-next

2010-05-03 Thread David Miller
From: Michael S. Tsirkin m...@redhat.com Date: Tue, 4 May 2010 00:32:45 +0300 The following tree includes a couple of enhancements that help vhost-net. Please pull them for net-next. Another set of patches is under debugging/testing and I hope to get them ready in time for 2.6.35, so there

Re: [GIT PULL] amended: first round of vhost-net enhancements for net-next

2010-05-06 Thread David Miller
From: Michael S. Tsirkin m...@redhat.com Date: Tue, 4 May 2010 14:21:01 +0300 This is an amended pull request: I have rebased the tree to the correct patches. This has been through basic tests and seems to work fine here. The following tree includes a couple of enhancements that help

Re: [PATCHv2] vhost-net: add dhclient work-around from userspace

2010-06-29 Thread David Miller
From: Michael S. Tsirkin m...@redhat.com Date: Mon, 28 Jun 2010 13:08:07 +0300 Userspace virtio server has the following hack so guests rely on it, and we have to replicate it, too: Use port number to detect incoming IPv4 DHCP response packets, and fill in the checksum for these. The

Re: [PATCHv2] vhost-net: add dhclient work-around from userspace

2010-06-30 Thread David Miller
From: Michael S. Tsirkin m...@redhat.com Date: Tue, 29 Jun 2010 16:04:39 +0300 Since using the module involves updating the management tools as well, if we go down this route it will be much less painful for everyone to do push it upstream. Ok, you can make your case to Patrick McHardy and if

Re: [GIT PULL net-2.6] vhost-net: more error handling fixes

2010-07-02 Thread David Miller
From: Michael S. Tsirkin m...@redhat.com Date: Thu, 1 Jul 2010 19:41:27 +0300 David, The following tree includes more fixes dealing with error handling in vhost-net. It is on top of net-2.6. Please merge it for 2.6.35. Thanks! The following changes since commit

Re: [Pv-drivers] RFC: Network Plugin Architecture (NPA) for vmxnet3

2010-07-14 Thread David Miller
From: Pankaj Thakkar pthak...@vmware.com Date: Wed, 14 Jul 2010 10:18:22 -0700 The plugin is guest agnostic and hence we did not want to rely on any kernel provided functions. While I disagree entirely with this kind of approach, even that doesn't justify what you're doing here. memcpy() and

Re: [GIT PULL] vhost-net fixes

2010-07-16 Thread David Miller
From: Michael S. Tsirkin m...@redhat.com Date: Fri, 16 Jul 2010 15:25:30 +0300 David, please pull the following fixes for 2.6.35. Thanks! The following changes since commit 91a72a70594e5212c97705ca6a694bd307f7a26b: net/core: neighbour update Oops (2010-07-14 18:02:16 -0700) are

Re: [GIT PULL net-next-2.6] vhost-net patchset for 2.6.36

2010-08-02 Thread David Miller
From: Michael S. Tsirkin m...@redhat.com Date: Wed, 28 Jul 2010 16:32:31 +0300 The following changes since commit 4cfa580e7eebb8694b875d2caff3b989ada2efac: r6040: Fix args to phy_mii_ioctl(). (2010-07-21 21:10:49 -0700) are available in the git repository at:

Re: [GIT PULL net-2.6] vhost-net: 2.6.36 regression fixes

2010-09-09 Thread David Miller
From: Michael S. Tsirkin m...@redhat.com Date: Mon, 6 Sep 2010 14:36:06 +0300 The following tree includes more regression fixes for vhost-net in 2.6.36. It is on top of net-2.6. Please merge it for 2.6.36. Pulled, thanks Michael. ___ Virtualization

Re: [GIT PULL net-2.6] vhost-net: fix range checking

2010-09-20 Thread David Miller
From: Michael S. Tsirkin m...@redhat.com Date: Mon, 20 Sep 2010 19:42:22 +0200 git://git.kernel.org/pub/scm/linux/kernel/git/mst/vhost.git vhost-net Pulled, thanks! ___ Virtualization mailing list Virtualization@lists.linux-foundation.org

Re: [GIT PULL net-2.6] vhost-net: last minute fix

2010-09-27 Thread David Miller
From: Michael S. Tsirkin m...@redhat.com Date: Mon, 27 Sep 2010 15:34:13 +0200 The following tree includes a last minute bugfix for vhost-net. It is on top of net-2.6. Please merge it for 2.6.36. Pulled, thanks Michael. ___ Virtualization mailing

Re: [GIT PULL net-next-2.6] vhost-net patchset for 2.6.37

2010-10-06 Thread David Miller
From: Michael S. Tsirkin m...@redhat.com Date: Tue, 5 Oct 2010 20:27:32 +0200 It looks like it was a quiet cycle for vhost-net: probably because most of energy was spent on bugfixes that went in for 2.6.36. People are working on multiqueue, tracing but I'm not sure it'll get done in time for

Re: [GIT PULL net-2.6] vhost-net: access_ok fix

2010-10-21 Thread David Miller
From: Michael S. Tsirkin m...@redhat.com Date: Tue, 19 Oct 2010 16:59:01 +0200 David, Not sure if it's too late for 2.6.36 - in case it's not, the following tree includes a last minute bugfix for vhost-net, found by code inspection. It is on top of net-2.6. Thanks! The following changes

Re: [GIT PULL net-2.6] vhost-net: rcu fixup

2010-11-28 Thread David Miller
From: Michael S. Tsirkin m...@redhat.com Date: Thu, 25 Nov 2010 14:23:01 +0200 Please merge the following fix for 2.6.36. Thanks! The following changes since commit a27e13d370415add3487949c60810e36069a23a6: econet: fix CVE-2010-3848 (2010-11-24 11:51:47 -0800) are available in the

Re: [GIT PULL net-2.6] vhost-net: logging fixup

2010-12-12 Thread David Miller
From: Michael S. Tsirkin m...@redhat.com Date: Sun, 12 Dec 2010 12:09:43 +0200 Please merge the following fix for 2.6.37. It is also applicable to -stable. Thanks! The following changes since commit a19faf0250e09b16cac169354126404bc8aa342b: net: fix skb_defer_rx_timestamp() (2010-12-10

Re: [GIT PULL net-next-2.6] vhost-net: tools, cleanups, optimizations

2010-12-14 Thread David Miller
From: Michael S. Tsirkin m...@redhat.com Date: Tue, 14 Dec 2010 14:23:26 +0200 On Mon, Dec 13, 2010 at 12:44:13PM +0200, Michael S. Tsirkin wrote: Please merge the following tree for 2.6.38. Thanks! Rusty Acked it as is, so please pull the below. Thanks very much! The following changes

Re: [PULL] vhost-net: 2.6.38 fix

2011-01-14 Thread David Miller
From: Michael S. Tsirkin m...@redhat.com Date: Fri, 14 Jan 2011 11:33:02 +0200 Please pull the following for 2.6.38. Thanks! The following changes since commit 0c21e3aaf6ae85bee804a325aa29c325209180fd: Merge branch 'for-next' of

Re: [PULL] vhost-net: 2.6.38 - warning fix

2011-02-01 Thread David Miller
From: Michael S. Tsirkin m...@redhat.com Date: Tue, 1 Feb 2011 17:44:40 +0200 git://git.kernel.org/pub/scm/linux/kernel/git/mst/vhost.git vhost-net Pulled, thanks Michael. ___ Virtualization mailing list Virtualization@lists.linux-foundation.org

Re: [PATCH] virtio_net: Add schedule check to napi_enable call

2011-02-10 Thread David Miller
From: Michael S. Tsirkin m...@redhat.com Date: Thu, 10 Feb 2011 19:57:26 +0200 On Thu, Feb 10, 2011 at 12:32:50PM +1030, Rusty Russell wrote: From: Bruce Rogers brog...@novell.com Under harsh testing conditions, including low memory, the guest would stop receiving packets. With this patch

Re: [PATCH] virtio_net: Add schedule check to napi_enable call

2011-02-10 Thread David Miller
From: Rusty Russell ru...@rustcorp.com.au Date: Thu, 10 Feb 2011 12:32:50 +1030 From: Bruce Rogers brog...@novell.com Under harsh testing conditions, including low memory, the guest would stop receiving packets. With this patch applied we no longer see any problems in the driver while

Re: [PATCH] vhost: copy_from_user - __copy_from_user

2011-03-06 Thread David Miller
From: Michael S. Tsirkin m...@redhat.com Date: Sun, 6 Mar 2011 13:33:49 +0200 copy_from_user is pretty high on perf top profile, replacing it with __copy_from_user helps. It's also safe because we do access_ok checks during setup. Signed-off-by: Michael S. Tsirkin m...@redhat.com Is Rusty

Re: [PULL net-2.6] vhost: cleanups and fixes

2011-03-20 Thread David Miller
From: Michael S. Tsirkin m...@redhat.com Date: Thu, 17 Mar 2011 16:04:04 +0200 The following changes since commit 1fc050a13473348f5c439de2bb41c8e92dba5588: ipv4: Cache source address in nexthop entries. (2011-03-07 20:54:48 -0800) are available in the git repository at:

Re: [PATCH] virtio_net: convert to hw_features

2011-04-01 Thread David Miller
From: Michał Mirosław mirq-li...@rere.qmqm.pl Date: Thu, 31 Mar 2011 13:01:35 +0200 (CEST) Signed-off-by: Michał Mirosław mirq-li...@rere.qmqm.pl Applied. ___ Virtualization mailing list Virtualization@lists.linux-foundation.org

Re: [PATCH RESEND] net: convert xen-netfront to hw_features

2011-04-01 Thread David Miller
From: Michał Mirosław mirq-li...@rere.qmqm.pl Date: Thu, 31 Mar 2011 13:01:35 +0200 (CEST) Not tested in any way. The original code for offload setting seems broken as it resets the features on every netback reconnect. This will set GSO_ROBUST at device creation time (earlier than connect

Re: [PATCH RESEND] net: convert xen-netfront to hw_features

2011-04-04 Thread David Miller
From: Ian Campbell ian.campb...@eu.citrix.com Date: Mon, 4 Apr 2011 13:29:19 +0100 From 0b56469abe56efae415b4603ef508ce9aec0e4c1 Mon Sep 17 00:00:00 2001 From: Ian Campbell ian.campb...@citrix.com Date: Mon, 4 Apr 2011 10:58:50 +0100 Subject: [PATCH] xen: netfront: assume all hw features are

Re: Signed bit field; int have_hotplug_status_watch:1

2011-04-06 Thread David Miller
From: Ian Campbell ian.campb...@eu.citrix.com Date: Mon, 4 Apr 2011 09:26:24 +0100 Subject: [PATCH] xen: netback: use unsigned type for one-bit bitfield. Fixes error from sparse: CHECK drivers/net/xen-netback/xenbus.c drivers/net/xen-netback/xenbus.c:29:40: error: dubious one-bit signed

Re: [PATCH] xen: drop anti-dependency on X86_VISWS

2011-04-06 Thread David Miller
From: Ian Campbell ian.campb...@eu.citrix.com Date: Mon, 4 Apr 2011 10:55:55 +0100 You mean the !X86_VISWS I presume? It doesn't make sense to me either. No, I think 32-bit x86 allmodconfig elides XEN because of it's X86_TSC dependency. And, well, you could type make allmodconfig on your tree

Re: [PATCHv2 00/14] virtio and vhost-net performance enhancements

2011-05-19 Thread David Miller
From: Michael S. Tsirkin m...@redhat.com Date: Fri, 20 May 2011 02:10:07 +0300 Rusty, I think it will be easier to merge vhost and virtio bits in one go. Can it all go in through your tree (Dave in the past acked sending a very similar patch through you so should not be a problem)? And in

Re: [PATCH] virtio_net: introduce VIRTIO_NET_HDR_F_DATA_VALID

2011-06-11 Thread David Miller
From: Michael S. Tsirkin m...@redhat.com Date: Fri, 10 Jun 2011 14:28:28 +0300 On Fri, Jun 10, 2011 at 06:56:17PM +0800, Jason Wang wrote: There's no need for the guest to validate the checksum if it have been validated by host nics. So this patch introduces a new flag -

Re: [PATCH] virtio-net: per cpu 64 bit stats (v2)

2011-06-17 Thread David Miller
From: Stephen Hemminger shemmin...@vyatta.com Date: Wed, 15 Jun 2011 12:36:29 -0400 Use per-cpu variables to maintain 64 bit statistics. Signed-off-by: Stephen Hemminger shemmin...@vyatta.com I'll apply this, thanks. ___ Virtualization mailing list

Re: [PATCH 4/4] xen/netback: Add module alias for autoloading

2011-06-30 Thread David Miller
From: Konrad Rzeszutek Wilk konrad.w...@oracle.com Date: Thu, 30 Jun 2011 12:39:54 -0400 On Wed, Jun 29, 2011 at 02:41:32PM +0200, Bastian Blank wrote: Add xen-backend:vif module alias to the xen-netback module. This allows automatic loading of the module. Dave, Could you queue this up

Re: Large Patch Series in Email

2011-07-15 Thread David Miller
From: Michael Witten mfwit...@gmail.com Date: Fri, 15 Jul 2011 22:55:29 - On Sat, 16 Jul 2011 00:09:03 +0300, Dan Carpenter wrote: On Fri, Jul 15, 2011 at 06:25:55PM -, Michael Witten wrote: Do not send more than 15 patches at once to the vger mailing lists!!! ... Don't be a

Re: [PATCHv9] vhost: experimental tx zero-copy support

2011-07-17 Thread David Miller
From: Michael S. Tsirkin m...@redhat.com Date: Sun, 17 Jul 2011 22:36:14 +0300 The below is what I came up with. We add the feature enabled by default ... s/enabled/disabled/ Well, at least you got it right in the commit message where it counts :-)

Re: [PATCHv11] vhost: vhost TX zero-copy support

2011-07-18 Thread David Miller
From: Michael S. Tsirkin m...@redhat.com Date: Mon, 18 Jul 2011 16:48:46 +0300 From: Shirley Ma mashi...@us.ibm.com This adds experimental zero copy support in vhost-net, disabled by default. To enable, set experimental_zcopytx module option to 1. This patch maintains the outstanding

Re: [PATCH repost] Fix panic in virtnet_remove

2011-07-21 Thread David Miller
From: Michael S. Tsirkin m...@redhat.com Date: Wed, 20 Jul 2011 17:31:15 +0300 On Wed, Jul 20, 2011 at 07:26:02PM +0530, Krishna Kumar wrote: Fix a panic in virtnet_remove. unregister_netdev has already freed up the netdev (and virtnet_info) due to dev-destructor being set, while virtnet_info

Re: [PULL net] vhost-net: zercopy mode fixes

2011-07-22 Thread David Miller
From: Michael S. Tsirkin m...@redhat.com Date: Fri, 22 Jul 2011 09:00:46 +0300 The following includes vhost-net fixes - both in the experimental zero copy mode. Please pull for 3.1. Thanks! Where is this the following? I don't see any GIT url to pull from or anything :-)

Re: [PULL net (try 2)] vhost-net: zercopy mode fixes

2011-07-22 Thread David Miller
From: Michael S. Tsirkin m...@redhat.com Date: Fri, 22 Jul 2011 09:32:38 +0300 Fixing a corrupted pull request sent earlier. Sorry about the noise! The following includes vhost-net fixes - both in the experimental zero copy mode. Please pull for 3.1. Pulled, thanks!

Re: [RFC 0/0] Introducing a generic socket offload framework

2011-08-18 Thread David Miller
I'm not reading any RFC without any example code, sorry. ___ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linux-foundation.org/mailman/listinfo/virtualization

Re: [RFC PATCH net-next v2] enable virtio_net to return bus_info in ethtool -i consistent with emulated NICs

2011-11-16 Thread David Miller
From: r...@tardy.cup.hp.com (Rick Jones) Date: Mon, 14 Nov 2011 16:17:08 -0800 (PST) From: Rick Jones rick.jon...@hp.com Add a new .bus_name to virtio_config_ops then modify virtio_net to call through to it in an ethtool .get_drvinfo routine to report bus_info in ethtool -i output which is

Re: [PATCH] macvtap: Fix macvtap_get_queue to use rxhash first

2011-11-24 Thread David Miller
From: Krishna Kumar2 krkum...@in.ibm.com Date: Fri, 25 Nov 2011 09:39:11 +0530 Jason Wang jasow...@redhat.com wrote on 11/25/2011 08:51:57 AM: My description is not clear again :( I mean the same vhost thead: vhost thread #0 transmits packets of flow A on processor M ... vhost thread #0

Re: [PATCH] vhost-net: Acquire device lock when releasing device

2011-11-26 Thread David Miller
From: Sasha Levin levinsasha...@gmail.com Date: Fri, 18 Nov 2011 11:19:42 +0200 Device lock should be held when releasing a device, and specifically when calling vhost_dev_cleanup(). Otherwise, RCU complains about it: ... Cc: Michael S. Tsirkin m...@redhat.com Cc: k...@vger.kernel.org Cc:

Re: [PATCH] macvtap: Fix macvtap_get_queue to use rxhash first

2011-12-07 Thread David Miller
From: Michael S. Tsirkin m...@redhat.com Date: Wed, 7 Dec 2011 18:10:02 +0200 On Fri, Nov 25, 2011 at 01:35:52AM -0500, David Miller wrote: From: Krishna Kumar2 krkum...@in.ibm.com Date: Fri, 25 Nov 2011 09:39:11 +0530 Jason Wang jasow...@redhat.com wrote on 11/25/2011 08:51:57 AM: My

Re: [PATCH v3 REPOST] xen-netfront: delay gARP until backend switches to Connected

2011-12-09 Thread David Miller
From: Laszlo Ersek ler...@redhat.com Date: Fri, 9 Dec 2011 12:38:58 +0100 These two together provide complete ordering. Sub-condition (1) is satisfied by pvops commit 43223efd9bfd. I don't see this commit in Linus's tree, so I doubt it's valid for me to apply this as a bug fix to my 'net'

Re: [PATCH v3 REPOST] xen-netfront: delay gARP until backend switches to Connected

2011-12-09 Thread David Miller
From: Ian Campbell ian.campb...@citrix.com Date: Fri, 9 Dec 2011 21:23:00 + On Fri, 2011-12-09 at 18:45 +, David Miller wrote: From: Laszlo Ersek ler...@redhat.com Date: Fri, 9 Dec 2011 12:38:58 +0100 These two together provide complete ordering. Sub-condition (1) is satisfied

Re: [PATCH] macvtap: Fix macvtap_get_queue to use rxhash first

2011-12-20 Thread David Miller
From: Michael S. Tsirkin m...@redhat.com Date: Tue, 20 Dec 2011 13:15:12 +0200 On Wed, Dec 07, 2011 at 01:52:35PM -0500, David Miller wrote: Once you sort this out, reply with an Acked-by: for me, thanks. Acked-by: Michael S. Tsirkin m...@redhat.com Applied

  1   2   3   4   5   >