RE: [patch 00/54] [Announce] Microsoft Hyper-V drivers for Linux

2009-07-21 Thread Hank Janssen
What is the long term strategy to keep the sources in sync? Is there one? Do you expect to get updates for these sources? Balbir Balbir, I think you are asking me if we plan to continue contributing? It is my plan to use the kernel as my primary development area, and I will Continue

Learning question regarding virtio and partvirt_ops

2009-09-29 Thread Hank Janssen
Greetings all, I guess this is my official first port on the virtualization mailing list. So any errors in posting and the correctness of asking questions in the present And future are mine alone :) I am one of the Microsoft developers responsible for Hyper-V support for Linux. I had the

Ringbuffer usage in Linux Hyper-V drivers

2010-03-03 Thread Hank Janssen
of non virtualization device drivers currently in the kernel. And all the ones I looked at have implemented their own ring buffer. Is there a reason why this might be the case? As usual, any help is appreciated. Thanks, Hank Janssen. ___ Virtualization

[PATCH 1/1] Stage: hv: Remove Ringbuffer from TODO line

2010-03-04 Thread Hank Janssen
From: Hank Janssen hjans...@microsoft.com Remove Ringbuffer work line item from TODO file. The ring buffer in the Hyper-V Linux drivers is used to communicate with the parent partition running Windows Server 2008 Hyper-V. The ring buffer functionality on the Hyper-V Linux drivers is written

[PATCH 1/1] Stage: hv: Corrected all header comments to follow kernel-doc format

2010-03-04 Thread Hank Janssen
From: Hank Janssen hjans...@microsoft.com Removed kerneldoc /** from functions that should not have them. Added proper kerneldoc headers to functions that should have them. Cc: Greg Kroah-Hartman gre...@suse.de Signed-off-by: Hank Janssen hjans...@microsoft.com Signed-off-by: Haiyang Zhang

[PATCH 1/1] Stage: hv: Corrected all header comments to follow kernel-doc format-CORRECTED

2010-03-04 Thread Hank Janssen
From: Hank Janssen hjans...@microsoft.com Removed kerneldoc /** from functions that should not have them. Added proper kerneldoc headers to functions that should have them. This includes fixes as pointed out by Randy Dunlap and Joe Perches. Cc: Greg Kroah-Hartman gre...@suse.de Cc: Joe Perches

RE: [PATCH 1/1] hv: Added new hv_utils driver to hyper-v - CORRECTED

2010-04-30 Thread Hank Janssen
From: Greg KH [mailto:g...@kroah.com] - Thursday, April 29, 2010 12:15 PM Cc: Greg Kroah-Hartman gre...@suse.de Signed-off-by: Hank Janssen hjans...@microsoft.com Signed-off-by: Haiyang Zhang haiya...@microsoft.com This patch fails to apply :( Can you redo it against the linux-next

[PATCH 1/1] hv: Added new hv_utils driver to hyper-v - RE-CREATED

2010-04-30 Thread Hank Janssen
this patch and the one I send earlier this Week, I do not see anything different in my patch. Let me know if there is still an issue with this. Thanks, Hank. - From: Hank Janssen hjans...@microsoft.com Subject: [PATCH 1/1] hv: Added new hv_utils driver with shutdown as first

[PATCH 1/1] hv: Added new hv_utils driver with shutdown as first functionality - NO OUTLOOK

2010-05-04 Thread Hank Janssen
Resending this patch from my personal Linux server. Exchange server and outlook at Microsoft seems to badly munge my patch. :( From: Hank Janssen hjans...@sailtheuniverse.com Subject: [PATCH 1/1] hv: Added new hv_utils driver with shutdown as first functionality Addition of new driver

RE: Patch to auto-load MSFT PV NIC driver

2010-05-08 Thread Hank Janssen
From: Ky Srinivasan [ksriniva...@novell.com] - Friday, May 07, 2010 4:52 PM I am attaching a patch to auto-load hv_netvsc. I am not sure if this is the right approach. hv_netvsc takes a dependency on hv_vmbus. hv_vmbus does have the same DMI detection logic in it. But unless hv_vmbus has

RE: Patch to auto-load MSFT PV NIC driver

2010-05-10 Thread Hank Janssen
Sent: Saturday, May 08, 2010 7:27 AM - Hank Janssen On Sat, May 08, 2010 at 01:52:01PM +, Hank Janssen wrote: I am not sure if this is the right approach. hv_netvsc takes a dependency on hv_vmbus. hv_vmbus does have the same DMI detection logic in it. But unless hv_vmbus has loaded

[PATCH 1/1] staging: hv: Added heartbeat functionality to hv_utils

2010-05-15 Thread Hank Janssen
From: Hank Janssen hjans...@microsoft.com Subject: [PATCH 1/1] staging: hv: Added heartbeat functionality to hv_utils Add heartbeat functionality to hv_utils/Hyper-V Signed-off-by: Haiyang Zhang haiya...@microsoft.com Signed-off-by: Hank Janssen hjans...@microsoft.com --- drivers/staging/hv

[PATCH 1/6] staging: hv: Fixed bounce kmap problem by using correct index

2010-08-03 Thread Hank Janssen
From: Hank Janssen hjans...@microsoft.com Fixed bounce offset kmap problem by using correct index Signed-off-by:Hank Janssen hjans...@microsoft.com Signed-off-by:Haiyang Zhang haiya...@microsoft.com --- drivers/staging/hv/storvsc_drv.c |4 ++-- 1 files changed, 2 insertions(+), 2

[PATCH 6/6] staging: hv: Gracefully handle SCSI resets

2010-08-03 Thread Hank Janssen
From: Hank Janssen hjans...@microsoft.com If we get a SCSI host bus reset we now gracefully handle it, and we take the device offline. This before sometimes caused hangs. Signed-off-by:Hank Janssen hjans...@microsoft.com Signed-off-by:Haiyang Zhang haiya...@microsoft.com --- drivers/staging

[PATCH 2/6] staging: hv: Fixed lockup problem with bounce_buffer scatter list

2010-08-03 Thread Hank Janssen
From: Hank Janssen hjans...@microsoft.com Fixed lockup problem with bounce_buffer scatter list which caused crashes in heavy loads. Signed-off-by:Hank Janssen hjans...@microsoft.com Signed-off-by:Haiyang Zhang haiya...@microsoft.com --- drivers/staging/hv/storvsc_drv.c |9 ++--- 1

RE: [PATCH 5/6] staging: hv: Increased storvsc ringbuffer and max_io_requests

2010-08-03 Thread Hank Janssen
And than Greg KH spoke these words: On Tue, Aug 03, 2010 at 05:31:55PM +, Hank Janssen wrote: From: Hank Janssen hjans...@microsoft.com Increased storvsc ringbuffer and max_io_requests. This now more closely mimics the numbers on Hyper-V. What do you mean by this? The max provided

RE: [PATCH 3/6] staging: hv: Fixed the value of the 64bit-hole inside ring buffer

2010-08-03 Thread Hank Janssen
On Tue, Aug 03, 2010 at 05:31:57PM +, Hank Janssen wrote: From: Haiyang Zhang haiya...@microsoft.com Fixed the value of the 64bit-hole inside ring buffer, this caused a problem on Hyper-V when running checked Windows builds. What was the problem, and why would this fix

RE: [PATCH 6/6] staging: hv: Gracefully handle SCSI resets

2010-08-03 Thread Hank Janssen
And then Greg spoke; On Tue, Aug 03, 2010 at 05:31:56PM +, Hank Janssen wrote: From: Hank Janssen hjans...@microsoft.com If we get a SCSI host bus reset we now gracefully handle it, and we take the device offline. This before sometimes caused hangs. Is this a problem for all older

RE: hv block drivers

2010-08-30 Thread Hank Janssen
On Monday 30 August 2010 Arnd Bergmann wrote: On Monday 30 August 2010, Jeremy Fitzhardinge wrote: Have you investigated making virtio a scsi device? I doubt that there is much value in changing it now, and it's not something I'd be interested in working on. For the HyperV drivers, it

RE: [PATCH 5/5] staging: hv: Gracefully handle SCSI resets

2010-09-01 Thread Hank Janssen
From: Greg KH [mailto:g...@kroah.com] Sent: Monday, August 30, 2010 4:52 PM This patch is corrupted as well, something odd is going on in your email system :( care to resend it? Of course, I will resend these from my own account in a few minutes after I check them At least it will bypass

[PATCH 2/5] staging: hv: Fixed lockup problem with bounce_buffer scatter list - RESEND

2010-09-01 Thread Hank Janssen
(Send from a linux machine, not routed through exchange) Fixed lockup problem with bounce_buffer scatter list which caused crashes in heavy loads. Signed-off-by:Hank Janssen hjans...@microsoft.com Signed-off-by:Haiyang Zhang haiya...@microsoft.com --- drivers/staging/hv/storvsc_drv.c |9

[PATCH 5/5] staging: hv: Gracefully handle SCSI resets - RESEND

2010-09-01 Thread Hank Janssen
(Send from a linux machine, not routed through exchange) If we get a SCSI host bus reset we now gracefully handle it, and we take the device offline. This before sometimes caused hangs. Signed-off-by:Hank Janssen hjans...@microsoft.com Signed-off-by:Haiyang Zhang haiya...@microsoft.com ---

Re: [PATCH 2/5] staging: hv: Fixed lockup problem with bounce_buffer scatter list - RESEND

2010-09-01 Thread Hank Janssen
On 09/01/2010 09:38 AM, Joe Perches wrote: On Tue, 2010-08-31 at 11:13 -0700, Hank Janssen wrote: diff --git a/drivers/staging/hv/storvsc_drv.c b/drivers/staging/hv/storvsc_drv.c [] -request-DataBuffer.PfnArray[i] = -page_to_pfn

[PATCH 2/5] staging: hv: Fixed lockup problem with bounce_buffer scatter list - Cleaned up

2010-09-02 Thread Hank Janssen
Fixed lockup problem with bounce_buffer scatter list which caused crashes in heavy loads. And minor code indentation cleanup in effected area. Removed whitespace and noted minor indentation changes in description as pointed out by Joe Perches. (Thanks for reviewing Joe) Signed-off-by:Hank

[PATCH 1/1] staging: hv: Remove camel case variables in channel.c

2010-09-30 Thread Hank Janssen
From: Haiyang Zhang haiya...@microsoft.com Rename camel case variables in channel.c and changed them to lowercase. Signed-off-by: Haiyang Zhang haiya...@microsoft.com Signed-off-by: Hank Janssen hjans...@microsoft.com --- drivers/staging/hv/channel.c | 767

[PATCH 1/1] staging: hv: Rename camel cased functions in channel.c to lowercase

2010-10-07 Thread Hank Janssen
From: Haiyang Zhang haiya...@microsoft.com Rename camel cased functions in channel.c to lowercase Signed-off-by: Haiyang Zhang haiya...@microsoft.com Signed-off-by: Hank Janssen hjans...@microsoft.com --- drivers/staging/hv/channel.c | 102 drivers

[PATCH 1/1] staging: hv: Doubled ringbuffer size for Hyper-v network driver

2010-10-12 Thread Hank Janssen
From: Hank Janssen hjans...@microsoft.com Double the default network ringsize buffer for Hyper-V network driver. In very heavily loaded systems the there is a chance you run out of ringbuffer space and error out. Signed-off-by: Haiyang Zhang haiya...@microsoft.com Signed-off-by: Hank Janssen

[PATCH 4/8] staging: hv: Convert camel case struct fields in storvsc.c to lowercase

2010-12-06 Thread Hank Janssen
From: Hank Janssen hjans...@microsoft.com Convert camel cased struct fields in storvsc.c to lowercase Signed-off-by: Abhishek Kane v-abk...@microsoft.com Signed-off-by: Haiyang Zhang haiya...@microsoft.com Signed-off-by: Hank Janssen hjans...@microsoft.com --- drivers/staging/hv/storvsc.c

[PATCH 3/8] staging: hv: Convert camel case functions in storvsc_api.h to lowercase

2010-12-06 Thread Hank Janssen
From: Hank Janssen hjans...@microsoft.com Convert camel case functions in storvsc_api.h to lowercase Signed-off-by: Abhishek Kane v-abk...@microsoft.com Signed-off-by: Haiyang Zhang haiya...@microsoft.com Signed-off-by: Hank Janssen hjans...@microsoft.com --- drivers/staging/hv/blkvsc.c

[PATCH 7/8] staging: hv: Convert camel case function names in blkvsc.c to lowercase

2010-12-06 Thread Hank Janssen
From: Hank Janssen hjans...@microsoft.com Convert camel case function names in blkvsc.c to lowercase Signed-off-by: Abhishek Kane v-abk...@microsoft.com Signed-off-by: Haiyang Zhang haiya...@microsoft.com Signed-off-by: Hank Janssen hjans...@microsoft.com --- drivers/staging/hv/blkvsc.c

[PATCH 8/8] staging: hv: Convert camel case local variables in blkvsc.c to lowercase

2010-12-06 Thread Hank Janssen
From: Hank Janssen hjans...@microsoft.com Convert camel case local variables in blkvsc.c to lowercase Signed-off-by: Abhishek Kane v-abk...@microsoft.com Signed-off-by: Haiyang Zhang haiya...@microsoft.com Signed-off-by: Hank Janssen hjans...@microsoft.com --- drivers/staging/hv/blkvsc.c

[PATCH 1/8] staging: hv: Convert camel case struct fields in vstorage.h to lowercase

2010-12-06 Thread Hank Janssen
From: Hank Janssen hjans...@microsoft.com Convert camel case struct fields in vstorage.h to lowercase Signed-off-by: Abhishek Kane v-abk...@microsoft.com Signed-off-by: Haiyang Zhang haiya...@microsoft.com Signed-off-by: Hank Janssen hjans...@microsoft.com --- drivers/staging/hv/storvsc.c

[PATCH 6/8] staging: hv: Convert camel case local variables in storvsc.c to lowercase

2010-12-06 Thread Hank Janssen
From: Hank Janssen hjans...@microsoft.com Convert camel case local variables in storvsc.c to lowercase Signed-off-by: Abhishek Kane v-abk...@microsoft.com Signed-off-by: Haiyang Zhang haiya...@microsoft.com Signed-off-by: Hank Janssen hjans...@microsoft.com --- drivers/staging/hv/storvsc.c

[PATCH 5/8] staging: hv: Convert camel case function names in storvsc.c to lowercase

2010-12-06 Thread Hank Janssen
From: Hank Janssen hjans...@microsoft.com Convert camel case function names in storvsc.c to lowercase Signed-off-by: Abhishek Kane v-abk...@microsoft.com Signed-off-by: Haiyang Zhang haiya...@microsoft.com Signed-off-by: Hank Janssen hjans...@microsoft.com --- drivers/staging/hv/blkvsc.c

[PATCH 2/8] staging: hv: Convert camel case struct fields in storvsc_api.h to lowercase

2010-12-06 Thread Hank Janssen
From: Hank Janssen hjans...@microsoft.com Convert camel case struct fields in vstorage.h to lowercase Signed-off-by: Abhishek Kane v-abk...@microsoft.com Signed-off-by: Haiyang Zhang haiya...@microsoft.com Signed-off-by: Hank Janssen hjans...@microsoft.com --- drivers/staging/hv/blkvsc.c

RE: [PATCH 2/3]: An implementation of HyperV KVP functionality

2010-12-08 Thread Hank Janssen
From: Ky Srinivasan [mailto:ksriniva...@novell.com] Sent: Tuesday, December 07, 2010 3:19 PM On 12/7/2010 at 5:29 PM, in message 20101207222933.ga10...@ioremap.net, Evgeniy Polyakov z...@ioremap.net wrote: On Tue, Dec 07, 2010 at 03:25:56PM -0700, Ky Srinivasan (ksriniva...@novell.com)

[PATCH 1/1] Properly check return values of kmalloc and vmbus_recvpacket

2010-12-09 Thread Hank Janssen
-by: Hank Janssen hjans...@microsoft.com --- drivers/staging/hv/hv_utils.c | 48 1 files changed, 33 insertions(+), 15 deletions(-) diff --git a/drivers/staging/hv/hv_utils.c b/drivers/staging/hv/hv_utils.c index 53e1e29..ac68575 100644 --- a/drivers/staging/hv

[PATCH 1/1] hv: Use only one receive buffer and kmalloc on initialize

2010-12-13 Thread Hank Janssen
. And thanks to Jesper Juhl j...@chaosbits.net and Ky Srinivasan ksriniva...@novell.com for suggesting a better implementation of my original patch. Signed-off-by: Haiyang Zhang haiya...@microsoft.com Signed-off-by: Hank Janssen hjans...@microsoft.com Cc:Evgeniy Polyakov z...@ioremap.net Cc:Jesper Juhl j

RE: [PATCH 1/1] hv: Use only one receive buffer and kmalloc on initialize

2010-12-13 Thread Hank Janssen
-Original Message- From: Greg KH [mailto:g...@kroah.com] Sent: Monday, December 13, 2010 11:41 AM The current versions of Hyper-V support interrupt handling on CPU0 only. I can make multiple buffers per channel, but because of Hyper-V implementation It does not really make a

[PATCH 1/1] hv: Use only one receive buffer per channel and kmalloc on initialize

2010-12-13 Thread Hank Janssen
. And thanks to Jesper Juhl j...@chaosbits.net and Ky Srinivasan ksriniva...@novell.com for suggesting a better implementation of my original patch. Signed-off-by: Haiyang Zhang haiya...@microsoft.com Signed-off-by: Hank Janssen hjans...@microsoft.com Cc: Evgeniy Polyakov z...@ioremap.net Cc: Jesper Juhl

RE: [PATCH 1/1] hv: Use only one receive buffer per channel and kmalloc on initialize

2010-12-13 Thread Hank Janssen
-Original Message- From: Jesper Juhl [mailto:j...@chaosbits.net] Sent: Monday, December 13, 2010 12:48 PM You are leaking memory in the failure path. If for example one or two allocations succeed but one or two fail, then you'll leak the two successful allocations. I believe

[PATCH 1/1] hv: Use only one txf buffer per channel and kmalloc on initialize

2010-12-13 Thread Hank Janssen
...@ioremap.net for pointing this out. And thanks to Jesper Juhl j...@chaosbits.net and Ky Srinivasan ksriniva...@novell.com for suggesting a better implementation of my original patch. Signed-off-by: Haiyang Zhang haiya...@microsoft.com Signed-off-by: Hank Janssen hjans...@microsoft.com Cc: Evgeniy

RE: [PATCH 1/1] hv: Use only one receive buffer per channel and kmalloc on initialize

2010-12-13 Thread Hank Janssen
-Original Message- From: Jesper Juhl [mailto:j...@chaosbits.net] Sent: Monday, December 13, 2010 1:06 PM On Mon, 13 Dec 2010, Hank Janssen wrote: ... Oops, you are correct. Resubmitting the patch in a few minutes. Ohh and another little detail; shouldn't this log message

RE: [PATCH 1/1] hv: Use only one txf buffer per channel and kmalloc on initialize

2010-12-13 Thread Hank Janssen
From: Jesper Juhl [mailto:j...@chaosbits.net] Sent: Monday, December 13, 2010 1:22 PM I can't spot any problems with these changes now, so feel free to add Reviewed-by: Jesper Juhl j...@chaosbits.net if you like. Thank you for your help Jesper. Greg, do you want me to resubmit with

RE: [PATCH 1/1] hv: Use only one receive buffer per channel and kmalloc on initialize

2010-12-13 Thread Hank Janssen
-Original Message- From: Jesper Juhl [mailto:j...@chaosbits.net] Sent: Monday, December 13, 2010 3:51 PM To: Ky Srinivasan + shut_txf_buf = kmalloc(PAGE_SIZE, GFP_ATOMIC); + time_txf_buf = kmalloc(PAGE_SIZE, GFP_ATOMIC); + hbeat_txf_buf = kmalloc(PAGE_SIZE, GFP_ATOMIC);

[PATCH 1/1] hv: Use only one txf buffer per channel and kmalloc/GFP_KERNEL on initialize

2010-12-13 Thread Hank Janssen
...@ioremap.net for pointing this out. And thanks to Jesper Juhl j...@chaosbits.net and Ky Srinivasan ksriniva...@novell.com for suggesting a better implementation of my original patch. Signed-off-by: Haiyang Zhang haiya...@microsoft.com Signed-off-by: Hank Janssen hjans...@microsoft.com Reviewed

[PATCH 1/1] staging: hv: Removed unneeded call to netif_stop_queue() in hv_netvsc

2011-01-07 Thread Hank Janssen
From: Hank Janssen hjans...@microsoft.com Removed the call to netif_stop_queue() in netvsc_probe() as the queue is not initialized at that point and further call to it after queue initialization is really not necessary. This change was prompted after an upstream change went into 2.6.37

RE: [PATCH 1/3]: Staging: hv: Use native page allocation/free functions

2011-02-11 Thread Hank Janssen
-Original Message- And then KY Srinivasan spoke on Friday, February 11, 2011 12:56 PM From: Greg KH [mailto:gre...@suse.de] Sent: Friday, February 11, 2011 1:30 PM - virtaddr = osd_virtual_alloc_exec(PAGE_SIZE); +#ifdef __x86_64__ + virtaddr = __vmalloc(PAGE_SIZE,

RE: [PATCH 1/3]: Staging: hv: Use native page allocation/free functions

2011-02-11 Thread Hank Janssen
-Original Message- From: Greg KH [mailto:gre...@suse.de] On Friday, February 11, 2011 1:24 PM On Fri, Feb 11, 2011 at 08:55:56PM +, KY Srinivasan wrote: I'm not saying this patch is wrong at all, but I still don't understand why this is different depending on the

[PATCH] Staging: hv: Use list_entry for msg_info and remove associated comment

2011-02-14 Thread Hank Janssen
Change code to use list_entry api. And removed comment suggesting that change. Signed-off-by: Abhishek Kane v-abk...@microsoft.com Signed-off-by: K.Y. Srinivasan k...@microsoft.com Signed-off-by: Hank Janssen hjans...@microsoft.com --- drivers/staging/hv/channel_mgmt.c | 17

RE: [PATCH ]:Staging: hv: Allocate the vmbus irq dynamically

2011-02-16 Thread Hank Janssen
; virtualizat...@lists.osdl.org; Haiyang Zhang; Hank Janssen Subject: Re: [PATCH ]:Staging: hv: Allocate the vmbus irq dynamically And why are you still printing this out for the whole world to see? Greg, this patch addressed a specific comment with regards dynamically allocate the irq. Hank

RE: [PATCH ]:Staging: hv: Allocate the vmbus irq dynamically

2011-02-16 Thread Hank Janssen
-Original Message- From: Greg KH [mailto:gre...@suse.de] Sent: Tuesday, February 15, 2011 9:23 AM Before the end of the week I will submit two patches for this; Remove DPRINT and change it to printk No, use dev_dbg() and friends instead of raw printk() calls. Will do,

RE: [PATCH ]:Staging: hv: Allocate the vmbus irq dynamically

2011-02-16 Thread Hank Janssen
-Original Message- From: Greg KH [mailto:gre...@suse.de] Sent: Tuesday, February 15, 2011 9:23 AM Before the end of the week I will submit two patches for this; Remove DPRINT and change it to printk No, use dev_dbg() and friends instead of raw printk() calls.

[PATCH] Staging: hv: Fixed FIXME comments by using list_for_each_entry

2011-02-18 Thread Hank Janssen
Fixed FIXME requests in channel_mgmt.c by using list_for_each_entry. Signed-off-by: Hank Janssen hjans...@microsoft.com Signed-off-by: K.Y. Srinivasan k...@microsoft.com --- drivers/staging/hv/channel_mgmt.c | 24 1 files changed, 8 insertions(+), 16 deletions

[PATCH 6/6] Staging: hv: connection.c Removed DPRINT replaced with pr_XX

2011-02-22 Thread Hank Janssen
has been significantly reduced. Signed-off-by: Hank Janssen hjans...@microsoft.com Signed-off-by: Haiyang Zhang haiya...@microsoft.com Signed-off-by: K. Y. Srinivasan k...@microsoft.com --- drivers/staging/hv/connection.c | 27 --- 1 files changed, 12 insertions(+), 15

[PATCH 5/6] Staging: hv: ring_buffer.c Removed DPRINT replaced with pr_XX

2011-02-22 Thread Hank Janssen
has been significantly reduced. Several DPRINT calls remain in this file, they will be removed in a subsequent patch. They are designed to print out a common debug stream that will be implemented differently. Signed-off-by: Hank Janssen hjans...@microsoft.com Signed-off-by: Haiyang Zhang haiya

[PATCH 3/6] Staging: hv: channel.c Removed debug DPRINTS use pr_err for errors

2011-02-22 Thread Hank Janssen
has been significantly reduced. Several DPRINT calls remain in this file, they will be removed in a subsequent patch. They are designed to print out a common debug stream that will be implemented differently. Signed-off-by: Hank Janssen hjans...@microsoft.com Signed-off-by: Haiyang Zhang haiya

[PATCH 2/6] Staging: hv: hv.c Removed all DPRINT and debug - using pr_err now

2011-02-22 Thread Hank Janssen
has been significantly reduced. Signed-off-by: Hank Janssen hjans...@microsoft.com Signed-off-by: Haiyang Zhang haiya...@microsoft.com Signed-off-by: K. Y. Srinivasan k...@microsoft.com --- drivers/staging/hv/hv.c | 88 +++--- 1 files changed, 21

[PATCH 1/6] Staging: hv: vmbus_drv.c Replaced DPRINT with native pr_XXX

2011-02-22 Thread Hank Janssen
has been significantly reduced. Signed-off-by: Hank Janssen hjans...@microsoft.com Signed-off-by: Haiyang Zhang haiya...@microsoft.com Signed-off-by: K. Y. Srinivasan k...@microsoft.com --- drivers/staging/hv/logging.h |1 + drivers/staging/hv/vmbus_drv.c | 145

[PATCH 4/6] Staging: hv: channel_mgmt.c Removed DPRINT and implemented pr_XX

2011-02-22 Thread Hank Janssen
has been significantly reduced. Signed-off-by: Hank Janssen hjans...@microsoft.com Signed-off-by: Haiyang Zhang haiya...@microsoft.com Signed-off-by: K. Y. Srinivasan k...@microsoft.com --- drivers/staging/hv/channel_mgmt.c | 73 +++-- 1 files changed, 14

RE: [PATCH 1/6] Staging: hv: vmbus_drv.c Replaced DPRINT with native pr_XXX

2011-02-23 Thread Hank Janssen
-Original Message- From: Joe Perches [mailto:j...@perches.com] Sent: Tuesday, February 22, 2011 8:51 PM On Tue, 2011-02-22 at 15:32 -0800, Hank Janssen wrote: This group of patches removes all DPRINT from hv_vmbus.ko. It is divided in several patches due to size

RE: [PATCH 1/6] Staging: hv: vmbus_drv.c Replaced DPRINT with native pr_XXX

2011-02-23 Thread Hank Janssen
-Original Message- From: Joe Perches [mailto:j...@perches.com] Sent: Wednesday, February 23, 2011 9:10 AM To: Hank Janssen On Wed, 2011-02-23 at 16:58 +, Hank Janssen wrote: #define pr_fmt(fmt) %s: fmt, VMBUS_MOD or #define pr_fmt(fmt) %s:%s fmt, VMBUS_MOD, __func__

RE: [PATCH 1/6] Staging: hv: vmbus_drv.c Replaced DPRINT with native pr_XXX

2011-02-23 Thread Hank Janssen
-Original Message- From: Greg KH [mailto:g...@kroah.com] Sent: Wednesday, February 23, 2011 11:12 AM To: Hank Janssen Why say this in the 1/6 patch? It should be in the 0/6 introduction. All DPRINT calls have been removed, and where needed have been replaced with pr_XX

RE: [PATCH 2/6] Staging: hv: hv.c Removed all DPRINT and debug - using pr_err now

2011-02-23 Thread Hank Janssen
-Original Message- From: Greg KH [mailto:g...@kroah.com] Sent: Wednesday, February 23, 2011 1:57 PM They where compile and run tested. And syslog was not a mess. What did I mess up here? The amount of printouts now are a fraction of what they where before. You forgot to put

Re: [PATCH 12/21] Staging: hv: Cleanup irq management

2011-03-10 Thread Hank Janssen
On Mar 10, 2011, at 14:46, Thomas Gleixner t...@linutronix.de wrote: } -vector = VMBUS_IRQ_VECTOR; -DPRINT_INFO(VMBUS_DRV, irq 0x%x vector 0x%x, vmbus_irq, vector); +vector = IRQ0_VECTOR + pdev-irq; +DPRINT_INFO(VMBUS_DRV, irq 0x%x vector 0x%x, pdev-irq, +

[PATCH 03/07] Remove all unneeded DPRINT from hv_utils

2011-03-29 Thread Hank Janssen
Remove all un-needed DPRINT calls from hv_utils. This patch deals with hv_utils only. Signed-off-by: Hank Janssen hjans...@microsoft.com Signed-off-by: Haiyang Zhang haiya...@microsoft.com Signed-off-by: K. Y. Srinivasan k...@microsoft.com --- drivers/staging/hv/hv_kvp.c |3 --- drivers

[PATCH 02/07] Remove all unneeded DPRINT from hv_netvsc

2011-03-29 Thread Hank Janssen
Remove all un-needed DPRINT calls from hv_netvsc. This patch deals with hv_netvsc only. Signed-off-by: Hank Janssen hjans...@microsoft.com Signed-off-by: Haiyang Zhang haiya...@microsoft.com Signed-off-by: K. Y. Srinivasan k...@microsoft.com --- drivers/staging/hv/netvsc.c | 102

[PATCH 01/07] Remove all unneeded DPRINT from hv_vmbus

2011-03-29 Thread Hank Janssen
Remove all un-needed DPRINT calls from hv_vmbus. Several are remaining that will be cleaned up in my next set of patches. They deal with printing out the ringbuffer debugging which is going to be implemented slightly differently. This patch deals with hv_vmbus only. Signed-off-by: Hank Janssen

[PATCH 06/07] Replaced DPRINT and printk with native functions in hv_utils

2011-03-29 Thread Hank Janssen
Replaced all DPRINT and printk calls with pr_ calls Signed-off-by: Hank Janssen hjans...@microsoft.com Signed-off-by: Haiyang Zhang haiya...@microsoft.com Signed-off-by: K. Y. Srinivasan k...@microsoft.com --- drivers/staging/hv/hv_kvp.c |6 +++--- drivers/staging/hv/hv_util.c | 17

[PATCH 05/07] replace DPRINT with native primitives in hv_netvsc

2011-03-29 Thread Hank Janssen
...@microsoft.com * Hank Janssen hjans...@microsoft.com */ +#define pr_fmt(fmt) KBUILD_MODNAME : fmt + #include linux/kernel.h #include linux/sched.h #include linux/wait.h @@ -200,7 +202,7 @@ static int netvsc_init_recv_buf(struct hv_device *device) net_device

[PATCH 07/07] Replaced printk with pr_info in hv_timesource

2011-03-29 Thread Hank Janssen
Replaced printk in hv_timesource with pr_ calls Signed-off-by: Hank Janssen hjans...@microsoft.com Signed-off-by: Haiyang Zhang haiya...@microsoft.com Signed-off-by: K. Y. Srinivasan k...@microsoft.com --- drivers/staging/hv/hv_timesource.c |3 ++- 1 files changed, 2 insertions(+), 1

[PATCH 00/07] Remove and replace all un-needed DPRINT and printk

2011-03-29 Thread Hank Janssen
out certain debugging that will be implemented slightly differently. The remaining hv_storvsc and hv_blkvsc will get the same treatment in a different set of patches. Regards, Hank Janssen hjans...@microsoft.com ___ Virtualization mailing list

[PATCH 1/5] staging: hv: change camel case funct names to lower case funct in hv_mouse

2011-04-01 Thread Hank Janssen
Change all camelcase function names to lower case in hv_mouse Signed-off-by: Abhishek Kane v-abk...@microsoft.com Signed-off-by: Hank Janssen hjans...@microsoft.com Signed-off-by: Haiyang Zhang haiya...@microsoft.com Signed-off-by: K. Y. Srinivasan k...@microsoft.com --- drivers/staging/hv

[PATCH 3/5] staging: hv: Convert camel case member of struct mousevsc_drv_obj to lower case

2011-04-01 Thread Hank Janssen
Change camelcase members of mousevsc_drv_obj to lower case in hv_mouse. Signed-off-by: Abhishek Kane v-abk...@microsoft.com Signed-off-by: Hank Janssen hjans...@microsoft.com Signed-off-by: Haiyang Zhang haiya...@microsoft.com Signed-off-by: K. Y. Srinivasan k...@microsoft.com --- drivers

[PATCH 2/5] staging: hv: Convert camel case func params to lower case in hv_mouse

2011-04-01 Thread Hank Janssen
Change all camelcase function params to lower case in hv_mouse Signed-off-by: Abhishek Kane v-abk...@microsoft.com Signed-off-by: Hank Janssen hjans...@microsoft.com Signed-off-by: Haiyang Zhang haiya...@microsoft.com Signed-off-by: K. Y. Srinivasan k...@microsoft.com --- drivers/staging/hv

[PATCH 4/5] staging: hv: Convert camel case members of struct mousevsc_dev to lower case

2011-04-01 Thread Hank Janssen
Change camelcase members of struct mousevsc_dev to lower case in hv_mouse Signed-off-by: Abhishek Kane v-abk...@microsoft.com Signed-off-by: Hank Janssen hjans...@microsoft.com Signed-off-by: Haiyang Zhang haiya...@microsoft.com Signed-off-by: K. Y. Srinivasan k...@microsoft.com --- drivers

[PATCH 5/5] staging: hv: Convert camel case in in all functions to lower case in hv_mouse

2011-04-01 Thread Hank Janssen
Convert all camelcase variables inside of all remaining functions to lower case in hv_mouse. Signed-off-by: Abhishek Kane v-abk...@microsoft.com Signed-off-by: Hank Janssen hjans...@microsoft.com Signed-off-by: Haiyang Zhang haiya...@microsoft.com Signed-off-by: K. Y. Srinivasan k

RE: [PATCH 07/07] Replaced printk with pr_info in hv_timesource

2011-04-05 Thread Hank Janssen
-Original Message- From: Greg KH [mailto:g...@kroah.com] Sent: Monday, April 04, 2011 10:01 PM To: Hank Janssen Cc: Haiyang Zhang; gre...@suse.de; linux-ker...@vger.kernel.org; de...@linuxdriverproject.org; virtualizat...@lists.osdl.org; KY Srinivasan Subject: Re: [PATCH 07/07