[PATCH] 9p/trans_virtio: reset virtio device on remove

2015-07-09 Thread Pierre Morel
to send a reset to the host virtio device. Signed-off-by: Pierre Morel pmo...@linux.vnet.ibm.com Reviewed-by: Cornelia Huck cornelia.h...@de.ibm.com --- net/9p/trans_virtio.c | 1 + 1 file changed, 1 insertion(+) diff --git a/net/9p/trans_virtio.c b/net/9p/trans_virtio.c index 9dd49ca..6e70ddb

[PATCH] net/virtio-net: reverse unregistering on exit

2017-08-22 Thread Pierre Morel
-by: Pierre Morel <pmo...@linux.vnet.ibm.com> --- drivers/net/virtio_net.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c index 143d8a9..c042ffd 100644 --- a/drivers/net/virtio_net.c +++ b/drivers/net/virtio_net.c @@ -2734,9 +

[PATCH] net/virtio-net: reverse unregistering on exit

2017-08-22 Thread Pierre Morel
lbacks in virtio_net_driver_exit. This patch solves the problem by first unregistering the virtio_net_driver before unregistering the hotplug state machine callbacks. Best regards, Pierre Morel Pierre Morel (1): net/virtio-net: reverse unregistering on exit drivers/net/virtio_net.c | 2 +-

Re: [PATCH] net/virtio-net: reverse unregistering on exit

2017-08-23 Thread Pierre Morel
On 22/08/2017 20:17, Michael S. Tsirkin wrote: On Tue, Aug 22, 2017 at 04:59:51PM +0200, Pierre Morel wrote: Hi, I got a problem with virtio-net in a QEMU guest. When virtio-net is used as a module in a guest and the network is activated, removing the virtio-net modules produces a kernel

[PATCH] [RFC] virtio: Limit the retries on a virtio device reset

2017-08-23 Thread Pierre Morel
need your opinion: Is it right? This patch also lead to another question: do we care if a device provided by the hypervisor is buggy? Signed-off-by: Pierre Morel <pmo...@linux.vnet.ibm.com> --- drivers/virtio/virtio.c| 4 drivers/virtio/virtio_pci_modern.c | 11

Re: [PATCH] [RFC] virtio: Limit the retries on a virtio device reset

2017-08-24 Thread Pierre Morel
On 24/08/2017 13:07, Cornelia Huck wrote: On Wed, 23 Aug 2017 18:33:02 +0200 Pierre Morel <pmo...@linux.vnet.ibm.com> wrote: Reseting a device can sometime fail, even a virtual device. If the device is not reseted after a while the driver should abandon the retries. This is the change pr

Re: [PATCH] [RFC] virtio: Limit the retries on a virtio device reset

2017-08-24 Thread Pierre Morel
On 24/08/2017 16:19, Michael S. Tsirkin wrote: On Wed, Aug 23, 2017 at 06:33:02PM +0200, Pierre Morel wrote: Reseting a device can sometime fail, even a virtual device. If the device is not reseted after a while the driver should abandon the retries. This is the change proposed for the modern

Re: [PATCH] [RFC] virtio: Limit the retries on a virtio device reset

2017-08-24 Thread Pierre Morel
On 24/08/2017 16:12, Michael S. Tsirkin wrote: On Thu, Aug 24, 2017 at 02:16:11PM +0200, Pierre Morel wrote: On 24/08/2017 13:07, Cornelia Huck wrote: On Wed, 23 Aug 2017 18:33:02 +0200 Pierre Morel <pmo...@linux.vnet.ibm.com> wrote: Reseting a device can sometime fail, even a virtual

Re: [PATCH] [RFC] virtio: Limit the retries on a virtio device reset

2017-08-25 Thread Pierre Morel
On 25/08/2017 10:26, Cornelia Huck wrote: On Fri, 25 Aug 2017 00:16:05 +0300 "Michael S. Tsirkin" <m...@redhat.com> wrote: On Thu, Aug 24, 2017 at 07:07:42PM +0200, Pierre Morel wrote: - we'll have to spread these tests all over the place. I counted 19 places where to ch

Re: [PATCH] [RFC] virtio: Limit the retries on a virtio device reset

2017-08-25 Thread Pierre Morel
On 24/08/2017 23:23, Michael S. Tsirkin wrote: On Thu, Aug 24, 2017 at 07:42:07PM +0200, Pierre Morel wrote: On 24/08/2017 16:19, Michael S. Tsirkin wrote: On Wed, Aug 23, 2017 at 06:33:02PM +0200, Pierre Morel wrote: Reseting a device can sometime fail, even a virtual device. If the device

Re: [PATCH 10/10] virtio/s390: make airq summary indicators DMA

2019-05-19 Thread Pierre Morel
virtio_ccw_init(void) { /* parse no_auto string before we do anything further */ no_auto_parse(); + summary_indicators = cio_dma_zalloc(MAX_AIRQ_AREAS); return ccw_driver_register(_ccw_driver); } device_initc

Re: [PATCH 09/10] virtio/s390: use DMA memory for ccw I/O and classic notifiers

2019-05-19 Thread Pierre Morel
On 08/05/2019 16:46, Pierre Morel wrote: On 26/04/2019 20:32, Halil Pasic wrote: Before virtio-ccw could get away with not using DMA API for the pieces of memory it does ccw I/O with. With protected virtualization this has to change, since the hypervisor needs to read and sometimes also write

Re: [PATCH 09/10] virtio/s390: use DMA memory for ccw I/O and classic notifiers

2019-05-19 Thread Pierre Morel
indicatorp = __vc_dma_alloc(>vdev, + sizeof(indicators(vcdev))); should be sizeof(long) ? This is a recurrent error, but it is not an issue because the size of the indicators is unsigned long as the size of the pointer. Regards, Pierre -- Pierre M

Re: [PATCH 08/10] virtio/s390: add indirection to indicators access

2019-05-19 Thread Pierre Morel
On 10/05/2019 13:54, Halil Pasic wrote: On Fri, 10 May 2019 09:43:08 +0200 Pierre Morel wrote: On 09/05/2019 20:26, Halil Pasic wrote: On Thu, 9 May 2019 14:01:01 +0200 Pierre Morel wrote: On 08/05/2019 16:31, Pierre Morel wrote: On 26/04/2019 20:32, Halil Pasic wrote: This will come

Re: [PATCH 08/10] virtio/s390: add indirection to indicators access

2019-05-19 Thread Pierre Morel
On 09/05/2019 20:26, Halil Pasic wrote: On Thu, 9 May 2019 14:01:01 +0200 Pierre Morel wrote: On 08/05/2019 16:31, Pierre Morel wrote: On 26/04/2019 20:32, Halil Pasic wrote: This will come in handy soon when we pull out the indicators from virtio_ccw_device to a memory area that is shared

Re: [PATCH 08/10] virtio/s390: add indirection to indicators access

2019-05-19 Thread Pierre Morel
On 08/05/2019 16:31, Pierre Morel wrote: On 26/04/2019 20:32, Halil Pasic wrote: This will come in handy soon when we pull out the indicators from virtio_ccw_device to a memory area that is shared with the hypervisor (in particular for protected virtualization guests). Signed-off-by: Halil

Re: [PATCH 08/10] virtio/s390: add indirection to indicators access

2019-05-19 Thread Pierre Morel
On 13/05/2019 12:15, Cornelia Huck wrote: On Fri, 10 May 2019 17:36:05 +0200 Pierre Morel wrote: On 10/05/2019 13:54, Halil Pasic wrote: On Fri, 10 May 2019 09:43:08 +0200 Pierre Morel wrote: On 09/05/2019 20:26, Halil Pasic wrote: On Thu, 9 May 2019 14:01:01 +0200 Pierre Morel wrote

Re: [PATCH 06/10] s390/cio: add basic protected virtualization support

2019-05-19 Thread Pierre Morel
= cdev->private->iccws; + struct ccw1 *cp = cdev->private->dma_area->iccws; cp[0].cmd_code = CCW_CMD_STLCK; cp[0].cda = (u32) (addr_t) buf1; diff --git a/drivers/s390/cio/device_status.c b/drivers/s390/cio/device_status.c index 7d5c7892b2c4..a9aabde604f4 100644 --

Re: [PATCH 08/10] virtio/s390: add indirection to indicators access

2019-05-19 Thread Pierre Morel
rupt(0, vq); } - if (test_bit(0, >indicators2)) { + if (test_bit(0, indicators2(vcdev))) { virtio_config_changed(>vdev); - clear_bit(0, >indicators2); + clear_bit(0, indicators2(vcdev)); } } Here again just a fast

[PATCH v10 2/2] s390: virtio: PV needs VIRTIO I/O device protection

2020-08-31 Thread Pierre Morel
-off-by: Pierre Morel Reviewed-by: Cornelia Huck --- arch/s390/Kconfig | 1 + arch/s390/mm/init.c | 10 ++ 2 files changed, 11 insertions(+) diff --git a/arch/s390/Kconfig b/arch/s390/Kconfig index 9cfd8de907cb..c12422c26389 100644 --- a/arch/s390/Kconfig +++ b/arch/s390/Kconfig

[PATCH v10 1/2] virtio: let arch advertise guest's memory access restrictions

2020-08-31 Thread Pierre Morel
to VIRTIO common code when the architecture restricts memory access from the host. The common code can then fail the probe for any device where VIRTIO_F_IOMMU_PLATFORM is required, but not set. Signed-off-by: Pierre Morel Reviewed-by: Cornelia Huck --- drivers/virtio/Kconfig| 6

[PATCH v10 0/2] s390: virtio: let arch validate VIRTIO features

2020-08-31 Thread Pierre Morel
renamed the callback to arch_has_restricted_virtio_memory_access, and the config option to ARCH_HAS_RESTRICTED_VIRTIO_MEMORY_ACCESS. Regards, Pierre Pierre Morel (2): virtio: let arch advertise guest's memory access restrictions s390: virtio: PV needs VIRTIO I/O device protection arch/s390

[PATCH v12 2/2] s390: virtio: PV needs VIRTIO I/O device protection

2020-09-10 Thread Pierre Morel
If protected virtualization is active on s390, VIRTIO has only retricted access to the guest memory. Define CONFIG_ARCH_HAS_RESTRICTED_VIRTIO_MEMORY_ACCESS and export arch_has_restricted_virtio_memory_access to advertize VIRTIO if that's the case. Signed-off-by: Pierre Morel Reviewed

[PATCH v12 1/2] virtio: let arch advertise guest's memory access restrictions

2020-09-10 Thread Pierre Morel
to VIRTIO common code when the architecture restricts memory access from the host. The common code can then fail the probe for any device where VIRTIO_F_ACCESS_PLATFORM is required, but not set. Signed-off-by: Pierre Morel Reviewed-by: Cornelia Huck Reviewed-by: Halil Pasic --- drivers/virtio

[PATCH v12 0/2] s390: virtio: let arch validate VIRTIO features

2020-09-10 Thread Pierre Morel
/s390/mm/init.c I wrongly removed in the last series. Regards, Pierre Pierre Morel (2): virtio: let arch advertise guest's memory access restrictions s390: virtio: PV needs VIRTIO I/O device protection arch/s390/Kconfig | 1 + arch/s390/mm/init.c | 11

[PATCH v11 0/2] s390: virtio: let arch validate VIRTIO features

2020-09-07 Thread Pierre Morel
renamed the callback to arch_has_restricted_virtio_memory_access, the config option to ARCH_HAS_RESTRICTED_VIRTIO_MEMORY_ACCESS, and VIRTIO_F_IOMMU_PLATFORM to VIRTIO_F_ACCESS_PLATFORM. Regards, Pierre Pierre Morel (2): virtio: let arch advertise guest's memory access restrictions s390: virtio

[PATCH v11 1/2] virtio: let arch advertise guest's memory access restrictions

2020-09-07 Thread Pierre Morel
to VIRTIO common code when the architecture restricts memory access from the host. The common code can then fail the probe for any device where VIRTIO_F_ACCESS_PLATFORM is required, but not set. Signed-off-by: Pierre Morel Reviewed-by: Cornelia Huck --- drivers/virtio/Kconfig| 6

[PATCH v11 2/2] s390: virtio: PV needs VIRTIO I/O device protection

2020-09-07 Thread Pierre Morel
-off-by: Pierre Morel Reviewed-by: Cornelia Huck --- arch/s390/Kconfig | 1 + arch/s390/mm/init.c | 10 ++ 2 files changed, 11 insertions(+) diff --git a/arch/s390/Kconfig b/arch/s390/Kconfig index b29fcc66ec39..938246200d39 100644 --- a/arch/s390/Kconfig +++ b/arch/s390/Kconfig

[PATCH v8 1/2] virtio: let arch validate VIRTIO features

2020-08-18 Thread Pierre Morel
features. Signed-off-by: Pierre Morel --- drivers/virtio/Kconfig| 6 ++ drivers/virtio/virtio.c | 4 include/linux/virtio_config.h | 9 + 3 files changed, 19 insertions(+) diff --git a/drivers/virtio/Kconfig b/drivers/virtio/Kconfig index 5809e5f5b157..eef09e3c92f9

[PATCH v8 0/2] s390: virtio: let arch validate VIRTIO features

2020-08-18 Thread Pierre Morel
of ARCH_HAS_RESTRICTED_MEMORY_ACCESS inside the VIRTIO Kconfig and the selection in the PROTECTED_VIRTUALIZATION_GUEST config entry. Regards, Pierre Pierre Morel (2): virtio: let arch validate VIRTIO features s390: virtio: PV needs VIRTIO I/O device protection arch/s390/Kconfig | 1 + arch/s390/mm/init.c

[PATCH v8 2/2] s390: virtio: PV needs VIRTIO I/O device protection

2020-08-18 Thread Pierre Morel
error on access attempt. Signed-off-by: Pierre Morel --- arch/s390/Kconfig | 1 + arch/s390/mm/init.c | 30 ++ 2 files changed, 31 insertions(+) diff --git a/arch/s390/Kconfig b/arch/s390/Kconfig index 9cfd8de907cb..d4a3ef4fa27b 100644 --- a/arch/s390/Kconfig +++ b

Re: [PATCH v8 1/2] virtio: let arch validate VIRTIO features

2020-08-19 Thread Pierre Morel
On 2020-08-18 19:19, Cornelia Huck wrote: On Tue, 18 Aug 2020 16:58:30 +0200 Pierre Morel wrote: ... +config ARCH_HAS_RESTRICTED_MEMORY_ACCESS + bool + help + This option is selected by any architecture enforcing + VIRTIO_F_IOMMU_PLATFORM This option is only

Re: [PATCH v8 2/2] s390: virtio: PV needs VIRTIO I/O device protection

2020-08-19 Thread Pierre Morel
, this function would be short and sweet :) yes, the smaller the better, thanks Pierre -- Pierre Morel IBM Lab Boeblingen ___ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/virtualization

Re: [PATCH v9 1/2] virtio: let arch advertise guest's memory access restrictions

2020-08-21 Thread Pierre Morel
On 2020-08-21 13:59, Cornelia Huck wrote: On Wed, 19 Aug 2020 18:23:17 +0200 Pierre Morel wrote: An architecture may restrict host access to guest memory. "e.g. IBM s390 Secure Execution or AMD SEV" Just to make clearer what you are referring to? yes, thanks Provide a n

Re: [PATCH v9 2/2] s390: virtio: PV needs VIRTIO I/O device protection

2020-08-21 Thread Pierre Morel
On 2020-08-21 14:05, Cornelia Huck wrote: On Wed, 19 Aug 2020 18:23:18 +0200 Pierre Morel wrote: If protected virtualization is active on s390, VIRTIO has retricted s/retricted/only restricted/ access to the guest memory. Define CONFIG_ARCH_HAS_RESTRICTED_VIRTIO_MEMORY_ACCESS

[PATCH v9 2/2] s390: virtio: PV needs VIRTIO I/O device protection

2020-08-19 Thread Pierre Morel
-by: Pierre Morel --- arch/s390/Kconfig | 1 + arch/s390/mm/init.c | 11 +++ 2 files changed, 12 insertions(+) diff --git a/arch/s390/Kconfig b/arch/s390/Kconfig index 9cfd8de907cb..c12422c26389 100644 --- a/arch/s390/Kconfig +++ b/arch/s390/Kconfig @@ -820,6 +820,7 @@ menu

[PATCH v9 0/2] s390: virtio: let arch validate VIRTIO features

2020-08-19 Thread Pierre Morel
restrictions for VIRTIO. I renamed the callback to arch_has_restricted_virtio_memory_access, and the config option to ARCH_HAS_RESTRICTED_VIRTIO_MEMORY_ACCESS. Regards, Pierre Pierre Morel (2): virtio: let arch advertise guest's memory access restrictions s390: virtio: PV needs VIRTIO I/O device

[PATCH v9 1/2] virtio: let arch advertise guest's memory access restrictions

2020-08-19 Thread Pierre Morel
restricts memory access from the host. Signed-off-by: Pierre Morel --- drivers/virtio/Kconfig| 6 ++ drivers/virtio/virtio.c | 15 +++ include/linux/virtio_config.h | 9 + 3 files changed, 30 insertions(+) diff --git a/drivers/virtio/Kconfig b/drivers/virtio

Re: [PATCH v7 2/2] s390: virtio: PV needs VIRTIO I/O device protection

2020-07-22 Thread Pierre Morel
On 2020-07-15 13:51, Michael S. Tsirkin wrote: On Wed, Jul 15, 2020 at 06:16:59PM +0800, Jason Wang wrote: On 2020/7/15 下午5:50, Michael S. Tsirkin wrote: On Wed, Jul 15, 2020 at 10:31:09AM +0200, Pierre Morel wrote: If protected virtualization is active on s390, the virtio queues

Re: [PATCH v1 0/1] s390: virtio-ccw: PV needs VIRTIO I/O device protection

2020-08-07 Thread Pierre Morel
transports, and things should work once an architecture opts in. That direction also shouldn't be a problem if virtio is a module. Yes thanks, I rework it in this direction. -- Pierre Morel IBM Lab Boeblingen ___ Virtualization mailing list Virtualization

Re: [PATCH v7 2/2] s390: virtio: PV needs VIRTIO I/O device protection

2020-07-30 Thread Pierre Morel
gentle ping. On 2020-07-15 13:51, Michael S. Tsirkin wrote: On Wed, Jul 15, 2020 at 06:16:59PM +0800, Jason Wang wrote: On 2020/7/15 下午5:50, Michael S. Tsirkin wrote: On Wed, Jul 15, 2020 at 10:31:09AM +0200, Pierre Morel wrote: If protected virtualization is active on s390, the virtio

Re: [PATCH v7 2/2] s390: virtio: PV needs VIRTIO I/O device protection

2020-08-06 Thread Pierre Morel
On 2020-07-30 13:31, Pierre Morel wrote: ...snip... What bothers me here is that arch code depends on virtio now. It works even with a modular virtio when functions are inline, but it seems fragile: e.g. it breaks virtio as an out of tree module, since layout of struct virtio_device can

[PATCH v1 1/1] s390: virtio-ccw: PV needs VIRTIO I/O device protection

2020-08-06 Thread Pierre Morel
. Signed-off-by: Pierre Morel --- drivers/s390/virtio/virtio_ccw.c | 24 +++- 1 file changed, 19 insertions(+), 5 deletions(-) diff --git a/drivers/s390/virtio/virtio_ccw.c b/drivers/s390/virtio/virtio_ccw.c index 5730572b52cd..cc8d8064c6c4 100644 --- a/drivers/s390/virtio

[PATCH v1 0/1] s390: virtio-ccw: PV needs VIRTIO I/O device protection

2020-08-06 Thread Pierre Morel
, Pierre Regards, Pierre Pierre Morel (1): s390: virtio-ccw: PV needs VIRTIO I/O device protection drivers/s390/virtio/virtio_ccw.c | 24 +++- 1 file changed, 19 insertions(+), 5 deletions(-) -- 2.25.1 ___ Virtualization mailing

Re: [PATCH v3 1/1] s390: virtio: let arch accept devices without IOMMU feature

2020-07-02 Thread Pierre Morel
On 2020-06-29 18:05, Cornelia Huck wrote: On Mon, 29 Jun 2020 11:57:14 -0400 "Michael S. Tsirkin" wrote: On Wed, Jun 17, 2020 at 12:43:57PM +0200, Pierre Morel wrote: An architecture protecting the guest memory against unauthorized host access may want to enforce VIRTIO

Re: [PATCH v5 2/2] s390: virtio: PV needs VIRTIO I/O device protection

2020-07-09 Thread Pierre Morel
On 2020-07-09 10:57, Cornelia Huck wrote: On Thu, 9 Jul 2020 10:39:19 +0200 Pierre Morel wrote: If protected virtualization is active on s390, the virtio queues are not accessible to the host, unless VIRTIO_F_IOMMU_PLATFORM has been negotiated. Use the new arch_validate_virtio_features

Re: [PATCH v5 1/2] virtio: let arch validate VIRTIO features

2020-07-09 Thread Pierre Morel
On 2020-07-09 11:58, Halil Pasic wrote: On Thu, 9 Jul 2020 10:39:18 +0200 Pierre Morel wrote: An architecture may need to validate the VIRTIO devices features based on architecture specifics. Signed-off-by: Pierre Morel Reviewed-by: Cornelia Huck Acked-by: Christian Borntraeger

Re: [PATCH v5 2/2] s390: virtio: PV needs VIRTIO I/O device protection

2020-07-09 Thread Pierre Morel
On 2020-07-09 11:55, Halil Pasic wrote: On Thu, 9 Jul 2020 10:57:33 +0200 Cornelia Huck wrote: On Thu, 9 Jul 2020 10:39:19 +0200 Pierre Morel wrote: If protected virtualization is active on s390, the virtio queues are not accessible to the host, unless VIRTIO_F_IOMMU_PLATFORM has been

[PATCH v5 0/2] s390: virtio: let arch validate VIRTIO features

2020-07-09 Thread Pierre Morel
-by with these changes? 2) I suppressed the unnecessary verbosity of the architecture specific patch 3) put back the arch specific code inside arch/s390/mm/init.c after offline discussion with Christian. Regards, Pierre Pierre Morel (2): virtio: let arch validate VIRTIO features s390

[PATCH v5 2/2] s390: virtio: PV needs VIRTIO I/O device protection

2020-07-09 Thread Pierre Morel
-by: Pierre Morel --- arch/s390/mm/init.c | 27 +++ 1 file changed, 27 insertions(+) diff --git a/arch/s390/mm/init.c b/arch/s390/mm/init.c index 6dc7c3b60ef6..b8e6f90117da 100644 --- a/arch/s390/mm/init.c +++ b/arch/s390/mm/init.c @@ -45,6 +45,7 @@ #include #include

[PATCH v5 1/2] virtio: let arch validate VIRTIO features

2020-07-09 Thread Pierre Morel
An architecture may need to validate the VIRTIO devices features based on architecture specifics. Signed-off-by: Pierre Morel Reviewed-by: Cornelia Huck Acked-by: Christian Borntraeger --- drivers/virtio/virtio.c | 19 +++ include/linux/virtio_config.h | 1 + 2 files

Re: [PATCH v5 2/2] s390: virtio: PV needs VIRTIO I/O device protection

2020-07-09 Thread Pierre Morel
On 2020-07-09 16:47, Halil Pasic wrote: On Thu, 9 Jul 2020 12:51:58 +0200 Pierre Morel wrote: +int arch_validate_virtio_features(struct virtio_device *dev) +{ + if (!is_prot_virt_guest()) + return 0; + + if (!virtio_has_feature(dev, VIRTIO_F_VERSION_1

[PATCH v4 2/2] s390: virtio: PV needs VIRTIO I/O device protection

2020-07-07 Thread Pierre Morel
S390, protecting the guest memory against unauthorized host access needs to enforce VIRTIO I/O device protection through the use of VIRTIO_F_VERSION_1 and VIRTIO_F_IOMMU_PLATFORM. Signed-off-by: Pierre Morel --- arch/s390/kernel/uv.c | 25 + 1 file changed, 25 insertions

[PATCH v4 1/2] virtio: let arch validate VIRTIO features

2020-07-07 Thread Pierre Morel
An architecture may need to validate the VIRTIO devices features based on architecture specificities. Signed-off-by: Pierre Morel --- drivers/virtio/virtio.c | 19 +++ include/linux/virtio_config.h | 1 + 2 files changed, 20 insertions(+) diff --git a/drivers/virtio

[PATCH v4 0/2] s390: virtio: let arch validate VIRTIO features

2020-07-07 Thread Pierre Morel
litted the patch into generic virtio and arch specific code. Regards, Pierre Pierre Morel (2): virtio: let arch validate VIRTIO features s390: virtio: PV needs VIRTIO I/O device protection arch/s390/kernel/uv.c | 25 + drivers/virtio/virtio.c

Re: [PATCH v4 2/2] s390: virtio: PV needs VIRTIO I/O device protection

2020-07-07 Thread Pierre Morel
On 2020-07-07 13:12, Christian Borntraeger wrote: On 07.07.20 10:44, Pierre Morel wrote: S390, protecting the guest memory against unauthorized host access needs to enforce VIRTIO I/O device protection through the use of VIRTIO_F_VERSION_1 and VIRTIO_F_IOMMU_PLATFORM. Signed-off

Re: [PATCH v4 1/2] virtio: let arch validate VIRTIO features

2020-07-07 Thread Pierre Morel
On 2020-07-07 13:09, Christian Borntraeger wrote: On 07.07.20 11:26, Cornelia Huck wrote: On Tue, 7 Jul 2020 10:44:36 +0200 Pierre Morel wrote: An architecture may need to validate the VIRTIO devices features based on architecture specificities. s/specifities/specifics/ yes

Re: [PATCH v4 2/2] s390: virtio: PV needs VIRTIO I/O device protection

2020-07-07 Thread Pierre Morel
On 2020-07-07 13:14, Michael S. Tsirkin wrote: On Tue, Jul 07, 2020 at 11:46:33AM +0200, Cornelia Huck wrote: On Tue, 7 Jul 2020 10:44:37 +0200 Pierre Morel wrote: S390, protecting the guest memory against unauthorized host access needs to enforce VIRTIO I/O device protection through

Re: [PATCH v4 1/2] virtio: let arch validate VIRTIO features

2020-07-07 Thread Pierre Morel
On 2020-07-07 11:26, Cornelia Huck wrote: On Tue, 7 Jul 2020 10:44:36 +0200 Pierre Morel wrote: An architecture may need to validate the VIRTIO devices features based on architecture specificities. s/specifities/specifics/ OK Signed-off-by: Pierre Morel --- drivers/virtio

Re: [PATCH v4 2/2] s390: virtio: PV needs VIRTIO I/O device protection

2020-07-07 Thread Pierre Morel
On 2020-07-07 11:46, Cornelia Huck wrote: On Tue, 7 Jul 2020 10:44:37 +0200 Pierre Morel wrote: S390, protecting the guest memory against unauthorized host access needs to enforce VIRTIO I/O device protection through the use of VIRTIO_F_VERSION_1 and VIRTIO_F_IOMMU_PLATFORM. Hm... what

Re: [PATCH v3 1/1] s390: virtio: let arch accept devices without IOMMU feature

2020-07-06 Thread Pierre Morel
On 2020-07-02 15:03, Pierre Morel wrote: On 2020-06-29 18:05, Cornelia Huck wrote: On Mon, 29 Jun 2020 11:57:14 -0400 "Michael S. Tsirkin" wrote: On Wed, Jun 17, 2020 at 12:43:57PM +0200, Pierre Morel wrote: An architecture protecting the guest memory against unauthorized h

Re: [PATCH v3 1/1] s390: virtio: let arch accept devices without IOMMU feature

2020-07-06 Thread Pierre Morel
On 2020-07-06 16:33, Cornelia Huck wrote: On Mon, 6 Jul 2020 15:37:37 +0200 Pierre Morel wrote: On 2020-07-02 15:03, Pierre Morel wrote: On 2020-06-29 18:05, Cornelia Huck wrote: On Mon, 29 Jun 2020 11:57:14 -0400 "Michael S. Tsirkin" wrote: On Wed, Jun 17, 2020 at 12:43:

Re: [PATCH v6 2/2] s390: virtio: PV needs VIRTIO I/O device protection

2020-07-14 Thread Pierre Morel
On 2020-07-14 13:42, Christian Borntraeger wrote: On 14.07.20 13:38, Pierre Morel wrote: If protected virtualization is active on s390, the virtio queues are not accessible to the host, unless VIRTIO_F_IOMMU_PLATFORM has been negotiated. Use the new arch_validate_virtio_features() interface

[PATCH v7 0/2] s390: virtio: let arch validate VIRTIO features

2020-07-15 Thread Pierre Morel
-by with these changes? 2) Rewording for warning messages Regards, Pierre Pierre Morel (2): virtio: let arch validate VIRTIO features s390: virtio: PV needs VIRTIO I/O device protection arch/s390/mm/init.c | 28 drivers/virtio/virtio.c | 19

[PATCH v7 1/2] virtio: let arch validate VIRTIO features

2020-07-15 Thread Pierre Morel
An architecture may need to validate the VIRTIO devices features based on architecture specifics. Signed-off-by: Pierre Morel Reviewed-by: Cornelia Huck Acked-by: Christian Borntraeger Acked-by: Halil Pasic --- drivers/virtio/virtio.c | 19 +++ include/linux

[PATCH v7 2/2] s390: virtio: PV needs VIRTIO I/O device protection

2020-07-15 Thread Pierre Morel
-by: Pierre Morel Reviewed-by: Cornelia Huck Acked-by: Halil Pasic Acked-by: Christian Borntraeger --- arch/s390/mm/init.c | 28 1 file changed, 28 insertions(+) diff --git a/arch/s390/mm/init.c b/arch/s390/mm/init.c index 6dc7c3b60ef6..d39af6554d4f 100644 --- a/arch

[PATCH v6 1/2] virtio: let arch validate VIRTIO features

2020-07-14 Thread Pierre Morel
An architecture may need to validate the VIRTIO devices features based on architecture specifics. Signed-off-by: Pierre Morel Reviewed-by: Cornelia Huck Acked-by: Christian Borntraeger Acked-by: Halil Pasic --- drivers/virtio/virtio.c | 19 +++ include/linux

[PATCH v6 0/2] s390: virtio: let arch validate VIRTIO features

2020-07-14 Thread Pierre Morel
-by with these changes? 2) Rewording for warning messages Regards, Pierre Pierre Morel (2): virtio: let arch validate VIRTIO features s390: virtio: PV needs VIRTIO I/O device protection arch/s390/mm/init.c | 28 drivers/virtio/virtio.c | 19

[PATCH v6 2/2] s390: virtio: PV needs VIRTIO I/O device protection

2020-07-14 Thread Pierre Morel
-by: Pierre Morel Reviewed-by: Cornelia Huck Acked-by: Halil Pasic --- arch/s390/mm/init.c | 28 1 file changed, 28 insertions(+) diff --git a/arch/s390/mm/init.c b/arch/s390/mm/init.c index 6dc7c3b60ef6..26efb663bac2 100644 --- a/arch/s390/mm/init.c +++ b/arch/s390/mm

Re: [PATCH v2 1/1] s390: virtio: let arch accept devices without IOMMU feature

2020-06-16 Thread Pierre Morel
On 2020-06-16 08:55, Christian Borntraeger wrote: On 15.06.20 14:39, Pierre Morel wrote: An architecture protecting the guest memory against unauthorized host access may want to enforce VIRTIO I/O device protection through the use of VIRTIO_F_IOMMU_PLATFORM. Let's give a chance

Re: [PATCH v2 1/1] s390: virtio: let arch accept devices without IOMMU feature

2020-06-16 Thread Pierre Morel
On 2020-06-16 08:22, Jason Wang wrote: On 2020/6/15 下午8:39, Pierre Morel wrote: An architecture protecting the guest memory against unauthorized host access may want to enforce VIRTIO I/O device protection through the use of VIRTIO_F_IOMMU_PLATFORM. Let's give a chance to the architecture

[PATCH v3 1/1] s390: virtio: let arch accept devices without IOMMU feature

2020-06-17 Thread Pierre Morel
An architecture protecting the guest memory against unauthorized host access may want to enforce VIRTIO I/O device protection through the use of VIRTIO_F_IOMMU_PLATFORM. Let's give a chance to the architecture to accept or not devices without VIRTIO_F_IOMMU_PLATFORM. Signed-off-by: Pierre Morel

[PATCH v3 0/1] s390: virtio: let arch choose to accept devices without IOMMU feature

2020-06-17 Thread Pierre Morel
An architecture protecting the guest memory against unauthorized host access may want to enforce VIRTIO I/O device protection through the use of VIRTIO_F_IOMMU_PLATFORM. Let's give a chance to the architecture to accept or not devices without VIRTIO_F_IOMMU_PLATFORM. Pierre Morel (1): s390

Re: [PATCH v3 1/1] s390: virtio: let arch accept devices without IOMMU feature

2020-06-17 Thread Pierre Morel
On 2020-06-17 13:22, Heiko Carstens wrote: On Wed, Jun 17, 2020 at 12:43:57PM +0200, Pierre Morel wrote: An architecture protecting the guest memory against unauthorized host access may want to enforce VIRTIO I/O device protection through the use of VIRTIO_F_IOMMU_PLATFORM. Let's give

Re: [PATCH v3 1/1] s390: virtio: let arch accept devices without IOMMU feature

2020-06-17 Thread Pierre Morel
On 2020-06-17 15:36, Tom Lendacky wrote: On 6/17/20 5:43 AM, Pierre Morel wrote: An architecture protecting the guest memory against unauthorized host access may want to enforce VIRTIO I/O device protection through the use of VIRTIO_F_IOMMU_PLATFORM. Let's give a chance to the architecture

Re: [PATCH v3 1/1] s390: virtio: let arch accept devices without IOMMU feature

2020-06-29 Thread Pierre Morel
access" ? But no issue with keeping the current message. I think I prefer Conny's version, but no strong feelings here. The reason why the device is not accepted without IOMMU_PLATFORM is arch specific, I think it should be clearly stated. If no strong oposition... Thanks, Pi

Re: [PATCH v3 1/1] s390: virtio: let arch accept devices without IOMMU feature

2020-06-29 Thread Pierre Morel
On 2020-06-19 11:20, Cornelia Huck wrote: On Thu, 18 Jun 2020 00:29:56 +0200 Halil Pasic wrote: On Wed, 17 Jun 2020 12:43:57 +0200 Pierre Morel wrote: ... But since this can be rewritten any time, let's go with the option people already agree with, instead of more discussion. Yes

Re: [PATCH v3 1/1] s390: virtio: let arch accept devices without IOMMU feature

2020-06-29 Thread Pierre Morel
On 2020-06-18 00:29, Halil Pasic wrote: On Wed, 17 Jun 2020 12:43:57 +0200 Pierre Morel wrote: An architecture protecting the guest memory against unauthorized host access may want to enforce VIRTIO I/O device protection through the use of VIRTIO_F_IOMMU_PLATFORM. Let's give a chance

Re: [PATCH v3 1/1] s390: virtio: let arch accept devices without IOMMU feature

2020-06-29 Thread Pierre Morel
On 2020-06-29 17:57, Michael S. Tsirkin wrote: On Wed, Jun 17, 2020 at 12:43:57PM +0200, Pierre Morel wrote: An architecture protecting the guest memory against unauthorized host access may want to enforce VIRTIO I/O device protection through the use of VIRTIO_F_IOMMU_PLATFORM. Let's give

Re: [PATCH v3 1/1] s390: virtio: let arch accept devices without IOMMU feature

2020-06-29 Thread Pierre Morel
On 2020-06-29 15:44, Cornelia Huck wrote: On Mon, 29 Jun 2020 15:14:04 +0200 Pierre Morel wrote: On 2020-06-19 11:20, Cornelia Huck wrote: On Thu, 18 Jun 2020 00:29:56 +0200 Halil Pasic wrote: On Wed, 17 Jun 2020 12:43:57 +0200 Pierre Morel wrote: @@ -179,6 +194,13 @@ int

Re: [PATCH v3 1/1] s390: virtio: let arch accept devices without IOMMU feature

2020-06-29 Thread Pierre Morel
On 2020-06-29 18:09, Michael S. Tsirkin wrote: On Wed, Jun 17, 2020 at 12:43:57PM +0200, Pierre Morel wrote: An architecture protecting the guest memory against unauthorized host access may want to enforce VIRTIO I/O device protection through the use of VIRTIO_F_IOMMU_PLATFORM. Let's give

Re: [PATCH v2 1/1] s390: virtio: let arch accept devices without IOMMU feature

2020-06-16 Thread Pierre Morel
On 2020-06-16 11:52, Halil Pasic wrote: On Mon, 15 Jun 2020 14:39:24 +0200 Pierre Morel wrote: I find the subject (commit short) sub optimal. The 'arch' is already accepting devices 'without IOMMU feature'. What you are introducing is the ability to reject. An architecture protecting

Re: [PATCH v2 1/1] s390: virtio: let arch accept devices without IOMMU feature

2020-06-16 Thread Pierre Morel
On 2020-06-16 14:20, Cornelia Huck wrote: On Tue, 16 Jun 2020 12:52:50 +0200 Pierre Morel wrote: On 2020-06-16 11:52, Halil Pasic wrote: On Mon, 15 Jun 2020 14:39:24 +0200 Pierre Morel wrote: @@ -162,6 +163,11 @@ bool force_dma_unencrypted(struct device *dev) return

Re: [PATCH v2 1/1] s390: virtio: let arch accept devices without IOMMU feature

2020-06-16 Thread Pierre Morel
On 2020-06-16 14:17, Cornelia Huck wrote: On Tue, 16 Jun 2020 13:57:26 +0200 Halil Pasic wrote: On Tue, 16 Jun 2020 12:52:50 +0200 Pierre Morel wrote: int virtio_finalize_features(struct virtio_device *dev) { int ret = dev->config->finalize_features(dev); @@ -179,6 +

Re: [PATCH] s390: protvirt: virtio: Refuse device without IOMMU

2020-06-15 Thread Pierre Morel
Regards, Halil OK, then back to the first idea. Thanks, Pierre -- Pierre Morel IBM Lab Boeblingen ___ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/virtualization

[PATCH v2 0/1] s390: virtio: let's arch choose to accept devices without IOMMU feature

2020-06-15 Thread Pierre Morel
An architecture protecting the guest memory against unauthorized host access may want to enforce VIRTIO I/O device protection through the use of VIRTIO_F_IOMMU_PLATFORM. Let's give a chance to the architecture to accept or not devices without VIRTIO_F_IOMMU_PLATFORM. Pierre Morel (1): s390

[PATCH v2 1/1] s390: virtio: let arch accept devices without IOMMU feature

2020-06-15 Thread Pierre Morel
An architecture protecting the guest memory against unauthorized host access may want to enforce VIRTIO I/O device protection through the use of VIRTIO_F_IOMMU_PLATFORM. Let's give a chance to the architecture to accept or not devices without VIRTIO_F_IOMMU_PLATFORM. Signed-off-by: Pierre Morel

Re: [PATCH] s390: protvirt: virtio: Refuse device without IOMMU

2020-06-15 Thread Pierre Morel
On 2020-06-15 05:01, Jason Wang wrote: On 2020/6/12 下午7:38, Pierre Morel wrote: On 2020-06-12 11:21, Pierre Morel wrote: On 2020-06-11 05:10, Jason Wang wrote: On 2020/6/10 下午9:11, Pierre Morel wrote: Protected Virtualisation protects the memory of the guest and do not allow

Re: [PATCH] s390: protvirt: virtio: Refuse device without IOMMU

2020-06-10 Thread Pierre Morel
On 2020-06-10 16:53, Cornelia Huck wrote: On Wed, 10 Jun 2020 16:37:55 +0200 Pierre Morel wrote: On 2020-06-10 15:24, Cornelia Huck wrote: On Wed, 10 Jun 2020 15:11:51 +0200 Pierre Morel wrote: Protected Virtualisation protects the memory of the guest and do not allow a the host

Re: [PATCH] s390: protvirt: virtio: Refuse device without IOMMU

2020-06-10 Thread Pierre Morel
On 2020-06-10 15:24, Cornelia Huck wrote: On Wed, 10 Jun 2020 15:11:51 +0200 Pierre Morel wrote: Protected Virtualisation protects the memory of the guest and do not allow a the host to access all of its memory. Let's refuse a VIRTIO device which does not use IOMMU protected access

[PATCH] s390: protvirt: virtio: Refuse device without IOMMU

2020-06-10 Thread Pierre Morel
Protected Virtualisation protects the memory of the guest and do not allow a the host to access all of its memory. Let's refuse a VIRTIO device which does not use IOMMU protected access. Signed-off-by: Pierre Morel --- drivers/s390/virtio/virtio_ccw.c | 5 + 1 file changed, 5 insertions

Re: [PATCH] s390: protvirt: virtio: Refuse device without IOMMU

2020-06-12 Thread Pierre Morel
On 2020-06-11 05:10, Jason Wang wrote: On 2020/6/10 下午9:11, Pierre Morel wrote: Protected Virtualisation protects the memory of the guest and do not allow a the host to access all of its memory. Let's refuse a VIRTIO device which does not use IOMMU protected access. Signed-off-by: Pierre

Re: [PATCH] s390: protvirt: virtio: Refuse device without IOMMU

2020-06-12 Thread Pierre Morel
On 2020-06-12 11:21, Pierre Morel wrote: On 2020-06-11 05:10, Jason Wang wrote: On 2020/6/10 下午9:11, Pierre Morel wrote: Protected Virtualisation protects the memory of the guest and do not allow a the host to access all of its memory. Let's refuse a VIRTIO device which does not use

Re: [PATCH] s390: protvirt: virtio: Refuse device without IOMMU

2020-06-12 Thread Pierre Morel
On 2020-06-12 15:45, Mauricio Tavares wrote: On Wed, Jun 10, 2020 at 12:32 PM Pierre Morel wrote: Protected Virtualisation protects the memory of the guest and do not allow a the host to access all of its memory. Let's refuse a VIRTIO device which does not use IOMMU protected access