[PATCH] virtio_balloon: Notify guest only after deflating the balloon

2011-07-01 Thread Sasha Levin
...@redhat.com Cc: virtualization@lists.linux-foundation.org Cc: k...@vger.kernel.org Signed-off-by: Sasha Levin levinsasha...@gmail.com --- drivers/virtio/virtio_balloon.c | 16 ++-- 1 files changed, 10 insertions(+), 6 deletions(-) diff --git a/drivers/virtio/virtio_balloon.c b

Re: [PATCH] virtio_balloon: Notify guest only after deflating the balloon

2011-07-03 Thread Sasha Levin
is merely a courtesy. I've noticed that if I don't process the deflate vq the guest doesn't use the deflated pages at all - something which contradicts the feature that lets him use the deflated pages without waiting for the deflate vq. On Sat, Jul 02, 2011 at 06:06:56AM +0300, Sasha Levin

Re: [PATCH] virtio_balloon: Notify guest only after deflating the balloon

2011-07-03 Thread Sasha Levin
On Sun, 2011-07-03 at 13:30 +0300, Michael S. Tsirkin wrote: On Sun, Jul 03, 2011 at 12:46:59PM +0300, Sasha Levin wrote: On Sun, 2011-07-03 at 11:27 +0300, Michael S. Tsirkin wrote: Doesn't this basically just revert bf50e69f63d21091e525185c3ae761412be0ba72? Yes. I haven't

Re: [PATCH] virtio_balloon: Notify guest only after deflating the balloon

2011-07-03 Thread Sasha Levin
On Sun, 2011-07-03 at 15:11 +0300, Michael S. Tsirkin wrote: On Sun, Jul 03, 2011 at 01:52:29PM +0300, Sasha Levin wrote: On Sun, 2011-07-03 at 13:30 +0300, Michael S. Tsirkin wrote: On Sun, Jul 03, 2011 at 12:46:59PM +0300, Sasha Levin wrote: On Sun, 2011-07-03 at 11:27 +0300, Michael S

Re: [PATCH] virtio_balloon: Notify guest only after deflating the balloon

2011-07-03 Thread Sasha Levin
On Sun, 2011-07-03 at 16:44 +0300, Michael S. Tsirkin wrote: On Sun, Jul 03, 2011 at 03:32:36PM +0300, Sasha Levin wrote: On Sun, 2011-07-03 at 15:11 +0300, Michael S. Tsirkin wrote: On Sun, Jul 03, 2011 at 01:52:29PM +0300, Sasha Levin wrote: On Sun, 2011-07-03 at 13:30 +0300, Michael S

RE: [PATCH 097/117] Staging: hv: storvsc: Add code to handle IDE devices using the storvsc driver

2011-07-16 Thread Sasha Levin
On Sat, 2011-07-16 at 12:57 +, KY Srinivasan wrote: -Original Message- From: Christoph Hellwig [mailto:h...@infradead.org] Sent: Friday, July 15, 2011 10:05 PM To: KY Srinivasan Cc: gre...@suse.de; linux-ker...@vger.kernel.org; de...@linuxdriverproject.org;

Re: [Qemu-devel] [net-next RFC PATCH 7/7] virtio-net changes

2011-08-12 Thread Sasha Levin
On Fri, 2011-08-12 at 09:55 +0800, Jason Wang wrote: From: Krishna Kumar krkum...@in.ibm.com Implement mq virtio-net driver. Though struct virtio_net_config changes, it works with the old qemu since the last element is not accessed unless qemu sets VIRTIO_NET_F_MULTIQUEUE.

[PATCH] virtio-net: Read MAC only after initializing MSI-X

2011-08-13 Thread Sasha Levin
. Tsirkin m...@redhat.com Cc: virtualization@lists.linux-foundation.org Cc: net...@vger.kernel.org Cc: k...@vger.kernel.org Signed-off-by: Sasha Levin levinsasha...@gmail.com --- drivers/net/virtio_net.c | 16 1 files changed, 8 insertions(+), 8 deletions(-) diff --git a/drivers

Re: [PATCH] virtio-net: Read MAC only after initializing MSI-X

2011-08-14 Thread Sasha Levin
On Sun, 2011-08-14 at 12:23 +0930, Rusty Russell wrote: On Sat, 13 Aug 2011 11:51:01 +0300, Sasha Levin levinsasha...@gmail.com wrote: The MAC of a virtio-net device is located at the first field of the device specific header. This header is located at offset 20 if the device doesn't

[PATCH 3/3] virtio-net: Use virtio_config_val() for retrieving config

2011-08-14 Thread Sasha Levin
: virtualization@lists.linux-foundation.org Signed-off-by: Sasha Levin levinsasha...@gmail.com --- drivers/net/virtio_net.c | 14 +- 1 files changed, 5 insertions(+), 9 deletions(-) diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c index 0c7321c..878db50 100644

[PATCH 1/3] virtio-console: Use virtio_config_val() for retrieving config

2011-08-14 Thread Sasha Levin
: virtualization@lists.linux-foundation.org Signed-off-by: Sasha Levin levinsasha...@gmail.com --- drivers/char/virtio_console.c | 10 -- 1 files changed, 4 insertions(+), 6 deletions(-) diff --git a/drivers/char/virtio_console.c b/drivers/char/virtio_console.c index fb68b12..ed99f3b

[PATCH 2/3] virtio_config: Add virtio_config_val_len()

2011-08-14 Thread Sasha Levin
-foundation.org Signed-off-by: Sasha Levin levinsasha...@gmail.com --- include/linux/virtio_config.h |3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/include/linux/virtio_config.h b/include/linux/virtio_config.h index 39c88c5..add4790 100644 --- a/include/linux/virtio_config.h

Re: [PULL] lguest fix, virtio documentation

2011-08-15 Thread Sasha Levin
On Mon, 2011-08-15 at 10:25 +0930, Rusty Russell wrote: [ This adds a text copy of the virtio draft spec to the kernel source, which should make it easier for people to find and read. The master is still the lyx document on my server, so I'll keep it in sync. ] The following changes

Re: [PATCH] virtio-net: Read MAC only after initializing MSI-X

2011-08-15 Thread Sasha Levin
On Mon, 2011-08-15 at 09:55 +0930, Rusty Russell wrote: On Sun, 14 Aug 2011 16:57:32 +0300, Sasha Levin levinsasha...@gmail.com wrote: On Sun, 2011-08-14 at 12:23 +0930, Rusty Russell wrote: On Sat, 13 Aug 2011 11:51:01 +0300, Sasha Levin levinsasha...@gmail.com wrote: The MAC

[PATCH] virtio-blk: Add stats VQ to collect information about devices

2011-08-16 Thread Sasha Levin
ru...@rustcorp.com.au Cc: Michael S. Tsirkin m...@redhat.com Cc: virtualization@lists.linux-foundation.org Cc: k...@vger.kernel.org Signed-off-by: Sasha Levin levinsasha...@gmail.com --- drivers/block/virtio_blk.c | 110 +--- include/linux/virtio_blk.h

Re: [PATCH 7/8] Staging: hv: vmbus: Fix a bug in error handling in vmbus_bus_init()

2011-08-17 Thread Sasha Levin
On Mon, 2011-08-15 at 15:12 -0700, K. Y. Srinivasan wrote: Fix a bug in error handling in vmbus_bus_init(). Signed-off-by: K. Y. Srinivasan k...@microsoft.com Signed-off-by: Haiyang Zhang haiya...@microsoft.com --- vmbus_bus_init() has a 'cleanup' label which is used just for returning,

Re: [PATCH] virtio-blk: Add stats VQ to collect information about devices

2011-08-17 Thread Sasha Levin
On Wed, 2011-08-17 at 16:00 -0700, Avi Kivity wrote: On 08/16/2011 12:47 PM, Sasha Levin wrote: This patch adds support for an optional stats vq that works similary to the stats vq provided by virtio-balloon. The purpose of this change is to allow collection of statistics about working

RE: [PATCH 2/8] Staging: hv: vmbus: Invoke vmbus_on_msg_dpc() directly

2011-08-17 Thread Sasha Levin
On Wed, 2011-08-17 at 18:43 +, KY Srinivasan wrote: -Original Message- From: Sasha Levin [mailto:levinsasha...@gmail.com] Sent: Wednesday, August 17, 2011 8:48 AM To: KY Srinivasan Cc: gre...@suse.de; linux-ker...@vger.kernel.org; de...@linuxdriverproject.org; virtualizat

[PATCH] virtio-blk: Update spec with new stats vq

2011-08-18 Thread Sasha Levin
+\author 2090695081 Sasha Levin \end_header \begin_body @@ -5224,7 +5225,24 @@ ID 2 \end_layout \begin_layout Description -Virtqueues 0:requestq. +Virtqueues 0:requestq +\change_inserted 2090695081 1313645732 +. + 1:statsq. +\begin_inset Foot +status open + +\begin_layout Plain Layout

Re: [PATCH] virtio-blk: Add stats VQ to collect information about devices

2011-08-18 Thread Sasha Levin
On Thu, 2011-08-18 at 08:10 -0700, Avi Kivity wrote: On 08/17/2011 09:38 PM, Sasha Levin wrote: On Wed, 2011-08-17 at 16:00 -0700, Avi Kivity wrote: On 08/16/2011 12:47 PM, Sasha Levin wrote: This patch adds support for an optional stats vq that works similary to the stats

Re: [PATCH] virtio-blk: Add stats VQ to collect information about devices

2011-08-18 Thread Sasha Levin
On Thu, 2011-08-18 at 10:36 -0700, Avi Kivity wrote: On 08/18/2011 09:29 AM, Sasha Levin wrote: What can you do with it? I was actually planning on submitting another patch that would add something similar into virtio-net. My plan was to enable collecting statistics regarding

Re: [PATCH] virtio-net: Read MAC only after initializing MSI-X

2011-08-19 Thread Sasha Levin
On Fri, 2011-08-19 at 18:23 +0300, Michael S. Tsirkin wrote: On Sat, Aug 13, 2011 at 11:51:01AM +0300, Sasha Levin wrote: The MAC of a virtio-net device is located at the first field of the device specific header. This header is located at offset 20 if the device doesn't support MSI-X

Re: [PATCH] virtio-net: Read MAC only after initializing MSI-X

2011-09-01 Thread Sasha Levin
Aug 2011 18:23:35 +0300, Michael S. Tsirkin m...@redhat.com wrote: On Sat, Aug 13, 2011 at 11:51:01AM +0300, Sasha Levin wrote: The MAC of a virtio-net device is located at the first field of the device specific header. This header is located at offset 20 if the device doesn't

Re: [PULL] virtio

2011-11-01 Thread Sasha Levin
On Tue, 2011-11-01 at 13:45 +0200, Michael S. Tsirkin wrote: On Tue, Nov 01, 2011 at 10:39:08AM +1030, Rusty Russell wrote: * [new tag] ru...@rustcorp.com.au-v3.1-7196-gac5be1e - ru...@rustcorp.com.au-v3.1-7196-gac5be1e The following changes since commit

Re: [PULL] virtio

2011-11-01 Thread Sasha Levin
On Tue, 2011-11-01 at 14:42 +0200, Michael S. Tsirkin wrote: On Tue, Nov 01, 2011 at 02:33:33PM +0200, Sasha Levin wrote: On Tue, 2011-11-01 at 13:45 +0200, Michael S. Tsirkin wrote: On Tue, Nov 01, 2011 at 10:39:08AM +1030, Rusty Russell wrote: * [new tag] ru...@rustcorp.com.au

Re: [PULL] virtio

2011-11-01 Thread Sasha Levin
On Wed, 2011-11-02 at 11:39 +1030, Rusty Russell wrote: On Tue, 1 Nov 2011 14:42:23 +0200, Michael S. Tsirkin m...@redhat.com wrote: On Tue, Nov 01, 2011 at 02:33:33PM +0200, Sasha Levin wrote: Unless Michael pointed this patch out, it would have broken (at least) the kvm tool in a non

virtio-pci new configuration proposal

2011-11-02 Thread Sasha Levin
This is a proposal for a new layout of the virtio-pci config space. We will separate the current configuration into two: A virtio-pci common configuration and a device specific configuration. This allows more flexibility with adding features and makes usage easier, specifically in cases like the

Re: virtio-pci new configuration proposal

2011-11-02 Thread Sasha Levin
On Wed, 2011-11-02 at 21:08 +0200, Michael S. Tsirkin wrote: On Wed, Nov 02, 2011 at 08:49:27PM +0200, Sasha Levin wrote: This is a proposal for a new layout of the virtio-pci config space. We will separate the current configuration into two: A virtio-pci common configuration

Re: [PATCH RFC] virtio-pci: flexible configuration layout

2011-11-02 Thread Sasha Levin
Hi Michael, On Thu, 2011-11-03 at 01:31 +0200, Michael S. Tsirkin wrote: Add a flexible mechanism to specify virtio configuration layout, using pci vendor-specific capability. A separate capability is used for each of common, device specific and data-path accesses. Warning: compiled only.

[PATCH] virtio-balloon: Trivial cleanups

2011-11-03 Thread Sasha Levin
Trivial changes to remove forgotten junk, format comments, and correct names. Cc: Rusty Russell ru...@rustcorp.com.au Cc: Michael S. Tsirkin m...@redhat.com Cc: virtualization@lists.linux-foundation.org Signed-off-by: Sasha Levin levinsasha...@gmail.com --- drivers/virtio/virtio_balloon.c |6

Re: virtio-pci new configuration proposal

2011-11-03 Thread Sasha Levin
On Thu, 2011-11-03 at 12:28 +1030, Rusty Russell wrote: On Wed, 02 Nov 2011 20:49:27 +0200, Sasha Levin levinsasha...@gmail.com wrote: This is a proposal for a new layout of the virtio-pci config space. We will separate the current configuration into two: A virtio-pci common

Re: virtio-pci new configuration proposal

2011-11-04 Thread Sasha Levin
On Fri, 2011-11-04 at 16:23 +0200, Michael S. Tsirkin wrote: On Fri, Nov 04, 2011 at 03:53:24PM +0200, Sasha Levin wrote: On Fri, 2011-11-04 at 15:51 +0200, Michael S. Tsirkin wrote: On Fri, Nov 04, 2011 at 02:32:19PM +0200, Sasha Levin wrote: On Fri, 2011-11-04 at 13:40 +0200, Michael S

Re: virtio-pci new configuration proposal

2011-11-06 Thread Sasha Levin
On Sun, 2011-11-06 at 09:30 +0200, Michael S. Tsirkin wrote: On Fri, Nov 04, 2011 at 04:53:05PM +0200, Sasha Levin wrote: As you said, the PCI cap list was introduced both to save space (which is not the motivation here), and because it's a very efficient It's

Re: virtio-pci new configuration proposal

2011-11-08 Thread Sasha Levin
On Tue, Nov 8, 2011 at 1:53 AM, Rusty Russell ru...@rustcorp.com.au wrote: On Mon, 7 Nov 2011 23:14:14 +0200, Michael S. Tsirkin m...@redhat.com wrote: On Mon, Nov 07, 2011 at 03:46:23PM +1030, Rusty Russell wrote: So far, the only three things make sense to have in a capability list:

Re: [PATCH RFC] virtio-spec: flexible configuration layout

2011-11-09 Thread Sasha Levin
On Tue, 2011-11-08 at 23:40 +0200, Michael S. Tsirkin wrote: Here's a spec change documenting what my C patch does (almost - I tweaked the layout a bit, but the idea is the same). Some more cleanups are needed but I thought I'd send it for early flames/comments. The idea is simple: we split

Re: [PATCH RFC] virtio-spec: flexible configuration layout

2011-11-09 Thread Sasha Levin
On Tue, 2011-11-08 at 23:40 +0200, Michael S. Tsirkin wrote: Here's a spec change documenting what my C patch does (almost - I tweaked the layout a bit, but the idea is the same). Some more cleanups are needed but I thought I'd send it for early flames/comments. The idea is simple: we split

Re: [PATCH RFC] virtio-spec: flexible configuration layout

2011-11-09 Thread Sasha Levin
On Wed, 2011-11-09 at 12:18 +0200, Michael S. Tsirkin wrote: On Wed, Nov 09, 2011 at 11:55:02AM +0200, Sasha Levin wrote: On Tue, 2011-11-08 at 23:40 +0200, Michael S. Tsirkin wrote: Here's a spec change documenting what my C patch does (almost - I tweaked the layout a bit, but the idea

Re: [PATCH RFC] virtio-spec: flexible configuration layout

2011-11-09 Thread Sasha Levin
On Wed, 2011-11-09 at 14:25 +0200, Pekka Enberg wrote: On Wed, 9 Nov 2011, Michael S. Tsirkin wrote: KVM tool actually has support for 64bit features, we can probably remove that when Pekka isn't looking :) It's not yet released so maybe it's not an issue yet. If it's too late I can

Re: [PATCH RFC] virtio-spec: flexible configuration layout

2011-11-09 Thread Sasha Levin
On Wed, 2011-11-09 at 14:38 +0200, Avi Kivity wrote: On 11/09/2011 10:46 AM, Sasha Levin wrote: Alternatively we can add new structures with new structure IDs, pointed to from PCI configuration space. As we don't yet have devices or drivers with 64 bit features, I decided we don't

Re: [RFC] [ver3 PATCH 0/6] Implement multiqueue virtio-net

2011-11-11 Thread Sasha Levin
Hi, I'm seeing this BUG() sometimes when running it using a small patch I did for KVM tool: [1.280766] BUG: unable to handle kernel NULL pointer dereference at 0010 [1.281531] IP: [810b3ac7] free_percpu+0x9a/0x104 [1.281531] PGD 0 [1.281531] Oops: [#1]

[RFC] kvm tools: Implement multiple VQ for virtio-net

2011-11-11 Thread Sasha Levin
@lists.linux-foundation.org Cc: net...@vger.kernel.org Signed-off-by: Sasha Levin levinsasha...@gmail.com --- tools/kvm/include/kvm/virtio-pci.h |2 +- tools/kvm/virtio/net.c | 94 +++ 2 files changed, 52 insertions(+), 44 deletions(-) diff --git a/tools

Re: [RFC] [ver3 PATCH 0/6] Implement multiqueue virtio-net

2011-11-11 Thread Sasha Levin
On Sat, 2011-11-12 at 11:15 +0530, Krishna Kumar wrote: Sasha Levin levinsasha...@gmail.com wrote on 11/12/2011 03:32:04 AM: I'm seeing this BUG() sometimes when running it using a small patch I did for KVM tool: [1.281531] Call Trace: [1.281531] [8138a0e5

Re: [RFC] kvm tools: Implement multiple VQ for virtio-net

2011-11-13 Thread Sasha Levin
On Sun, 2011-11-13 at 12:24 +0200, Michael S. Tsirkin wrote: On Sat, Nov 12, 2011 at 12:12:01AM +0200, Sasha Levin wrote: This is a patch based on Krishna Kumar's patch series which implements multiple VQ support for virtio-net. The patch was tested with ver3 of the patch. Cc

Re: [RFC] kvm tools: Implement multiple VQ for virtio-net

2011-11-13 Thread Sasha Levin
On Sun, 2011-11-13 at 17:00 +0200, Sasha Levin wrote: On Sun, 2011-11-13 at 12:24 +0200, Michael S. Tsirkin wrote: On Sat, Nov 12, 2011 at 12:12:01AM +0200, Sasha Levin wrote: This is a patch based on Krishna Kumar's patch series which implements multiple VQ support for virtio-net

Re: [RFC] kvm tools: Implement multiple VQ for virtio-net

2011-11-14 Thread Sasha Levin
On Mon, 2011-11-14 at 10:04 +0800, Asias He wrote: Hi, Shsha On 11/13/2011 11:00 PM, Sasha Levin wrote: On Sun, 2011-11-13 at 12:24 +0200, Michael S. Tsirkin wrote: On Sat, Nov 12, 2011 at 12:12:01AM +0200, Sasha Levin wrote: This is a patch based on Krishna Kumar's patch series which

[RFC 0/5] virtio-pci, kvm tools: Support new virtio-pci spec in kvm tools

2011-11-14 Thread Sasha Levin
kernel side patches. The usermode code isn't complete, but it's working properly and should be enough for functionality testing. Michael S. Tsirkin (1): virtio-pci: flexible configuration layout Sasha Levin (4): virtio-pci: Fix compilation issue iomap: Don't ignore offset kvm tools: Free up

[RFC 2/5] virtio-pci: Fix compilation issue

2011-11-14 Thread Sasha Levin
Signed-off-by: Sasha Levin levinsasha...@gmail.com --- drivers/virtio/virtio_pci.c |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/virtio/virtio_pci.c b/drivers/virtio/virtio_pci.c index 7625434..d242fcc 100644 --- a/drivers/virtio/virtio_pci.c +++ b/drivers

[RFC 1/5] virtio-pci: flexible configuration layout

2011-11-14 Thread Sasha Levin
From: Michael S. Tsirkin m...@redhat.com Add a flexible mechanism to specify virtio configuration layout, using pci vendor-specific capability. A separate capability is used for each of common, device specific and data-path accesses. Warning: compiled only. This patch also needs to be split up,

[RFC 3/5] iomap: Don't ignore offset

2011-11-14 Thread Sasha Levin
Offset was ignored for start calulcations, making all mappings start at offset 0 always. Signed-off-by: Sasha Levin levinsasha...@gmail.com --- lib/iomap.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/lib/iomap.c b/lib/iomap.c index f28720e..93ae915 100644 --- a/lib

[RFC 4/5] kvm tools: Free up the MSI-X PBA BAR

2011-11-14 Thread Sasha Levin
Free up the BAR to make space for the new virtio BARs. It isn't required to have the PBA and the table in the separate BARs, and uniting them will just give us extra BARs to play with. Signed-off-by: Sasha Levin levinsasha...@gmail.com --- tools/kvm/include/kvm/virtio-pci.h |1 - tools/kvm

[RFC 5/5] kvm tools: Support new virtio-pci configuration layout

2011-11-14 Thread Sasha Levin
Signed-off-by: Sasha Levin levinsasha...@gmail.com --- tools/kvm/include/kvm/pci.h| 13 ++- tools/kvm/include/kvm/virtio-pci.h |4 + tools/kvm/virtio/pci.c | 248 ++-- 3 files changed, 254 insertions(+), 11 deletions(-) diff --git

[PATCH] virtio-mmio: Correct the name of the guest features selector

2011-11-15 Thread Sasha Levin
Guest features selector spelling mistake. Cc: Pawel Moll pawel.m...@arm.com Cc: Rusty Russell ru...@rustcorp.com.au Cc: virtualization@lists.linux-foundation.org Signed-off-by: Sasha Levin levinsasha...@gmail.com --- Hopefully not too late to fix, should possibly be done in one of the next RCs

Re: [RFC] kvm tools: Implement multiple VQ for virtio-net

2011-11-15 Thread Sasha Levin
On Tue, 2011-11-15 at 10:14 +0530, Krishna Kumar2 wrote: Sasha Levin levinsasha...@gmail.com wrote on 11/14/2011 03:45:40 PM: Why both the bandwidth and latency performance are dropping so dramatically with multiple VQ? It looks like theres no hash sync between host and guest, which

Re: [PATCHv2 RFC] virtio-spec: flexible configuration layout

2011-11-16 Thread Sasha Levin
On Wed, 2011-11-16 at 09:21 +0200, Michael S. Tsirkin wrote: On Wed, Nov 16, 2011 at 10:28:52AM +1030, Rusty Russell wrote: On Fri, 11 Nov 2011 09:39:13 +0200, Sasha Levin levinsasha...@gmail.com wrote: On Fri, Nov 11, 2011 at 6:24 AM, Rusty Russell ru...@rustcorp.com.au wrote: (2

Re: [RFC] kvm tools: Add support for virtio-mmio

2011-11-16 Thread Sasha Levin
On Wed, 2011-11-16 at 13:21 +, Pawel Moll wrote: On Tue, 2011-11-15 at 17:56 +, Sasha Levin wrote: Hmm... If thats the plan, it should probably be a virtio thing (not virtio-mmio specific). Either way, it could also use some clarification in the spec. Well, the spec (p. 2.1

Re: [RFC] [ver3 PATCH 3/6] virtio_net: virtio_net driver changes

2011-11-17 Thread Sasha Levin
On Fri, 2011-11-18 at 01:08 +, Ben Hutchings wrote: On Fri, 2011-11-11 at 18:34 +0530, Krishna Kumar wrote: Changes for multiqueue virtio_net driver. [...] @@ -677,25 +730,35 @@ static struct rtnl_link_stats64 *virtnet { struct virtnet_info *vi = netdev_priv(dev); int cpu;

[PATCH] vhost-net: Acquire device lock when releasing device

2011-11-18 Thread Sasha Levin
] system_call_fastpath+0x16/0x1b Cc: Michael S. Tsirkin m...@redhat.com Cc: k...@vger.kernel.org Cc: virtualization@lists.linux-foundation.org Cc: net...@vger.kernel.org Signed-off-by: Sasha Levin levinsasha...@gmail.com --- drivers/vhost/net.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions

Re: [RFC] [ver3 PATCH 3/6] virtio_net: virtio_net driver changes

2011-11-18 Thread Sasha Levin
On Fri, 2011-11-18 at 15:40 +, Ben Hutchings wrote: On Fri, 2011-11-18 at 08:24 +0200, Sasha Levin wrote: On Fri, 2011-11-18 at 01:08 +, Ben Hutchings wrote: On Fri, 2011-11-11 at 18:34 +0530, Krishna Kumar wrote: Changes for multiqueue virtio_net driver. [...] @@ -677,25

Re: [PATCHv3 RFC] virtio-pci: flexible configuration layout

2011-11-23 Thread Sasha Levin
On Wed, 2011-11-23 at 10:49 +0200, Michael S. Tsirkin wrote: On Wed, Nov 23, 2011 at 01:02:22PM +1030, Rusty Russell wrote: +/* Fields in VIRTIO_PCI_CAP_COMMON_CFG: */ +struct virtio_pci_common_cfg { + /* About the whole device. */ + __u64 device_features; /* read-only */ + __u64

Re: [PATCHv3 RFC] virtio-pci: flexible configuration layout

2011-11-23 Thread Sasha Levin
On Wed, 2011-11-23 at 13:02 +1030, Rusty Russell wrote: On Tue, 22 Nov 2011 20:36:22 +0200, Michael S. Tsirkin m...@redhat.com wrote: Here's an updated vesion. I'm alternating between updating the spec and the driver, spec update to follow. Don't touch the spec yet, we have a long way

Re: [PATCH v3 2/3] hvc_init(): Enforce one-time initialization.

2011-11-23 Thread Sasha Levin
On Wed, 2011-11-23 at 18:26 +0530, Amit Shah wrote: On (Wed) 23 Nov 2011 [16:08:52], Amit Shah wrote: With this setup, with and without patches, I can spawn two consoles via: /sbin/agetty /dev/hvc0 9600 vt100 /sbin/agetty /dev/hvc1 9600 vt100 (Strange thing is, the second one

Re: [PATCHv3 RFC] virtio-pci: flexible configuration layout

2011-11-28 Thread Sasha Levin
On Mon, 2011-11-28 at 11:25 +1030, Rusty Russell wrote: I'd like to see kvmtools remove support for legacy mode altogether, but they probably have existing users. While we can't simply remove it right away, instead of mixing our implementation for both legacy and new spec in the same code we

[PATCH] virtio-ring: Use threshold for switching to indirect descriptors

2011-11-29 Thread Sasha Levin
10.005353.28 Cc: Rusty Russell ru...@rustcorp.com.au Cc: Michael S. Tsirkin m...@redhat.com Cc: virtualization@lists.linux-foundation.org Cc: k...@vger.kernel.org Signed-off-by: Sasha Levin levinsasha...@gmail.com --- drivers/virtio/virtio_ring.c | 12 ++-- 1 files changed, 10

Re: [PATCH] virtio-ring: Use threshold for switching to indirect descriptors

2011-11-29 Thread Sasha Levin
On Tue, 2011-11-29 at 14:56 +0200, Michael S. Tsirkin wrote: On Tue, Nov 29, 2011 at 11:33:16AM +0200, Sasha Levin wrote: Currently if VIRTIO_RING_F_INDIRECT_DESC is enabled we will use indirect descriptors even if we have plenty of space in the ring. This means that we take a performance

Re: [PATCH] virtio-ring: Use threshold for switching to indirect descriptors

2011-11-29 Thread Sasha Levin
On Tue, 2011-11-29 at 15:54 +0200, Michael S. Tsirkin wrote: On Tue, Nov 29, 2011 at 03:34:48PM +0200, Sasha Levin wrote: On Tue, 2011-11-29 at 14:56 +0200, Michael S. Tsirkin wrote: On Tue, Nov 29, 2011 at 11:33:16AM +0200, Sasha Levin wrote: Currently if VIRTIO_RING_F_INDIRECT_DESC

Re: [PATCHv3 RFC] virtio-pci: flexible configuration layout

2011-11-30 Thread Sasha Levin
On Wed, 2011-11-30 at 10:10 +1030, Rusty Russell wrote: On Mon, 28 Nov 2011 11:15:31 +0200, Sasha Levin levinsasha...@gmail.com wrote: On Mon, 2011-11-28 at 11:25 +1030, Rusty Russell wrote: I'd like to see kvmtools remove support for legacy mode altogether, but they probably have

Re: [PATCH] virtio-ring: Use threshold for switching to indirect descriptors

2011-11-30 Thread Sasha Levin
Sorry, I forgot to copy-paste one of the results :) On Wed, 2011-11-30 at 18:11 +0200, Sasha Levin wrote: I did some testing of indirect descriptors under different workloads. All tests were on a 2 vcpu guest with vhost on. Simple TCP_STREAM using netperf. Indirect desc off: guest - host

Re: [PATCH] virtio-ring: Use threshold for switching to indirect descriptors

2011-12-01 Thread Sasha Levin
On Thu, 2011-12-01 at 09:58 +0200, Michael S. Tsirkin wrote: On Thu, Dec 01, 2011 at 01:12:25PM +1030, Rusty Russell wrote: On Wed, 30 Nov 2011 18:11:51 +0200, Sasha Levin levinsasha...@gmail.com wrote: On Tue, 2011-11-29 at 16:58 +0200, Avi Kivity wrote: On 11/29/2011 04:54 PM

Re: [PATCH] virtio-ring: Use threshold for switching to indirect descriptors

2011-12-03 Thread Sasha Levin
On Fri, 2011-12-02 at 11:16 +1030, Rusty Russell wrote: On Thu, 1 Dec 2011 12:26:42 +0200, Michael S. Tsirkin m...@redhat.com wrote: On Thu, Dec 01, 2011 at 10:09:37AM +0200, Sasha Levin wrote: On Thu, 2011-12-01 at 09:58 +0200, Michael S. Tsirkin wrote: We'll presumably need some

Re: [PATCH] virtio-ring: Use threshold for switching to indirect descriptors

2011-12-04 Thread Sasha Levin
On Sun, 2011-12-04 at 13:52 +0200, Avi Kivity wrote: On 12/03/2011 01:50 PM, Sasha Levin wrote: On Fri, 2011-12-02 at 11:16 +1030, Rusty Russell wrote: On Thu, 1 Dec 2011 12:26:42 +0200, Michael S. Tsirkin m...@redhat.com wrote: On Thu, Dec 01, 2011 at 10:09:37AM +0200, Sasha Levin

Re: [PATCH] virtio-ring: Use threshold for switching to indirect descriptors

2011-12-04 Thread Sasha Levin
On Sun, 2011-12-04 at 18:22 +0200, Michael S. Tsirkin wrote: On Sun, Dec 04, 2011 at 02:13:51PM +0200, Sasha Levin wrote: On Sun, 2011-12-04 at 13:52 +0200, Avi Kivity wrote: On 12/03/2011 01:50 PM, Sasha Levin wrote: On Fri, 2011-12-02 at 11:16 +1030, Rusty Russell wrote: On Thu, 1

Re: [PATCH] virtio-ring: Use threshold for switching to indirect descriptors

2011-12-04 Thread Sasha Levin
On Sun, 2011-12-04 at 19:37 +0200, Avi Kivity wrote: On 12/04/2011 07:34 PM, Sasha Levin wrote: I'm confused. didn't you see a bigger benefit for guest-host by switching indirect off? The 5% improvement is over the 'regular' indirect on, not over indirect off. Sorry

Re: [PATCH] virtio-ring: Use threshold for switching to indirect descriptors

2011-12-04 Thread Sasha Levin
On Sun, 2011-12-04 at 19:39 +0200, Sasha Levin wrote: On Sun, 2011-12-04 at 19:37 +0200, Avi Kivity wrote: On 12/04/2011 07:34 PM, Sasha Levin wrote: I'm confused. didn't you see a bigger benefit for guest-host by switching indirect off? The 5% improvement is over

Re: [PATCH] virtio-ring: Use threshold for switching to indirect descriptors

2011-12-07 Thread Sasha Levin
On Sun, 2011-12-04 at 20:23 +0200, Sasha Levin wrote: [snip] Rusty, Michael, does the below looks a reasonable optimization for you? should I send it as a patch? Something like the following patch: diff --git a/drivers/virtio/virtio_ring.c b/drivers/virtio/virtio_ring.c index c7a2c20

Re: [PATCH 0/11] RFC: PCI using capabilitities

2011-12-08 Thread Sasha Levin
Rusty, I can't find the actual patches, could you verify that they were indeed sent? On Thu, 2011-12-08 at 20:52 +1030, Rusty Russell wrote: Here's the patch series I ended up with. I haven't coded up the QEMU side yet, so no idea if the new driver works. Questions: (1) Do we win from

Re: [PATCH 0/11] RFC: PCI using capabilitities

2011-12-08 Thread Sasha Levin
On Thu, 2011-12-08 at 20:52 +1030, Rusty Russell wrote: Here's the patch series I ended up with. I haven't coded up the QEMU side yet, so no idea if the new driver works. Questions: (1) Do we win from separating ISR, NOTIFY and COMMON? (2) I used a u8 bar; should I use a bir and pack it

Re: [RFC 4/11] virtio-pci: define layout for virtio vendor-specific capabilities.

2011-12-10 Thread Sasha Levin
On Thu, 2011-12-08 at 21:04 +1030, Rusty Russell wrote: Based on patch by Michael S. Tsirkin m...@redhat.com, but I found it hard to follow so changed to use structures which are more self-documenting. Signed-off-by: Rusty Russell ru...@rustcorp.com.au --- include/linux/virtio_pci.h |

Re: [RFC 6/11] virtio_pci: don't use the legacy driver if we find the new PCI capabilities.

2011-12-10 Thread Sasha Levin
On Thu, 2011-12-08 at 21:08 +1030, Rusty Russell wrote: With module option to override. I assume I can call pci_find_capability() before pci_request_regions? I don't think thats safe. -- Sasha. ___ Virtualization mailing list

Re: [PATCH 0/11] RFC: PCI using capabilitities

2011-12-10 Thread Sasha Levin
On Fri, 2011-12-09 at 16:47 +1030, Rusty Russell wrote: On Thu, 08 Dec 2011 17:37:37 +0200, Sasha Levin levinsasha...@gmail.com wrote: Which leads me to the question: Are MMIO vs MMIO reads/writes not ordered? That seems really odd, especially being repeatable. Happens every single time

Re: [PATCH 0/11] RFC: PCI using capabilitities

2011-12-11 Thread Sasha Levin
On Sun, 2011-12-11 at 11:05 +0200, Avi Kivity wrote: mmios are strictly ordered. Perhaps your printfs are reordered by buffering? Are they from different threads? Are you using coalesced mmio (which is still strictly ordered, if used correctly)? I print the queue_selector and

Re: [PATCH 0/11] RFC: PCI using capabilitities

2011-12-11 Thread Sasha Levin
On Sun, 2011-12-11 at 14:30 +0200, Michael S. Tsirkin wrote: On Sun, Dec 11, 2011 at 12:03:52PM +0200, Sasha Levin wrote: On Sun, 2011-12-11 at 11:05 +0200, Avi Kivity wrote: mmios are strictly ordered. Perhaps your printfs are reordered by buffering? Are they from different

Re: [PATCH 0/11] RFC: PCI using capabilitities

2011-12-11 Thread Sasha Levin
On Sun, 2011-12-11 at 14:47 +0200, Michael S. Tsirkin wrote: First, I'd like to answer your questions from the PCI side. Look for PCI rules in the PCI spec. You will notices that a write is required to be able to pass a read request. It might also pass read completion. A read request will not

Re: [PATCH 0/2] vhot-net: Use kvm_memslots instead of vhost_memory to translate GPA to HVA

2011-12-15 Thread Sasha Levin
On Fri, 2011-12-16 at 13:32 +0800, zanghongy...@huawei.com wrote: From: Hongyong Zang zanghongy...@huawei.com Vhost-net uses its own vhost_memory, which results from user space (qemu) info, to translate GPA to HVA. Since kernel's kvm structure already maintains the address relationship in

Re: [PATCH 0/2] vhot-net: Use kvm_memslots instead of vhost_memory to translate GPA to HVA

2011-12-15 Thread Sasha Levin
On Fri, 2011-12-16 at 15:40 +0800, Zang Hongyong wrote: 于 2011/12/16,星期五 15:05, Sasha Levin 写道: On Fri, 2011-12-16 at 13:32 +0800, zanghongy...@huawei.com wrote: From: Hongyong Zangzanghongy...@huawei.com Vhost-net uses its own vhost_memory, which results from user space (qemu) info

Re: [PATCH 0/2] vhot-net: Use kvm_memslots instead of vhost_memory to translate GPA to HVA

2011-12-16 Thread Sasha Levin
On Fri, 2011-12-16 at 09:59 +0200, Sasha Levin wrote: There has been a great deal of effort to keep vhost and kvm untangled. One example is the memory translation it has to do, another one is the eventfd/irqfd thing it does just so it could signal an IRQ in the guest instead of accessing

Re: [PATCH] vhost-net: Acquire device lock when releasing device

2012-01-27 Thread Sasha Levin
18, 2011 at 11:19:42AM +0200, Sasha Levin wrote: Device lock should be held when releasing a device, and specifically when calling vhost_dev_cleanup(). Otherwise, RCU complains about it: [ 2025.642835] === [ 2025.643838] [ INFO: suspicious RCU usage

Re: [PATCH 1/2] virtio-blk: Fix hot-unplug race in remove method

2012-05-02 Thread Sasha Levin
On Thu, May 3, 2012 at 4:19 AM, Asias He as...@redhat.com wrote: @@ -190,6 +194,7 @@ static void do_virtblk_request(struct request_queue *q)        while ((req = blk_peek_request(q)) != NULL) {                BUG_ON(req-nr_phys_segments + 2 vblk-sg_elems); +              

Re: using cache for virtio allocations?

2012-05-02 Thread Sasha Levin
On Thu, May 3, 2012 at 7:29 AM, Michael S. Tsirkin m...@redhat.com wrote: Sasha, didn't you have a patch to allocate things using cache in virtio core? What happened to it? Thanks, MST It got stuck due to several things, and I got sidetracked, sorry. Here are the outstanding issues: 1.

Re: using cache for virtio allocations?

2012-05-03 Thread Sasha Levin
On Thu, May 3, 2012 at 9:32 AM, Michael S. Tsirkin m...@redhat.com wrote: On Thu, May 03, 2012 at 07:51:18AM +0200, Sasha Levin wrote: On Thu, May 3, 2012 at 7:29 AM, Michael S. Tsirkin m...@redhat.com wrote: Sasha, didn't you have a patch to allocate things using cache in virtio core

Re: using cache for virtio allocations?

2012-05-03 Thread Sasha Levin
On Thu, May 3, 2012 at 10:44 AM, Michael S. Tsirkin m...@redhat.com wrote: On Thu, May 03, 2012 at 10:38:56AM +0200, Sasha Levin wrote: On Thu, May 3, 2012 at 9:32 AM, Michael S. Tsirkin m...@redhat.com wrote: On Thu, May 03, 2012 at 07:51:18AM +0200, Sasha Levin wrote: On Thu, May 3, 2012

Re: [PATCH 3/3] virtio-blk: Add bio-based IO path for virtio-blk

2012-06-18 Thread Sasha Levin
On Mon, 2012-06-18 at 14:14 +0300, Dor Laor wrote: On 06/18/2012 01:05 PM, Rusty Russell wrote: On Mon, 18 Jun 2012 16:03:23 +0800, Asias Heas...@redhat.com wrote: On 06/18/2012 03:46 PM, Rusty Russell wrote: On Mon, 18 Jun 2012 14:53:10 +0800, Asias Heas...@redhat.com wrote: This patch

Re: [PATCH RFC] virtio-spec: flexible configuration layout

2012-06-18 Thread Sasha Levin
On Mon, 2012-06-18 at 14:54 +0300, Michael S. Tsirkin wrote: On Wed, Nov 09, 2011 at 02:36:43PM +0200, Pekka Enberg wrote: On Wed, 9 Nov 2011, Sasha Levin wrote: They don't exist in kernel code either, for same reason as above. Nothing will break if we remove it since no one really used

[RFC 2/2] virtio-ring: Allocate indirect buffers from cache when possible

2012-06-18 Thread Sasha Levin
Currently if VIRTIO_RING_F_INDIRECT_DESC is enabled we will use indirect descriptors and allocate them using a simple kmalloc(). This patch adds a cache which will allow indirect buffers under a configurable size to be allocated from that cache instead. Signed-off-by: Sasha Levin levinsasha

[RFC 1/2] virtio-ring: Use threshold for switching to indirect descriptors

2012-06-18 Thread Sasha Levin
offset. Signed-off-by: Sasha Levin levinsasha...@gmail.com --- drivers/block/virtio_blk.c |4 drivers/char/hw_random/virtio-rng.c |4 drivers/char/virtio_console.c |4 drivers/net/virtio_net.c|4 drivers/virtio/virtio_balloon.c |4

Re: [net-next RFC V5 2/5] virtio_ring: move queue_index to vring_virtqueue

2012-07-05 Thread Sasha Levin
On Thu, 2012-07-05 at 18:29 +0800, Jason Wang wrote: Instead of storing the queue index in virtio infos, this patch moves them to vring_virtqueue and introduces helpers to set and get the value. This would simplify the management and tracing. Signed-off-by: Jason Wang jasow...@redhat.com

Re: [net-next RFC V5 5/5] virtio_net: support negotiating the number of queues through ctrl vq

2012-07-05 Thread Sasha Levin
On Thu, 2012-07-05 at 18:29 +0800, Jason Wang wrote: @@ -1387,6 +1404,10 @@ static int virtnet_probe(struct virtio_device *vdev) if (virtio_has_feature(vdev, VIRTIO_NET_F_CTRL_VQ)) vi-has_cvq = true; + /* Use single tx/rx queue pair as default */ +

Re: [net-next RFC V5 5/5] virtio_net: support negotiating the number of queues through ctrl vq

2012-07-06 Thread Sasha Levin
On Fri, 2012-07-06 at 11:20 +0800, Jason Wang wrote: On 07/05/2012 08:51 PM, Sasha Levin wrote: On Thu, 2012-07-05 at 18:29 +0800, Jason Wang wrote: @@ -1387,6 +1404,10 @@ static int virtnet_probe(struct virtio_device *vdev) if (virtio_has_feature(vdev, VIRTIO_NET_F_CTRL_VQ

Re: [net-next RFC V5 4/5] virtio_net: multiqueue support

2012-07-21 Thread Sasha Levin
On 07/20/2012 03:40 PM, Michael S. Tsirkin wrote: -err = init_vqs(vi); + if (virtio_has_feature(vdev, VIRTIO_NET_F_CTRL_VQ)) + vi-has_cvq = true; + How about we disable multiqueue if there's no cvq? Will make logic a bit simpler, won't it? multiqueues don't really depend on

Re: [net-next RFC V5 4/5] virtio_net: multiqueue support

2012-07-23 Thread Sasha Levin
On 07/23/2012 07:54 AM, Jason Wang wrote: On 07/21/2012 08:02 PM, Sasha Levin wrote: On 07/20/2012 03:40 PM, Michael S. Tsirkin wrote: -err = init_vqs(vi); +if (virtio_has_feature(vdev, VIRTIO_NET_F_CTRL_VQ)) +vi-has_cvq = true; + How about we disable multiqueue if there's

[RFC 0/2] virtio: provide a way for host to monitor critical events in the device

2012-07-23 Thread Sasha Levin
the guest at intervals chosen by the host, and act accordingly if no response has been received. Sasha Levin (2): virtio: Introduce virtio-notifier kvm tools: support virtio-notifier drivers/virtio/Kconfig | 11 ++ drivers/virtio/Makefile |1 + drivers

  1   2   3   >