Re: [RFC PATCH net-next v6 2/4] net: Introduce generic bypass module

2018-04-19 Thread Jiri Pirko
Thu, Apr 19, 2018 at 06:08:58AM CEST, m...@redhat.com wrote: >On Wed, Apr 18, 2018 at 10:32:06PM +0200, Jiri Pirko wrote: >> >> >> > With regards to alternate names for 'active', you suggested >> >> >> > 'stolen', but i >> >> >> > am not too happy with it. >> >> >> > netvsc uses vf_netdev, are you

Re: [RFC PATCH net-next v6 2/4] net: Introduce generic bypass module

2018-04-18 Thread Jiri Pirko
Thu, Apr 19, 2018 at 12:46:11AM CEST, sridhar.samudr...@intel.com wrote: >On 4/18/2018 1:32 PM, Jiri Pirko wrote: >> > > > > > > You still use "active"/"backup" names which is highly misleading >> > > > > > > as >> > > > > > > it has completely different meaning that in bond for example. >> > > >

Re: [RFC PATCH net-next v6 2/4] net: Introduce generic bypass module

2018-04-18 Thread Michael S. Tsirkin
On Wed, Apr 18, 2018 at 10:32:06PM +0200, Jiri Pirko wrote: > >> >> > With regards to alternate names for 'active', you suggested 'stolen', > >> >> > but i > >> >> > am not too happy with it. > >> >> > netvsc uses vf_netdev, are you OK with this? Or another option is > >> >> > 'passthru' > >> >>

Re: [RFC PATCH net-next v6 2/4] net: Introduce generic bypass module

2018-04-18 Thread Samudrala, Sridhar
On 4/18/2018 1:32 PM, Jiri Pirko wrote: You still use "active"/"backup" names which is highly misleading as it has completely different meaning that in bond for example. I noted that in my previous review already. Please change it. I guess the issue is with only the 'active'  name. 'backup' shou

Re: [RFC PATCH net-next v6 2/4] net: Introduce generic bypass module

2018-04-18 Thread Jiri Pirko
Wed, Apr 18, 2018 at 09:46:04PM CEST, m...@redhat.com wrote: >On Wed, Apr 18, 2018 at 09:13:15PM +0200, Jiri Pirko wrote: >> Wed, Apr 18, 2018 at 08:43:15PM CEST, sridhar.samudr...@intel.com wrote: >> >On 4/18/2018 2:25 AM, Jiri Pirko wrote: >> >> Wed, Apr 11, 2018 at 09:13:52PM CEST, sridhar.samud

Re: [RFC PATCH net-next v6 2/4] net: Introduce generic bypass module

2018-04-18 Thread Michael S. Tsirkin
On Wed, Apr 18, 2018 at 09:13:15PM +0200, Jiri Pirko wrote: > Wed, Apr 18, 2018 at 08:43:15PM CEST, sridhar.samudr...@intel.com wrote: > >On 4/18/2018 2:25 AM, Jiri Pirko wrote: > >> Wed, Apr 11, 2018 at 09:13:52PM CEST, sridhar.samudr...@intel.com wrote: > >> > On 4/11/2018 8:51 AM, Jiri Pirko wro

Re: [RFC PATCH net-next v6 2/4] net: Introduce generic bypass module

2018-04-18 Thread Jiri Pirko
Wed, Apr 18, 2018 at 08:43:15PM CEST, sridhar.samudr...@intel.com wrote: >On 4/18/2018 2:25 AM, Jiri Pirko wrote: >> Wed, Apr 11, 2018 at 09:13:52PM CEST, sridhar.samudr...@intel.com wrote: >> > On 4/11/2018 8:51 AM, Jiri Pirko wrote: >> > > Tue, Apr 10, 2018 at 08:59:48PM CEST, sridhar.samudr...@i

Re: [RFC PATCH net-next v6 2/4] net: Introduce generic bypass module

2018-04-18 Thread Samudrala, Sridhar
On 4/18/2018 2:25 AM, Jiri Pirko wrote: Wed, Apr 11, 2018 at 09:13:52PM CEST, sridhar.samudr...@intel.com wrote: On 4/11/2018 8:51 AM, Jiri Pirko wrote: Tue, Apr 10, 2018 at 08:59:48PM CEST, sridhar.samudr...@intel.com wrote: This provides a generic interface for paravirtual drivers to listen

Re: [RFC PATCH net-next v6 2/4] net: Introduce generic bypass module

2018-04-18 Thread Jiri Pirko
Wed, Apr 11, 2018 at 09:13:52PM CEST, sridhar.samudr...@intel.com wrote: >On 4/11/2018 8:51 AM, Jiri Pirko wrote: >> Tue, Apr 10, 2018 at 08:59:48PM CEST, sridhar.samudr...@intel.com wrote: >> > This provides a generic interface for paravirtual drivers to listen >> > for netdev register/unregister/

Re: [RFC PATCH net-next v6 2/4] net: Introduce generic bypass module

2018-04-11 Thread Samudrala, Sridhar
On 4/11/2018 8:51 AM, Jiri Pirko wrote: Tue, Apr 10, 2018 at 08:59:48PM CEST, sridhar.samudr...@intel.com wrote: This provides a generic interface for paravirtual drivers to listen for netdev register/unregister/link change events from pci ethernet devices with the same MAC and takeover their da

Re: [RFC PATCH net-next v6 2/4] net: Introduce generic bypass module

2018-04-11 Thread Jiri Pirko
Tue, Apr 10, 2018 at 08:59:48PM CEST, sridhar.samudr...@intel.com wrote: >This provides a generic interface for paravirtual drivers to listen >for netdev register/unregister/link change events from pci ethernet >devices with the same MAC and takeover their datapath. The notifier and >event handling

[RFC PATCH net-next v6 2/4] net: Introduce generic bypass module

2018-04-10 Thread Sridhar Samudrala
This provides a generic interface for paravirtual drivers to listen for netdev register/unregister/link change events from pci ethernet devices with the same MAC and takeover their datapath. The notifier and event handling code is based on the existing netvsc implementation. It exposes 2 sets of i