Re: [PATCH] virtio-blk: Assign discard_granularity

2022-03-01 Thread Martin K. Petersen
Akihiko, > I'd like to leave this patch as is since I cannot deny the possibility > that the host has a different alignment offset for discarding and > other operations. That's correct. SCSI explicitly reports separate values for physical block alignment and "discard" alignment. The queue

Re: [PATCH] virtio-blk: Assign discard_granularity

2022-03-01 Thread Stefan Hajnoczi
On Tue, Mar 01, 2022 at 02:43:55PM +0900, Akihiko Odaki wrote: > On 2022/02/28 19:51, Stefan Hajnoczi wrote: > > On Thu, Feb 24, 2022 at 06:38:02PM +0900, Akihiko Odaki wrote: > > > Virtual I/O Device (VIRTIO) Version 1.1 > > >

Re: [PATCH] virtio-blk: Assign discard_granularity

2022-02-28 Thread Stefan Hajnoczi
On Thu, Feb 24, 2022 at 06:38:02PM +0900, Akihiko Odaki wrote: > Virtual I/O Device (VIRTIO) Version 1.1 > https://docs.oasis-open.org/virtio/virtio/v1.1/csprd01/virtio-v1.1-csprd01.html > > discard_sector_alignment can be used by OS when splitting a request > > based on alignment. > > According