Re: [PATCH] virtio_mmio: expose header to userspace
On Thu, Jan 12, 2017 at 11:58:22PM -0800, Christoph Hellwig wrote: > On Thu, Jan 12, 2017 at 11:37:22PM +0200, Michael S. Tsirkin wrote: > > It's handy for userspace emulators like QEMU. > > But it's not actually a userspace API - it's an on the write protocol. We do this for all other virtio transports, mmio shouldn't be any different. > so: NAK. We'll have to agree to disagree on this one. It's the interface beween linux and the hypervisor. It isn't any less stable than the one to userspace, for better or worse kvm (ab)uses uapi for that. Compare also to include/uapi/linux/kvm_para.h etc. -- MST ___ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/virtualization
Re: [PATCH] virtio_mmio: expose header to userspace
On Thu, Jan 12, 2017 at 11:37:22PM +0200, Michael S. Tsirkin wrote: > It's handy for userspace emulators like QEMU. But it's not actually a userspace API - it's an on the write protocol. so: NAK. ___ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/virtualization
Re: [PATCH] virtio_mmio: expose header to userspace
On 2017年01月13日 05:37, Michael S. Tsirkin wrote: It's handy for userspace emulators like QEMU. Signed-off-by: Michael S. Tsirkin--- drivers/virtio/virtio_mmio.c | 2 +- include/{ => uapi}/linux/virtio_mmio.h | 0 2 files changed, 1 insertion(+), 1 deletion(-) rename include/{ => uapi}/linux/virtio_mmio.h (100%) diff --git a/drivers/virtio/virtio_mmio.c b/drivers/virtio/virtio_mmio.c index d47a2fc..7a10aa2 100644 --- a/drivers/virtio/virtio_mmio.c +++ b/drivers/virtio/virtio_mmio.c @@ -69,7 +69,7 @@ #include #include #include -#include +#include #include diff --git a/include/linux/virtio_mmio.h b/include/uapi/linux/virtio_mmio.h similarity index 100% rename from include/linux/virtio_mmio.h rename to include/uapi/linux/virtio_mmio.h Acked-by: Jason Wang ___ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/virtualization